Re: [Intel-gfx] [PATCH] drm/i915: Sanitize the output registers after resume

2011-04-13 Thread Chris Wilson
On Tue, 12 Apr 2011 17:00:05 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Tue, 12 Apr 2011 18:06:51 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Similar to booting, we need to inspect the state left by the BIOS and remove any conflicting bits before we take over. The

Re: [Intel-gfx] [PATCH] drm/i915: Sanitize the output registers after resume

2011-04-12 Thread Chris Wilson
After sending this patch, to the changelog I added: See commit 47f1c6c9ffdec0c0e5a2c2709bd63c7380b325c4 (drm/i915: Clean conflicting modesetting registers upon init) for further details on the original bug. -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH] drm/i915: Sanitize the output registers after resume

2011-04-12 Thread Keith Packard
On Tue, 12 Apr 2011 18:06:51 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: This patch rearranges the code we already have to clear up the conflicting state upon init and calls it from reset (which is called after we have lost control of the hardware, i.e. along both the boot and resume

Re: [Intel-gfx] [PATCH] drm/i915: Sanitize the output registers after resume

2011-04-12 Thread Jesse Barnes
On Tue, 12 Apr 2011 18:06:51 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Similar to booting, we need to inspect the state left by the BIOS and remove any conflicting bits before we take over. The example reported by Seth Forshee is very similar to the bug we encountered with the state