[Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after cleanup

2011-04-22 Thread Chris Wilson
Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after cleanup), we missed one neighbouring read that was mistakenly replaced with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage). This was preventing us from correctly determining the mode the BIOS left the panel in

Re: [Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after cleanup

2011-04-22 Thread Jesse Barnes
On Fri, 22 Apr 2011 22:22:28 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after cleanup), we missed one neighbouring read that was mistakenly replaced with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).

[Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after cleanup

2011-04-22 Thread Chris Wilson
Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after cleanup), we missed one neighbouring read that was mistakenly replaced with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage). This was preventing us from correctly determining the mode the BIOS left the panel in

Re: [Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after cleanup

2011-04-22 Thread Jesse Barnes
On Fri, 22 Apr 2011 22:34:46 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after cleanup), we missed one neighbouring read that was mistakenly replaced with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).

Re: [Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after cleanup

2011-04-22 Thread Keith Packard
On Fri, 22 Apr 2011 22:22:28 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: fp = FP0(pipe); else fp = FP1(pipe); + fp = I915_READ(fp); Please use different variables for the offset vs the value... -- keith.pack...@intel.com pgpaGbAUtaJf4.pgp