Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Nathan Chancellor
On Wed, Apr 13, 2022 at 11:25:02AM +0200, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Fix it by

Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 11:21, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote: >> Hello Daniel, >> >> On 4/13/22 10:21, Daniel Vetter wrote: >>> I messed up the delayed takover path in the locking conversion in >>> 6e7da3af008b ("fbcon: Move console_lock for

Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > I messed up the delayed takover path in the locking conversion in > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > Fix it by re-extracting the lockless function and using it in the > delayed takeover

Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 11:16:08AM +0200, Javier Martinez Canillas wrote: > Hello Daniel, > > On 4/13/22 10:21, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Maybe a

Re: [Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Javier Martinez Canillas
Hello Daniel, On 4/13/22 10:21, Daniel Vetter wrote: > I messed up the delayed takover path in the locking conversion in > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > Maybe a few more words of what the issue is ? Something like the following: If

[Intel-gfx] [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Daniel Vetter
I messed up the delayed takover path in the locking conversion in 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). Fix it by re-extracting the lockless function and using it in the delayed takeover path, where we need to hold the lock already to iterate over the list of