Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Feng, Boqun
to merge them into two function? -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Tuesday, April 26, 2011 10:29 PM To: Feng, Boqun; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x Only

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Chris Wilson
On Wed, 27 Apr 2011 14:08:57 +0800, Feng, Boqun boqun.f...@intel.com wrote: I am very sorry for my careless about whitespace. But my patch will not affect gen6+ paths, for gen6+, it use gen6_bsd_ring , bsd_ring is only used by g4x and ironlake. Reviewer error, sorry. Saw the gen6_* in the

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Feng, Boqun
Subject: RE: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x On Wed, 27 Apr 2011 14:08:57 +0800, Feng, Boqun boqun.f...@intel.com wrote: I am very sorry for my careless about whitespace. But my patch will not affect gen6+ paths, for gen6+, it use gen6_bsd_ring

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Chris Wilson
On Wed, 27 Apr 2011 16:23:00 +0800, Feng, Boqun boqun.f...@intel.com wrote: Err...I just send another two patches before read this letter. : ) Ironlake and g4x share the same bsd_ring, so they share the same bsd_ring_put/get_irq functions of the ring. Given this, we can't just change the

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Daniel Vetter
On Wed, Apr 27, 2011 at 11:15 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: At the moment, I'm more concerned about making sure our functions are consistently named and prefixed with the chipset they first work with. So we have:  intel_ - general functions, used by all  i8xx_ - gen2  

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-27 Thread Ben Widawsky
On Wed, Apr 27, 2011 at 01:07:24PM +0200, Daniel Vetter wrote: On Wed, Apr 27, 2011 at 11:15 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: At the moment, I'm more concerned about making sure our functions are consistently named and prefixed with the chipset they first work with. So

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-26 Thread Chris Wilson
Only, the first 2 chunks are required. The gen6+ paths are unaffected. And be careful of your whitespace. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-26 Thread Keith Packard
On Tue, 26 Apr 2011 18:12:52 +0800, Feng, Boqun boqun.f...@intel.com wrote: Signed-off-by: Feng, Boqun boqun.f...@intel.com Please add a description here of what the bug was and how this fixes it. -- keith.pack...@intel.com pgph19eyUhT0a.pgp Description: PGP signature

Re: [Intel-gfx] [PATCH] fix interrupt request miss problem in bsd ring for g4x

2011-04-26 Thread Feng, Boqun
] fix interrupt request miss problem in bsd ring for g4x On Tue, 26 Apr 2011 18:12:52 +0800, Feng, Boqun boqun.f...@intel.com wrote: Signed-off-by: Feng, Boqun boqun.f...@intel.com Please add a description here of what the bug was and how this fixes it. -- keith.pack...@intel.com