Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 15:07:28 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 12:03:22) > > On Wed, 10 Apr 2019 12:44:49 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 10 Apr 2019 12:24:24 +0200, > > > Chris Wilson wrote: > > > > > > > > Quoting Takashi Iwai (2019-04-10

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Chris Wilson
Quoting Takashi Iwai (2019-04-10 12:03:22) > On Wed, 10 Apr 2019 12:44:49 +0200, > Takashi Iwai wrote: > > > > On Wed, 10 Apr 2019 12:24:24 +0200, > > Chris Wilson wrote: > > > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > > Chris Wilson

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 12:44:49 +0200, Takashi Iwai wrote: > > On Wed, 10 Apr 2019 12:24:24 +0200, > Chris Wilson wrote: > > > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > > On Wed, 10 Apr 2019 10:17:33 +0200, > > > Chris Wilson wrote: > > > > > > > > While we only allow a single display power

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 12:24:24 +0200, Chris Wilson wrote: > > Quoting Takashi Iwai (2019-04-10 11:09:47) > > On Wed, 10 Apr 2019 10:17:33 +0200, > > Chris Wilson wrote: > > > > > > While we only allow a single display power reference, the current > > > acquisition/release is racy and a direct call

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Chris Wilson
Quoting Takashi Iwai (2019-04-10 11:09:47) > On Wed, 10 Apr 2019 10:17:33 +0200, > Chris Wilson wrote: > > > > While we only allow a single display power reference, the current > > acquisition/release is racy and a direct call may run concurrently with > > a runtime-pm worker. Prevent the double

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Takashi Iwai
On Wed, 10 Apr 2019 10:17:33 +0200, Chris Wilson wrote: > > While we only allow a single display power reference, the current > acquisition/release is racy and a direct call may run concurrently with > a runtime-pm worker. Prevent the double unreference by atomically > tracking the

Re: [Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Chris Wilson
Quoting Chris Wilson (2019-04-10 09:17:33) > While we only allow a single display power reference, the current > acquisition/release is racy and a direct call may run concurrently with > a runtime-pm worker. Prevent the double unreference by atomically > tracking the display_power_active cookie.

[Intel-gfx] [PATCH] snd/hda: Only get/put display_power once

2019-04-10 Thread Chris Wilson
While we only allow a single display power reference, the current acquisition/release is racy and a direct call may run concurrently with a runtime-pm worker. Prevent the double unreference by atomically tracking the display_power_active cookie. Testcase: igt/i915_pm_rpm/module-reload #glk-dsi