Re: [Intel-gfx] [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable

2011-05-04 Thread Keith Packard
On Thu, 21 Apr 2011 22:18:23 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: As we failed to update the dpms_mode after modeset, where it is presumed to have been changed to DRM_MODE_DPMS_ON by the upper layers the dpms state on the crtc became inconsistent with its actual active state.

Re: [Intel-gfx] [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable

2011-05-04 Thread Chris Wilson
On Wed, 04 May 2011 14:20:27 -0700, Keith Packard kei...@keithp.com wrote: On Wed, 04 May 2011 20:40:37 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: We can remove dpms_mode in favour of solely using active. That sounds like a good plan. And what about the intel_dp-dpms_mode

[Intel-gfx] [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable

2011-04-21 Thread Chris Wilson
As we failed to update the dpms_mode after modeset, where it is presumed to have been changed to DRM_MODE_DPMS_ON by the upper layers the dpms state on the crtc became inconsistent with its actual active state. This notably confused code and left the pipe active when it was meant to be disabled,