Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-11-03 Thread Keith Packard
On Sun, 23 Oct 2011 13:35:45 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: On Sun, 23 Oct 2011 14:09:07 +0200, Daniel Vetter dan...@ffwll.ch wrote: Keith, can take a look at patches 1-2 and consider merging them for 3.2? Those two are Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-23 Thread Daniel Vetter
On Mon, Oct 10, 2011 at 10:58:22AM -0700, Jesse Barnes wrote: On Sun, 9 Oct 2011 21:52:01 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: So don't forget to restore them on resume and dump them into the error state. This should probably just be = 6 instead; I don't think we're

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-23 Thread Chris Wilson
Regardless of the outcome of Jesse's request for an if-ladder, the substance of the patches look sound. However, I remain unconvinced that there are 32 fence registers on IVB. Daniel's evidence is based upon the size of the register map (and not on the BSPEC explicitly stating a change to 32 ;-),

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-23 Thread Daniel Vetter
On Sun, Oct 23, 2011 at 12:23:14PM +0100, Chris Wilson wrote: Regardless of the outcome of Jesse's request for an if-ladder, the substance of the patches look sound. However, I remain unconvinced that there are 32 fence registers on IVB. Daniel's evidence is based upon the size of the

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-23 Thread Chris Wilson
On Sun, 23 Oct 2011 14:09:07 +0200, Daniel Vetter dan...@ffwll.ch wrote: Keith, can take a look at patches 1-2 and consider merging them for 3.2? Those two are Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk -Chris -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-23 Thread Daniel Vetter
On Sun, Oct 23, 2011 at 01:45:21PM -0700, Kenneth Graunke wrote: On 10/23/2011 04:23 AM, Chris Wilson wrote: Regardless of the outcome of Jesse's request for an if-ladder, the substance of the patches look sound. However, I remain unconvinced that there are 32 fence registers on IVB.

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-10 Thread Jesse Barnes
On Sun, 9 Oct 2011 21:52:01 +0200 Daniel Vetter daniel.vet...@ffwll.ch wrote: So don't forget to restore them on resume and dump them into the error state. This should probably just be = 6 instead; I don't think we're getting rid of fences anytime soon. -- Jesse Barnes, Intel Open Source

[Intel-gfx] [PATCH 1/3] drm/i915: Ivybridge still has fences!

2011-10-09 Thread Daniel Vetter
So don't forget to restore them on resume and dump them into the error state. Cc: sta...@kernel.org Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_irq.c |1 + drivers/gpu/drm/i915/i915_suspend.c |2 ++ 2 files changed, 3 insertions(+), 0