Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-17 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 02:10:22PM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 10:05:03PM +0200, Daniel Vetter wrote: > > On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > > > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > > > On Tue, 14 Sept 2021 at

[Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-16 Thread Matthew Brost
From: Venkata Sandeep Dhanalakota Defining vma on stack can cause stack overflow, if vma gets populated with new fields. v2: (Daniel Vetter) - Add kerneldoc for new field Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Signed-off-by: Venkata Sandeep Dhanalakota Signed-off-by: Matthew Brost

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 10:05:03PM +0200, Daniel Vetter wrote: > On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > > On Tue, 14 Sept 2021 at 14:55, Matthew Brost > > > wrote: > > > > > > > > From: Venkata Sandeep

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Daniel Vetter
On Tue, Sep 14, 2021 at 08:36:56AM -0700, Matthew Brost wrote: > On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > > On Tue, 14 Sept 2021 at 14:55, Matthew Brost > > wrote: > > > > > > From: Venkata Sandeep Dhanalakota > > > > > > Defining vma on stack can cause stack overflow, if

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-14 Thread Matthew Brost
On Tue, Sep 14, 2021 at 03:04:59PM +1000, Dave Airlie wrote: > On Tue, 14 Sept 2021 at 14:55, Matthew Brost wrote: > > > > From: Venkata Sandeep Dhanalakota > > > > Defining vma on stack can cause stack overflow, if > > vma gets populated with new fields. > > Is there some higher level locking

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-13 Thread Dave Airlie
On Tue, 14 Sept 2021 at 14:55, Matthew Brost wrote: > > From: Venkata Sandeep Dhanalakota > > Defining vma on stack can cause stack overflow, if > vma gets populated with new fields. Is there some higher level locking stopping that from getting trashed? or a guarantee that uc_fw_bind_ggtt is

[Intel-gfx] [PATCH 1/5] drm/i915: Do not define vma on stack

2021-09-13 Thread Matthew Brost
From: Venkata Sandeep Dhanalakota Defining vma on stack can cause stack overflow, if vma gets populated with new fields. Cc: Daniele Ceraolo Spurio Cc: Tvrtko Ursulin Signed-off-by: Venkata Sandeep Dhanalakota Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost ---