Re: [Intel-gfx] [PATCH 12/13] drm/i915: Prevent mixing of snooped and tiling modes for old chipsets

2011-05-04 Thread Keith Packard
On Thu, 14 Apr 2011 10:03:46 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Older chipsets do not support snooping (i.e. cache sharing between the CPU and GPU) on tiled surfaces. So prevent userspace from being silly should we one day expose the ability to change cache levels from

[Intel-gfx] [PATCH 12/13] drm/i915: Prevent mixing of snooped and tiling modes for old chipsets

2011-04-14 Thread Chris Wilson
Older chipsets do not support snooping (i.e. cache sharing between the CPU and GPU) on tiled surfaces. So prevent userspace from being silly should we one day expose the ability to change cache levels from userspace. It does enforce a strict ordering for mode changing though. So in order to

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Prevent mixing of snooped and tiling modes for old chipsets

2011-04-14 Thread Daniel Vetter
On Thu, Apr 14, 2011 at 10:03:46AM +0100, Chris Wilson wrote: Older chipsets do not support snooping (i.e. cache sharing between the CPU and GPU) on tiled surfaces. So prevent userspace from being silly should we one day expose the ability to change cache levels from userspace. It does

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Prevent mixing of snooped and tiling modes for old chipsets

2011-04-14 Thread Chris Wilson
On Thu, 14 Apr 2011 19:43:35 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Apr 14, 2011 at 10:03:46AM +0100, Chris Wilson wrote: + if (INTEL_INFO(dev)-gen 6 + args-tiling_mode != I915_TILING_NONE + obj-cache_level != I915_CACHE_NONE) { + DRM_DEBUG(can't