Re: [Intel-gfx] [PATCH 3/6] drm/i915: change power_well-lock to be mutex

2013-10-19 Thread Daniel Vetter
On Fri, Oct 18, 2013 at 11:50:47AM -0700, Jesse Barnes wrote: Are there ordering requirements we should document? E.g. always take this after the mode config lock or something? The mode_config lock is pretty much the outermost thing, and for getting it right we have lockdpe. As long as we

Re: [Intel-gfx] [PATCH 3/6] drm/i915: change power_well-lock to be mutex

2013-10-18 Thread Jesse Barnes
On Wed, 16 Oct 2013 17:25:50 +0300 Imre Deak imre.d...@intel.com wrote: There is no hard need for this to be a spin lock, as we don't take these locks in irq context from anywhere. An upcoming patch will add calls to punit read/write functions from within regions protected by this lock and

Re: [Intel-gfx] [PATCH 3/6] drm/i915: change power_well-lock to be mutex

2013-10-16 Thread Imre Deak
On Wed, 2013-10-16 at 13:19 -0300, Paulo Zanoni wrote: 2013/10/16 Imre Deak imre.d...@intel.com: There is no hard need for this to be a spin lock, as we don't take these locks in irq context from anywhere. An upcoming patch will add calls to punit read/write functions from within regions