Re: [Intel-gfx] [PATCH 3/8] drm/i915: Flush the plane enable using the DSPCNTR latch

2011-03-18 Thread Keith Packard
This comment is misleading -- the patch replaces a call to intel_wait_for_vblank with a call to intel_flush_display_plane. From my reading of the docs, enable requires two actions: 1) DSPACNTR with enable going from 0-1 2) wait for vblank At disable, three actions are required: 1) DSPACNTR

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Flush the plane enable using the DSPCNTR latch

2011-03-18 Thread Jesse Barnes
On Fri, 18 Mar 2011 08:02:05 + Chris Wilson ch...@chris-wilson.co.uk wrote: References: https://bugs.freedesktop.org/show_bug.cgi?id=34601 Cc: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c | 24

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Flush the plane enable using the DSPCNTR latch

2011-03-18 Thread Chris Wilson
On Fri, 18 Mar 2011 09:26:04 -0700, Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 18 Mar 2011 08:02:05 + Chris Wilson ch...@chris-wilson.co.uk wrote: References: https://bugs.freedesktop.org/show_bug.cgi?id=34601 Cc: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Chris