Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-17 Thread Imre Deak
On Wed, 2013-10-16 at 08:08 -0700, Jesse Barnes wrote: On Wed, 16 Oct 2013 14:10:13 +0300 Imre Deak imre.d...@intel.com wrote: On Tue, 2013-10-15 at 13:40 -0700, Jesse Barnes wrote: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: [...] No that's taken

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-16 Thread Imre Deak
On Tue, 2013-10-15 at 13:40 -0700, Jesse Barnes wrote: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: [...] No that's taken into account here. In __intel_set_mode we take a private ref on the appropriate power well so that we'll preserve state until we do the

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-16 Thread Jesse Barnes
On Wed, 16 Oct 2013 14:10:13 +0300 Imre Deak imre.d...@intel.com wrote: On Tue, 2013-10-15 at 13:40 -0700, Jesse Barnes wrote: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: [...] No that's taken into account here. In __intel_set_mode we take a private ref

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-15 Thread Paulo Zanoni
2013/10/14 Jesse Barnes jbar...@virtuousgeek.org: When accessing the display regs for hw state readout or cross check, we need to make sure the power well is enabled so we can read valid register state. On the current code (HSW) we already check for the power wells in the HW state readout

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-15 Thread Jesse Barnes
On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/14 Jesse Barnes jbar...@virtuousgeek.org: When accessing the display regs for hw state readout or cross check, we need to make sure the power well is enabled so we can read valid register state. On the

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-15 Thread Paulo Zanoni
2013/10/15 Jesse Barnes jbar...@virtuousgeek.org: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/14 Jesse Barnes jbar...@virtuousgeek.org: When accessing the display regs for hw state readout or cross check, we need to make sure the power well is enabled

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-15 Thread Jesse Barnes
On Tue, 15 Oct 2013 17:47:20 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/15 Jesse Barnes jbar...@virtuousgeek.org: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/14 Jesse Barnes jbar...@virtuousgeek.org: When accessing the display regs for

Re: [Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-15 Thread Paulo Zanoni
2013/10/15 Jesse Barnes jbar...@virtuousgeek.org: On Tue, 15 Oct 2013 17:47:20 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/15 Jesse Barnes jbar...@virtuousgeek.org: On Tue, 15 Oct 2013 16:54:00 -0300 Paulo Zanoni przan...@gmail.com wrote: 2013/10/14 Jesse Barnes

[Intel-gfx] [PATCH 4/5] drm/i915: take power well refs when needed

2013-10-14 Thread Jesse Barnes
When accessing the display regs for hw state readout or cross check, we need to make sure the power well is enabled so we can read valid register state. Likewise, in an actual mode set, we need to take a ref on the appropriate power well so that the mode set succeeds. From then on, the power