[Intel-gfx] [PATCH 5/5] drm/i915/gmbus: Reset the controller on initialisation

2011-04-05 Thread Chris Wilson
Toggle the Software Clear Interrupt bit which resets the controller to clear any prior BUS_ERROR condition before we begin to use the controller in earnest. Suggested-by: Ben Widawsky b...@bwidawsk.net Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_i2c.c |

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gmbus: Reset the controller on initialisation

2011-04-05 Thread Ben Widawsky
On Tue, Apr 05, 2011 at 09:18:37AM -0700, Ben Widawsky wrote: Outside of being able to do that directly, I would add a call to intel_i2c_reset() from intel_teardown_gmbus(). Hmm, forget that, I think this is silly. How about just a comment in the code stating that intel_i2c_reset() should

Re: [Intel-gfx] [PATCH 5/5] drm/i915/gmbus: Reset the controller on initialisation

2011-04-05 Thread Keith Packard
On Tue, 5 Apr 2011 10:24:18 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Toggle the Software Clear Interrupt bit which resets the controller to clear any prior BUS_ERROR condition before we begin to use the controller in earnest. We do this in two places now, do we want to share the