Hi,
Seems like there were couple too many steps away from "just reordering
code", and indeed it's not working with GuC enabled, so have to spend
some time to see why.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
On ke, 2017-02-15 at 18:28 -0800, Daniele Ceraolo Spurio wrote:
>
> On 14/02/17 05:53, Joonas Lahtinen wrote:
> >
> > Started adding proper teardown to guc_client_alloc, ended up removing
> > quite a few dead ends where errors communicating with the GuC were
> > silently ignored. There also
On 02/14/2017 05:53 AM, Joonas Lahtinen wrote:
Started adding proper teardown to guc_client_alloc, ended up removing
quite a few dead ends where errors communicating with the GuC were
silently ignored. There also seemed to be quite a few erronous
teardown actions performed in case of an error
On 15/02/17 23:44, Chris Wilson wrote:
On Wed, Feb 15, 2017 at 06:28:59PM -0800, Daniele Ceraolo Spurio wrote:
On 14/02/17 05:53, Joonas Lahtinen wrote:
-static void guc_disable_doorbell(struct intel_guc *guc,
-struct i915_guc_client *client)
+static int
On Wed, Feb 15, 2017 at 06:28:59PM -0800, Daniele Ceraolo Spurio wrote:
> On 14/02/17 05:53, Joonas Lahtinen wrote:
> >-static void guc_disable_doorbell(struct intel_guc *guc,
> >- struct i915_guc_client *client)
> >+static int __destroy_doorbell(struct i915_guc_client
On 14/02/17 05:53, Joonas Lahtinen wrote:
Started adding proper teardown to guc_client_alloc, ended up removing
quite a few dead ends where errors communicating with the GuC were
silently ignored. There also seemed to be quite a few erronous
teardown actions performed in case of an error
Started adding proper teardown to guc_client_alloc, ended up removing
quite a few dead ends where errors communicating with the GuC were
silently ignored. There also seemed to be quite a few erronous
teardown actions performed in case of an error (ordering wrong).
v2:
- Increase function
