Re: [Intel-gfx] [PATCH v2] drm: Check if primary mst is null

2018-11-09 Thread Lyude Paul
Pushed with small changes to drm-misc-fixes: Renamed patch and added stable Cc Thanks! On Fri, 2018-11-09 at 11:00 +0200, Stanislav Lisovskiy wrote: > Unfortunately drm_dp_get_mst_branch_device which is called from both > drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely > on

[Intel-gfx] [PATCH v2] drm: Check if primary mst is null

2018-11-09 Thread Stanislav Lisovskiy
Unfortunately drm_dp_get_mst_branch_device which is called from both drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely on that mgr->mst_primary is not NULL, which seem to be wrong as it can be cleared with simultaneous mode set, if probing fails or in other case. mgr->lock mutex

Re: [Intel-gfx] [PATCH v2] drm: Check if primary mst is null

2018-11-08 Thread Lisovskiy, Stanislav
On Thu, 2018-11-08 at 10:20 +0200, Stanislav Lisovskiy wrote: > Unfortunately drm_dp_get_mst_branch_device which is called from both > drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely > on that mgr->mst_primary is not NULL, which seem to be wrong as it > can be > cleared with

[Intel-gfx] [PATCH v2] drm: Check if primary mst is null

2018-11-08 Thread Stanislav Lisovskiy
Unfortunately drm_dp_get_mst_branch_device which is called from both drm_dp_mst_handle_down_rep and drm_dp_mst_handle_up_rep seem to rely on that mgr->mst_primary is not NULL, which seem to be wrong as it can be cleared with simultaneous mode set, if probing fails or in other case. mgr->lock mutex