Re: [Intel-gfx] [PATCH v3 03/23] drm/i915: Micro-optimise gen8_ppgtt_insert_entries()

2017-02-15 Thread Chris Wilson
On Tue, Feb 14, 2017 at 06:00:55PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > - while (__sg_page_iter_next(sg_iter)) { > > - if (pt_vaddr == NULL) { > > - struct i915_page_directory *pd = > > pdp->page_directory[pdpe]; > > -

Re: [Intel-gfx] [PATCH v3 03/23] drm/i915: Micro-optimise gen8_ppgtt_insert_entries()

2017-02-14 Thread Mika Kuoppala
Chris Wilson writes: > Improve the sg iteration and in hte process eliminate a bug in > miscomputing the pml4 length as orig_nents< full length of the sg table. > > v2: Check for the end of the fourth level page table (the final pdpe) > and move onto the next. > >

[Intel-gfx] [PATCH v3 03/23] drm/i915: Micro-optimise gen8_ppgtt_insert_entries()

2017-02-14 Thread Chris Wilson
Improve the sg iteration and in hte process eliminate a bug in miscomputing the pml4 length as orig_nents< --- drivers/gpu/drm/i915/i915_gem_gtt.c | 170 +++- 1 file changed, 91 insertions(+), 79 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c