Re: [Intel-gfx] xf86-video-intel: 3 commits - src/intel_display.c src/intel_dri.c src/intel.h

2011-03-24 Thread Keith Packard
On Thu, 24 Mar 2011 02:02:56 +0100, Julien Cristau jcris...@debian.org wrote: Hi Keith, a couple suggestions below from a quick look over these patches. Thanks for your review! static void intel_vblank_handler(int fd, unsigned int frame, unsigned int tv_sec, -

Re: [Intel-gfx] xf86-video-intel: 3 commits - src/intel_display.c src/intel_dri.c src/intel.h

2011-03-24 Thread Keith Packard
On Thu, 24 Mar 2011 19:31:03 +0100, Julien Cristau jcris...@debian.org wrote: This will cause a double free as the blit_fallback path does it too. Argh! So we need to check before we reference the buffers and set swap_info to NULL. This code is too twisty... @@ -955,11 +960,16 @@

Re: [Intel-gfx] xf86-video-intel: 3 commits - src/intel_display.c src/intel_dri.c src/intel.h

2011-03-24 Thread Julien Cristau
On Thu, Mar 24, 2011 at 16:52:25 -0700, Keith Packard wrote: On Thu, 24 Mar 2011 19:31:03 +0100, Julien Cristau jcris...@debian.org wrote: This will cause a double free as the blit_fallback path does it too. Argh! So we need to check before we reference the buffers and set swap_info to

Re: [Intel-gfx] xf86-video-intel: 3 commits - src/intel_display.c src/intel_dri.c src/intel.h

2011-03-24 Thread Keith Packard
On Fri, 25 Mar 2011 00:57:10 +0100, Julien Cristau jcris...@debian.org wrote: With that change, Reviewed-by: Julien Cristau jcris...@debian.org Thanks for catching my bugs before they caused any damage... Pushed. ec133ab..7ccbec8 master - master -- keith.pack...@intel.com

Re: [Intel-gfx] xf86-video-intel: 3 commits - src/intel_display.c src/intel_dri.c src/intel.h

2011-03-23 Thread Julien Cristau
Hi Keith, a couple suggestions below from a quick look over these patches. On Wed, Mar 23, 2011 at 17:24:57 -0700, Keith Packard wrote: commit e1ff5182304e00c0d392092069422cae7626cf8d Author: Keith Packard kei...@keithp.com Date: Wed Mar 9 17:00:41 2011 -0800 Handle drawable/client