Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-28 Thread Dixit, Ashutosh
On Wed, 27 Mar 2024 13:37:19 -0700, Dixit, Ashutosh wrote: > > On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > > > > Hi Janusz, > > > For me, that still doesn't explain why you think that i915->hwmon reset to > > NULL on i915 driver unregister can be the root cause of the reported

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-28 Thread Krzysztofik, Janusz
Hi Ashutosh, On Wednesday, 27 March 2024 21:37:19 CET Dixit, Ashutosh wrote: > On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > > > > Hi Janusz, > > > For me, that still doesn't explain why you think that i915->hwmon reset to > > NULL on i915 driver unregister can be the root

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-27 Thread Dixit, Ashutosh
On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > Hi Janusz, > For me, that still doesn't explain why you think that i915->hwmon reset to > NULL on i915 driver unregister can be the root cause of the reported UAF in > hwmon sysfs and this patch is going to fix that UAF issue. I

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-27 Thread Dixit, Ashutosh
On Tue, 26 Mar 2024 05:48:38 -0700, Badal Nilawar wrote: > Hi Badal, > i915_hwmon and its resources are managed resources of i915 dev. > During i915 driver unregister flow the function i915_hwmon_unregister() > explicitly makes i915_hwmon resource NULL. This happen before > hwmon is actually

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-27 Thread Krzysztofik, Janusz
Hi Badal, On Wednesday, 27 March 2024 05:30:17 CET Nilawar, Badal wrote: > > On 27-03-2024 02:58, Krzysztofik, Janusz wrote: > > On Tuesday, 26 March 2024 13:48:38 CET Badal Nilawar wrote: > >> i915_hwmon and its resources are managed resources of i915 dev. > >> During i915 driver unregister

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-26 Thread Nilawar, Badal
On 27-03-2024 02:58, Krzysztofik, Janusz wrote: On Tuesday, 26 March 2024 13:48:38 CET Badal Nilawar wrote: i915_hwmon and its resources are managed resources of i915 dev. During i915 driver unregister flow the function i915_hwmon_unregister() explicitly makes i915_hwmon resource NULL. This

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-26 Thread Krzysztofik, Janusz
On Tuesday, 26 March 2024 13:48:38 CET Badal Nilawar wrote: > i915_hwmon and its resources are managed resources of i915 dev. > During i915 driver unregister flow the function i915_hwmon_unregister() > explicitly makes i915_hwmon resource NULL. This happen before > hwmon is actually unregistered.

[PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-26 Thread Badal Nilawar
i915_hwmon and its resources are managed resources of i915 dev. During i915 driver unregister flow the function i915_hwmon_unregister() explicitly makes i915_hwmon resource NULL. This happen before hwmon is actually unregistered. Doing so may cause UAF if hwmon sysfs is being accessed: <7>