Re: [Intel-gfx] [PATCH 2/6] drm/i915: Use common LRU inactive vma bumping for unpin_from_display

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > Now that i915_gem_object_bump_inactive_ggtt() exists, also make use of > it for the LRU bumping from i915_gem_object_unpin_from_display() > > Signed-off-by: Chris Wilson >   /* Bump the LRU to try and avoid

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Treat an error from i915_vma_instance() as unlikely

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > When pinning into the global GTT, an error from creating the VMA is > unlikely, so mark it so. > > Signed-off-by: Chris Wilson   >   vma = i915_vma_instance(obj, vm, view); > - if (IS_ERR(vma)) > + if

Re: [Intel-gfx] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

On Fri, 20 Jan 2017 23:22:31 +0100, Jerome Anand wrote: > > + had_ops_v1 = had_ops_v1;/* unused */ Until now I didn't realize that the whole v1 stuff is never used in the current patchset. Will it be ever used in future? If not, can't we clean it up? It's a bunch of codes,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Skip BSW display interrupt checks if we have a GT interrupt

== Series Details == Series: drm/i915: Skip BSW display interrupt checks if we have a GT interrupt URL : https://patchwork.freedesktop.org/series/18293/ State : failure == Summary == Series 18293v1 drm/i915: Skip BSW display interrupt checks if we have a GT interrupt

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Assert the vma can fit within the address space

On to, 2017-01-19 at 14:30 +, Chris Wilson wrote: > On Thu, Jan 19, 2017 at 12:58:46PM +, Chris Wilson wrote: > > > > Useful sanity check that the vma is legal to bind inside the address > > space. > > > > Signed-off-by: Chris Wilson > > +

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Assert the drm_mm_node is allocated when on the VM lists

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > Before moving the vma between the VM active/inactive lists, assert that > the node is still allocated. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards,

[Intel-gfx] [PATCH] drm/i915/error: use rb_entry()

To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang --- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c

[Intel-gfx] [PATCH 1/4] drm/i915: Don't leak edid in intel_crt_detect_ddc()

In the path where intel_crt_detect_ddc() detects a CRT, if would return true without freeing the edid. Found by coverity. Fixes: a2bd1f541f19 ("drm/i915: check whether we actually received an edid in detect_ddc") Cc: Chris Wilson Cc: Daniel Vetter

[Intel-gfx] [PATCH 3/4] drm/i915: Fix calculation of rotated x and y offsets for planar formats

Parameters tile_size, tile_width and tile_height were passed in the wrong order to _intel_adjust_tile_offset() when calculating the rotated offsets. This doesn't fix any user visible bug, since for packaged formats new and old offset are the same and the rotated offsets are within a tile before

[Intel-gfx] [PATCH 2/4] drm/i915: Don't init hpd polling for vlv and chv from runtime_suspend()

An error in the condition for avoiding the call to intel_hpd_poll_init() for valleyview and cherryview from intel_runtime_suspend() caused it to be called unconditionally. Fix it. Found by coverity. Fixes: 19625e85c6ec ("drm/i915: Enable polling when we don't have hpd") Cc:

[Intel-gfx] [PATCH 4/4] drm/i915: Check for NULL atomic state in intel_crtc_disable_noatomic()

In intel_crtc_disable_noatomic(), bail on a failure to allocate an atomic state to avoid a NULL pointer dereference. Found by coverity. Fixes: 4a80655827af ("drm/i915: Pass atomic state to crtc enable/disable functions") Cc: Maarten Lankhorst Cc: Daniel

Re: [Intel-gfx] [RFC] drm/i915: Skip BSW display interrupt checks if we have a GT interrupt

On Fri, Jan 20, 2017 at 01:13:48PM +, Chris Wilson wrote: > On Fri, Jan 20, 2017 at 10:15:09AM +, Chris Wilson wrote: > > GT interrupts are very, very frequent as they are used for submitting > > every request to the hardware (thanks be to execlists). Given their > > prevalence and the

[Intel-gfx] [PATCH] drm/i915/crt: Keep the EDID for the whole detect cycle

Other than reducing the number of EDID reads required for probing the modes on a connector, this refactor has the importance of centralising the logic for deciding when we need to probe for an analogue output via DVI-I and then consistently using that information between detection and mode

[Intel-gfx] [CI 1/3] drm/i915/huc: Avoid attempting to authenticate non-existent fw

HuC authentication is called even if HuC firmware is not present in the system, leading to NULL ptr dereference on not allocated gem_object. Let's avoid trying to authenticate HuC if its firmware is not loaded successfully. Fixes: dac84a388528 ("drm/i915/huc: Support HuC authentication") v2:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/huc: Avoid attempting to authenticate non-existent fw

== Series Details == Series: series starting with [CI,1/3] drm/i915/huc: Avoid attempting to authenticate non-existent fw URL : https://patchwork.freedesktop.org/series/18320/ State : failure == Summary == Series 18320v1 Series without cover letter

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/3] drm/i915/huc: Avoid attempting to authenticate non-existent fw

On Fri, Jan 20, 2017 at 07:54:09PM -, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/3] drm/i915/huc: Avoid attempting to > authenticate non-existent fw > URL : https://patchwork.freedesktop.org/series/18320/ > State : failure > > == Summary == > > Series

Re: [Intel-gfx] [PATCH 2/5] drm/edid: Introduce drm_default_rgb_quant_range()

ville.syrj...@linux.intel.com writes: > From: Ville Syrjälä > > Make the code selecting the RGB quantization range a little less magicy > by wrapping it up in a small helper. This series seems good. I won't have the ability to test it on vc4 within a reasonable

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Remove crtc->config usage from intel_modeset_readout_hw_state()

On Tue, Dec 27, 2016 at 03:56:54PM +0100, Daniel Vetter wrote: > On Thu, Dec 22, 2016 at 04:04:41PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > crtc->config is on its way out. Let's reduce our dependence on it a > > little bit by

[Intel-gfx] [CI 3/3] HAX enable guc loading for CI

--- drivers/gpu/drm/i915/i915_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 0e280fb..90d838f 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@

[Intel-gfx] [CI 2/3] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

HuC firmware is mapped at GuC accessible range. Let's add an assert to verify that. Cc: Anusha Srivatsa Cc: Arkadiusz Hiler Cc: Chris Wilson Reviewed-by: Michal Wajdeczko Signed-off-by:

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

The intel_dp_autotest_video_pattern() function gets invoked through the compliance test handler on a HPD short pulse if the test type is set to DP_TEST_VIDEO_PATTERN. This performs the DPCD registers reads to read the requested test pattern, video pattern resolution, frame rate and bits per color

[Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

v4: * Remove redundant single bit defs (Jani Nikula) v3: * Fix the conventions in bit definitions (Jani Nikula) v2: * Add all the other DP Complianec TEST register defs (Jani Nikula) Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter

[Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. v2: * Added read

[Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

This patch series addresses all the review comments from the previous series: https://patchwork.freedesktop.org/series/18256/ On top of that it also adds a fix for CRC mismatches seen during 18bpp video pattern compliance testing. This is done by forcing dither on the pipe to be disabled if it is

[Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

This patch adds support to handle automated DP compliance link training test requests. This patch has been tested with Unigraf DPR-120 DP Compliance device for testing Link Training Compliance. After we get a short pulse Compliance test request, test request values are read and hotplug uevent is

[Intel-gfx] ✓ Fi.CI.BAT: success for Add automation support for DP Compliance (Rev 6)

== Series Details == Series: Add automation support for DP Compliance (Rev 6) URL : https://patchwork.freedesktop.org/series/18329/ State : success == Summary == Series 18329v1 Add automation support for DP Compliance (Rev 6)

Re: [Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

On Fri, Jan 20, 2017 at 01:16:13PM -0800, Daniele Ceraolo Spurio wrote: > Ping. can anyone review/comment on this? > > Thanks, > Daniele > > On 12/01/17 14:21, daniele.ceraolospu...@intel.com wrote: > >From: Daniele Ceraolo Spurio > > > >The call went away in: >

[Intel-gfx] [PATCH v2] drm/i915: reinstate call to trace_i915_vma_bind

The call went away in: commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad Author: Chris Wilson Date: Thu Aug 4 16:32:25 2016 +0100 drm/i915: Split insertion/binding of an object into the VM It is useful to have this trace as it pairs nicely with the vma_unbind one

Re: [Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

On Fri, Jan 20, 2017 at 01:35:21PM -0800, Daniele Ceraolo Spurio wrote: > > > On 20/01/17 13:28, Chris Wilson wrote: > >On Fri, Jan 20, 2017 at 01:16:13PM -0800, Daniele Ceraolo Spurio wrote: > >>Ping. can anyone review/comment on this? > >> > >>Thanks, > >>Daniele > >> > >>On 12/01/17 14:21,

[Intel-gfx] [PATCH 2/2] drm/i915: Silence smatch for cmdparser

drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue

[Intel-gfx] [PATCH 1/2] drm/i915: Squelch smatch warning for statement with no effect

The sgt iterators cause an drivers/gpu/drm/i915/i915_gpu_error.c:846 i915_error_object_create() warn: statement has no effect 7 everywhere they are used. If we change the code slightly, we can achieve the same increment without altering the output or raising a warning. textdata bss

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: reinstate call to trace_i915_vma_bind (rev2)

== Series Details == Series: drm/i915: reinstate call to trace_i915_vma_bind (rev2) URL : https://patchwork.freedesktop.org/series/17929/ State : success == Summary == Series 17929v2 drm/i915: reinstate call to trace_i915_vma_bind

Re: [Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

Ping. can anyone review/comment on this? Thanks, Daniele On 12/01/17 14:21, daniele.ceraolospu...@intel.com wrote: From: Daniele Ceraolo Spurio The call went away in: commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad Author: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Squelch smatch warning for statement with no effect

== Series Details == Series: series starting with [1/2] drm/i915: Squelch smatch warning for statement with no effect URL : https://patchwork.freedesktop.org/series/18326/ State : success == Summary == Series 18326v1 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

On 20/01/17 13:28, Chris Wilson wrote: On Fri, Jan 20, 2017 at 01:16:13PM -0800, Daniele Ceraolo Spurio wrote: Ping. can anyone review/comment on this? Thanks, Daniele On 12/01/17 14:21, daniele.ceraolospu...@intel.com wrote: From: Daniele Ceraolo Spurio

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/huc: Avoid attempting to authenticate non-existent fw

On Fri, Jan 20, 2017 at 04:28:23PM +0100, Michał Winiarski wrote: > HuC authentication is called even if HuC firmware is not present in the > system, leading to NULL ptr dereference on not allocated gem_object. > Let's avoid trying to authenticate HuC if its firmware is not loaded > successfully.

Re: [Intel-gfx] [PATCH 2/2] drm/i915/glk: Apply WaIncreaseDefaultTLBEntries on GLK.

On Fri, Jan 20, 2017 at 1:32 AM, Ander Conselvan De Oliveira wrote: > On Thu, 2017-01-19 at 10:39 -0800, Rodrigo Vivi wrote: >> According to wa_database this Wa persist on GLK as it was on BXT. >> >> Cc: Tim Gore >> Cc: Mika Kuoppala

Re: [Intel-gfx] [PATCH v3] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

On Fri, Jan 20, 2017 at 04:56:08PM +0100, Michał Winiarski wrote: > HuC firmware is mapped at GuC accessible range. Let's add an assert to > verify that. > > v2: Split from previous commit (Michał) > v3: Oops, hit send before compiling, s/huc_fw/huc->fw And now I've amended the wrong patch...

Re: [Intel-gfx] [PATCH 3/3] drm/i915/glk: Turn on workarounds that apply to Geminilake too

On Thu, Jan 12, 2017 at 3:47 AM, Ander Conselvan de Oliveira wrote: > Apply workarounds to Geminilake, and annoatate those that are applied > uncondionally when they apply to GLK based on the workaround database. > > Signed-off-by: Ander Conselvan de

[Intel-gfx] [PATCH] drm/i915/huc: Avoid attempting to authenticate non-existent fw

HuC authentication is called even if HuC firmware is not present in the system, leading to NULL ptr dereference on not allocated gem_object. Let's avoid trying to authenticate HuC if its firmware is not loaded succesfully. While I'm here let's also assert that HuC vma is placed in GuC accessible

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Fix calculation of rotated x and y offsets for planar formats

On Fri, Jan 20, 2017 at 04:28:44PM +0200, Ander Conselvan de Oliveira wrote: > Parameters tile_size, tile_width and tile_height were passed in the > wrong order to _intel_adjust_tile_offset() when calculating the rotated > offsets. > > This doesn't fix any user visible bug, since for packaged

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Check for NULL atomic state in intel_crtc_disable_noatomic()

On Fri, Jan 20, 2017 at 04:28:45PM +0200, Ander Conselvan de Oliveira wrote: > In intel_crtc_disable_noatomic(), bail on a failure to allocate an > atomic state to avoid a NULL pointer dereference. > > Found by coverity. > > Fixes: 4a80655827af ("drm/i915: Pass atomic state to crtc

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Don't leak edid in intel_crt_detect_ddc()

On Fri, Jan 20, 2017 at 04:28:42PM +0200, Ander Conselvan de Oliveira wrote: > In the path where intel_crt_detect_ddc() detects a CRT, if would return > true without freeing the edid. > > Found by coverity. > > Fixes: a2bd1f541f19 ("drm/i915: check whether we actually received an > edid in

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Don't leak edid in intel_crt_detect_ddc()

On Fri, 20 Jan 2017, Ander Conselvan de Oliveira wrote: > In the path where intel_crt_detect_ddc() detects a CRT, if would return > true without freeing the edid. > > Found by coverity. > > Fixes: a2bd1f541f19 ("drm/i915: check whether we actually received

Re: [Intel-gfx] [PATCH] drm/i915/huc: Avoid attempting to authenticate non-existent fw

On Fri, Jan 20, 2017 at 03:54:30PM +0100, Michał Winiarski wrote: > HuC authentication is called even if HuC firmware is not present in the > system, leading to NULL ptr dereference on not allocated gem_object. > Let's avoid trying to authenticate HuC if its firmware is not loaded > succesfully. >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with drm/i915/crt: Keep the EDID for the whole detect cycle (rev2)

== Series Details == Series: series starting with drm/i915/crt: Keep the EDID for the whole detect cycle (rev2) URL : https://patchwork.freedesktop.org/series/18297/ State : failure == Summary == Series 18297v2 Series without cover letter

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/error: use rb_entry()

== Series Details == Series: drm/i915/error: use rb_entry() URL : https://patchwork.freedesktop.org/series/18298/ State : failure == Summary == Series 18298v1 drm/i915/error: use rb_entry() https://patchwork.freedesktop.org/api/1.0/series/18298/revisions/1/mbox/ Test gem_busy:

[Intel-gfx] [PATCH v2 1/2] drm/i915/huc: Avoid attempting to authenticate non-existent fw

HuC authentication is called even if HuC firmware is not present in the system, leading to NULL ptr dereference on not allocated gem_object. Let's avoid trying to authenticate HuC if its firmware is not loaded successfully. Fixes: dac84a388528 ("drm/i915/huc: Support HuC authentication") v2:

[Intel-gfx] [PATCH v2 2/2] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

HuC firmware is mapped at GuC accessible range. Let's add an assert to verify that. Cc: Anusha Srivatsa Cc: Arkadiusz Hiler Cc: Chris Wilson Cc: Michal Wajdeczko Signed-off-by: Michał

Re: [Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

On Fri, 20 Jan 2017, Manasi Navare wrote: > v3: > * Fix the conventions in bit definitions (Jani Nikula) > v2: > * Add all the other DP Complianec TEST register defs (Jani Nikula) > Cc: dri-de...@lists.freedesktop.org > Cc: Jani Nikula >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

On Fri, Jan 20, 2017 at 04:28:24PM +0100, Michał Winiarski wrote: > HuC firmware is mapped at GuC accessible range. Let's add an assert to > verify that. > > Cc: Anusha Srivatsa > Cc: Arkadiusz Hiler > Cc: Chris Wilson

[Intel-gfx] [PATCH] drm/i915/dp: do not proceed with autotests if we don't ACK them

There is no point in setting intel_dp->compliance.test_type, and proceeding with the autotests, if we're about to NAK the request. Some drive-by cleanups while at it. Cc: Manasi Navare Signed-off-by: Jani Nikula ---

[Intel-gfx] [PATCH v3] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

HuC firmware is mapped at GuC accessible range. Let's add an assert to verify that. v2: Split from previous commit (Michał) v3: Oops, hit send before compiling, s/huc_fw/huc->fw Cc: Anusha Srivatsa Cc: Arkadiusz Hiler Cc: Chris Wilson

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Don't leak edid in intel_crt_detect_ddc()

== Series Details == Series: series starting with [1/4] drm/i915: Don't leak edid in intel_crt_detect_ddc() URL : https://patchwork.freedesktop.org/series/18297/ State : warning == Summary == Series 18297v1 Series without cover letter

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Don't init hpd polling for vlv and chv from runtime_suspend()

On Fri, Jan 20, 2017 at 04:28:43PM +0200, Ander Conselvan de Oliveira wrote: > An error in the condition for avoiding the call to intel_hpd_poll_init() > for valleyview and cherryview from intel_runtime_suspend() caused it to > be called unconditionally. Fix it. > > Found by coverity. > > Fixes:

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

On Fri, 20 Jan 2017, Manasi Navare wrote: > This patch adds support to handle automated DP compliance > link training test requests. This patch has been tested with > Unigraf DPR-120 DP Compliance device for testing Link > Training Compliance. > After we get a short

[Intel-gfx] [PATCH i-g-t] tools/intel_reg: Dump SKL AUX_DIST registers for all planes

From: Ville Syrjälä We are missing the AUX_DIST registers for pipes A and B. Add them, and move the pipe C AUX_DIST registers next to the AUX_OFFSET registers for a bit more convenience. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add support for Legacy HDMI audio drivers (rev5)

== Series Details == Series: Add support for Legacy HDMI audio drivers (rev5) URL : https://patchwork.freedesktop.org/series/16254/ State : failure == Summary == Series 16254v5 Add support for Legacy HDMI audio drivers https://patchwork.freedesktop.org/api/1.0/series/16254/revisions/5/mbox/

Re: [Intel-gfx] [RFC] drm/i915: Skip BSW display interrupt checks if we have a GT interrupt

On Fri, Jan 20, 2017 at 10:15:09AM +, Chris Wilson wrote: > GT interrupts are very, very frequent as they are used for submitting > every request to the hardware (thanks be to execlists). Given their > prevalence and the comparity rarity of display interrupts, if we do > receive an IRQ and we

Re: [Intel-gfx] 4.9.3, NULL pointer in __wake_up_common / drm / i915

On Thu, Dec 01, Olaf Hering wrote: > On Wed, Nov 16, Olaf Hering wrote: > > During boot into a current openSUSE Tumbleweed 20161108 this laptop > > starts to hang sometimes with 4.8.x. Today I was able to catch this > > crash in __wake_up_common caused by i915 or drm or whatever: > > ... > > [

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Pass around gen to tile_height to special case gen2

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > gen2 has a different tiling pattern, and a fixed tile_height. Pass > along the gen so that we the computed tile_row is large enough to align > with gen2 fences. > > Reported-by: Ville Syrjälä > Signed-off-by:

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Reject vma creation larger than address space

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > Disallow creation of a vma that is larger than the available address > space, or triggers an overflow on fence expansion. > > Testcase: igt/gem_exec_reloc/gtt-32 > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Pass around gen to tile_height to special case gen2

On pe, 2017-01-20 at 10:36 +, Chris Wilson wrote: > On Thu, Jan 19, 2017 at 09:44:23PM +0200, Ville Syrjälä wrote: > > > > Still inaccurate for 915+Y, but if this is only used to compute the tile > > row size it'll just give a needlessly large answer and so should be > > safe. > > The

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Assert that created vma has a whole number of pages

On to, 2017-01-19 at 19:26 +, Chris Wilson wrote: > VMA (and their objects) are supposed to composed of whole pages. Add an > assert to catch any invalid construct when we create the VMA. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala

Re: [Intel-gfx] [PATCH] drm/i915: Re-enable preallocated top level PDPs support

Hi Guys: Please don't merge this patch at this time as I found another problem about alias PPGTT. It seems the alias PPGTT on GEN8+ is also broken under native i915. The first allocate_va_range() in alias PPGTT initialization path will allocate all the page tables and the next

Re: [Intel-gfx] [PATCH i-g-t v1 0/6] Memory allocation fixes

Patches 1-4 and 6 are Reviewed-by: Petri Latvala On Thu, Jan 19, 2017 at 11:35:00AM -0500, Robert Foss wrote: > This series contains a few separate fixes mostly for memory allocations > but also some small unrelated small fixes. > > This series can be found here

Re: [Intel-gfx] [PATCH v2] pwm: lpss: Make builtin so that i915 can find the pwm_backlight

On Fri, Jan 20, 2017 at 10:02:50AM +0200, Jani Nikula wrote: > That said, I suppose there could be an alternative to handling pwm_get() > failures at probe. We could just go on with our init, but schedule a > retry later. Perhaps a bit hacky, but it would address both of the > concerns above.

[Intel-gfx] [PATCH v2] drm/i915/dp: do not proceed with autotests if we don't ACK them

There is no point in setting intel_dp->compliance.test_type, and proceeding with the autotests, if we're about to NAK the request. Some drive-by cleanups while at it. v2: look at the ACK bit, as the result may also contain TEST_EDID_CHECKSUM_WRITE Cc: Manasi Navare

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On 20/01/17 18:44, Jani Nikula wrote: On Fri, 20 Jan 2017, Martin Peres wrote: On 19/01/17 11:18, Jani Nikula wrote: On Wed, 18 Jan 2017, Martin Peres wrote: On 16/12/16 15:48, Daniel Vetter wrote: On Fri, Dec 16, 2016 at

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/huc: Avoid attempting to authenticate non-existent fw (rev3)

== Series Details == Series: series starting with [v3,1/2] drm/i915/huc: Avoid attempting to authenticate non-existent fw (rev3) URL : https://patchwork.freedesktop.org/series/18301/ State : failure == Summary == Series 18301v3 Series without cover letter

Re: [Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

On Fri, Jan 20, 2017 at 05:33:51PM +0200, Jani Nikula wrote: > On Fri, 20 Jan 2017, Manasi Navare wrote: > > v3: > > * Fix the conventions in bit definitions (Jani Nikula) > > v2: > > * Add all the other DP Complianec TEST register defs (Jani Nikula) > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Use IS_GEN9 and IS_LP to put Skylake and Kabylake in the same bucket.

On Thu, Jan 19, 2017 at 10:56 PM, Jani Nikula wrote: > On Fri, 20 Jan 2017, Anusha Srivatsa wrote: >> With GLK was introduced IS_LP. >> With this, we can use IS_GEN9 and IS_LP to put Skylake >> and Kabylake in the same bucket. The main intention

Re: [Intel-gfx] [alsa-devel] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

On 1/20/17 5:15 AM, Takashi Iwai wrote: On Fri, 20 Jan 2017 23:22:31 +0100, Jerome Anand wrote: + had_ops_v1 = had_ops_v1;/* unused */ Until now I didn't realize that the whole v1 stuff is never used in the current patchset. Will it be ever used in future? If not, can't we

[Intel-gfx] [PATCH v3 1/2] drm/i915/huc: Avoid attempting to authenticate non-existent fw

HuC authentication is called even if HuC firmware is not present in the system, leading to NULL ptr dereference on not allocated gem_object. Let's avoid trying to authenticate HuC if its firmware is not loaded successfully. Fixes: dac84a388528 ("drm/i915/huc: Support HuC authentication") v2:

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On 19/01/17 11:18, Jani Nikula wrote: On Wed, 18 Jan 2017, Martin Peres wrote: On 16/12/16 15:48, Daniel Vetter wrote: On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote: The two remaining patches from [1], rebased. BR, Jani. [1]

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On Fri, 20 Jan 2017, Martin Peres wrote: > On 19/01/17 11:18, Jani Nikula wrote: >> On Wed, 18 Jan 2017, Martin Peres wrote: >>> On 16/12/16 15:48, Daniel Vetter wrote: On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: do not proceed with autotests if we don't ACK them

== Series Details == Series: drm/i915/dp: do not proceed with autotests if we don't ACK them URL : https://patchwork.freedesktop.org/series/18305/ State : success == Summary == Series 18305v1 drm/i915/dp: do not proceed with autotests if we don't ACK them

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/huc: Avoid attempting to authenticate non-existent fw

== Series Details == Series: drm/i915/huc: Avoid attempting to authenticate non-existent fw URL : https://patchwork.freedesktop.org/series/18300/ State : warning == Summary == Series 18300v1 drm/i915/huc: Avoid attempting to authenticate non-existent fw

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On 19/01/17 13:34, Ville Syrjälä wrote: On Wed, Jan 18, 2017 at 11:05:18PM +0200, Martin Peres wrote: On 16/12/16 15:48, Daniel Vetter wrote: On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote: The two remaining patches from [1], rebased. BR, Jani. [1]

Re: [Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

On Fri, 20 Jan 2017, Manasi Navare wrote: > On Fri, Jan 20, 2017 at 05:33:51PM +0200, Jani Nikula wrote: >> On Fri, 20 Jan 2017, Manasi Navare wrote: >> > v3: >> > * Fix the conventions in bit definitions (Jani Nikula) >> > v2: >> > * Add all

Re: [Intel-gfx] [PATCH v3] drm/i915/huc: Assert that HuC vma is placed in GuC accessible range

On Fri, Jan 20, 2017 at 04:58:51PM +0100, Michał Winiarski wrote: > On Fri, Jan 20, 2017 at 04:56:08PM +0100, Michał Winiarski wrote: > > HuC firmware is mapped at GuC accessible range. Let's add an assert to > > verify that. > > > > v2: Split from previous commit (Michał) > > v3: Oops, hit send

[Intel-gfx] [PATCH i-g-t v1 16/32] tests/kms_mmio_vs_cs_flip: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_mmio_vs_cs_flip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_mmio_vs_cs_flip.c b/tests/kms_mmio_vs_cs_flip.c

[Intel-gfx] [PATCH i-g-t v1 06/32] tests/kms_busy: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_busy.c b/tests/kms_busy.c index 1ae5d7fb..e6276927 100644 ---

[Intel-gfx] [PATCH i-g-t v1 17/32] tests/kms_panel_fitting: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/kms_panel_fitting.c

[Intel-gfx] [PATCH i-g-t v1 14/32] tests/kms_legacy_colorkey: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_legacy_colorkey.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_legacy_colorkey.c b/tests/kms_legacy_colorkey.c

[Intel-gfx] [PATCH i-g-t v1 10/32] tests/kms_cursor_legacy: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_cursor_legacy.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/tests/kms_cursor_legacy.c

[Intel-gfx] [PATCH i-g-t v1 05/32] tests/kms_atomic_transition: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_atomic_transition.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/tests/kms_atomic_transition.c

[Intel-gfx] [PATCH i-g-t v1 09/32] tests/kms_cursor_crc: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_cursor_crc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index

[Intel-gfx] [PATCH i-g-t v1 04/32] lib/igt_kms: Implement dynamic plane count support

In upcoming drm-misc-next changes, the number of planes per pipe has been increased as more than one primary plane can be associated with a pipe. The simple fix for this would be to simply bump hardcoded value for number of frames per pipe. But a better solution would be to add support for

[Intel-gfx] [PATCH i-g-t v1 01/32] lib/igt_kms: Add index property to kmstest_plane struct

Add an index property which helps accessing the corresponding igt_plane_t structure through the igt_*_get_plane() functions. Signed-off-by: Robert Foss --- lib/igt_kms.c| 12 ++-- lib/igt_kms.h| 1 + tests/kms_plane_lowres.c | 2 +- 3

[Intel-gfx] [PATCH i-g-t v1 18/32] tests/kms_pipe_color: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_pipe_color.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/kms_pipe_color.c b/tests/kms_pipe_color.c index

[Intel-gfx] [PATCH i-g-t v1 19/32] tests/kms_plane: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_plane.c | 94 ++- 1 file changed, 52 insertions(+), 42 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t v1 15/32] tests/kms_mmap_write_crc: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_mmap_write_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_mmap_write_crc.c b/tests/kms_mmap_write_crc.c index

[Intel-gfx] [PATCH i-g-t v1 13/32] tests/kms_flip_event_leak: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_flip_event_leak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_flip_event_leak.c b/tests/kms_flip_event_leak.c index

[Intel-gfx] [PATCH i-g-t v1 07/32] tests/kms_chv_cursor_fail: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_chv_cursor_fail.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_chv_cursor_fail.c b/tests/kms_chv_cursor_fail.c

[Intel-gfx] [PATCH i-g-t v1 08/32] tests/kms_crtc_background_color: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_crtc_background_color.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_crtc_background_color.c

[Intel-gfx] [PATCH i-g-t v1 03/32] lib/igt_kms: Rename kmstest properties nplanes and plane

Rename these properties to have them use the same naming convention as the igt_*_t structs. Signed-off-by: Robert Foss --- lib/igt_kms.c| 16 +--- lib/igt_kms.h| 4 ++-- tests/kms_plane_lowres.c | 10 +- 3 files changed, 16

[Intel-gfx] [PATCH i-g-t v1 02/32] lib/igt_kms: Avoid depencency on static plane count

Rework kmstest_crtc and kmstest_plane structs and their usage to not depend on a static plane count. Signed-off-by: Robert Foss --- lib/igt_kms.c | 47 ++- lib/igt_kms.h | 4 ++-- 2 files changed, 32 insertions(+), 19

[Intel-gfx] [PATCH i-g-t v1 12/32] tests/kms_fence_pin_leak: Add support for dynamic number of planes

Add changes reflecting the new support for dynamic number of planes per pipe. Signed-off-by: Robert Foss --- tests/kms_fence_pin_leak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_fence_pin_leak.c b/tests/kms_fence_pin_leak.c index

[Intel-gfx] [PATCH i-g-t v1 00/32] lib/igt_kms: Implement dynamic plane count support

This series implements dynamic plane count support in lib/igt_kms and modifies all of the tests that rely on a static plane count. Currently it has has gone through incomplete testing on vc4 (many tests are intel only) and intel (on intel-ci). This series can be found in branch

  1   2   >