On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> commit 64f6a5d1922b ("container_of: add container_of_const()
> that preserves const-ness of the pointer") is nice. Let's use
> it so that we don't accidentally cast away the const from our
> state pointers.
>
> The only thing I
On Wed, Feb 28, 2024 at 10:02:13AM +0200, Stanislav Lisovskiy wrote:
> Currently we can't change MBUS join status without doing a modeset,
> because we are lacking mechanism to synchronize those with vblank.
> However then this means that we can't do a fastset, if there is a need
> to change MBUS
Some renames, some formatting fixes, add some missing documentation.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git
There's no proper way to document function pointer members, but at least
silence the warnings.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_kmap_iter.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h
Ensure drm headers build, are self-contained, have header guards, and
have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y.
The mechanism follows similar patters used in i915, xe, and usr/include.
To cover include/drm, we need to recurse there using the top level
Kbuild and the new
struct seq_file needs a forward declaration in some configs. Sort the
forward declarations while at it.
Cc: Christian Koenig
Cc: Huang Rui
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202403072259.eec2vf1x-...@intel.com/
Signed-off-by: Jani Nikula
---
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/display/drm_dp_mst_topology_internal.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology_internal.h
Include for pgprot_t.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_caching.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/drm/ttm/ttm_caching.h b/include/drm/ttm/ttm_caching.h
index
Fix some formatting errors and excess documentation.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_execbuf_util.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/drm/ttm/ttm_execbuf_util.h
From: Geert Uytterhoeven
When just including :
include/asm-generic/pgtable-nop4d.h:9:18: error: unknown type name ‘pgd_t’
9 | typedef struct { pgd_t pgd; } p4d_t;
| ^
Make self-contained by including .
Reported-by: Jani Nikula
Closes:
== Series Details ==
Series: drm/i915: Use drm_printer more (rev7)
URL : https://patchwork.freedesktop.org/series/129956/
State : warning
== Summary ==
Error: dim checkpatch failed
b04d780cbd26 drm/i915: Indicate which pipe failed the fastset check overall
c250c70986f2 drm/i915: Include CRTC
== Series Details ==
Series: drm/i915: Use drm_printer more (rev7)
URL : https://patchwork.freedesktop.org/series/129956/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The connector state passed to .atomic_get_property() is const.
> We should preserve that when downcasting to our version.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
>
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Remove the pointless (void*) cast, the incoming pointer is already
> the correct type.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/intel_sdvo.c | 2 +-
> 1 file changed, 1
On Thu, 2024-03-07 at 19:16 +0200, Ville Syrjälä wrote:
> On Wed, Mar 06, 2024 at 10:34:25AM +0200, Jouni Högander wrote:
> > Bspec mentions 50 us for IO wake time and 32 us for fast wake time.
> > 32 us
> > is most probably wrong as it doesn't meet the specification as fast
> > wake
> > time is
On Thu, 2024-03-07 at 19:15 +0200, Ville Syrjälä wrote:
> On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote:
> > IO buffer wake time used for IO wake calculation is dependent on
> > port clock
> > on LunarLake and beyond. Take this into account in
> > get_io_buffer_wake_time.
> >
> >
On Thu, 7 Mar 2024 14:02:33 +0530
Nemesa Garg wrote:
> This allows the user to set the intensity
> so as to get the sharpness effect.
>
> It is useful in scenario when the output is blurry
> and user want to sharpen the pixels.
>
> Signed-off-by: Nemesa Garg
> ---
>
On Thu, 07 Mar 2024, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Use enc_to_intel_dsi() instead hand rolling it.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 3 +--
> drivers/gpu/drm/i915/display/vlv_dsi.c | 3 +--
> 2 files
== Series Details ==
Series: drm/i915: Use drm_printer more (rev7)
URL : https://patchwork.freedesktop.org/series/129956/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14410 -> Patchwork_129956v7
Summary
---
This patch set is improving IO and fast wake lines calculation in PSR
code:
Use actual fast wake sync pulse count in calculation Implement getter
for IO buffer wake times and use that. Better presentation on how
these are calculated. Use calculation for display version < 12 as
well.
Also
ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO
wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static
to make it available for PSR code.
v2: use int instead of u8
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 2 +-
Current fast and IO wake lines calculation is assuming fast wake sync
length is 18 pulses. Let's improve this by checking actual length.
Add getter for IO buffer wake time and return 10 us there which was assumed
with static 42 us IO wake time. Upcoming patches will extent this for
different
IO buffer wake time used for IO wake calculation is dependent on port clock
on LunarLake and beyond. Take this into account in get_io_buffer_wake_time.
Bspec: 65450
v2: add own io_wake_time helper for LunarLake
Signed-off-by: Jouni Högander
---
drivers/gpu/drm/i915/display/intel_psr.c | 14
Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us
is most probably wrong as it doesn't meet the specification as fast wake
time is calculated in Bspec like this:
10..16 us (precharge) + 8 us (preamble) + 4 us (phy_wake) + 20 us
(tfw_exit_latency)
Instead of using these
Increasing number of fast wake sync pulses seem to fix problems with
certain PSR panels. This should be ok for other panels as well as the eDP
specification allows 10...16 precharge pulses and we are still within that
range.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9739
On Fri, 2024-03-08 at 12:11 +0200, Ville Syrjälä wrote:
> On Fri, Mar 08, 2024 at 08:39:36AM +, Hogander, Jouni wrote:
> > On Thu, 2024-03-07 at 19:15 +0200, Ville Syrjälä wrote:
> > > On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote:
> > > > IO buffer wake time used for IO wake
Make the documentation match code.
v2: Small fixups while at it (Lucas)
Acked-by: Thomas Zimmermann
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
include/drm/i915_hdcp_interface.h | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git
Make documentation match code. Slightly fix up the documentation
comments while at it.
v2:
- Move comments next to members instead of struct comment (Lucas)
- Small fixups while at it
Cc: Lucas De Marchi
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
Document structs drm_encoder_slave_funcs, drm_encoder_slave, and
drm_i2c_encoder_driver.
v2: Actually document the structs instead of just silencing kernel-doc
Signed-off-by: Jani Nikula
---
include/drm/drm_encoder_slave.h | 91 +++--
1 file changed, 74
Mark some members private to silence kernel-doc warnings, and add FIXME
comments.
Signed-off-by: Jani Nikula
---
include/drm/i2c/ch7006.h | 1 +
include/drm/i2c/sil164.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/drm/i2c/ch7006.h b/include/drm/i2c/ch7006.h
index
Follow-up to [1], with the already merged patches dropped, review
comments addressed, some new patches added, etc.
I did still leave in the FIXME comments in "drm/i2c: silence ch7006.h
and sil164.h kernel-doc warnings", and just silenced the
warnings. Fairly rarely used stuff, and mostly
Including the file twice can lead to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_internal.h
b/drivers/gpu/drm/drm_crtc_internal.h
index c0c5d79ed4c9..0c693229a1c9 100644
---
Including the file twice can lead to errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_helper_internal.h
b/drivers/gpu/drm/drm_crtc_helper_internal.h
index
There's no proper way to document function pointer members, but at least
silence the warnings.
Acked-by: Thomas Zimmermann
Reviewed-by: Lucas De Marchi
Signed-off-by: Jani Nikula
---
include/drm/i915_gsc_proxy_mei_interface.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On Fri, Mar 08, 2024 at 08:39:36AM +, Hogander, Jouni wrote:
> On Thu, 2024-03-07 at 19:15 +0200, Ville Syrjälä wrote:
> > On Wed, Mar 06, 2024 at 10:34:26AM +0200, Jouni Högander wrote:
> > > IO buffer wake time used for IO wake calculation is dependent on
> > > port clock
> > > on LunarLake
On Fri, Mar 08, 2024 at 12:07:19PM +0200, Ville Syrjälä wrote:
> On Wed, Feb 28, 2024 at 10:02:13AM +0200, Stanislav Lisovskiy wrote:
> > Currently we can't change MBUS join status without doing a modeset,
> > because we are lacking mechanism to synchronize those with vblank.
> > However then this
== Series Details ==
Series: VBT read cleanup (rev7)
URL : https://patchwork.freedesktop.org/series/130528/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14413 -> Patchwork_130528v7
Summary
---
**WARNING**
Minor
On Fri, Mar 08, 2024 at 01:00:36PM +0200, Jouni Högander wrote:
> Current fast and IO wake lines calculation is assuming fast wake sync
> length is 18 pulses. Let's improve this by checking actual length.
>
> Add getter for IO buffer wake time and return 10 us there which was assumed
> with
On Fri, Mar 08, 2024 at 01:00:35PM +0200, Jouni Högander wrote:
> ALPM AUX-Wake fast wake sync pulse count is needed by PSR to calculate IO
> wake and fast wake lines. Convert intel_dp_aux_fw_sync_len as non-static
> to make it available for PSR code.
>
> v2: use int instead of u8
>
>
Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure
after linux-next include refactoring.
Signed-off-by: Joonas Lahtinen
Cc: Chris Wilson
Cc: Jani Nikula
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_memcpy.c | 2 ++
1 file changed, 2 insertions(+)
On Fri, Mar 08, 2024 at 01:55:53PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 10 ++
1 file changed, 6 insertions(+),
On Fri, Mar 08, 2024 at 01:55:52PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/display/drm_dp_mst_topology_internal.h | 4 +++-
1 file changed, 3
On Fri, Mar 08, 2024 at 09:24:00AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Our definitions for bit 7 and bit 0 of ICL_PORT_TX_DW6 are
> swapped. Functionally it doesn't matter as we always set both
> bits, but let's rename the bits to match bspec 100%.
>
> And while at it, add the
On Mon, 2024-03-04 at 13:13 +0530, Animesh Manna wrote:
> Link Off Between Active Frames, is a new feature for eDP
> that allows the panel to go to lower power state after
> transmission of data. This is a feature on top of ALPM, AS SDP.
> Add compute config during atomic-check phase.
>
>
On Fri, Mar 08, 2024 at 01:00:38PM +0200, Jouni Högander wrote:
> IO buffer wake time used for IO wake calculation is dependent on port clock
> on LunarLake and beyond. Take this into account in get_io_buffer_wake_time.
>
> Bspec: 65450
>
> v2: add own io_wake_time helper for LunarLake
>
>
On Fri, Mar 08, 2024 at 04:39:55PM +0200, Ville Syrjälä wrote:
> On Fri, Mar 08, 2024 at 01:00:38PM +0200, Jouni Högander wrote:
> > IO buffer wake time used for IO wake calculation is dependent on port clock
> > on LunarLake and beyond. Take this into account in get_io_buffer_wake_time.
> >
> >
== Series Details ==
Series: drm: fix headers, add header test facility
URL : https://patchwork.freedesktop.org/series/130917/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14413 -> Patchwork_130917v1
Summary
---
On Fri, Mar 08, 2024 at 01:55:45PM +0200, Jani Nikula wrote:
Make documentation match code. Slightly fix up the documentation
comments while at it.
v2:
- Move comments next to members instead of struct comment (Lucas)
- Small fixups while at it
Cc: Lucas De Marchi
Acked-by: Thomas Zimmermann
== Series Details ==
Series: Bigjoiner refactoring (rev9)
URL : https://patchwork.freedesktop.org/series/128311/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14413 -> Patchwork_128311v9
Summary
---
**FAILURE**
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 4 ++--
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Adrien Grassein
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 16 +++-
1 file changed, 7 insertions(+), 9
The drm_connector_helper_funcs .get_modes() hooks are not supposed to
return negative error codes. Some do, but they're not checked, and could
lead to mysterious errors. Fix this all over the place.
BR,
Jani.
Jani Nikula (8):
drm/probe-helper: warn about negative .get_modes()
drm/panel: do
The .get_modes() callback is supposed to return the number of modes,
never a negative error code. If a negative value is returned, it'll just
be interpreted as a negative count, and added to previous calculations.
Document the rules, but handle the negative values gracefully with an
error
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Philipp Zabel
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
The .get_modes() hooks aren't supposed to return negative error
codes. Return 0 for no modes, whatever the reason.
Cc: Maxime Ripard
Cc: sta...@vger.kernel.org
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
None of the callers of drm_panel_get_modes() expect it to return
negative error codes. Either they propagate the return value in their
struct drm_connector_helper_funcs .get_modes() hook (which is also not
supposed to return negative codes), or add it to other counts leading to
bogus values.
On
lt9611uxc_connector_get_modes() propagates the return value of
drm_edid_connector_add_modes() but stores the int temporarily in an
unsigned int. Use the correct type.
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Signed-off-by: Jani Nikula
---
On 3/6/2024 12:31 PM, Thomas Hellström wrote:
Have iterators insert themselves into the list they are iterating
over using hitch list nodes. Since only the iterator owner
can remove these list nodes from the list, it's safe to unlock
the list and when continuing, use them as a starting point.
On Fri, Mar 08, 2024 at 01:00:37PM +0200, Jouni Högander wrote:
> Bspec mentions 50 us for IO wake time and 32 us for fast wake time. 32 us
> is most probably wrong as it doesn't meet the specification as fast wake
> time is calculated in Bspec like this:
>
> 10..16 us (precharge) + 8 us
On Fri, 15 Dec 2023, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet
This seems to have been merged to v6.8-rc1 as commit 86b9357c1bbe
("drivers/gpu/drm/i915/i915_memcpy.c: fix missing includes") without
Cc'ing the relevant lists or people, with no commit message or reviews,
or the CI
== Series Details ==
Series: IO and fast wake lines calculation and increase fw sync length (rev5)
URL : https://patchwork.freedesktop.org/series/130173/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: IO and fast wake lines calculation and increase fw sync length (rev5)
URL : https://patchwork.freedesktop.org/series/130173/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14413 -> Patchwork_130173v5
On Fri, Mar 08, 2024 at 04:46:43PM +0200, Joonas Lahtinen wrote:
> Add standalone includes for BUG_ON and BUILD_BUG_ON to avoid build failure
> after linux-next include refactoring.
any lore link so we can use with a 'Closes:' tag?
and perhaps a reported-by?
>
> Signed-off-by: Joonas Lahtinen
On Fri, Mar 08, 2024 at 03:43:35PM +0200, Lisovskiy, Stanislav wrote:
> On Fri, Mar 08, 2024 at 12:07:19PM +0200, Ville Syrjälä wrote:
> > On Wed, Feb 28, 2024 at 10:02:13AM +0200, Stanislav Lisovskiy wrote:
> > > Currently we can't change MBUS join status without doing a modeset,
> > > because we
On Thu, Mar 07, 2024 at 10:14:12PM +0200, Imre Deak wrote:
> On Thu, Mar 07, 2024 at 09:46:22AM -0500, Rodrigo Vivi wrote:
> > On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote:
> > > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote:
> > > > This patch brings no functional
On Wed, Mar 06, 2024 at 04:11:54PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 05.03.24 um 17:25 schrieb Jani Nikula:
> > On Tue, 05 Mar 2024, Rodrigo Vivi wrote:
> > > On Fri, Mar 01, 2024 at 02:42:55PM +0100, Thomas Zimmermann wrote:
> > > > Unregister all in-kernel clients before unloading
Just use 0 and 1 directly, instead of the confusing local variable
that's always set to 0.
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/exynos/exynos_dp.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
On Fr, 2024-03-08 at 18:03 +0200, Jani Nikula wrote:
> The .get_modes() hooks aren't supposed to return negative error
> codes. Return 0 for no modes, whatever the reason.
>
> Cc: Philipp Zabel
> Cc: sta...@vger.kernel.org
> Signed-off-by: Jani Nikula
Acked-by: Philipp Zabel
regards
Philipp
== Series Details ==
Series: drm/i915: Rename ICL_PORT_TX_DW6 bits
URL : https://patchwork.freedesktop.org/series/130899/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14413 -> Patchwork_130899v1
Summary
---
Reorganize the crtc disable path to only deal with the
master pipes/transcoders in intel_old_crtc_state_disables()
and offload the handling of joined pipes to hsw_crtc_disable().
This makes the whole thing much more sensible since we can
actually control the order in which we do the per-pipe vs.
Handle only bigjoiner masters in skl_commit_modeset_enables/disables,
slave crtcs should be handled by master hooks. Same for encoders.
That way we can also remove a bunch of checks like
intel_crtc_is_bigjoiner_slave.
v2: - Moved skl_pfit_enable, intel_dsc_enable, intel_crtc_vblank_on to
From: Vidya Srinivas
We need bigjoiner support with MST functionality
for MST monitor resolutions > 5K to work.
Adding support for the same.
v2: Addressed review comments from Jani.
Revert rejection of MST bigjoiner modes and add
functionality
v3: Fixed pipe_mismatch WARN for
There are few things we need to do for bigjoiner, in order
to improve code maintenance and also make testing for Bigjoiner
easier.
Those series contain addition of bigjoiner force debugfs option,
in order to be able to force bigjoiner even if there is no display
support, also we refactor pipe vs
And we have at least one trivial place in
intel_ddi_update_active_dpll() where we can use it
immediately, so let's do that.
v2: - Fixed conflicts, part of patch didn't apply, because of master_crtc
rename(Stan)
Signed-off-by: Ville Syrjälä
Signed-off-by: Stanislav Lisovskiy
Credits-to:
Extract the "not-MST" stuff from intel_ddi_post_disable() so that
the whole thing isn't so cluttered.
The bigjoiner slave handling was outside of the !MST check,
but it really should have been inside it as its the counterpart
to the master handling inside the check. So we pull that
in as well.
Unify the master vs. slave handling in
intel_ddi_post_disable_hdmi_or_sst() by looping over all the
pipes in one go.
This also lets us move the intel_crtc_vblank_off() calls to
happen in a consistent place vs. the transcoder disable.
Previously we did the master vs. slaves on different sides
of
== Series Details ==
Series: VBT read cleanup (rev7)
URL : https://patchwork.freedesktop.org/series/130528/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Hello Suraj,
> -Original Message-
> From: Intel-gfx On Behalf Of Suraj
> Kandpal
> Sent: Thursday, March 7, 2024 3:59 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Shankar, Uma ; Nautiyal, Ankit K
> ; Kandpal, Suraj
> Subject: [PATCH] drm/i915/dp: Enable AUX based backlight for HDR
>
== Series Details ==
Series: drm: fix headers, add header test facility
URL : https://patchwork.freedesktop.org/series/130917/
State : warning
== Summary ==
Error: dim checkpatch failed
12dea9670af4 drm: add missing header guards to drm_crtc_internal.h
26f540b42f9a drm: add missing header
== Series Details ==
Series: drm: fix headers, add header test facility
URL : https://patchwork.freedesktop.org/series/130917/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Quoting Gustavo Sousa (2024-03-05 11:40:48-03:00)
>Quoting Matt Roper (2024-03-04 18:58:34-03:00)
>>On Mon, Mar 04, 2024 at 03:30:21PM -0300, Gustavo Sousa wrote:
>>> There will be future changes that rely on the source of the MDCLK. Let's
>>> have xe2lpd_mdclk_source_sel() as the function
On Fri, 8 Mar 2024 18:03:44 +0200, Jani Nikula wrote:
> The .get_modes() hooks aren't supposed to return negative error
> codes. Return 0 for no modes, whatever the reason.
>
> Cc: Maxime Ripard
> Cc: sta...@vger.kernel.org
>
> [ ... ]
Acked-by: Maxime Ripard
Thanks!
Maxime
Some renames, some formatting fixes, add some missing documentation.
v3: Fix struct ttm_buffer_object .sg documentation (Christian)
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Reviewed-by: Christian König
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 17
Am 08.03.24 um 12:55 schrieb Jani Nikula:
Some renames, some formatting fixes, add some missing documentation.
Cc: Christian Koenig
Cc: Huang Rui
Acked-by: Thomas Zimmermann
Signed-off-by: Jani Nikula
---
include/drm/ttm/ttm_bo.h | 18 --
1 file changed, 12 insertions(+),
== Series Details ==
Series: Bigjoiner refactoring (rev9)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
+./arch/x86/include/asm/bitops.h:116:1:
== Series Details ==
Series: Bigjoiner refactoring (rev9)
URL : https://patchwork.freedesktop.org/series/128311/
State : warning
== Summary ==
Error: dim checkpatch failed
1a027433f244 Add a small helper to compute the set of pipes that the current
crtc is using.
6fc2f34fb53f drm/i915:
On Fri, Mar 01, 2024 at 02:42:54PM +0100, Thomas Zimmermann wrote:
> Export drm_client_dev_unregister() for use by the i915 driver. The
> driver does not use drm_dev_unregister(),
Perhaps we should make i915 to call for the drm_dev_unregister since it calls
for drm_dev_register?
> so it has to
== Series Details ==
Series: drm/i915: Add includes for BUG_ON/BUILD_BUG_ON in i915_memcpy.c
URL : https://patchwork.freedesktop.org/series/130921/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_14415 -> Patchwork_130921v1
== Series Details ==
Series: drm: fix .get_modes() return values
URL : https://patchwork.freedesktop.org/series/130926/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
Hi
Am 08.03.24 um 17:03 schrieb Jani Nikula:
The drm_connector_helper_funcs .get_modes() hooks are not supposed to
return negative error codes. Some do, but they're not checked, and could
lead to mysterious errors. Fix this all over the place.
Acked-by: Thomas Zimmermann
for the series.
Do
On 3/8/2024 8:03 AM, Jani Nikula wrote:
None of the callers of drm_panel_get_modes() expect it to return
negative error codes. Either they propagate the return value in their
struct drm_connector_helper_funcs .get_modes() hook (which is also not
supposed to return negative codes), or add it
== Series Details ==
Series: drm: fix .get_modes() return values
URL : https://patchwork.freedesktop.org/series/130926/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14415 -> Patchwork_130926v1
Summary
---
== Series Details ==
Series: drm: fix headers, add header test facility (rev2)
URL : https://patchwork.freedesktop.org/series/130917/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_14416 -> Patchwork_130917v2
Summary
On Fri, Mar 8, 2024 at 7:03 AM Jani Nikula wrote:
>
> Including the file twice can lead to errors.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/drm_crtc_internal.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
On Fri, Mar 8, 2024 at 7:08 AM Jani Nikula wrote:
>
> Document structs drm_encoder_slave_funcs, drm_encoder_slave, and
> drm_i2c_encoder_driver.
>
> v2: Actually document the structs instead of just silencing kernel-doc
>
> Signed-off-by: Jani Nikula
Reviewed-by: Alex Deucher
> ---
>
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote:
>
> Including the file twice can lead to errors.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/drm_crtc_helper_internal.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote:
>
> Include for pgprot_t.
>
> Cc: Christian Koenig
> Cc: Huang Rui
> Acked-by: Thomas Zimmermann
> Signed-off-by: Jani Nikula
Reviewed-by: Alex Deucher
> ---
> include/drm/ttm/ttm_caching.h | 2 ++
> 1 file changed, 2 insertions(+)
>
>
On Fri, Mar 8, 2024 at 7:23 AM Jani Nikula wrote:
>
> struct seq_file needs a forward declaration in some configs. Sort the
> forward declarations while at it.
>
> Cc: Christian Koenig
> Cc: Huang Rui
> Reported-by: kernel test robot
> Closes:
>
== Series Details ==
Series: drm: fix headers, add header test facility (rev2)
URL : https://patchwork.freedesktop.org/series/130917/
State : warning
== Summary ==
Error: dim checkpatch failed
b821d1b2ac6b drm: add missing header guards to drm_crtc_internal.h
2a1e5c572621 drm: add missing
1 - 100 of 109 matches
Mail list logo
