Re: [Intel-gfx] [PATCH 16/28] drm/i915: add Punit read/write routines for VLV

2013-03-04 Thread Jani Nikula
On Fri, 01 Mar 2013, Jesse Barnes jbar...@virtuousgeek.org wrote: Slightly different than other platforms. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915/i915_reg.h | 22

[Intel-gfx] [I-G-T PATCH] tools/intel_reg_dumper: add hsw backlight registers

2013-03-04 Thread Jani Nikula
The more the merrier. Signed-off-by: Jani Nikula jani.nik...@intel.com --- lib/intel_reg.h |5 + tools/intel_reg_dumper.c |5 + 2 files changed, 10 insertions(+) diff --git a/lib/intel_reg.h b/lib/intel_reg.h index 99d97bb..db07064 100644 --- a/lib/intel_reg.h +++

[Intel-gfx] Tabs or spaces? (was: [I-G-T] tools/intel_reg_dumper: add hsw backlight registers)

2013-03-04 Thread Paul Menzel
Dear intel-gfx folks, Am Montag, den 04.03.2013, 12:22 +0200 schrieb Jani Nikula: The more the merrier. Signed-off-by: Jani Nikula jani.nik...@intel.com --- lib/intel_reg.h |5 + tools/intel_reg_dumper.c |5 + 2 files changed, 10 insertions(+) diff --git

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't clobber crtc-fb when queue_flip fails

2013-03-04 Thread Ville Syrjälä
On Sun, Mar 03, 2013 at 07:52:33PM +0100, Daniel Vetter wrote: On Fri, Feb 22, 2013 at 03:13:00PM +, Chris Wilson wrote: On Fri, Feb 22, 2013 at 04:53:38PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Restore crtc-fb to the old

[Intel-gfx] [PATCH i-g-t 0/2] kms_flip: Test for page flip crtc-fb clobber bug

2013-03-04 Thread ville . syrjala
This new test 'flip-vs-bad-tiling' will trigger the pin_count underflow BUG in the kernel due to page flip clobbering the crtc-fb pointer when queue_flip fails. With the kernel fix applied the test completes succesfully. I also included a small fix for a use-after-free bug I spotted.

[Intel-gfx] [PATCH i-g-t 1/2] kms_flip: Add flip-vs-bad-tiling test

2013-03-04 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com flip-vs-bad-tiling tests that page flipping to a Y-tiled buffer returns an error correctly, rather than triggering kernel BUG for instance. Create a third fb for this purpose. After the fb has been created, change its tiling mode to Y. When

[Intel-gfx] [PATCH i-g-t 2/2] kms_flip: Don't access freed data

2013-03-04 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- tests/kms_flip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 0da40d3..902ac31 100644 --- a/tests/kms_flip.c +++

Re: [Intel-gfx] [PATCH] drm/i915: GFDT support for SNB/IVB

2013-03-04 Thread Ville Syrjälä
On Sun, Mar 03, 2013 at 05:39:09PM +, Chris Wilson wrote: On Sun, Mar 03, 2013 at 05:28:52PM +0100, Daniel Vetter wrote: The other thing was that I didn't manage to get things to work properly, leaving some random cachline dirt on the screen. Looking at your code, you add the gfdt flush

Re: [Intel-gfx] [PATCH] drm/i915: GFDT support for SNB/IVB

2013-03-04 Thread Chris Wilson
On Mon, Mar 04, 2013 at 03:51:11PM +0200, Ville Syrjälä wrote: On Sun, Mar 03, 2013 at 05:39:09PM +, Chris Wilson wrote: On Sun, Mar 03, 2013 at 05:28:52PM +0100, Daniel Vetter wrote: The other thing was that I didn't manage to get things to work properly, leaving some random cachline

Re: [Intel-gfx] [PATCH] drm/i915: GFDT support for SNB/IVB

2013-03-04 Thread Ville Syrjälä
On Sun, Mar 03, 2013 at 05:28:52PM +0100, Daniel Vetter wrote: On Fri, Mar 01, 2013 at 08:32:57PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Currently all scanout buffers must be uncached because the display controller doesn't snoop the

Re: [Intel-gfx] [PATCH 03/10] drm/i915: add pipe_config-timings_set

2013-03-04 Thread Ville Syrjälä
On Sun, Mar 03, 2013 at 07:01:12PM +0100, Daniel Vetter wrote: On Fri, Feb 22, 2013 at 03:51:15PM +0200, Ville Syrjälä wrote: On Fri, Feb 22, 2013 at 12:56:47AM +0100, Daniel Vetter wrote: Only used by the lvds encoder. Note that we shouldn't do the same simple conversion with the

[Intel-gfx] [PATCH] DRM/i915: On G45 enable cursor plane briefly after enabling the display plane.

2013-03-04 Thread Egbert Eich
On G45 some low res modes (800x600 and 1024x768) produce a blank screen when the display plane is enabled with with cursor plane off. Experiments showed that this issue occurred when the following conditions were met: a. a previous mode had the cursor plane enabled (Xserver). b. this mode or the

Re: [Intel-gfx] [PATCH] DRM/i915: On G45 enable cursor plane briefly after enabling the display plane.

2013-03-04 Thread Daniel Vetter
On Mon, Mar 04, 2013 at 09:24:38AM -0500, Egbert Eich wrote: On G45 some low res modes (800x600 and 1024x768) produce a blank screen when the display plane is enabled with with cursor plane off. Experiments showed that this issue occurred when the following conditions were met: a. a previous

[Intel-gfx] Bug Report

2013-03-04 Thread Roberto CORRADO
Mar 3 06:32:18 hp530 kernel: [20049.642823] [drm:i9xx_crtc_mode_set] *ERROR* Couldn't find PLL settings for mode! Mar 3 06:32:18 hp530 kernel: [20049.642836] [ cut here ] Mar 3 06:32:18 hp530 kernel: [20049.642877] WARNING: at drivers/gpu/drm/i915/intel_display.c:7877

Re: [Intel-gfx] [PATCH 16/28] drm/i915: add Punit read/write routines for VLV

2013-03-04 Thread Jesse Barnes
On Mon, 04 Mar 2013 10:43:03 +0200 Jani Nikula jani.nik...@linux.intel.com wrote: +int valleyview_punit_read(struct drm_i915_private *dev_priv, u8 addr, u32 *val) +{ + u32 cmd, devfn, opcode, port, be, bar; + + bar = 0; + be = 0xf; + port = IOSF_PORT_PUNIT; + opcode =

Re: [Intel-gfx] Sync the assembler with Mesa's opcode emission code

2013-03-04 Thread Damien Lespiau
On Thu, Feb 14, 2013 at 07:18:41PM +, Damien Lespiau wrote: http://cgit.freedesktop.org/~damien/intel-gpu-tools/log/?h=assembler-rebased As agreed on IRC and after making sure the rework doesn't introduce regressions in our existing shaders, I've finally merged this assembler branch and

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_flip: Don't access freed data

2013-03-04 Thread Daniel Vetter
On Mon, Mar 04, 2013 at 03:34:07PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com All four kms_flip patches applied, thanks a lot. -Daniel -- Daniel Vetter Software Engineer, Intel

Re: [Intel-gfx] i915 black screen introduced by ACPI changes

2013-03-04 Thread Daniel Vetter
Meh, forgotten to actually cc more lists ... -Daniel On Mon, Mar 4, 2013 at 6:49 PM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Mon, Mar 4, 2013 at 6:11 PM, Chris Li l...@chrisli.org wrote: To recap, the black screen first show up after the ACPI change to use widows 8 string. The

Re: [Intel-gfx] [PATCH 01/28] drm/i915: sprite support for ValleyView

2013-03-04 Thread Ville Syrjälä
On Fri, Mar 01, 2013 at 01:14:04PM -0800, Jesse Barnes wrote: No constant alpha yet though, that needs a new ioctl and/or property to get/set. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_dma.c |4 + drivers/gpu/drm/i915/i915_drv.h |

Re: [Intel-gfx] [PATCH 02/28] drm/i915: add sprite assertion function for VLV

2013-03-04 Thread Ville Syrjälä
On Fri, Mar 01, 2013 at 01:14:05PM -0800, Jesse Barnes wrote: Need to make sure sprites are disabled before shutting off a pipe. But we don't actually turn them off anywhere, do we? Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c | 20

Re: [Intel-gfx] [PATCH 3/3] [v2] drm/i915: Capture current context on error

2013-03-04 Thread Daniel Vetter
On Sun, Feb 24, 2013 at 06:10:02PM -0800, Ben Widawsky wrote: On error, this represents the state of the currently running context at the time it was loaded. Unfortunately, since we're hung and can't switch out the context this may not tell us too much about the most current state of the

[Intel-gfx] [PATCH] [v3] drm/i915: Capture current context on error

2013-03-04 Thread Ben Widawsky
On error, this represents the state of the currently running context at the time it was loaded. Unfortunately, since we're hung and can't switch out the context this may not tell us too much about the most current state of the context, but does give clues about what has happened since loading.

Re: [Intel-gfx] [PATCH 6/6] drm/i915: remove disabled memset of framebuffer from intel_fb

2013-03-04 Thread Daniel Vetter
On Tue, Feb 19, 2013 at 06:17:09PM -0300, Paulo Zanoni wrote: Hi 2013/2/19 Jesse Barnes jbar...@virtuousgeek.org: Commented out and unneeded. Oh, DRM: i915: add mode setting support added it, already commented. Signed-off-by: Jesse Barnes jbar...@virtuousgeek.org Reviewed-by:

[Intel-gfx] [PATCH] drm/i915: add pipe_config-has_pch_encoder

2013-03-04 Thread Daniel Vetter
This is used way too often in the enable/disable paths. And will be even more useful in the future. Note that correct semantics of this change highly depend upon correct updating of intel_crtc-config: Like with all other modeset state, we need to call -disable with the old config, but -mode_set

Re: [Intel-gfx] [PATCH 8/8] drm/i915: clarify confusion between SDVO and HDMI registers

2013-03-04 Thread Daniel Vetter
On Tue, Feb 19, 2013 at 04:19:52PM -0300, Paulo Zanoni wrote: Hi 2013/2/19 Daniel Vetter dan...@ffwll.ch: On Mon, Feb 18, 2013 at 07:00:27PM -0300, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com Some HDMI registers can be used for SDVO, so saying HDMIB should be the

[Intel-gfx] linux-next: manual merge of the drm-intel tree with Linus' tree

2013-03-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got conflicts in drivers/gpu/drm/i915/intel_hdmi.c and drivers/gpu/drm/i915/intel_sdvo.c between commit 18316c8c39a8 (drm: Remove duplicate drm_mode_cea_vic()) from Linus' tree and commit 4f3a8bc7ba6e (drm/i915: rename some HDMI bit

Re: [Intel-gfx] [PATCH 0/8] Enable eDP PSR functionality at HSW - v3

2013-03-04 Thread Daniel Vetter
On Thu, Feb 28, 2013 at 08:02:18PM +0200, Ville Syrjälä wrote: On Thu, Feb 28, 2013 at 02:52:32PM -0300, Paulo Zanoni wrote: Hi 2013/2/25 Rodrigo Vivi rodrigo.v...@gmail.com: PSR is an eDP feature that allows power saving even with static image at eDP screen. v3: Accepted many

Re: [Intel-gfx] [PATCH 0/8] Enable eDP PSR functionality at HSW - v3

2013-03-04 Thread Rodrigo Vivi
Yeah, I completely agree with you. This is the reason of that separated 2 lines patch 8/8. On Mon, Mar 4, 2013 at 8:27 PM, Daniel Vetter dan...@ffwll.ch wrote: On Thu, Feb 28, 2013 at 08:02:18PM +0200, Ville Syrjälä wrote: On Thu, Feb 28, 2013 at 02:52:32PM -0300, Paulo Zanoni wrote: Hi

[Intel-gfx] [PATCH] [v4] drm/i915: Capture current context on error

2013-03-04 Thread Ben Widawsky
On error, this represents the state of the currently running context at the time it was loaded. Unfortunately, since we're hung and can't switch out the context this may not tell us too much about the most current state of the context, but does give clues about what has happened since loading.