> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:06 PM
> +
> +static struct vfio {
> + dev_t device_devt;
> +} vfio;
the structure is meaningless.
> +int vfio_device_fops_open(struct inode *inode, struct file *filep)
> +{
> + struct vfio_device *device = container_of(inode->i_cdev,
> From: Yan Zhao
> Sent: Tuesday, February 7, 2023 11:41 AM
>
> On Mon, Feb 06, 2023 at 01:05:31AM -0800, Yi Liu wrote:
> ...
>
> > +void vfio_device_cdev_close(struct vfio_device_file *df)
> > +{
> > + mutex_lock(>device->dev_set->lock);
> > + vfio_device_close(df);
> > +
From: Swati Sharma
DSC_Output_Format_Sink_Support entry is added to i915_dsc_fec_support_show
to depict if sink supports DSC output formats (RGB/YCbCr420/YCbCr444).
Also, new debugfs entry is created to enforce output format. This is
required because of our driver policy. For ex. if a mode is
From: Ankit Nautiyal
Go with DSC only if the given output_format is supported.
v2: Use drm helper to get DSC format support for sink.
Signed-off-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_dp.c | 30 +
1 file changed, 30 insertions(+)
diff --git
Now that we have laid the groundwork for YUV420 Enablement
we fill up native_420 field in vdsc_cfg and add appropriate
checks wherever required.
---v2
-adding native_422 field as 0 [Vandita]
-filling in second_line_bpg_offset, second_line_offset_adj
and nsl_bpg_offset in vds_cfg when native_420
Add function to check if slice design requirements are being
met as defined in Bspec: 49259 in the section
Slice Design Requirement
--v7
-remove full bspec link [Jani]
-rename intel_dsc_check_slice_design_req to
intel_dsc_slice_dimensions_valid [Jani]
--v8
-fix condition to check if slice width
Adding new DSC register which are introducted MTL onwards
Signed-off-by: Suraj Kandpal
Reviewed-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/i915_reg.h | 28
1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h
This patch series aims to enable the YCbCr420 format
for DSC. Changes are mostly compute params related for
hdmi,dp and dsi along with the addition of new rc_tables
for native_420 and corresponding changes to macros used to
fetch them.
---v2
-add fields missed for vdsc_cfg [Vandita]
-add
Implementation of VDSC for YCbCr420.
Add QP tables for 8,10,12 BPC from rc_tables.h in intel_qp_tables.c
(Derived from C-Model, which is given along with DSC1.2a Spec from Vesa)
intel_lookup_range_min/max_qp functons need to take into account the
output format. Based on that appropriate qp table
From: Ankit Nautiyal
Add helper function to check if the DP sink supports DSC with the given
output format.
Signed-off-by: Ankit Nautiyal
---
include/drm/display/drm_dp_helper.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/drm/display/drm_dp_helper.h
Hi Jani,
Thanks for the review.
Have floated https://patchwork.freedesktop.org/patch/521301/
addressing your review comments.
Corresponding IGT https://patchwork.freedesktop.org/series/113253/
On 11-Jan-23 7:24 PM, Jani Nikula wrote:
On Wed, 11 Jan 2023, Suraj Kandpal wrote:
From: Swati
== Series Details ==
Series: drm/i915: Fix eDP+DSI dual panel systems
URL : https://patchwork.freedesktop.org/series/113728/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12707 -> Patchwork_113728v1
Summary
---
== Series Details ==
Series: drm/i915: Fix eDP+DSI dual panel systems
URL : https://patchwork.freedesktop.org/series/113728/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
From: Ville Syrjälä
Use the second backlight controller on ICP+ if the VBT asks
us to do so.
On pre-MTP we also check the chicken bit to make sure the
pins have been correctly muxed by the firmware.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8016
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
We now have some eDP+DSI dual panel systems floating around
where the DSI panel is the secondary LFP and thus needs to
consult "panel type 2" in VBT in order to locate all the
other panel type dependante stuff correctly.
To that end we need to pass in the devdata to
From: Ville Syrjälä
Turns out modern (icl+) VBTs still declare their DSI ports
as MIPI-A and MIPI-C despite the PHYs now being A and B.
Remap appropriately to allow the panels declared as MIPI-C
to work.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8016
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Several fixes to light up the secondary (DSI) panel on
Lenovo ThinkBook Plus Gen 3.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/8016
Ville Syrjälä (3):
drm/i915: Fix VBT DSI DVO port handling
drm/i915: Populate encoder->devdata for DSI on icl+
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> struct vfio_device_file *
> -vfio_allocate_device_file(struct vfio_device *device)
> +vfio_allocate_device_file(struct vfio_device *device, bool is_cdev_device)
> {
> struct vfio_device_file *df;
>
> @@ -407,6 +407,7 @@
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
> @@ -149,14 +149,18 @@ int vfio_iommufd_emulated_bind(struct
> vfio_device *vdev,
> }
> EXPORT_SYMBOL_GPL(vfio_iommufd_emulated_bind);
>
> +static void __vfio_iommufd_access_destroy(struct vfio_device *vdev)
> +{
> +
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> +static void __vfio_iommufd_detach(struct vfio_device *vdev)
> +{
> + iommufd_device_detach(vdev->iommufd_device);
> + vdev->iommufd_attached = false;
> +}
> +
> void vfio_iommufd_physical_unbind(struct vfio_device *vdev)
>
== Series Details ==
Series: More drm_dbg to guc_dbg changes (rev2)
URL : https://patchwork.freedesktop.org/series/113624/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12707 -> Patchwork_113624v2
Summary
---
> -Original Message-
> From: Murthy, Arun R
> Sent: Thursday, February 2, 2023 4:59 PM
> To: Ville Syrjälä
> Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville
> Subject: RE: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear
> buffers
>
> > -Original Message-
> >
== Series Details ==
Series: More drm_dbg to guc_dbg changes (rev2)
URL : https://patchwork.freedesktop.org/series/113624/
State : warning
== Summary ==
Error: dim checkpatch failed
800ec7a87261 drm/i915/guc: More debug print updates - UC firmware
219cdc2fb45b drm/i915/guc: More debug print
Enable SDP error detection configuration, this will set CRC16 in
128b/132b link layer.
For Display version 13 a hardware bit31 in register VIDEO_DIP_CTL is
added to enable/disable SDP CRC applicable for DP2.0 only, but the
default value of this bit will enable CRC16 in 128b/132b hence
skipping
DP2.0 E11 defines a new register to facilitate SDP error detection by a
128B/132B capable DPRX device.
v2: Update the macro name to reflect the DP spec(Harry)
Signed-off-by: Arun R Murthy
Reviewed-by: Harry Wentland
---
include/drm/display/drm_dp.h | 3 +++
1 file changed, 3 insertions(+)
*** BLURB HERE ***
Arun R Murthy (2):
drm: Add SDP Error Detection Configuration Register
i915/display/dp: SDP CRC16 for 128b132b link layer
.../gpu/drm/i915/display/intel_dp_link_training.c| 12
include/drm/display/drm_dp.h | 3 +++
2 files
== Series Details ==
Series: drm/i915/pcode: Give the punit time to settle before fatally failing
URL : https://patchwork.freedesktop.org/series/113717/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12704_full -> Patchwork_113717v1_full
From: John Harrison
Update more print messages to the new scheme.
v2: Also change all errors to %pe rather than %d (MichalW).
Few other tweaks.
Signed-off-by: John Harrison
John Harrison (6):
drm/i915/guc: More debug print updates - UC firmware
drm/i915/guc: More debug print updates -
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
v2: Also change prints to use %pe for error values (MichalW).
Signed-off-by: John Harrison
Acked-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 9 -
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
v2: Upgrade the no node found message to a warning on the grounds of
it being quite important if the error capture can't find any register
state information.
Signed-off-by: John Harrison
Reviewed-by: Alan
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
v2: Also change prints to use %pe for error values (MichalW).
Fix a context leak on error due to a -- being too early.
Use the correct header file for the debug macros.
Signed-off-by: John Harrison
---
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
Signed-off-by: John Harrison
Reviewed-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/intel_gt_print.h | 3 +++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 3 +--
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
v2: Also change prints to use %pe for error values (MichalW).
Signed-off-by: John Harrison
Acked-by: Michal Wajdeczko
---
drivers/gpu/drm/i915/gt/uc/intel_guc_rc.c | 8 +--
From: John Harrison
Update a bunch more debug prints to use the new GT based scheme.
v2: Also change prints to use %pe for error values (MichalW).
Signed-off-by: John Harrison
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c| 42
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 116
== Series Details ==
Series: series starting with [1/3] drm/i915: Move display power initialization
during driver probing later
URL : https://patchwork.freedesktop.org/series/113711/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12704_full -> Patchwork_113711v1_full
On Mon, Feb 06, 2023 at 01:05:31AM -0800, Yi Liu wrote:
...
> +void vfio_device_cdev_close(struct vfio_device_file *df)
> +{
> + mutex_lock(>device->dev_set->lock);
> + vfio_device_close(df);
> + vfio_device_put_kvm(df->device);
> + mutex_unlock(>device->dev_set->lock);
> +}
> +
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> For the device fd opened from cdev, userspace needs to bind it to an
> iommufd and attach it to IOAS managed by iommufd. With such operations,
> userspace can set up a secure DMA context and hence access device.
>
> This changes the
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> Allow the vfio_device file to be in a state where the device FD is
> opened but the device cannot be used by userspace (i.e. its .open_device()
> hasn't been called). This inbetween state is not used when the device
> FD is spawned
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> This avoids passing too much parameters in multiple functions.
>
> Signed-off-by: Yi Liu
Reviewed-by: Kevin Tian
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> This defines KVM_DEV_VFIO_FILE* and make alias with
> KVM_DEV_VFIO_GROUP*.
> Old userspace uses KVM_DEV_VFIO_GROUP* works as well.
>
> Signed-off-by: Yi Liu
> ---
> Documentation/virt/kvm/devices/vfio.rst | 40
> From: Liu, Yi L
> Sent: Monday, February 6, 2023 5:05 PM
>
> This makes the vfio file kAPIs to accepte vfio device files, also a
> preparation for vfio device cdev support.
>
> For the kvm set with vfio device file, kvm pointer is stored in struct
> vfio_device_file, and use kvm_ref_lock to
On 2/3/2023 23:29, Teres Alexis, Alan Previn wrote:
I see you are inferring that a guc-id of zero can be valid.
I am guessing that might have contributed to some lost captures?
Thanks for catching this.
I'm not inferring anything. I might be implying something, though. The
patch description
On 2/4/2023 00:19, Teres Alexis, Alan Previn wrote:
So i do have one request - but its a nit - for the following case, should it be
a guc_warn instead of a guc_dbg?
(last hunk in this patch)
"No register capture node found for 0x%04X / 0x%08X\n",
ce->guc_id.id, ce->lrc.lrca);"
On 2/6/23 11:35, Imre Deak wrote:
Factor out a function used both on older and new platforms to disable
the display functionality if the display is fused-off.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_device_info.c | 34 +---
1 file changed, 18
On Wed, 2023-02-01 at 17:04 +0200, Imre Deak wrote:
>
> Yes, this patch should have no functional change, so please check what
> would apply to other drivers as well.
>
> Could you also check Ville's comment about storing start_slot elsewhere
> than the atomic state (leaving only time_slots
== Series Details ==
Series: series starting with [CI,1/4] drm/i915/dp_mst: Add the MST topology
state for modesetted CRTCs
URL : https://patchwork.freedesktop.org/series/113703/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12703_full -> Patchwork_113703v1_full
== Series Details ==
Series: drm/i915/pcode: Give the punit time to settle before fatally failing
URL : https://patchwork.freedesktop.org/series/113717/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12704 -> Patchwork_113717v1
On Thu, Feb 02, 2023 at 03:13:09PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs_lookup() the result must have dput() called on it,
> otherwise the memory will leak over time. To make things simpler, just
> call debugfs_lookup_and_remove() instead which handles all of the logic
> at
== Series Details ==
Series: series starting with [v2,1/2] drm/i915: Fix GEN8_MISCCPCTL
URL : https://patchwork.freedesktop.org/series/113713/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12704 -> Patchwork_113713v1
== Series Details ==
Series: series starting with [1/3] drm/i915: Move display power initialization
during driver probing later
URL : https://patchwork.freedesktop.org/series/113711/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12704 -> Patchwork_113711v1
On 2/3/2023 12:59 AM, Michal Wajdeczko wrote:
Like we did it for GuC, introduce some helper print macros for
HuC to have unified format of messages that also include GT#.
While around improve some messages and use %pe if possible.
v2: update GSC/PXP timeout message
Signed-off-by: Michal
On Tue, Feb 07, 2023 at 12:12:18AM +0530, Deepak R Varma wrote:
> On Mon, Feb 06, 2023 at 10:33:13AM +, Matthew Auld wrote:
> > On 06/02/2023 09:45, Tvrtko Ursulin wrote:
> > >
> > > Hi,
> > >
> > > Adding Matt & Thomas as potential candidates to review.
> > >
> > > Regards,
> > >
> > >
On Mon, Feb 06, 2023 at 10:33:13AM +, Matthew Auld wrote:
> On 06/02/2023 09:45, Tvrtko Ursulin wrote:
> >
> > Hi,
> >
> > Adding Matt & Thomas as potential candidates to review.
> >
> > Regards,
> >
> > Tvrtko
> >
> > On 03/02/2023 19:30, Deepak R Varma wrote:
> > > The macro definition
From: Aravind Iddamsetty
During module load the punit might still be busy with its booting
routines. During this time we try to communicate with it but we
fail because we don't receive any feedback from it and we return
immediately with a -EINVAL fatal error.
At this point the driver load is
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
branch HEAD: 129af770823407ee115a56c69a04b440fd2fbe61 Add linux-next specific
files for 20230206
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/202301230743.xnut0zvc-...@intel.com
https
On Mon, Feb 06, 2023 at 12:00:01PM -0500, Rodrigo Vivi wrote:
> On Tue, Jan 31, 2023 at 02:03:01PM +0100, Mauro Carvalho Chehab wrote:
> >
> > On 1/24/23 20:39, Rodrigo Vivi wrote:
> > > On Sat, Jan 21, 2023 at 04:08:53PM -0300, Gustavo Sousa wrote:
> > > > The wildchar ("*") used in the function
On Mon, Feb 06, 2023 at 08:54:10AM -0800, Lucas De Marchi wrote:
> INF_UNIT_LEVEL_CLKGATE is not replicated, but since it's not actually
> used it can just be removed.
>
> Signed-off-by: Lucas De Marchi
Reviewed-by: Matt Roper
Looks like the only reference to the register was removed in
On Tue, Jan 31, 2023 at 02:03:01PM +0100, Mauro Carvalho Chehab wrote:
>
> On 1/24/23 20:39, Rodrigo Vivi wrote:
> > On Sat, Jan 21, 2023 at 04:08:53PM -0300, Gustavo Sousa wrote:
> > > The wildchar ("*") used in the function name patterns in the
> > > documentation was taken as a start of an
On 06/02/2023 14:19, Dan Carpenter wrote:
[ Ancient code but the warning showed up again because the function was
renamed or something? - dan ]
Hello Chris Wilson,
The patch 871dfbd67d4e: "drm/i915: Allow compaction upto SWIOTLB max
segment size" from Oct 11, 2016, leads to the following
On Mon, Feb 06, 2023 at 06:21:11PM +0200, Jani Nikula wrote:
> On Fri, 03 Feb 2023, Imre Deak wrote:
> > On Thu, Feb 02, 2023 at 10:47:46PM +0200, Jani Nikula wrote:
> >> There's only one reference to the struct intel_dmc members dc_state,
> >> target_dc_state, and allowed_dc_mask within
On Sun, Feb 05, 2023 at 11:20:36AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Fix memory leaks in scatterlist (rev2)
> URL : https://patchwork.freedesktop.org/series/113576/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12692_full ->
INF_UNIT_LEVEL_CLKGATE is not replicated, but since it's not actually
used it can just be removed.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_gt_regs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h
Register 0x9424 is not replicated on any platform, so it shouldn't be
declared with REG_MCR(). Declaring it with _MMIO() is basically
duplicate of the GEN7 version, so just remove the GEN8 and change all
the callers to use the right functions.
Old versions of the gen8 bspec page used to contain a
On Fri, Feb 03, 2023 at 05:02:13PM +0700, Bagas Sanjaya wrote:
> Stephen Rothwell reported htmldocs warnings:
>
> Documentation/gpu/i915:64: drivers/gpu/drm/i915/gt/intel_workarounds.c:32:
> WARNING: Inline emphasis start-string without end-string.
> Documentation/gpu/i915:64:
Factor out a function used both on older and new platforms to disable
the display functionality if the display is fused-off.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_device_info.c | 34 +---
1 file changed, 18 insertions(+), 16 deletions(-)
diff --git
DG1/DG2 and MTL+ has added a new display-present HW flag. Check this
flag and if cleared, disable the driver's display functionality.
So far the missing check resulted in running the display initialization
sequence, and the WARNs below, due to the display register accesses
timing out:
[
Determining whether the display engine is fused-off on a platform happens
only in intel_device_info_runtime_init(). Initializing the display power
functionality depends on this condition, so move
intel_power_domains_init() later after the runtime init function has
been called.
The next patch
On Fri, 03 Feb 2023, Imre Deak wrote:
> On Thu, Feb 02, 2023 at 10:47:46PM +0200, Jani Nikula wrote:
>> There's only one reference to the struct intel_dmc members dc_state,
>> target_dc_state, and allowed_dc_mask within intel_dmc.c, begging the
>> question why they are under struct intel_dmc to
== Series Details ==
Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw
if possible (rev4)
URL : https://patchwork.freedesktop.org/series/112438/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12701_full -> Patchwork_112438v4_full
== Series Details ==
Series: series starting with [CI,1/4] drm/i915/dp_mst: Add the MST topology
state for modesetted CRTCs
URL : https://patchwork.freedesktop.org/series/113703/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12703 -> Patchwork_113703v1
Tested-by: Tony Krowiak
On 2/3/23 4:50 PM, Matthew Rosato wrote:
Nothing uses this value during vfio_device_open anymore so it's safe
to remove it.
Signed-off-by: Matthew Rosato
---
drivers/vfio/group.c | 2 +-
drivers/vfio/vfio.h | 3 +--
drivers/vfio/vfio_main.c | 7 +++
Tested-by: Tony Krowiak
On 2/3/23 4:50 PM, Matthew Rosato wrote:
After 51cdc8bc120e, we have another deadlock scenario between the
kvm->lock and the vfio group_lock with two different codepaths acquiring
the locks in different order. Specifically in vfio_open_device, vfio
holds the vfio
[ Ancient code but the warning showed up again because the function was
renamed or something? - dan ]
Hello Chris Wilson,
The patch 871dfbd67d4e: "drm/i915: Allow compaction upto SWIOTLB max
segment size" from Oct 11, 2016, leads to the following Smatch static
checker warning:
On Mon, 2023-02-06 at 08:59 +, Patchwork wrote:
> Patch Details
> Series: drm/i915: Add another EHL pci id
> URL: https://patchwork.freedesktop.org/series/113691/
> State: success
Pushed, thanks for the patch.
> Details:
>
Hi Tvrtko,
On 2023-02-06 at 09:19:02 +, Tvrtko Ursulin wrote:
>
> On 03/02/2023 16:42, Kamil Konieczny wrote:
> > Hi Tvrtko,
> >
> > On 2023-01-31 at 11:32:37 +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Rudimentary vendor agnostic example of how lib_igt_drm_clients
On Mon, 2023-02-06 at 15:37 +1100, Jonathan Gray wrote:
> described as "32 Execution Unit (EU) Super SKU" in:
> Intel Atom x6000E Series, and Intel Pentium and Celeron N and
> J Series Processors for IoT Applications
> Datasheet, Volume 1
> Document Number: 636112-1.6
>
Reviewed-by: José Roberto
== Series Details ==
Series: series starting with [v2,1/9] drm/i915/display/core: use intel_de_rmw
if possible (rev4)
URL : https://patchwork.freedesktop.org/series/112438/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12701 -> Patchwork_112438v4
== Series Details ==
Series: drm/i915: add guard page to ggtt->error_capture (rev4)
URL : https://patchwork.freedesktop.org/series/113560/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12699_full -> Patchwork_113560v4_full
== Series Details ==
Series: Add vfio_device cdev for iommufd support
URL : https://patchwork.freedesktop.org/series/113696/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/113696/revisions/1/mbox/ not
applied
Applying: vfio: Allocate per device
Use the correct old/new topology and payload states in
intel_mst_disable_dp(). So far drm_atomic_get_mst_topology_state() it
used returned either the old state, in case the state was added already
earlier during the atomic check phase or otherwise the new state (but
the latter could fail, which
Add a function to get the old MST topology state, required by a
follow-up i915 patch.
While at it clarify the code comment of
drm_atomic_get_new_mst_topology_state() and add _new prefix
to the new state pointer to remind about its difference from the old
state.
v2: Use old_/new_ prefixes for the
Atm, drm_dp_remove_payload() uses the same payload state to both get the
vc_start_slot required for the payload removal DPCD message and to
deduct time_slots from vc_start_slot of all payloads after the one being
removed.
The above isn't always correct, as vc_start_slot must be the up-to-date
Add the MST topology for a CRTC to the atomic state if the driver
needs to force a modeset on the CRTC after the encoder compute config
functions are called.
Later the MST encoder's disable hook also adds the state, but that isn't
guaranteed to work (since in that hook getting the state may fail,
On Mon, 06 Feb 2023, Andrzej Hajda wrote:
> Hi Rodrigo,
>
> On 30.01.2023 14:06, Jani Nikula wrote:
>> On Mon, 30 Jan 2023, Andrzej Hajda wrote:
>>> Hi all,
>>>
>>> Gently ping on merging this and all other intel_de_rmw patches.
>>> All patches reviewed.
>>> drm/i915/display/fdi: use
On 06-02-2023 15:21, Tvrtko Ursulin wrote:
>
>
> On 03/02/2023 13:52, Aravind Iddamsetty wrote:
>> Obj flags for shmem objects is not being set correctly. Fixes in setting
>> BO_ALLOC_USER flag which applies to shmem objs as well.
>>
>> Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally
On 06/02/2023 09:45, Tvrtko Ursulin wrote:
Hi,
Adding Matt & Thomas as potential candidates to review.
Regards,
Tvrtko
On 03/02/2023 19:30, Deepak R Varma wrote:
The macro definition of gen6_for_all_pdes() expands to a for loop such
that it breaks when the page table is null. Hence there
== Series Details ==
Series: drm/i915: add guard page to ggtt->error_capture (rev4)
URL : https://patchwork.freedesktop.org/series/113560/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12699 -> Patchwork_113560v4
Summary
On 03/02/2023 13:52, Aravind Iddamsetty wrote:
Obj flags for shmem objects is not being set correctly. Fixes in setting
BO_ALLOC_USER flag which applies to shmem objs as well.
Fixes: 13d29c823738 ("drm/i915/ehl: unconditionally flush the pages on acquire")
Cc: # v5.15+
These tags should
Hi,
Adding Matt & Thomas as potential candidates to review.
Regards,
Tvrtko
On 03/02/2023 19:30, Deepak R Varma wrote:
The macro definition of gen6_for_all_pdes() expands to a for loop such
that it breaks when the page table is null. Hence there is no need to
again test validity of the
On 03/02/2023 18:15, Rob Clark wrote:
On Fri, Feb 3, 2023 at 8:49 AM Rob Clark wrote:
From: Rob Clark
Because eb_composite_fence_create() drops the fence_array reference
after creation of the sync_file, only the sync_file holds a ref to the
fence. But fd_install() makes that reference
Hi Rodrigo,
On 30.01.2023 14:06, Jani Nikula wrote:
On Mon, 30 Jan 2023, Andrzej Hajda wrote:
Hi all,
Gently ping on merging this and all other intel_de_rmw patches.
All patches reviewed.
drm/i915/display/fdi: use intel_de_rmw if possible
drm/i915/display/vlv: fix pixel overlap register
On 03/02/2023 16:42, Kamil Konieczny wrote:
Hi Tvrtko,
On 2023-01-31 at 11:32:37 +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used
to display a sorted by card and usage list of processes using GPUs.
Borrows a bit
group code is not needed for vfio device cdev, so with vfio device cdev
introduced, the group infrastructures can be compiled out if only cdev
is needed.
Signed-off-by: Yi Liu
---
drivers/vfio/Kconfig | 18 +++
drivers/vfio/Makefile | 2 +-
drivers/vfio/vfio.h | 69
This adds three vfio device ioctls for userspace using iommufd to set up
secure DMA context for device access.
VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA
control provided by the iommufd. VFIO no
iommu mode is
This allows user to directly open a vfio device w/o using the legacy
container/group interface, as a prerequisite for supporting new iommu
features like nested translation.
The device fd opened in this manner doesn't have the capability to access
the device as the fops open() doesn't open the
With the introduction of vfio device cdev, userspace can get device
access by either the legacy group path or the cdev path. For VFIO devices,
it can only be opened by one of the group path and the cdev path at one
time. e.g. when the device is opened via cdev path, the group path should
be
this prepares for adding DETACH ioctl for emulated VFIO devices.
Signed-off-by: Yi Liu
---
drivers/gpu/drm/i915/gvt/kvmgt.c | 1 +
drivers/s390/cio/vfio_ccw_ops.c | 1 +
drivers/s390/crypto/vfio_ap_ops.c | 1 +
drivers/vfio/iommufd.c| 29 +
For the device fd opened from cdev, userspace needs to bind it to an
iommufd and attach it to IOAS managed by iommufd. With such operations,
userspace can set up a secure DMA context and hence access device.
This changes the existing vfio_iommufd_bind() to accept a pt_id pointer
as an optional
this prepares for adding DETACH ioctl for physical VFIO devices.
Signed-off-by: Yi Liu
---
Documentation/driver-api/vfio.rst | 8 +++--
drivers/vfio/fsl-mc/vfio_fsl_mc.c | 1 +
drivers/vfio/iommufd.c| 31 ---
Allow the vfio_device file to be in a state where the device FD is
opened but the device cannot be used by userspace (i.e. its .open_device()
hasn't been called). This inbetween state is not used when the device
FD is spawned from the group FD, however when we create the device FD
directly by
1 - 100 of 110 matches
Mail list logo
