[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2) URL : https://patchwork.freedesktop.org/series/120719/ State : success == Summary == CI Bug Log - changes from CI_DRM_13489 -> Patchwork_120719v2 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2) URL : https://patchwork.freedesktop.org/series/120719/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or directory

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dp: Fix LT debug print in SDP CRC enable (rev2) URL : https://patchwork.freedesktop.org/series/120719/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or

[Intel-gfx] [PATCH] drm/i915/dp: Fix LT debug print in SDP CRC enable

2023-08-07 Thread Arun R Murthy
The debug print for enabling SDP CRC16 is applicable only for DP2.0, but this debug print was not within the uhbr check and was always printed. Fis this by adding proper checks and returning. Signed-off-by: Arun R Murthy Reviewed-by: Chaitanya Kumar Borah ---

[Intel-gfx] ✓ Fi.CI.BAT: success for Test conflict fix for "Fix Wa_22016122933 implementation" (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev2) URL : https://patchwork.freedesktop.org/series/122099/ State : success == Summary == CI Bug Log - changes from CI_DRM_13488 -> Patchwork_122099v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Test conflict fix for "Fix Wa_22016122933 implementation" (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev2) URL : https://patchwork.freedesktop.org/series/122099/ State : warning == Summary == Error: dim sparse failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Test conflict fix for "Fix Wa_22016122933 implementation" (rev2)

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" (rev2) URL : https://patchwork.freedesktop.org/series/122099/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such

Re: [Intel-gfx] [PATCH v1 00/14] Replace acronym with full platform name in defines

2023-08-07 Thread Sripada, Radhakrishna
Thank you for the patches and the reviews. Thank you Rodrigo for the backmerge to apply the patches. Pushed! --Radhakrishna(RK) Sripada > -Original Message- > From: Intel-gfx On Behalf Of > Dnyaneshwar Bhadane > Sent: Tuesday, August 1, 2023 6:54 AM > To:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI URL : https://patchwork.freedesktop.org/series/122108/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13485_full -> Patchwork_122108v1_full

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix potential null pointer deref in GuC 'steal id' test

2023-08-07 Thread John Harrison
On 8/3/2023 06:28, Andi Shyti wrote: Hi John, On Wed, Aug 02, 2023 at 11:49:40AM -0700, john.c.harri...@intel.com wrote: From: John Harrison It was noticed that if the very first 'stealing' request failed to create for some reason then the 'steal all ids' loop would immediately exit with

Re: [Intel-gfx] [preempt-rt] BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gt/uc/intel_guc.h

2023-08-07 Thread John B. Wyatt IV
On Mon, Aug 07, 2023 at 03:33:54PM +0200, Sebastian Andrzej Siewior wrote: > > Could you try v6.4.6-rt8+ and check if it still there or gone? > > Sebastian > Just checked. I do not see the call traces in dmesg now. This also resolves a long (20+ minute) boot issue I had + stuttering in the

[Intel-gfx] ✗ Fi.CI.IGT: failure for Test conflict fix for "Fix Wa_22016122933 implementation"

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" URL : https://patchwork.freedesktop.org/series/122099/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13485_full -> Patchwork_122099v1_full

Re: [Intel-gfx] [PATCH v1 3/3] drm/i915/gt: Timeout when waiting for idle in suspending

2023-08-07 Thread Rodrigo Vivi
On Wed, Aug 02, 2023 at 04:35:01PM -0700, Alan Previn wrote: > When suspending, add a timeout when calling > intel_gt_pm_wait_for_idle else if we have a lost > G2H event that holds a wakeref (which would be > indicating of a bug elsewhere in the driver), we > get to complete the suspend-resume

Re: [Intel-gfx] [PATCH v1 1/3] drm/i915/guc: Flush context destruction worker at suspend

2023-08-07 Thread Rodrigo Vivi
On Wed, Aug 02, 2023 at 04:34:59PM -0700, Alan Previn wrote: > Suspend is not like reset, it can unroll, so we have to properly > flush pending context-guc-id deregistrations to complete before > we return from suspend calls. But if is 'unrolls' the execution should just continue, no?! In other

Re: [Intel-gfx] [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-08-07 Thread Sean Christopherson
On Mon, Aug 07, 2023, Like Xu wrote: > On 23/12/2022 8:57 am, Sean Christopherson wrote: > > +static inline void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, > > + const u8 *new, int bytes) > > +{ > > + __kvm_page_track_write(vcpu, gpa, new, bytes); >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI URL : https://patchwork.freedesktop.org/series/122108/ State : success == Summary == CI Bug Log - changes from CI_DRM_13485 -> Patchwork_122108v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI URL : https://patchwork.freedesktop.org/series/122108/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI

2023-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI URL : https://patchwork.freedesktop.org/series/122108/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_drm_clients: Store memory info in the client

2023-08-07 Thread Kamil Konieczny
Hi Tvrtko, On 2023-07-27 at 10:20:24 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Define the storage structure and copy over memory data as parsed by the > fdinfo helpers. > > v2: > * Fix empty region map entry skip condition. (Kamil, Chris) > > Signed-off-by: Tvrtko Ursulin >

[Intel-gfx] [PATCH] drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI

2023-08-07 Thread Suraj Kandpal
Assign explicit value of 12 at 8bpp as per Table E2 of DSC 1.1 for DSI panels even though we already use calculations from CModel for first_line_bpg_offset. The reason being some DSI monitors may have not have added the change in errata for the calculation of first_line_bpg_offset. Signed-off-by:

Re: [Intel-gfx] [PATCH v6 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-07 Thread Kandpal, Suraj
> > > On 8/3/2023 6:33 PM, Suraj Kandpal wrote: > > Add function to read any PPS register based on the intel_dsc_pps enum > > provided. Add a function which will call the new pps read function and > > place it in crtc state. Only PPS0 and > > PPS1 are readout the rest of the registers will be

Re: [Intel-gfx] [PATCH 19/27] KVM: x86/mmu: Use page-track notifiers iff there are external users

2023-08-07 Thread Like Xu
On 23/12/2022 8:57 am, Sean Christopherson wrote: +static inline void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, + const u8 *new, int bytes) +{ + __kvm_page_track_write(vcpu, gpa, new, bytes); + + kvm_mmu_track_write(vcpu, gpa, new,

Re: [Intel-gfx] [PATCH v4 12/29] KVM: x86/mmu: Move kvm_arch_flush_shadow_{all, memslot}() to mmu.c

2023-08-07 Thread Isaku Yamahata
On Fri, Jul 28, 2023 at 06:35:18PM -0700, Sean Christopherson wrote: > Move x86's implementation of kvm_arch_flush_shadow_{all,memslot}() into > mmu.c, and make kvm_mmu_zap_all() static as it was globally visible only > for kvm_arch_flush_shadow_all(). This will allow refactoring >

Re: [Intel-gfx] [preempt-rt] BUG: sleeping function called from invalid context at drivers/gpu/drm/i915/gt/uc/intel_guc.h

2023-08-07 Thread Sebastian Andrzej Siewior
On 2023-07-10 20:51:14 [-0400], John B. Wyatt IV wrote: > Hello everyone, I am a new kernel developer with the Red Hat real-time team. > > I am seeing two different call traces with 6.4-rt6 on my 12th Gen > Intel Framework Laptop with i915 emit the same bug. Both of them > occurred in the same

Re: [Intel-gfx] [PATCH v6 5/8] drm/i915/vdsc: Add function to write in PPS register

2023-08-07 Thread Nautiyal, Ankit K
On 8/3/2023 6:33 PM, Suraj Kandpal wrote: Now that we have a function that reads any PPS register based on intel_dsc_pps enum provided lets create a function that can write on any PPS. --v2 -Changes need as PPS enum was dropped -Remove duplicated code in intel_dsc_write_pps_reg [Jani] --v3

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915/display: Compare the readout dsc pps params

2023-08-07 Thread Nautiyal, Ankit K
On 8/3/2023 6:33 PM, Suraj Kandpal wrote: With the dsc config being readout and filled in crtc_state add macros and use them to compare current and previous PPS param in DSC. --v2 -Remove version check [Jani] -Remove dupe macro for dsc pipe compare and use the existing ones [Jani]

[Intel-gfx] ✓ Fi.CI.BAT: success for Test conflict fix for "Fix Wa_22016122933 implementation"

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" URL : https://patchwork.freedesktop.org/series/122099/ State : success == Summary == CI Bug Log - changes from CI_DRM_13485 -> Patchwork_122099v1

Re: [Intel-gfx] [PATCH v6 4/8] drm/i915/vdsc: Add function to read any PPS register

2023-08-07 Thread Nautiyal, Ankit K
On 8/3/2023 6:33 PM, Suraj Kandpal wrote: Add function to read any PPS register based on the intel_dsc_pps enum provided. Add a function which will call the new pps read function and place it in crtc state. Only PPS0 and PPS1 are readout the rest of the registers will be read in upcoming

Re: [Intel-gfx] [PATCH] drm/i915: Replace dead 01.org link

2023-08-07 Thread Jani Nikula
On Fri, 04 Aug 2023, Zhenyu Wang wrote: > 01.org is dead so replace old gvt link with current wiki page. > > Signed-off-by: Zhenyu Wang Acked-by: Jani Nikula > --- > MAINTAINERS | 2 +- > drivers/gpu/drm/i915/Kconfig | 2 +- > drivers/gpu/drm/i915/intel_gvt.c | 2 +-

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Test conflict fix for "Fix Wa_22016122933 implementation"

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" URL : https://patchwork.freedesktop.org/series/122099/ State : warning == Summary == Error: dim sparse failed /home/kbuild/linux/maintainer-tools/dim: line 50: /home/kbuild/.dimrc: No such file or

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Test conflict fix for "Fix Wa_22016122933 implementation"

2023-08-07 Thread Patchwork
== Series Details == Series: Test conflict fix for "Fix Wa_22016122933 implementation" URL : https://patchwork.freedesktop.org/series/122099/ State : warning == Summary == Error: dim checkpatch failed /home/kbuild2/linux/maintainer-tools/dim: line 50: /home/kbuild2/.dimrc: No such file or

Re: [Intel-gfx] [PATCH 16/20] drm/i915/dp: Separate out function to get compressed bpp with joiner

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:46AM +0530, Ankit Nautiyal wrote: > Pull the code to get joiner constraints on maximum compressed bpp into > separate function. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 54 ++--- > 1 file changed, 30

Re: [Intel-gfx] [PATCH 11/20] drm/i915/dp: Check min bpc DSC limits for dsc_force_bpc also

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:41AM +0530, Ankit Nautiyal wrote: > For DSC the min BPC is 8 for ICL+ and so the min pipe_bpp is 24. > Check this condition for cases where bpc is forced by debugfs flag > dsc_force_bpc. If the check fails, then WARN and ignore the debugfs > flag. > > For MST case

Re: [Intel-gfx] [PATCH 10/20] drm/i915/dp: Add functions to get min/max src input bpc with DSC

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Aug 04, 2023 at 09:42:34AM +0530, Nautiyal, Ankit K wrote: > > On 8/2/2023 5:35 PM, Lisovskiy, Stanislav wrote: > > On Fri, Jul 28, 2023 at 09:41:40AM +0530, Ankit Nautiyal wrote: > > > Separate out functions for getting maximum and minimum input BPC based > > > on platforms, when DSC is

Re: [Intel-gfx] [PATCH 19/20] drm/i915/dp: Check src/sink compressed bpp limit for edp

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:49AM +0530, Ankit Nautiyal wrote: > Use checks for src and sink limits before computing compressed bpp for > eDP. > > Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_dp.c | 20 +--- > 1

Re: [Intel-gfx] [PATCH 20/20] drm/i915/dp: Check if force_dsc_output_format is possible

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:50AM +0530, Ankit Nautiyal wrote: > Currently for testing an output format with DSC, we just force the > output format, without checking if it can be supported. > This also creates an issue where there is a PCON which might need to > convert from forced output format

Re: [Intel-gfx] [PATCH 15/20] drm/i915/dp: Add DSC BPC/BPP constraints while selecting pipe bpp with DSC

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:45AM +0530, Ankit Nautiyal wrote: > Currently we check if the pipe_bpp selected is >= the > min DSC bpc/bpp requirement. We do not check if it is <= the max DSC > bpc/bpp requirement. > > Add checks for max DSC BPC/BPP constraints while computing the > pipe_bpp when

[Intel-gfx] [CI 3/3] drm/i915/gt: Apply workaround 22016122933 correctly

2023-08-07 Thread Andi Shyti
From: Jonathan Cavitt WA_22016122933 was recently applied to all MeteorLake engines, which is simultaneously too broad (should only apply to Media engines) and too specific (should apply to all platforms that use the same media engine as MeteorLake). Correct this in cases where coherency

[Intel-gfx] [CI 2/3] drm/i915: Make i915_coherent_map_type GT-centric

2023-08-07 Thread Andi Shyti
From: Jonathan Cavitt Refactor i915_coherent_map_type to be GT-centric rather than device-centric. Each GT may require different coherency handling due to hardware workarounds. Since the function now takes a GT instead of the i915, the function is renamed and moved to the gt folder.

[Intel-gfx] [CI 0/3] Test conflict fix for "Fix Wa_22016122933 implementation"

2023-08-07 Thread Andi Shyti
Hi Jonathan, I'm just sending to CI this series because I had to fix a rebase conflict. Andi Jonathan Cavitt (3): drm/i915/gt: Simplify shmem_create_from_object map_type selection drm/i915: Make i915_coherent_map_type GT-centric drm/i915/gt: Apply workaround 22016122933 correctly

[Intel-gfx] [CI 1/3] drm/i915/gt: Simplify shmem_create_from_object map_type selection

2023-08-07 Thread Andi Shyti
From: Jonathan Cavitt The object pin created for shmem_create_from_object is just a single use mapping with the sole purpose of reading the contents of the whole object in bulk. And the whole source object is also even a throw-away. Ergo, the additional logic required by i915_coherent_map_type

Re: [Intel-gfx] [PATCH 14/20] drm/i915/dp: Separate out functions for edp/DP for computing DSC bpp

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:44AM +0530, Ankit Nautiyal wrote: > Refactor code to separate functions for eDP and DP for computing > pipe_bpp/compressed bpp when DSC is involved. > > This will help to optimize the link configuration for DP later. > > v2: Fix checkpatch warning. > >

Re: [Intel-gfx] [PATCH 13/20] drm/i915/dp: Rename helper to get DSC max pipe_bpp

2023-08-07 Thread Lisovskiy, Stanislav
On Fri, Jul 28, 2023 at 09:41:43AM +0530, Ankit Nautiyal wrote: > The helper intel_dp_dsc_compute_bpp gives the maximum > pipe bpp that is allowed with DSC. > > Rename the this to reflect that it returns max pipe bpp supported > with DSC. > > Signed-off-by: Ankit Nautiyal Reviewed-by: