[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/aux: add separate register macros and functions for VLV/CHV

2023-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/aux: add separate register macros and functions for VLV/CHV URL : https://patchwork.freedesktop.org/series/124999/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13744_full -> Patchwork_124999v1_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Store DSC DPCD capabilities in the connector (rev9)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Store DSC DPCD capabilities in the connector (rev9) URL : https://patchwork.freedesktop.org/series/124723/ State : success == Summary == CI Bug Log - changes from CI_DRM_13751 -> Patchwork_124723v9

Re: [Intel-gfx] [RFC 01/33] drm/doc/rfc: Add RFC document for proposed Plane Color Pipeline

2023-10-12 Thread Shankar, Uma
> -Original Message- > From: Christopher Braga > Sent: Friday, September 8, 2023 1:39 AM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org > Cc: Borah, Chaitanya Kumar ; wayland- > de...@lists.freedesktop.org > Subject: Re: [RFC 01/33]

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Store DSC DPCD capabilities in the connector (rev9)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Store DSC DPCD capabilities in the connector (rev9) URL : https://patchwork.freedesktop.org/series/124723/ State : warning == Summary == Error: dim checkpatch failed 6f400555c8b5 drm/i915/dp: Sanitize DPCD revision check in intel_dp_get_dsc_sink_cap()

[Intel-gfx] [PATCH] tests: save GPU engine information more properly

2023-10-12 Thread Lee Shawn C
We encounter a unexpected error on chrome book device while running kms_busy test. It will restore GPU engine's timeout value but open incorrect file name (XR24 in below). openat(AT_FDCWD, "/sys/dev/char/226:0", O_RDONLY) = 12 openat(12, "dev", O_RDONLY) = 13 read(13, "226:0\n", 1023)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: make some error capture functions static (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: make some error capture functions static (rev2) URL : https://patchwork.freedesktop.org/series/124993/ State : success == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124993v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915: make some error capture functions static (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: make some error capture functions static (rev2) URL : https://patchwork.freedesktop.org/series/124993/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: make some error capture functions static (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: make some error capture functions static (rev2) URL : https://patchwork.freedesktop.org/series/124993/ State : warning == Summary == Error: dim checkpatch failed e2e0d9ee6ffa drm/i915: make some error capture functions static

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop including i915_utils.h from intel_runtime_pm.h (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: stop including i915_utils.h from intel_runtime_pm.h (rev2) URL : https://patchwork.freedesktop.org/series/124989/ State : success == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124989v2

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: stop including i915_utils.h from intel_runtime_pm.h (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: stop including i915_utils.h from intel_runtime_pm.h (rev2) URL : https://patchwork.freedesktop.org/series/124989/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: drop gt/intel_gt.h include from skl_universal_plane.c (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: drop gt/intel_gt.h include from skl_universal_plane.c (rev2) URL : https://patchwork.freedesktop.org/series/124980/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124980v2

Re: [Intel-gfx] [PATCH v13 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-12 Thread John Harrison
On 10/12/2023 15:38, Jonathan Cavitt wrote: From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to

Re: [Intel-gfx] [PATCH v13 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-12 Thread John Harrison
On 10/12/2023 15:38, Jonathan Cavitt wrote: In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Temporarily force MTL into uncached mode (rev4)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev4) URL : https://patchwork.freedesktop.org/series/124866/ State : success == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124866v4

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the asm-generic tree

2023-10-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: arch/ia64/include/asm/fb.h between commit: cf8e8658100d ("arch: Remove Itanium (IA-64) architecture") from the asm-generic tree and commit: 052ddf7b86d2 ("fbdev: Replace fb_pgprotect() with pgprot_framebuffer()")

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Temporarily force MTL into uncached mode (rev4)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915/gt: Temporarily force MTL into uncached mode (rev4) URL : https://patchwork.freedesktop.org/series/124866/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Prevent potential null-ptr-deref in engine_init_common (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Prevent potential null-ptr-deref in engine_init_common (rev2) URL : https://patchwork.freedesktop.org/series/124971/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124971v2

Re: [Intel-gfx] [PATCH v4] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-10-12 Thread Balasubrawmanian, Vivaik
On 9/19/2023 11:04 AM, Alan Previn wrote: Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v3 : - move gt_dbg to after mutex block in function i915_gsc_proxy_component_bind. (Vivaik)

[Intel-gfx] ✓ Fi.CI.BAT: success for Frontbuffer tracking preparing for Xe (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: Frontbuffer tracking preparing for Xe (rev2) URL : https://patchwork.freedesktop.org/series/125033/ State : success == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_125033v2 Summary ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for Panel replay phase1 implementation (rev9)

2023-10-12 Thread Patchwork
== Series Details == Series: Panel replay phase1 implementation (rev9) URL : https://patchwork.freedesktop.org/series/94470/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13742_full -> Patchwork_94470v9_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Frontbuffer tracking preparing for Xe (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: Frontbuffer tracking preparing for Xe (rev2) URL : https://patchwork.freedesktop.org/series/125033/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support FP16 compressed formats on MTL (rev3)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Support FP16 compressed formats on MTL (rev3) URL : https://patchwork.freedesktop.org/series/124957/ State : success == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_124957v3 Summary

[Intel-gfx] [PATCH v13 7/7] drm/i915: Enable GuC TLB invalidations for MTL

2023-10-12 Thread Jonathan Cavitt
Enable GuC TLB invalidations for MTL. Though more platforms than just MTL support GuC TLB invalidations, MTL is presently the only platform that requires it for any purpose, so only enable it there for now to minimize cross-platform impact. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti

[Intel-gfx] [PATCH v13 6/7] drm/i915/gt: Increase sleep in gt_tlb selftest sanitycheck

2023-10-12 Thread Jonathan Cavitt
For the gt_tlb live selftest, when operating on the GSC engine, increase the timeout from 10 ms to 200 ms because the GSC engine is a bit slower than the rest. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti Acked-by: Tvrtko Ursulin Reviewed-by: Nirmoy Das ---

[Intel-gfx] [PATCH v13 5/7] drm/i915: No TLB invalidation on wedged GT

2023-10-12 Thread Jonathan Cavitt
It is not an error for GuC TLB invalidations to fail when the GT is wedged or disabled, so do not process a wait failure as one in guc_send_invalidate_tlb. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison Reviewed-by: Andi Shyti Acked-by: Tvrtko Ursulin Acked-by:

[Intel-gfx] [PATCH v13 0/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-12 Thread Jonathan Cavitt
Implement GuC-based TLB invalidations and use them on MTL. Some complexity in the implementation was introduced early on and will be required for range-based TLB invalidations. RFC: https://patchwork.freedesktop.org/series/124922/ v2: - Add missing supporting patches. v3: - Split suspend/resume

[Intel-gfx] [PATCH v13 2/7] drm/i915/guc: Add CT size delay helper

2023-10-12 Thread Jonathan Cavitt
As of now, there is no mechanism for tracking a given request's progress through the queue. Instead, add a helper that returns an estimated maximum time the queue should take to drain if completely full. Suggested-by: John Harrison Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti

[Intel-gfx] [PATCH v13 4/7] drm/i915: No TLB invalidation on suspended GT

2023-10-12 Thread Jonathan Cavitt
In case of GT is suspended, don't allow submission of new TLB invalidation request and cancel all pending requests. The TLB entries will be invalidated either during GuC reload or on system resume. Signed-off-by: Fei Yang Signed-off-by: Jonathan Cavitt CC: John Harrison Reviewed-by: Andi Shyti

[Intel-gfx] [PATCH v13 3/7] drm/i915: Define and use GuC and CTB TLB invalidation routines

2023-10-12 Thread Jonathan Cavitt
From: Prathap Kumar Valsan The GuC firmware had defined the interface for Translation Look-Aside Buffer (TLB) invalidation. We should use this interface when invalidating the engine and GuC TLBs. Add additional functionality to intel_gt_invalidate_tlb, invalidating the GuC TLBs and falling back

[Intel-gfx] [PATCH v13 1/7] drm/i915: Add GuC TLB Invalidation device info flags

2023-10-12 Thread Jonathan Cavitt
Add device info flags for if GuC TLB Invalidation is enabled. Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti Acked-by: Tvrtko Ursulin Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 2 files changed, 3

Re: [Intel-gfx] [PATCH] drm/i915: drop gt/intel_gt.h include from skl_universal_plane.c

2023-10-12 Thread Matt Roper
On Wed, Oct 11, 2023 at 05:27:04PM +0300, Jani Nikula wrote: > No longer needed after commit 94bcf876cb6a ("drm/i915/mtl: Drop > Wa_14017240301"). > > Signed-off-by: Jani Nikula Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 - > 1 file changed, 1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/sprite: move sprite_name() to intel_sprite.c (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915/sprite: move sprite_name() to intel_sprite.c (rev2) URL : https://patchwork.freedesktop.org/series/125000/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13749 -> Patchwork_125000v2

[Intel-gfx] ✗ Fi.CI.BUILD: failure for linux-next: build failure after merge of the drm-misc tree (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: linux-next: build failure after merge of the drm-misc tree (rev2) URL : https://patchwork.freedesktop.org/series/125017/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/125017/revisions/2/mbox/ not applied Applying:

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dsb: Correct DSB command buffer cache coherency settings

2023-10-12 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, October 9, 2023 6:52 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 2/4] drm/i915/dsb: Correct DSB command buffer > cache coherency settings > > From: Ville Syrjälä > > The

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove the module parameter 'fastboot' (rev5)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove the module parameter 'fastboot' (rev5) URL : https://patchwork.freedesktop.org/series/124255/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13741_full -> Patchwork_124255v5_full

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dsb: Allocate command buffer from local memory

2023-10-12 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Monday, October 9, 2023 6:52 PM > To: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 1/4] drm/i915/dsb: Allocate command buffer from > local memory > > From: Ville Syrjälä > > Using system

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Retry gtt fault when out of fence register URL : https://patchwork.freedesktop.org/series/125058/ State : success == Summary == CI Bug Log - changes from CI_DRM_13748 -> Patchwork_125058v1 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Retry gtt fault when out of fence register URL : https://patchwork.freedesktop.org/series/125058/ State : warning == Summary == Error: dim checkpatch failed 34c4698cf822 drm/i915: Retry gtt fault when out of fence register -:19:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move the g45 PEG band gap HPD workaround to the HPD code

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Move the g45 PEG band gap HPD workaround to the HPD code URL : https://patchwork.freedesktop.org/series/125053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13748 -> Patchwork_125053v1

[Intel-gfx] [PATCH] drm/i915: Fix bigjoiner case for DP2.0

2023-10-12 Thread vsrini4
Patch calculates bigjoiner pipes in mst compute. Patch also passes bigjoiner bool to validate plane max size. Signed-off-by: vsrini4 --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: DPLL code cleanups

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: DPLL code cleanups URL : https://patchwork.freedesktop.org/series/125052/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13747 -> Patchwork_125052v1 Summary --- **FAILURE**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: DPLL code cleanups

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: DPLL code cleanups URL : https://patchwork.freedesktop.org/series/125052/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-12 Thread John Harrison
On 10/12/2023 06:45, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) *URL:* https://patchwork.freedesktop.org/series/125002/ *State:*failure *Details:*

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add new DG2 PCI IDs (rev2)

2023-10-12 Thread Matt Roper
On Thu, Oct 12, 2023 at 03:26:14AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add new DG2 PCI IDs (rev2) > URL : https://patchwork.freedesktop.org/series/124937/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_13741 -> Patchwork_124937v2 >

Re: [Intel-gfx] [PATCH] drm/i915/guc: Suppress 'ignoring reset notification' message

2023-10-12 Thread John Harrison
On 10/12/2023 03:21, Tvrtko Ursulin wrote: On 21/09/2023 19:20, john.c.harri...@intel.com wrote: From: John Harrison If an active context has been banned (e.g. Ctrl+C killed) then it is likely to be reset as part of evicting it from the hardware. That results in a 'ignoring context reset

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add bigjoiner force enable option to debugfs (rev3)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Add bigjoiner force enable option to debugfs (rev3) URL : https://patchwork.freedesktop.org/series/124730/ State : success == Summary == CI Bug Log - changes from CI_DRM_13747 -> Patchwork_124730v3

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add bigjoiner force enable option to debugfs (rev3)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Add bigjoiner force enable option to debugfs (rev3) URL : https://patchwork.freedesktop.org/series/124730/ State : warning == Summary == Error: dim checkpatch failed e206f80af151 drm/i915: Add bigjoiner force enable option to debugfs -:61:

[Intel-gfx] [PATCH v7 18/25] dyndbg-doc: add classmap info to howto

2023-10-12 Thread Jim Cromie
Add some basic info on classmap usage and api Signed-off-by: Jim Cromie --- v5- adjustments per Randy Dunlap, me --- .../admin-guide/dynamic-debug-howto.rst | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH v7 25/25] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

2023-10-12 Thread Jim Cromie
Lots of burn-in testing needed before signing, upstreaming. NOTE: I set default Y to maximize testing by default. Is there a better way to do this ? Signed-off-by: Jim Cromie --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH v7 24/25] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers

2023-10-12 Thread Jim Cromie
Add a DRM_CLASSMAP_USE declaration to 2nd batch of helpers and *_drv.c files. For drivers, add the decl just above the module's PARAMs, since it identifies the "inherited" drm.debug param. Note: with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, a module not also declaring DRM_CLASSMAP_USE will have its

[Intel-gfx] [PATCH v7 23/25] drm: use correct ccflags-y spelling

2023-10-12 Thread Jim Cromie
Incorrectly spelled CFLAGS- failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=y CONFIG_DYNAMIC_DEBUG_CORE=y CONFIG_DYNAMIC_DEBUG=n Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in

[Intel-gfx] [PATCH v7 19/25] dyndbg: reserve flag bit _DPRINTK_FLAGS_PREFIX_CACHED

2023-10-12 Thread Jim Cromie
Reserve bit 7 to remember that a pr-debug callsite is/was: - enabled, with +p - wants a dynamic-prefix, with one+ of module:function:sourcfile - was previously called - was thus saved in the cache. NOT YET. Its unclear whether any cache fetch would be faster than 2-3 field fetches, but theres

[Intel-gfx] [PATCH v7 20/25] dyndbg: add _DPRINTK_FLAGS_INCL_LOOKUP

2023-10-12 Thread Jim Cromie
dyndbg's dynamic prefixing (by +tmfsl flags) is needlessly expensive. When an enabled (with +p) pr_debug is called, _DPRINTK_FLAGS_INCL_ANY prefix decorations are sprintf'd into stack-mem for every call. This string (or part of it) could be cached once its 1st generated, and retreived

[Intel-gfx] [PATCH v7 22/25] dyndbg: improve err report in attach_user_module_classes

2023-10-12 Thread Jim Cromie
convert a WARN on 3 conditions, into BUG_ON 2 of them (which don't happen), and an early return on (!cli->user_mod_name), which *was* happening, so should be seen going forward. Maybe this should be a WARN. NB: The underlying problem was a missing __align(8) in the DYNDBG_CLASSMAP_USE, which

[Intel-gfx] [PATCH v7 13/25] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code

2023-10-12 Thread Jim Cromie
Remove the NAMED class types; these 2 classmap types accept class names at the PARAM interface, for example: echo +DRM_UT_CORE,-DRM_UT_KMS > /sys/module/drm/parameters/debug_names The code works, but its only used by test-dynamic-debug, and wasn't asked for by anyone else, so simplify things

[Intel-gfx] [PATCH v7 21/25] dyndbg: refactor *dynamic_emit_prefix

2023-10-12 Thread Jim Cromie
Refactor the split of duties between outer & inner fns. The outer fn was previously just an inline unlikely forward to inner, which did all the work. Now, outer handles +t and +l flags itself, and calls inner only when _DPRINTK_FLAGS_INCL_LOOKUP is needed. No functional change. But it does

[Intel-gfx] [PATCH v7 16/25] dyndbg: refactor ddebug_classparam_clamp_input

2023-10-12 Thread Jim Cromie
Extract input validation code, from param_set_dyndbg_module_classes() (the sys-node >handler) to new: ddebug_classparam_clamp_input(kp), call it from former. It takes kernel-param arg, so it can complain about "foo: bad input". Reuse ddparam_clamp_input(kp) in ddebug_sync_classbits(), to

[Intel-gfx] [PATCH v7 17/25] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

2023-10-12 Thread Jim Cromie
move macro from test-dynamic-debug.c into header, and refine it. Distinguish the 2 use cases of DYNDBG_CLASSMAP_PARAM* 1.DYNDBG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm can still use it as before 2.DYNDBG_CLASSMAP_PARAM new

[Intel-gfx] [PATCH v7 15/25] dyndbg: add for_each_boxed_vector

2023-10-12 Thread Jim Cromie
Add a for_each iterator to walk a counted vector member in a struct (ie the box), and use it to replace 8 open-coded loops. Signed-off-by: Jim Cromie --- v5- parens-on-box-force-precedence --- lib/dynamic_debug.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff

[Intel-gfx] [PATCH v7 14/25] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression

2023-10-12 Thread Jim Cromie
DECLARE_DYNDBG_CLASSMAP() has a design error; it fails a basic K rule: "define once, refer many times". When DRM_USE_DYNAMIC_DEBUG=y, DECLARE_DYNDBG_CLASSMAP() is used across DRM core & drivers; they all repeat the same classmap-defn args, which must match for the modules to respond together when

[Intel-gfx] [PATCH v7 09/25] dyndbg: silence debugs with no-change updates

2023-10-12 Thread Jim Cromie
check for actual changes before announcing them, declutter logs. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index b0e11f6bfaa2..b07aab422604 100644 ---

[Intel-gfx] [PATCH v7 10/25] dyndbg: tighten ddebug_class_name() 1st arg type

2023-10-12 Thread Jim Cromie
Change function's 1st arg-type, and deref in the caller. The fn doesn't need any other fields in the struct. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c

[Intel-gfx] [PATCH v7 11/25] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

2023-10-12 Thread Jim Cromie
old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++-- 1 file changed, 11 insertions(+), 10

[Intel-gfx] [PATCH v7 12/25] dyndbg: reduce verbose=3 messages in ddebug_add_module

2023-10-12 Thread Jim Cromie
The fn currently says "add-module", then "skipping" if the module has no prdbgs. Just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c

[Intel-gfx] [PATCH v7 06/25] dyndbg: split param_set_dyndbg_classes to module/wrapper fns

2023-10-12 Thread Jim Cromie
rename param_set_dyndbg_classes: add _module_ name & arg, old name is wrapper to new. New arg allows caller to specify that only one module is affected by a prdbgs update. Outer fn preserves kernel_param interface, passing NULL to inner fn. This selectivity will be used later to narrow the scope

[Intel-gfx] [PATCH v7 07/25] dyndbg: drop NUM_TYPE_ARRAY

2023-10-12 Thread Jim Cromie
ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index

[Intel-gfx] [PATCH v7 08/25] dyndbg: reduce verbose/debug clutter

2023-10-12 Thread Jim Cromie
currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0x dyndbg: parsed: func="" file="" module=""

[Intel-gfx] [PATCH v7 05/25] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

2023-10-12 Thread Jim Cromie
Add query_module param to ddebug_apply_class_bitmap(). This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional change. Signed-off-by: Jim Cromie --- after `modprobe i915`, heres the

[Intel-gfx] [PATCH v7 04/25] dyndbg: replace classmap list with a vector

2023-10-12 Thread Jim Cromie
Classmaps are stored/linked in a section/array, but are each added to the module's ddebug_table.maps list-head. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a module's possibly

[Intel-gfx] [PATCH v7 03/25] dyndbg: make ddebug_class_param union members same size

2023-10-12 Thread Jim Cromie
struct ddebug_class_param keeps a ref to the state-storage of the param, make both flavors use the same unsigned long under-type. ISTM this is simpler and safer. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2

[Intel-gfx] [PATCH v7 01/25] test-dyndbg: fixup CLASSMAP usage error

2023-10-12 Thread Jim Cromie
more careful reading of test output reveals: lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing categories\n" lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI

[Intel-gfx] [PATCH v7 02/25] dyndbg: reword "class unknown, " to "class:_UNKNOWN_"

2023-10-12 Thread Jim Cromie
This appears in the control-file to report an unknown class-name, which indicates that the class_id is not authorized, and dyndbg will ignore changes to it. Generally, this means that a DYNDBG_CLASSMAP_DEFINE or DYNDBG_CLASSMAP_USE is missing. But the word "unknown" appears in quite a few prdbg

[Intel-gfx] [PATCH v7 00/25] fix DRM_USE_DYNAMIC_DEBUG=y regression

2023-10-12 Thread Jim Cromie
hi Jason, DRM-folk This patchest fixes the chicken-egg initialization problem in the 1st version of ddebug-class-maps, that DRM-CI uncovered. The root-problem was DECLARE_DYNDBG_CLASSMAP, which broke the K rule: "define once, refer many". In patch 14 it is replaced by: DYNDBG_CLASSMAP_DEFINE

[Intel-gfx] [PATCH v7 00/25] fix DRM_USE_DYNAMIC_DEBUG=y regression

2023-10-12 Thread Jim Cromie
hi Jason, DRM-folk This patchest fixes the chicken-egg initialization problem in the 1st version of ddebug-class-maps, that DRM-CI uncovered. The root-problem was DECLARE_DYNDBG_CLASSMAP, which broke the K rule: "define once, refer many". In patch 14 it is replaced by: DYNDBG_CLASSMAP_DEFINE

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clean up zero initializers

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Clean up zero initializers URL : https://patchwork.freedesktop.org/series/125050/ State : success == Summary == CI Bug Log - changes from CI_DRM_13746 -> Patchwork_125050v1 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up zero initializers

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Clean up zero initializers URL : https://patchwork.freedesktop.org/series/125050/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Abstract the extra JSL/EHL DPLL4 power domain better

2023-10-12 Thread Imre Deak
On Thu, Oct 12, 2023 at 05:56:34PM +0300, Jani Nikula wrote: > On Thu, 12 Oct 2023, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Just include the JSL/EHL DPLL4 extra power domain in the dpll_info > > struct. This way the same approach could be used by other platforms > > as well (should

Re: [Intel-gfx] [PATCH] drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Greg KH
On Thu, Oct 12, 2023 at 04:53:38PM +0300, Ville Syrjälä wrote: > On Thu, Oct 12, 2023 at 03:40:08PM +0200, Greg KH wrote: > > On Thu, Oct 12, 2023 at 04:28:01PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > If we can't find a free fence register to handle a fault in the GMADR

Re: [Intel-gfx] [PATCH 00/25] Framework for display parameters

2023-10-12 Thread Jani Nikula
On Tue, 10 Oct 2023, Jouni Högander wrote: > Currently all module parameters are handled by i915_param.c/h. This > is a problem for display parameters when Xe driver is used. > > This patch set adds a mechanism to add parameters specific to the > display. This is mainly copied from existing i915

Re: [Intel-gfx] [PATCH 0/6] drm/i915: Clean up zero initializers

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Unify the array/struct zero initialization to use the least > awkward form (= {}). Yes, please! Reviewed-by: Jani Nikula on the series > > Ville Syrjälä (6): > drm/i915/display: Clean up zero initializers >

Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Stanislav Lisovskiy wrote: > For validation purposes, it might be useful to be able to > force Bigjoiner mode, even if current dotclock/resolution > do not require that. > Lets add such to option to debugfs. > > v2: - Apparently intel_dp_need_bigjoiner can't be used, when >

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Extract _intel_{enable, disable}_shared_dpll()

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We have a bit of duplicated code around the DPLL disabling. Extact *extract > that to new function, and for symmetry also do the same for the > enable direction. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Move the DPLL extra power domain handling up one level

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > The extra DPLL power domain is currently handled in three places: > - combo_pll_enable() > - combo_pll_disable() > - readout_dpll_hw_state() > > First two of those are low level PLL funcs, but the third is a higher > level

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Abstract the extra JSL/EHL DPLL4 power domain better

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Just include the JSL/EHL DPLL4 extra power domain in the dpll_info > struct. This way the same approach could be used by other platforms > as well (should the need arise), and we don't have to sprinkle > platform checks all over

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Use named initializers for DPLL info

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > Use named initializers when populating the DPLL info. This > is just more convenient and less error prone as we no longer > have to keep the initializers in a specific order. > > Signed-off-by: Ville Syrjälä Nitpick, it's

Re: [Intel-gfx] [PATCH] drm/i915: Move the g45 PEG band gap HPD workaround to the HPD code

2023-10-12 Thread Jani Nikula
On Thu, 12 Oct 2023, Ville Syrjala wrote: > From: Ville Syrjälä > > We are asked to reprogram PEG_BAND_GAP_DATA prior to enabling > hotplug detection on the g45 HDMI/DP ports. Currently we do said > reprogamming from the DP/HDMI connector initialization functions. > That code should be mostly

Re: [Intel-gfx] [PATCH i-g-t v3 04/11] lib/kunit: Fix misplaced igt_kunit() doc

2023-10-12 Thread Mauro Carvalho Chehab
On Wed, 11 Oct 2023 16:17:39 +0200 Janusz Krzysztofik wrote: > When igt_kunit() was converted to a helper and wrapped with a new function > promoted to take the name and role of the library API, related > documentation was left unchanged and still placed in front the demoted > function. Update

Re: [Intel-gfx] [PATCH i-g-t v3 02/11] lib/kunit: Fix handling of potential errors from F_GETFL

2023-10-12 Thread Mauro Carvalho Chehab
On Wed, 11 Oct 2023 16:17:37 +0200 Janusz Krzysztofik wrote: > Function fcntl(..., F_GETFL, ...) that returns file status flags may also > return a negative error code. Handle that error instead of blindly using > the returned value as flags. > > Signed-off-by: Janusz Krzysztofik >

Re: [Intel-gfx] [PATCH i-g-t v3 01/11] lib/ktap: Improve TODO workaround description

2023-10-12 Thread Mauro Carvalho Chehab
On Wed, 11 Oct 2023 16:17:36 +0200 Janusz Krzysztofik wrote: > A workaround was implemented in IGT KTAP parser so it could accepted KTAP > reports with missing top level KTAP version and test suite plan headers. > While the issue has been fixed by a kernel side commit c95e7c05c139 > ("kunit:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove the modparam verbose_state_checks

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove the modparam verbose_state_checks URL : https://patchwork.freedesktop.org/series/125047/ State : success == Summary == CI Bug Log - changes from CI_DRM_13746 -> Patchwork_125047v1 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Remove the modparam verbose_state_checks

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove the modparam verbose_state_checks URL : https://patchwork.freedesktop.org/series/125047/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [Intel-gfx] [PATCH] drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Ville Syrjälä
On Thu, Oct 12, 2023 at 03:40:08PM +0200, Greg KH wrote: > On Thu, Oct 12, 2023 at 04:28:01PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If we can't find a free fence register to handle a fault in the GMADR > > range just return VM_FAULT_NOPAGE without populating the PTE so that

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/125002/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13746 -> Patchwork_125002v2

[Intel-gfx] [PULL] drm-intel-next

2023-10-12 Thread Jani Nikula
Hi Dave & Sima - Here's the 2nd i915 feature pull for v6.7. There might be another small feature pull coming next week, mainly to remove force probe for Meteorlake, and promote it to fully supported. There are some final issues being ironed out still. There's a backmerge in there; I

Re: [Intel-gfx] [PATCH] drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Greg KH
On Thu, Oct 12, 2023 at 04:28:01PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > If we can't find a free fence register to handle a fault in the GMADR > range just return VM_FAULT_NOPAGE without populating the PTE so that > userspace will retry the access and trigger another fault.

[Intel-gfx] [PATCH] drm/i915: Retry gtt fault when out of fence register

2023-10-12 Thread Ville Syrjala
From: Ville Syrjälä If we can't find a free fence register to handle a fault in the GMADR range just return VM_FAULT_NOPAGE without populating the PTE so that userspace will retry the access and trigger another fault. Eventually we should find a free fence and the fault will get properly

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/125002/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2)

2023-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Define and use GuC and CTB TLB invalidation routines (rev2) URL : https://patchwork.freedesktop.org/series/125002/ State : warning == Summary == Error: dim checkpatch failed d834878536d9 drm/i915: Add GuC TLB Invalidation device info flags 5a90bbf66c6e

Re: [Intel-gfx] [PATCH] drm/i915: stop including i915_utils.h from intel_runtime_pm.h

2023-10-12 Thread Ville Syrjälä
On Wed, Oct 11, 2023 at 07:21:02PM +0300, Jani Nikula wrote: > Remove an unnecessary include. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_runtime_pm.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915/sprite: move sprite_name() to intel_sprite.c

2023-10-12 Thread Ville Syrjälä
On Wed, Oct 11, 2023 at 11:22:59PM +0300, Jani Nikula wrote: > Move sprite_name() where its only user is, and convert it to a function, > removing the implicit dev_priv usage. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_display.h | 1 -

  1   2   >