[Intel-gfx] [PATCH] drm/i915/chv: calculate rc6 residency correctly

2014-07-09 Thread Mika Kuoppala
Barnes jbar...@virtuousgeek.org Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Tested-by: Guo Jinxian jinxianx@intel.com Reviewed-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_reg.h |2 +- drivers/gpu/drm/i915/i915_sysfs.c | 39

[Intel-gfx] [PATCH 4/4] drm/i915: remove i915_rstdby_delays debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading on 0x11100 References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/4] drm/i915: remove i915_gfxec debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading on 0x112f4. References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Suggested-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 21 - 1 file changed, 21

[Intel-gfx] [PATCH 1/4] drm/i915: remove i915_delayedfreq_table debugfs entry

2014-07-09 Thread Mika Kuoppala
CHV hard hangs on reading these registers. As these have not been used since cantiga ilk, remove the debugfs entry. References: https://bugs.freedesktop.org/show_bug.cgi?id=80893 Suggested-by: Jesse Barnes jbar...@virtuousgeek.org Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers

[Intel-gfx] [PATCH 0/4] remove obsolete debugfs entries

2014-07-09 Thread Mika Kuoppala
These are accessing registers that the chv doesn't seem to have. Read access on these regions cause a system hard hang. If some of these are still on use just nack and I do gen check patch instead. Mika Kuoppala (4): drm/i915: remove i915_delayedfreq_table debugfs entry drm/i915: remove

Re: [Intel-gfx] [PATCH 1/2] lib/gen6_render: removed duplicate defines

2014-07-10 Thread Mika Kuoppala
Damien Lespiau damien.lesp...@intel.com writes: On Thu, Jul 10, 2014 at 03:47:55PM +0300, Mika Kuoppala wrote: Textually the same so no harm was done and no warnings from compiler either. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Ship it! Will do. (is there a patch 2/2

Re: [Intel-gfx] [PATCH 1/7] drm/i915: Read guaranteed freq for valleyview

2014-07-11 Thread Mika Kuoppala
deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com Reading RP1 for valleyview to help us enable pm_rps i-g-t testcase execution. Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Add RP0/RP1/RPn render P state thresholds in VLV sysfs

2014-07-11 Thread Mika Kuoppala
deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com This is useful for userspace utilities to verify and micromanaging the increase/decrease frequncy. Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu

Re: [Intel-gfx] [PATCH 4/7] drm/i915: populate mem_freq/cz_clock for chv

2014-07-11 Thread Mika Kuoppala
cherryview_init_clock_gating(struct drm_device *dev) { struct drm_i915_private *dev_priv = dev-dev_private; + u32 val; + + mutex_lock(dev_priv-rps.hw_lock); + val = vlv_punit_read(dev_priv, CCK_FUSE_REG); s/punit/cck (?) With the changes mentioned above: Reviewed-by: Mika Kuoppala mika.kuopp

Re: [Intel-gfx] [PATCH 6/7] drm/i915/chv: Add basic PM interrupt support for CHV

2014-07-11 Thread Mika Kuoppala
deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com Enabled PM interrupt programming for CHV. Re-using gen8 code and extending same for CHV. Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: CHV GPU frequency to opcode functions

2014-07-11 Thread Mika Kuoppala
deepa...@linux.intel.com writes: From: Deepak S deepa...@linux.intel.com Adding chv specific fre/encode conversion. v2: Remove generic function and platform check (Daniel) Signed-off-by: Deepak S deepa...@linux.intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers

Re: [Intel-gfx] [PATCH v2] drm/i915: Add RP1 render P state thresholds in CHV

2014-07-11 Thread Mika Kuoppala
cherryview_rps_rpe_freq(struct drm_i915_private *dev_priv) return rpe; } +int cherryview_rps_guar_freq(struct drm_i915_private *dev_priv) ^^static Daniel said he will add it, missing in other patches too. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com +{ + u32 val, rp1

[Intel-gfx] [PATCH] tests: Add drv_workarounds

2014-08-01 Thread Mika Kuoppala
To check that static workarounds are set and stay after init, hang and suspend/restore. Checks are currently provided for ivb and bdw only. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- lib/intel_chipset.h |4 + lib/intel_workaround.h | 142 +++ tests

[Intel-gfx] [PATCH] igt: Add drv_workarounds

2014-08-01 Thread Mika Kuoppala
Hi, With ivb we currently drop 5 out of 11 static workarounds due to hang/reset recovery. With bdw we see that some workarounds wont stick even after init, due to rc6 entry dropping some regs that are not part of power context? Mika Kuoppala (1): tests: Add drv_workarounds lib

[Intel-gfx] [PATCH 3/5] lib/gen6_render: fix GEN6_3DSTATE_VF_STATISTICS define

2014-08-01 Thread Mika Kuoppala
We dont use this pre CTG and we will need it for gen8 golden state. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- lib/gen6_render.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/gen6_render.h b/lib/gen6_render.h index dfee6e7..c3e85eb 100644 --- a/lib

[Intel-gfx] [PATCH 5/5] tools/null_state_gen: build cmd and state space separately

2014-08-01 Thread Mika Kuoppala
. There is no change in the output states produced. This can be considered as a preparatory patch to help introduce gen8 golden state. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/null_state_gen/intel_batchbuffer.c | 251 + tools/null_state_gen

[Intel-gfx] [PATCH 1/5] tools/null_state_gen: terminate relocs with -1

2014-08-01 Thread Mika Kuoppala
as this was already changed in kernel. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/null_state_gen/intel_null_state_gen.c |1 + 1 file changed, 1 insertion(+) diff --git a/tools/null_state_gen/intel_null_state_gen.c b/tools/null_state_gen/intel_null_state_gen.c index

[Intel-gfx] [PATCH 4/5] lib: Add MI_LOAD_REGISTER_IMM

2014-08-01 Thread Mika Kuoppala
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- lib/intel_reg.h |1 + tests/gem_exec_parse.c |1 - tests/gem_non_secure_batch.c |4 +--- tests/gen7_forcewake_mt.c|5 ++--- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/lib

[Intel-gfx] [PATCH 2/5] lib/rendercopy: fix a typo in define

2014-08-01 Thread Mika Kuoppala
No functional changes Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- lib/gen6_render.h |2 +- lib/rendercopy_gen8.c |2 +- tools/null_state_gen/intel_renderstate_gen8.c |2 +- 3 files changed, 3 insertions(+), 3 deletions

[Intel-gfx] [PATCH] drm/i915: Don't accumate hangcheck score on forward progress

2014-08-05 Thread Mika Kuoppala
If the actual head has progressed forward inside a batch (request), don't accumulate hangcheck score. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gpu_error.c |2 ++ drivers/gpu/drm/i915/i915_irq.c | 15 --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Don't accumulate hangcheck score on forward progress

2014-08-05 Thread Mika Kuoppala
the batch progression so that it overcomes the bonus that forward progress gives. v2: Improved commit message (Chris Wilson) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gpu_error.c |2 ++ drivers/gpu/drm/i915/i915_irq.c | 15

Re: [Intel-gfx] [PATCH v2] drm/i915: Rework GPU reset sequence to match driver load thaw

2014-08-06 Thread Mika Kuoppala
Hi, alistair.mcau...@intel.com writes: From: McAulay, Alistair alistair.mcau...@intel.com This patch is to address Daniels concerns over different code during reset: http://lists.freedesktop.org/archives/intel-gfx/2014-June/047758.html The reason for aiming as hard as possible to use the

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Print captured bo for all VM in error state

2014-08-13 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: The current error state harks back to the era of just a single VM. For full-ppgtt, we capture every bo on every VM. It behoves us to then print every bo for every VM, which we currently fail to do and so miss vital information in the error state.

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Print captured bo for all VM in error state

2014-08-14 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: On Wed, Aug 13, 2014 at 05:50:38PM +0300, Mika Kuoppala wrote: Chris Wilson ch...@chris-wilson.co.uk writes: The current error state harks back to the era of just a single VM. For full-ppgtt, we capture every bo on every VM. It behoves us

[Intel-gfx] [PATCH] drm/i915: Don't warn if we restore pm interrupts during reset

2014-08-14 Thread Mika Kuoppala
We lost the software state tracking due to reset, so don't complain if it doesn't match. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers

[Intel-gfx] [PATCH v2] drm/i915: Don't warn if we restore pm interrupts during reset

2014-08-14 Thread Mika Kuoppala
We lost the software state tracking due to reset, so don't complain if it doesn't match. v2: fix build error Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Do not access stolen memory directly by the CPU, even for error capture

2014-08-14 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: For stolen pages, since it is verboten to access them directly on many architectures, we have to read them through the GTT aperture. If they are not accessible through the aperture, then we have to abort. This was complicated by commit

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't warn if we restore pm interrupts during reset

2014-08-14 Thread Mika Kuoppala
Daniel Vetter dan...@ffwll.ch writes: On Thu, Aug 14, 2014 at 03:46:43PM +0300, Mika Kuoppala wrote: We lost the software state tracking due to reset, so don't complain if it doesn't match. This sounds more like gpu reset should be a bit more careful (even more careful than we already

Re: [Intel-gfx] [PATCH v2] drm/i915: Don't warn if we restore pm interrupts during reset

2014-08-14 Thread Mika Kuoppala
Mika Kuoppala mika.kuopp...@linux.intel.com writes: Daniel Vetter dan...@ffwll.ch writes: On Thu, Aug 14, 2014 at 03:46:43PM +0300, Mika Kuoppala wrote: We lost the software state tracking due to reset, so don't complain if it doesn't match. This sounds more like gpu reset should be a bit

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Do not access stolen memory directly by the CPU, even for error capture

2014-08-15 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: For stolen pages, since it is verboten to access them directly on many architectures, we have to read them through the GTT aperture. If they are not accessible through the aperture, then we have to abort. This was complicated by commit

Re: [Intel-gfx] [PATCH v2] drm/i915: Rework GPU reset sequence to match driver load thaw

2014-08-15 Thread Mika Kuoppala
i915_gem_render_state_init() for it. But this can be considered as a possible future work. -Mika Alistair. -Original Message- From: Mika Kuoppala [mailto:mika.kuopp...@linux.intel.com] Sent: Wednesday, August 06, 2014 5:25 PM To: Mcaulay, Alistair; intel-gfx@lists.freedesktop.org Subject: Re

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Do not access stolen memory directly by the CPU, even for error capture

2014-08-15 Thread Mika Kuoppala
Mika Kuoppala mika.kuopp...@linux.intel.com writes: Chris Wilson ch...@chris-wilson.co.uk writes: For stolen pages, since it is verboten to access them directly on many architectures, we have to read them through the GTT aperture. If they are not accessible through the aperture, then we have

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Remove num_pages parameter to i915_error_object_create()

2014-08-15 Thread Mika Kuoppala
to only capture the first page of the context), we can remove the redundant macro and be NULL safe again. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org Cc: John Harrison john.c.harri...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Suppress a WARN on reading an object back for a GPU hang

2014-08-15 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com

Re: [Intel-gfx] [PATCH v3] drm/i915: Rework GPU reset sequence to match driver load thaw

2014-08-19 Thread Mika Kuoppala
of preventing check_wedge returning -EAGAIN V3: Clean the last_context during reset, to ensure do_switch() does the MI_SET_CONTEXT. As per review. Signed-off-by: McAulay, Alistair alistair.mcau...@intel.com --- Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com drivers/gpu/drm/i915/i915_drv.c

Re: [Intel-gfx] [PATCH 1/2] drm/i915/bdw: Apply workarounds using the golden render state

2014-08-22 Thread Mika Kuoppala
Ville Syrjälä ville.syrj...@linux.intel.com writes: On Wed, Aug 20, 2014 at 03:19:17PM +0100, Arun Siluvery wrote: Workarounds for bdw are currently applied in init_clock_gating() but they are lost following a gpu reset. Some of the WA registers are part of register state context and they are

[Intel-gfx] [PATCH] drm/i915: detect hang using per ring hangcheck_score

2013-05-30 Thread Mika Kuoppala
-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 80 ++- drivers/gpu/drm/i915/intel_ringbuffer.h |2 + 2 files changed, 49 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/4] drm/i915: export error state to string conversion

2013-06-06 Thread Mika Kuoppala
In preparation for accessing error state from sysfs, export error state to string conversion function. Also tuck buffer error handling inside the function. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 24 drivers/gpu

[Intel-gfx] [PATCH 4/4] drm/i915: add i915_error_state sysfs entry

2013-06-06 Thread Mika Kuoppala
As getting error state doesn't anymore require big kmallocs, make error state accessible also from sysfs. Suggested-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_sysfs.c | 49 + 1

[Intel-gfx] [PATCH 2/4] drm/i915: export error state ref handling

2013-06-06 Thread Mika Kuoppala
In preparation for sysfs error state access, export ref error state ref counting interface. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 31 ++- drivers/gpu/drm/i915/i915_drv.h |3 +++ 2 files changed, 25

[Intel-gfx] [PATCH 3/4] drm/i915: introduce i915_error_state_buf_init

2013-06-06 Thread Mika Kuoppala
Make function for struct i915_error_state_buf initialization and export it, for sysfs and debugfs. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 50 +-- drivers/gpu/drm/i915/i915_drv.h |7 + 2 files

[Intel-gfx] [PATCH 4/4] drm/i915: add error_state sysfs entry

2013-06-06 Thread Mika Kuoppala
As getting error state doesn't anymore require big kmallocs, make error state accessible also from sysfs. v2: - error state clearing (Chris Wilson) - user hint, proper access mode bits and name (Daniel Vetter) Suggested-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Mika Kuoppala

[Intel-gfx] [PATCH 4/4] drm/i915: add error_state sysfs entry

2013-06-06 Thread Mika Kuoppala
daniel.vet...@ffwll.ch Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c |3 +- drivers/gpu/drm/i915/i915_sysfs.c | 71 + 2 files changed, 72 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Only slightly increment hangcheck score if we succesfully kick a ring

2013-06-06 Thread Mika Kuoppala
the hangcheck score - just not as severely so that it takes multiple kicks to fail. This should address part of Ben's justified criticism of commit 05407ff889ceebe383aa5907219f86582ef96b72 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Thu May 30 09:04:29 2013 +0300 drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Eliminate the addr/seqno from the hangcheck warning

2013-06-07 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: This is of no value to the developer reading the report, let alone the bamboozled user. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Acked-by: Mika Kuoppala mika.kuopp...@intel.com ___ Intel-gfx

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Eliminate the addr/seqno from the hangcheck warning

2013-06-10 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: This is of no value to the developer reading the report, let alone the bamboozled user. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Acked-by: Mika Kuoppala mika.kuopp...@linux.intel.com --- drivers/gpu/drm/i915/i915_irq.c |8

[Intel-gfx] [PATCH 5/7] drm/i915: store ring hangcheck action

2013-06-12 Thread Mika Kuoppala
For guilty batchbuffer analysis later on when rings are reset, store what state the ring was on when hang was declared. This helps to weed out the waiting rings from the active ones. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c |8

[Intel-gfx] [PATCH 4/7] drm/i915: add batch bo to i915_add_request()

2013-06-12 Thread Mika Kuoppala
-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h| 11 +-- drivers/gpu/drm/i915/i915_gem.c|6 +- drivers/gpu/drm/i915/i915_gem_execbuffer.c |7 --- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 1/7] drm/i915: add struct i915_ctx_hang_stats

2013-06-12 Thread Mika Kuoppala
To count context losses, add struct i915_ctx_hang_stats for both i915_hw_context and drm_i915_file_private. drm_i915_file_private is used when there is no context. v2: renamed and cleaned up the struct (Chris Wilson, Ian Romanick) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers

[Intel-gfx] [PATCH 7/7] drm/i915: refuse to submit more batchbuffers from guilty context

2013-06-12 Thread Mika Kuoppala
instead of stashing state into gpu_error (Chris Wilson) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c|6 +++-- drivers/gpu/drm/i915/i915_drv.h|8 ++- drivers/gpu/drm/i915/i915_gem.c| 34

[Intel-gfx] [PATCH 2/7] drm/i915: add i915_gem_context_get_hang_stats()

2013-06-12 Thread Mika Kuoppala
drm_i915_file_private. v2: handle default context inside get_reset_state v3: return struct pointer instead of passing it in as param (Chris Wilson) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |4 drivers/gpu/drm/i915/i915_gem_context.c

[Intel-gfx] [PATCH 3/7] drm/i915: change i915_add_request to macro

2013-06-12 Thread Mika Kuoppala
commit smaller and easier to understand. v2: _i915_add_request as function name (Chris Wilson) v3: change name __i915_add_request and fix ordering of params (Ben Widawsky) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h|8 +--- drivers/gpu

[Intel-gfx] [PATCH 6/7] drm/i915: find guilty batch buffer on ring resets

2013-06-12 Thread Mika Kuoppala
in commit message (Ville Syrjälä) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 88 +++ 1 file changed, 88 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 5be7846

[Intel-gfx] [PATCH 4/7] drm/i915: add batch bo to i915_add_request()

2013-06-12 Thread Mika Kuoppala
comment about request vs batch_obj lifetimes (Chris Wilson) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h| 11 +-- drivers/gpu/drm/i915/i915_gem.c| 13 - drivers/gpu/drm/i915/i915_gem_execbuffer.c |7

[Intel-gfx] [PATCH 6/7] drm/i915: find guilty batch buffer on ring resets

2013-06-12 Thread Mika Kuoppala
ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 97 +++ 1 file changed, 97 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index dc32fae..9b20fbb

[Intel-gfx] [PATCH 6/7] drm/i915: find guilty batch buffer on ring resets

2013-06-12 Thread Mika Kuoppala
ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gem.c | 97 +++ 1 file changed, 97 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index dc32fae..9b20fbb

Re: [Intel-gfx] [PATCH] drm/i915: stop killing pfit on i9xx

2013-06-13 Thread Mika Kuoppala
. For fastboot we need a bit of work here to correctly kill unsupported configs (if e.g. the pfit is used on anything else than the built-in panel). But since that's not yet supported we don't need to worry. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Reviewed-by: Mika Kuoppala mika.kuopp

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix retrieval of hangcheck stats

2013-06-18 Thread Mika Kuoppala
-wilson.co.uk Patches 1-3: Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Trim the i915_error_printf by the trailing '\0'

2013-06-24 Thread Mika Kuoppala
: 1000 Regression from commit edc3d8848dc9fe2a470316363dab8ef211d77e01 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Thu May 23 13:55:35 2013 +0300 drm/i915: avoid big kmallocs on reading error state Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Mika

[Intel-gfx] [PATCH 2/3] drm/i915: no hangcheck when reset is in progress

2013-06-25 Thread Mika Kuoppala
-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 3a25a6c..e709a47 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/3] drm/i915: introduce i915_queue_hangcheck

2013-06-25 Thread Mika Kuoppala
To run hangcheck in near future. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c |6 ++ drivers/gpu/drm/i915/i915_irq.c | 21 - 3 files changed, 15 insertions(+), 13 deletions

[Intel-gfx] [PATCH 3/3] drm/i915: Allow contexts to be specified for unsupported rings

2013-06-25 Thread Mika Kuoppala
a no-op for unsupported rings, we just suffered from a little too overzealous parameter checking on entry - now we just check that the context is valid. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_gem_execbuffer.c

[Intel-gfx] [PATCH 1/3] drm/i915: Fix retrieval of hangcheck stats

2013-06-25 Thread Mika Kuoppala
-wilson.co.uk Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i915/i915_gem_context.c | 23 --- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/3] tests: rename debugfs base path to be more specific

2013-06-27 Thread Mika Kuoppala
In preparation to have sysfs entries used in scripts rename to more specific name. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tests/ZZ_hangman |2 +- tests/debugfs_emon_crash |2 +- tests/debugfs_reader |2 +- tests/debugfs_wedged |4 ++-- tests

[Intel-gfx] [PATCH 3/3] tests/ZZ_hangman: Test both error_state interfaces

2013-06-27 Thread Mika Kuoppala
Test both debugfs and sysfs error_state interfaces. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tests/ZZ_hangman | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/tests/ZZ_hangman b/tests/ZZ_hangman index 08c5514..303dbc7

[Intel-gfx] [PATCH 2/3] tests: add i915_sfs_path

2013-06-27 Thread Mika Kuoppala
To access 'error_state' through sysfs. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tests/drm_lib.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/drm_lib.sh b/tests/drm_lib.sh index 7eaf34e..72da4ad 100755 --- a/tests/drm_lib.sh +++ b/tests/drm_lib.sh

[Intel-gfx] [PATCH 3/3] tests/ZZ_hangman: Test both error_state interfaces

2013-06-28 Thread Mika Kuoppala
Test both debugfs and sysfs error_state interfaces. v2: sysfs error_state not mandatory Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tests/ZZ_hangman | 52 ++-- 1 file changed, 38 insertions(+), 14 deletions(-) diff --git a/tests

[Intel-gfx] [PATCH 2/7] drm/i915: Replace open-coding of DEFAULT_CONTEXT_ID

2013-07-03 Thread Mika Kuoppala
From: Chris Wilson ch...@chris-wilson.co.uk The intent of the check is made more clear if we use the proper name for 0 here. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com Reviewed-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm

[Intel-gfx] [PATCH 4/7] drm/i915: no hangcheck when reset is in progress

2013-07-03 Thread Mika Kuoppala
From: Mika Kuoppala mika.kuopp...@linux.intel.com The timer for hangchecking can run again before the previous reset it has triggered has been handled. This can corrupt the hangcheck state as reset handling will access and write to the hangcheck data. To prevent this, avoid running the hangcheck

[Intel-gfx] [PATCH 6/7] drm/i915: add i915_reset_count

2013-07-03 Thread Mika Kuoppala
Use reset_counter to track how many actual resets have been done. Reset in progress is enough to increment the counter. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |9 +++-- drivers/gpu/drm/i915/i915_irq.c |2 +- 2 files changed, 8

[Intel-gfx] [PATCH 3/7] drm/i915: introduce i915_queue_hangcheck

2013-07-03 Thread Mika Kuoppala
From: Mika Kuoppala mika.kuopp...@linux.intel.com To run hangcheck in near future. Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com Reviewed-by: Ben Widawsky b...@bwidawsk.net --- drivers/gpu/drm/i915/i915_drv.h |1 + drivers/gpu/drm/i915/i915_gem.c |6 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH 7/7] drm/i915: add i915_get_reset_stats_ioctl

2013-07-03 Thread Mika Kuoppala
-off-by: Mika Kuoppala mika.kuopp...@intel.com Cc: Ian Romanick i...@freedesktop.org Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_dma.c |1 + drivers/gpu/drm/i915/i915_drv.c | 34 ++ drivers

[Intel-gfx] [PATCH 0/7] Hangcheck and arb robustness

2013-07-03 Thread Mika Kuoppala
Hi, Assortment of hangcheck related stuff and reset stats ioctl on top. Ben noted that his ppgtt series provides 1/7 but I included it here cause 7/7 depends on it. -Mika Chris Wilson (2): drm/i915: Fix retrieval of hangcheck stats drm/i915: Replace open-coding of DEFAULT_CONTEXT_ID Mika

[Intel-gfx] [PATCH 1/7] drm/i915: Fix retrieval of hangcheck stats

2013-07-03 Thread Mika Kuoppala
-wilson.co.uk Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i915/i915_gem_context.c | 23 --- 2 files changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm

[Intel-gfx] [PATCH] tools/inter_error_decode: decode for ctl and acthd

2013-07-12 Thread Mika Kuoppala
Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- tools/intel_error_decode.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/tools/intel_error_decode.c b/tools/intel_error_decode.c index 434c13a..b3d7efb 100644 --- a/tools

Re: [Intel-gfx] [benjamin.widaw...@intel.com: intel_gpu_top broken for HSW. Ideas needed]

2013-07-15 Thread Mika Kuoppala
Ben Widawsky benjamin.widaw...@intel.com writes: FWD'd from our internal list now that we have more insight. - Forwarded message from Ben Widawsky benjamin.widaw...@intel.com - Date: Thu, 11 Jul 2013 10:32:03 -0700 From: Ben Widawsky benjamin.widaw...@intel.com To:

[Intel-gfx] [PATCH] drm/i915: make i915_get_extra_instdone() static

2013-07-18 Thread Mika Kuoppala
commit 84734a049d0ef2f6f5fb0a1fe060cd51480dd855 Author: Mika Kuoppala mika.kuopp...@linux.intel.com Date: Fri Jul 12 16:50:57 2013 +0300 drm/i915: move error state to own compilation unit had to export i915_get_extra_instdone() as it was used also in i915_irq.c. Daniel Vetter noticed

Re: [Intel-gfx] [PATCH 01/10] drm/i915: kill ivybridge_irq_preinstall

2013-07-19 Thread Mika Kuoppala
hotplug from PCH */ This comment will be lost. I couldn't figure out if it is is relevant anymore or not. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com - I915_WRITE(DEIMR, 0x); - I915_WRITE(DEIER, 0x0); - POSTING_READ(DEIER); - - gen5_gt_irq_preinstall(dev

Re: [Intel-gfx] [PATCH 02/10] drm/i915: extract ilk_display_irq_handler

2013-07-19 Thread Mika Kuoppala
the pattern. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 104 +--- 1 file changed, 56 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index f397f9a

Re: [Intel-gfx] [PATCH 03/10] drm/i915: extract ivb_display_irq_handler

2013-07-19 Thread Mika Kuoppala
Paulo Zanoni przan...@gmail.com writes: From: Paulo Zanoni paulo.r.zan...@intel.com Just like we did with ilk_display_irq_handler. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 63

Re: [Intel-gfx] [PATCH 4/9] drm/i915: don't read or write GEN6_PMIIR on Gen 5

2013-07-19 Thread Mika Kuoppala
Paulo Zanoni przan...@gmail.com writes: From: Paulo Zanoni paulo.r.zan...@intel.com The register doesn't exist on Gen 5. v2: Simplify checks since pm_iir is always 0 on Gen 5 (Chris) Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com

Re: [Intel-gfx] [PATCH 5/9] drm/i915: reorganize ironlake_irq_handler

2013-07-19 Thread Mika Kuoppala
...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 46 - 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index c674dc3

Re: [Intel-gfx] [PATCH 06/10] drm/i915: POSTING_READ(DEIER) on ivybridge_irq_handler

2013-07-19 Thread Mika Kuoppala
...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 7bc36ae..bdaab93 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b

Re: [Intel-gfx] [PATCH 7/9] drm/i915: add ILK/SNB support to ivybridge_irq_handler

2013-07-19 Thread Mika Kuoppala
to a tighter scope (Chris) - Change some Gen checks for readability Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 115 +++- 1 file changed, 32 insertions(+), 83

Re: [Intel-gfx] [PATCH 8/9] drm/i915: kill Ivybridge vblank irq vfuncs

2013-07-19 Thread Mika Kuoppala
. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 41 - drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 11 insertions(+), 33 deletions

Re: [Intel-gfx] [PATCH 9/9] drm/i915: kill ivybridge_irq_postinstall

2013-07-19 Thread Mika Kuoppala
are now unified. v2: Add ( and ) to make at least one vim user much happier (Chris) Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_irq.c | 69 - 1 file changed, 20

Re: [Intel-gfx] [PATCH] [v2] drm/i915/vma: Correct use after free in eviction

2013-08-19 Thread Mika Kuoppala
(Ville) Reported-by: Mika Kuoppala mika.kuopp...@intel.com Cc: Ville Syrjälä ville.syrj...@linux.intel.com Cc: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Ben Widawsky b...@bwidawsk.net Since the commit message lacks that crucial piece of information: How was this discovered

[Intel-gfx] [PATCH] drm/i915: Don't mask EI UP interrupt on IVB|SNB

2013-08-22 Thread Mika Kuoppala
Azad vinit.a...@intel.com Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index cbab95dc..e6a124e 100644

[Intel-gfx] [PATCH] drm/i915: sanitize forcewake registers on reset

2013-08-23 Thread Mika Kuoppala
, right after the chip has been reset. Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_uncore.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b

[Intel-gfx] [PATCH 1/2] drm/i915: increase GPU wedging timeout

2013-08-23 Thread Mika Kuoppala
time. This commit increases wedging period from 5 seconds to 8 seconds. v2: better name for macro (Chris Wilson) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c |3 ++- drivers/gpu/drm/i915/i915_drv.h |3 +++ 2 files changed, 5 insertions(+), 1

[Intel-gfx] [PATCH 2/2] drm/i915: ban badly behaving contexts

2013-08-23 Thread Mika Kuoppala
into gpu_error (Chris Wilson) v4: - rebase on top of fixed hang stats api - add define for ban period - rename commit and improve commit msg Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_drv.c|6 +++-- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH 1/2] drm/i915: increase GPU wedging timeout

2013-08-28 Thread Mika Kuoppala
Mika Kuoppala mika.kuopp...@linux.intel.com writes: Currently our wedge timeout is 5 seconds. Hangcheck needs atleast three runs to declare a hang with 1500ms timer tick period. To make sure that gpu can be wedged in the first place, define wedge timeout as multiple of hangcheck timer

Re: [Intel-gfx] [PATCH] drm/i915: fix lvds/dp panel fitter setting

2013-08-28 Thread Mika Kuoppala
of 21d8a4756af5fdf4a42e79a77cf3b6f52678d443. Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_panel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a43c33b..913cb9d 100644 --- a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH 59/71] drm/i915/chv: Fix CHV PLL state tracking

2014-04-25 Thread Mika Kuoppala
...@linux.intel.com Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_display.c | 41 +++- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 64/71] drm/i915/chv: Don't use PCS group access reads

2014-04-25 Thread Mika Kuoppala
ville.syrj...@linux.intel.com writes: From: Ville Syrjälä ville.syrj...@linux.intel.com Minor formatting issue in this one, newline before ';' And next one in series fixes it. Patches 60 - 64 Reviewed-by: Mika Kuoppala mika.kuopp...@intel.com All PCS groups access reads return 0x, so

Re: [Intel-gfx] [PATCH 66/71] drm/i915/chv: Use RMW to toggle swing calc init

2014-04-28 Thread Mika Kuoppala
-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_dp.c | 17 ++--- drivers/gpu/drm/i915/intel_hdmi.c | 18 ++ 3 files changed, 35 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/1] tests/gem_reset_stats: EPERM check not needed

2014-05-02 Thread Mika Kuoppala
Without root we used to get EPERM if we tried to aquire default context statistics. Now we have per fd statistics so only thing which is hidden from us without root access, is the global reset count. Drop EPERM and check that global reset count is always zero for nonroot. Signed-off-by: Mika

[Intel-gfx] [PATCH v2 0/2] render state initialization (bdw rc6)

2014-05-06 Thread Mika Kuoppala
://cgit.freedesktop.org/~miku/drm-intel/log/?h=render_state Thank you to all who provided feedback. -Mika Mika Kuoppala (2): drm/i915: add render state initialization drm/i915: add null render states for gen6, gen7 and gen8 drivers/gpu/drm/i915/Makefile |6 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH v2 2/2] drm/i915: add null render states for gen6, gen7 and gen8

2014-05-06 Thread Mika Kuoppala
These are generated with intel-gpu-tools/tools/null_state_gen v2: Don't use header file for states (Daniel Vetter) Tested-by: Kristen Carlson Accardi kris...@linux.intel.com (v1) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com --- drivers/gpu/drm/i915/intel_renderstate_gen6.c | 281

[Intel-gfx] [PATCH v2 1/2] drm/i915: add render state initialization

2014-05-06 Thread Mika Kuoppala
) - use .c files for state (Daniel Vetter) - no need to flush as i915_add_request does it - remove parameter for batch alloc size - don't wait for the init (Ben Widawsky) Tested-by: Kristen Carlson Accardi kris...@linux.intel.com (v1) Signed-off-by: Mika Kuoppala mika.kuopp...@intel.com

  1   2   3   4   5   6   7   8   9   10   >