[Intel-gfx] [PATCH v4] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-26 Thread Stanislav Lisovskiy
ate at intel_plane_pixel_rate callsites v4: - Renamed skl_plane_ratio function back(Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/display/intel_atomic_plane.c | 28 ++- .../gpu/drm/i915/display/intel_atomic_plane.h | 3 ++ drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v18 5/8] drm/i915: Refactor intel_can_enable_sagv

2020-02-27 Thread Stanislav Lisovskiy
ula) - Taken ddb_state_changed and bw_state_changed into use. v14: - total_affected_planes is no longer needed to check for ddb changes, just as active_pipe_changes. v15: - Fixed stupid mistake with uninitialized crtc in skl_compute_sagv_mask. Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH v6] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-27 Thread Stanislav Lisovskiy
v6: - Removed useless warn in intel_plane_pixel_rate(Ville Syrjälä) - Fixed alignment in intel_plane_data_rate(Ville Syrjälä) - Changed pixel_rate type to be unsigned int in skl_plane_min_cdclk(Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/disp

[Intel-gfx] [PATCH v5] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-27 Thread Stanislav Lisovskiy
ned-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/display/intel_atomic_plane.c | 26 ++- .../gpu/drm/i915/display/intel_atomic_plane.h | 3 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 15 ++- 3 files changed, 30 insertions(+), 14 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH v18 7/8] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-02-24 Thread Stanislav Lisovskiy
comment for near atomic global state locking in bw code. v16: - Fixed intel_atomic_bw_* functions to be intel_bw_* as discussed with Jani Nikula. - Take bw_state_changed flag into use. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/

[Intel-gfx] [PATCH v18 8/8] drm/i915: Enable SAGV support for Gen12

2020-02-24 Thread Stanislav Lisovskiy
Flip the switch and enable SAGV support for Gen12 also. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 853fc9e9084d..fe2873af7f4b 100644

[Intel-gfx] [PATCH v18 5/8] drm/i915: Refactor intel_can_enable_sagv

2020-02-24 Thread Stanislav Lisovskiy
ula) - Taken ddb_state_changed and bw_state_changed into use. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.h | 18 + drivers/gpu/drm/i915/display/intel_display.c | 27 +- .../drm/i915/display/intel_display_type

[Intel-gfx] [PATCH v18 6/8] drm/i915: Added required new PCode commands

2020-02-24 Thread Stanislav Lisovskiy
We need a new PCode request commands and reply codes to be added as a prepartion patch for QGV points restricting for new SAGV support. v2: - Extracted those changes into separate patch (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 4

[Intel-gfx] [PATCH v18 4/8] drm/i915: Introduce more *_state_changed indicators

2020-02-24 Thread Stanislav Lisovskiy
hanged. active_pipe_changes just indicate whether there was some pipe added or removed. Then we evaluate if wm/ddb had been changed. Same for sagv/bw state. ddb changes may or may not affect if out bandwidth constraints have been changed. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_at

[Intel-gfx] [PATCH v18 1/8] drm/i915: Start passing latency as parameter

2020-02-24 Thread Stanislav Lisovskiy
We need to start passing memory latency as a parameter when calculating plane wm levels, as latency can get changed in different circumstances(for example with or without SAGV). So we need to be more flexible on that matter. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v18 2/8] drm/i915: Introduce skl_plane_wm_level accessor.

2020-02-24 Thread Stanislav Lisovskiy
; function. This will be changed in next coming patches from this series. v2: - plane_id -> plane->id(Ville Syrjälä) - Moved wm_level var to have more local scope (Ville Syrjälä) - Renamed yuv to color_plane(Ville Syrjälä) in skl_plane_wm_level Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v18 0/8] Refactor Gen11+ SAGV support

2020-02-24 Thread Stanislav Lisovskiy
intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+. v17: Had to rebase the whole series. v18: Resent whole series as new patch was introduced. Stanislav Lisovskiy (8): drm/i915: Start passing latency as parameter drm

[Intel-gfx] [PATCH v18 3/8] drm/i915: Add intel_bw_get_*_state helpers

2020-02-24 Thread Stanislav Lisovskiy
Add correspondent helpers to be able to get old/new bandwidth global state object. v2: - Fixed typo in function call v3: - Changed new functions naming to use convention proposed by Jani Nikula, i.e intel_bw_* in intel_bw.c file. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm

[Intel-gfx] [PATCH v18 7/8] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-02-25 Thread Stanislav Lisovskiy
comment for near atomic global state locking in bw code. v16: - Fixed intel_atomic_bw_* functions to be intel_bw_* as discussed with Jani Nikula. - Take bw_state_changed flag into use. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/

[Intel-gfx] [PATCH v18 4/8] drm/i915: Introduce more *_state_changed indicators

2020-02-25 Thread Stanislav Lisovskiy
ed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_atomic.c | 2 ++ drivers/gpu/drm/i915/display/intel_bw.c | 28 ++-- drivers/gpu/drm/i915/display/intel_display.c | 16 ++ .../drm/i915/display/intel_display_types.h| 32 --- drivers/g

[Intel-gfx] [PATCH v18 5/8] drm/i915: Refactor intel_can_enable_sagv

2020-02-25 Thread Stanislav Lisovskiy
ula) - Taken ddb_state_changed and bw_state_changed into use. v14: - total_affected_planes is no longer needed to check for ddb changes, just as active_pipe_changes. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_b

[Intel-gfx] [PATCH v16 1/7] drm/i915: Remove skl_ddl_allocation struct

2020-01-24 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v16 7/7] drm/i915: Update dbuf slices only with full modeset

2020-01-24 Thread Stanislav Lisovskiy
During full modeset, global state(i.e dev_priv) is protected by locking the crtcs in state, otherwise global state is not serialized. Also if it is not a full modeset, we anyway don't need to change DBuf slice configuration as Pipe configuration doesn't change. Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH v16 5/7] drm/i915: Correctly map DBUF slices to pipes

2020-01-24 Thread Stanislav Lisovskiy
s, until "pipe ratio" thing is finally sorted out(Ville Syrjälä) - Removed unused parameter crtc_state for now(Ville Syrjälä) from icl/tgl_compute_dbuf_slices function Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 385 +++

[Intel-gfx] [PATCH v16 0/7] Enable second DBuf slice for ICL and TGL

2020-01-24 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (7): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v16 4/7] drm/i915: Manipulate DBuf slices properly

2020-01-24 Thread Stanislav Lisovskiy
m_supported_dbuf_slices instead of intel_dbuf_max_slices function as it is trivial(Matthew Roper) v8: - Fixed icl_dbuf_disable to disable all dbufs still(Ville Syrjälä) Reviewed-by: Matt Roper Reviewed-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH v16 6/7] drm/i915: Protect intel_dbuf_slices_update with mutex

2020-01-24 Thread Stanislav Lisovskiy
, as gen9_assert_dbuf_enabled might preempt this when registers were already updated, while dev_priv was not. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display_power.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b

[Intel-gfx] [PATCH v16 2/7] drm/i915: Move dbuf slice update to proper place

2020-01-24 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index ae0

[Intel-gfx] [PATCH v16 3/7] drm/i915: Introduce parameterized DBUF_CTL

2020-01-24 Thread Stanislav Lisovskiy
le Syrjälä) Reviewed-by: Ville Syrjälä Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 30 +++ .../drm/i915/display/intel_display_power.h| 5 drivers/gpu/drm/i915/i915_reg.h | 7 +++-- drivers/gp

[Intel-gfx] [PATCH v1] drm/i915: Fix inconsistance between pfit.enable and scaler freeing

2020-01-24 Thread Stanislav Lisovskiy
not updating the whole state consistently. This fix is to not free the scaler if we have pfit.enabled flag set, so that the state is now consistent and the warnings are gone. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- 1 file changed, 1 insertion

[Intel-gfx] [PATCH v2] drm/i915: Fix inconsistance between pfit.enable and scaler freeing

2020-01-24 Thread Stanislav Lisovskiy
not updating the whole state consistently. This fix is to not free the scaler if we have pfit.enabled flag set, so that the state is now consistent and the warnings are gone. Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/577 Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH v14 6/7] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-02-03 Thread Stanislav Lisovskiy
patch, this all will be moved to bw state as global state, once new global state patch series from Ville lands v14: - Now using global state to serialize access to qgv points Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel

[Intel-gfx] [PATCH v14 2/7] drm/i915: Introduce skl_plane_wm_level accessor.

2020-02-03 Thread Stanislav Lisovskiy
; function. This will be changed in next coming patches from this series. v2: - plane_id -> plane->id(Ville Syrjälä) - Moved wm_level var to have more local scope (Ville Syrjälä) - Renamed yuv to color_plane(Ville Syrjälä) in skl_plane_wm_level Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v14 1/7] drm/i915: Start passing latency as parameter

2020-02-03 Thread Stanislav Lisovskiy
We need to start passing memory latency as a parameter when calculating plane wm levels, as latency can get changed in different circumstances(for example with or without SAGV). So we need to be more flexible on that matter. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v14 0/7] Refactor Gen11+ SAGV support

2020-02-03 Thread Stanislav Lisovskiy
intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+. Stanislav Lisovskiy (7): drm/i915: Start passing latency as parameter drm/i915: Introduce skl_plane_wm_level accessor. drm/i915: Init obj state

[Intel-gfx] [PATCH v14 0/7] Refactor Gen11+ SAGV support

2020-02-03 Thread Stanislav Lisovskiy
intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+. Stanislav Lisovskiy (7): drm/i915: Start passing latency as parameter drm/i915: Introduce skl_plane_wm_level accessor. drm/i915: Init obj state

[Intel-gfx] [PATCH v14 7/7] drm/i915: Enable SAGV support for Gen12

2020-02-03 Thread Stanislav Lisovskiy
Flip the switch and enable SAGV support for Gen12 also. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 0ee4ac6976f8..d89d99c24e71 100644

[Intel-gfx] [PATCH v14 3/7] drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state

2020-02-03 Thread Stanislav Lisovskiy
in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c | 28 - drivers/gpu/drm/i915/display/intel_bw.h | 9 ++ .../gpu/drm/i915/display/intel_global_state.c | 30

[Intel-gfx] [PATCH v14 5/7] drm/i915: Added required new PCode commands

2020-02-03 Thread Stanislav Lisovskiy
We need a new PCode request commands and reply codes to be added as a prepartion patch for QGV points restricting for new SAGV support. v2: - Extracted those changes into separate patch (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 4

[Intel-gfx] [PATCH v14 4/7] drm/i915: Refactor intel_can_enable_sagv

2020-02-03 Thread Stanislav Lisovskiy
v10: - Starting to use new global state for storing pipe_sagv_mask Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.h | 6 + drivers/gpu/drm/i915/display/intel_display.c | 22 +- .../drm/i915/display/intel_display_types.h|

[Intel-gfx] [PATCH v14 3/7] drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state

2020-02-03 Thread Stanislav Lisovskiy
in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state v2: - Fixed typo in function call Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c | 28 - drivers/gpu/drm/i915/display/intel_bw.h | 9 ++ .../gpu/drm/i915

[Intel-gfx] [PATCH v17 4/6] drm/i915: Introduce parameterized DBUF_CTL

2020-02-02 Thread Stanislav Lisovskiy
le Syrjälä) Reviewed-by: Ville Syrjälä Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 40 ++- .../drm/i915/display/intel_display_power.h| 5 +++ drivers/gpu/drm/i915/gvt/handlers.c | 2 +- drivers/gp

[Intel-gfx] [PATCH v17 0/6] Enable second DBuf slice for ICL and TGL

2020-02-02 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (6): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v17 4/6] drm/i915: Introduce parameterized DBUF_CTL

2020-02-02 Thread Stanislav Lisovskiy
le Syrjälä) Reviewed-by: Ville Syrjälä Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 40 ++- .../drm/i915/display/intel_display_power.h| 5 +++ drivers/gpu/drm/i915/gvt/handlers.c | 2 +- drivers/gp

[Intel-gfx] [PATCH v17 5/6] drm/i915: Manipulate DBuf slices properly

2020-02-02 Thread Stanislav Lisovskiy
rs were already updated, while dev_priv was not. Reviewed-by: Matt Roper Reviewed-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++-- .../drm/i915/display/intel_display_power.c| 102 +++--- .../drm/i915/displa

[Intel-gfx] [PATCH v17 0/6] Enable second DBuf slice for ICL and TGL

2020-02-02 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (6): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v17 6/6] drm/i915: Correctly map DBUF slices to pipes

2020-02-02 Thread Stanislav Lisovskiy
s, until "pipe ratio" thing is finally sorted out(Ville Syrjälä) - Removed unused parameter crtc_state for now(Ville Syrjälä) from icl/tgl_compute_dbuf_slices function Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 385 +++

[Intel-gfx] [PATCH v17 1/6] drm/i915: Remove skl_ddl_allocation struct

2020-02-02 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v17 2/6] drm/i915: Move dbuf slice update to proper place

2020-02-02 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index ead

[Intel-gfx] [PATCH v17 3/6] drm/i915: Update dbuf slices only with full modeset

2020-02-02 Thread Stanislav Lisovskiy
During full modeset, global state(i.e dev_priv) is protected by locking the crtcs in state, otherwise global state is not serialized. Also if it is not a full modeset, we anyway don't need to change DBuf slice configuration as Pipe configuration doesn't change. Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH v17 3/6] drm/i915: Update dbuf slices only with full modeset

2020-02-02 Thread Stanislav Lisovskiy
-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index d553de2c3f5e..27622ef069cf 100644 --- a/drivers

[Intel-gfx] [PATCH v17 2/6] drm/i915: Move dbuf slice update to proper place

2020-02-02 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index ead

[Intel-gfx] [PATCH v17 1/6] drm/i915: Remove skl_ddl_allocation struct

2020-02-02 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v17 5/6] drm/i915: Manipulate DBuf slices properly

2020-02-02 Thread Stanislav Lisovskiy
rs were already updated, while dev_priv was not. Reviewed-by: Matt Roper Reviewed-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++-- .../drm/i915/display/intel_display_power.c| 102 +++--- .../drm/i915/displa

[Intel-gfx] [PATCH v17 6/6] drm/i915: Correctly map DBUF slices to pipes

2020-02-02 Thread Stanislav Lisovskiy
s, until "pipe ratio" thing is finally sorted out(Ville Syrjälä) - Removed unused parameter crtc_state for now(Ville Syrjälä) from icl/tgl_compute_dbuf_slices function Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- drivers

[Intel-gfx] [PATCH v3] drm/i915: Fix inconsistance between pfit.enable and scaler freeing

2020-01-24 Thread Stanislav Lisovskiy
/intel/issues/577 Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 5768cfcf71c4..cd242d91a924

[Intel-gfx] [PATCH v16 4/7] drm/i915: Refactor intel_can_enable_sagv

2020-02-19 Thread Stanislav Lisovskiy
ime, if bw_state hasn't changed. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.h | 18 + drivers/gpu/drm/i915/display/intel_display.c | 22 +- .../drm/i915/display/intel_display_types.h| 2 + .../gpu/drm/i915/disp

[Intel-gfx] [PATCH v1] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-20 Thread Stanislav Lisovskiy
ate as a basis from there as well. Signed-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/display/intel_atomic_plane.c | 16 ++- drivers/gpu/drm/i915/display/intel_sprite.c | 46 +++ 2 files changed, 41 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v2] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-20 Thread Stanislav Lisovskiy
ate as a basis from there as well. v2: - Don't use 64 division if not needed(Ville Syrjälä) - Now use intel_plane_pixel_rate as a basis for calculations both at intel_plane_data_rate and skl_plane_min_cdclk(Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/disp

[Intel-gfx] [PATCH v1] drm/i915: Call intel_edp_init_connector only for eDP.

2020-02-11 Thread Stanislav Lisovskiy
. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index f4dede6253f8..9bd36197a43d 100644

[Intel-gfx] [PATCH v3] drm/i915: Use intel_plane_data_rate for min_cdclk calculation

2020-02-21 Thread Stanislav Lisovskiy
ate at intel_plane_pixel_rate callsites Signed-off-by: Stanislav Lisovskiy --- .../gpu/drm/i915/display/intel_atomic_plane.c | 22 +- .../gpu/drm/i915/display/intel_atomic_plane.h | 3 +++ drivers/gpu/drm/i915/display/intel_sprite.c | 23 +-- 3 files chan

[Intel-gfx] [PATCH v17 4/7] drm/i915: Refactor intel_can_enable_sagv

2020-02-21 Thread Stanislav Lisovskiy
ion. Fix that by just analyzing the current global bw_state object - because we simply have no other objects related to that. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.h | 18 + drivers/gpu/drm/i915/disp

[Intel-gfx] [PATCH v16 6/7] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-02-18 Thread Stanislav Lisovskiy
patch, this all will be moved to bw state as global state, once new global state patch series from Ville lands v14: - Now using global state to serialize access to qgv points - Added global state locking back, otherwise we seem to read bw state in a wrong way. Signed-off-by: Sta

[Intel-gfx] [PATCH v16 5/7] drm/i915: Added required new PCode commands

2020-02-18 Thread Stanislav Lisovskiy
We need a new PCode request commands and reply codes to be added as a prepartion patch for QGV points restricting for new SAGV support. v2: - Extracted those changes into separate patch (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 4

[Intel-gfx] [PATCH v16 3/7] drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state

2020-02-18 Thread Stanislav Lisovskiy
in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state v2: - Fixed typo in function call Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c | 28 - drivers/gpu/drm/i915/display/intel_bw.h | 9 2 files changed, 36

[Intel-gfx] [PATCH v16 2/7] drm/i915: Introduce skl_plane_wm_level accessor.

2020-02-18 Thread Stanislav Lisovskiy
; function. This will be changed in next coming patches from this series. v2: - plane_id -> plane->id(Ville Syrjälä) - Moved wm_level var to have more local scope (Ville Syrjälä) - Renamed yuv to color_plane(Ville Syrjälä) in skl_plane_wm_level Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v16 7/7] drm/i915: Enable SAGV support for Gen12

2020-02-18 Thread Stanislav Lisovskiy
Flip the switch and enable SAGV support for Gen12 also. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index e8f10a413808..31c3dc19fbdd 100644

[Intel-gfx] [PATCH v16 1/7] drm/i915: Start passing latency as parameter

2020-02-18 Thread Stanislav Lisovskiy
We need to start passing memory latency as a parameter when calculating plane wm levels, as latency can get changed in different circumstances(for example with or without SAGV). So we need to be more flexible on that matter. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v16 0/7] Refactor Gen11+ SAGV support

2020-02-18 Thread Stanislav Lisovskiy
intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+. Stanislav Lisovskiy (7): drm/i915: Start passing latency as parameter drm/i915: Introduce skl_plane_wm_level accessor. drm/i915: Init obj state

[Intel-gfx] [PATCH v16 4/7] drm/i915: Refactor intel_can_enable_sagv

2020-02-18 Thread Stanislav Lisovskiy
v10: - Starting to use new global state for storing pipe_sagv_mask v11: - Fixed rebase conflict with recent drm-tip - Check if we really need to recalculate SAGV mask, otherwise bail out without making any changes. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Aus

[Intel-gfx] [PATCH v17 5/7] drm/i915: Added required new PCode commands

2020-02-20 Thread Stanislav Lisovskiy
We need a new PCode request commands and reply codes to be added as a prepartion patch for QGV points restricting for new SAGV support. v2: - Extracted those changes into separate patch (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/i915_reg.h | 4

[Intel-gfx] [PATCH v17 4/7] drm/i915: Refactor intel_can_enable_sagv

2020-02-20 Thread Stanislav Lisovskiy
ime, if bw_state hasn't changed. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.h | 18 + drivers/gpu/drm/i915/display/intel_display.c | 22 +- .../drm/i915/display/intel_display_types.h| 2 + .../gpu/drm/i915/disp

[Intel-gfx] [PATCH v17 2/7] drm/i915: Introduce skl_plane_wm_level accessor.

2020-02-20 Thread Stanislav Lisovskiy
; function. This will be changed in next coming patches from this series. v2: - plane_id -> plane->id(Ville Syrjälä) - Moved wm_level var to have more local scope (Ville Syrjälä) - Renamed yuv to color_plane(Ville Syrjälä) in skl_plane_wm_level Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v17 3/7] drm/i915: Init obj state in intel_atomic_get_old/new_global_obj_state

2020-02-20 Thread Stanislav Lisovskiy
in intel_atomic_get_old_global_obj_state and intel_atomic_get_new_global_obj_state v2: - Fixed typo in function call Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_bw.c | 28 - drivers/gpu/drm/i915/display/intel_bw.h | 9 2 files changed, 36

[Intel-gfx] [PATCH v17 6/7] drm/i915: Restrict qgv points which don't have enough bandwidth.

2020-02-20 Thread Stanislav Lisovskiy
comment for near atomic global state locking in bw code. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/display/intel_bw.c | 177 ++- drivers/gpu/drm/i915/display/intel_bw.h | 9 + drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH v17 7/7] drm/i915: Enable SAGV support for Gen12

2020-02-20 Thread Stanislav Lisovskiy
Flip the switch and enable SAGV support for Gen12 also. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 2aafd2b07e4a..6d4240f260a9 100644

[Intel-gfx] [PATCH v17 0/7] Refactor Gen11+ SAGV support

2020-02-20 Thread Stanislav Lisovskiy
intel_can_enable_sagv function, as current seems to be outdated and using skl specific workarounds, also not following BSpec for Gen11+. v17: Had to rebase the whole series. Stanislav Lisovskiy (7): drm/i915: Start passing latency as parameter drm/i915: Introduce skl_plane_wm_level accessor. drm

[Intel-gfx] [PATCH v17 1/7] drm/i915: Start passing latency as parameter

2020-02-20 Thread Stanislav Lisovskiy
We need to start passing memory latency as a parameter when calculating plane wm levels, as latency can get changed in different circumstances(for example with or without SAGV). So we need to be more flexible on that matter. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v2] drm/i915: Bump up CDCLK to eliminate underruns on TGL

2020-01-09 Thread Stanislav Lisovskiy
for also plane requirements, however in some cases the lowest possible CDCLK doesn't work and causing the underruns. Explicitly stating here that this seems to be currently rather a Hack, than final solution. v2: Use clamp operation instead of min(Matt Roper) Signed-off-by: Stanislav Lisovskiy

[Intel-gfx] [PATCH v11 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-15 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index eaf

[Intel-gfx] [PATCH v11 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-15 Thread Stanislav Lisovskiy
typos. - Renamed i915_find_pipe_conf to *_compute_dbuf_slices (Ville Syrjälä) - Changed platforms ordering in skl_compute_dbuf_slices to be from newest to oldest(Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 384 +

[Intel-gfx] [PATCH v11 4/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-15 Thread Stanislav Lisovskiy
than add. Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 19 +++ drivers/gpu/drm/i915/i915_reg.h | 12 +--- drivers/gpu/drm/i915/intel_pm.c | 19 ++- 3 files changed, 14 insertions(+), 36

[Intel-gfx] [PATCH v11 0/5] Enable second DBuf slice for ICL and TGL

2020-01-15 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v11 3/5] drm/i915: Manipulate DBuf slices properly

2020-01-15 Thread Stanislav Lisovskiy
Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++--- .../drm/i915/display/intel_display_power.c| 95 +-- .../drm/i915/display/intel_display_power.h| 6 ++ .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu

[Intel-gfx] [PATCH v11 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-15 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v12 3/5] drm/i915: Manipulate DBuf slices properly

2020-01-15 Thread Stanislav Lisovskiy
Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++--- .../drm/i915/display/intel_display_power.c| 95 +-- .../drm/i915/display/intel_display_power.h| 6 ++ .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu

[Intel-gfx] [PATCH v12 4/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-15 Thread Stanislav Lisovskiy
than add. Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 19 +++ drivers/gpu/drm/i915/i915_reg.h | 12 +--- drivers/gpu/drm/i915/intel_pm.c | 19 ++- 3 files changed, 14 insertions(+), 36

[Intel-gfx] [PATCH v12 0/5] Enable second DBuf slice for ICL and TGL

2020-01-15 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v12 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-15 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index eee

[Intel-gfx] [PATCH v12 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-15 Thread Stanislav Lisovskiy
red on. (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_pm.c | 395 ++-- drivers/gpu/drm/i915/intel_pm.h | 2 + 2 files changed, 379 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu

[Intel-gfx] [PATCH v12 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-15 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v12 4/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-15 Thread Stanislav Lisovskiy
than add. Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 19 +++ drivers/gpu/drm/i915/i915_reg.h | 12 +--- drivers/gpu/drm/i915/intel_pm.c | 18 ++ 3 files changed, 14 insertions(+), 35

[Intel-gfx] [PATCH v12 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-15 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index eee

[Intel-gfx] [PATCH v12 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-15 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v12 3/5] drm/i915: Manipulate DBuf slices properly

2020-01-15 Thread Stanislav Lisovskiy
Syrjälä) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++--- .../drm/i915/display/intel_display_power.c| 95 +-- .../drm/i915/display/intel_display_power.h| 6 ++ .../drm/i915/display/intel_display_types.h| 2 +- drivers/gpu

[Intel-gfx] [PATCH v12 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-15 Thread Stanislav Lisovskiy
red on. (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 15 +- drivers/gpu/drm/i915/intel_pm.c | 395 +- drivers/gpu/drm/i915/intel_pm.h | 2 + 3 files changed, 390 insertions(+), 22 dele

[Intel-gfx] [PATCH v12 0/5] Enable second DBuf slice for ICL and TGL

2020-01-15 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v12 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-16 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

[Intel-gfx] [PATCH v12 4/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-16 Thread Stanislav Lisovskiy
than add. v2: - Removed unneeded DBUF_CTL_DIST and DBUF_CTL_ADDR macros. Started to use _PICK construct as suggested by Matt Roper. Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 19 +++ drivers/gpu/drm

[Intel-gfx] [PATCH v12 5/5] drm/i915: Correctly map DBUF slices to pipes

2020-01-16 Thread Stanislav Lisovskiy
red on. (Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 9 +- drivers/gpu/drm/i915/intel_pm.c | 395 +- drivers/gpu/drm/i915/intel_pm.h | 2 + 3 files changed, 384 insertions(+), 22 dele

[Intel-gfx] [PATCH v12 0/5] Enable second DBuf slice for ICL and TGL

2020-01-16 Thread Stanislav Lisovskiy
Those patch series, do some initial preparation DBuf manipulating code cleanups, i.e remove redundant structures/code, switch to mask based DBuf manupulation, get into use DBuf assignment according to BSpec rules. Stanislav Lisovskiy (5): drm/i915: Remove skl_ddl_allocation struct drm/i915

[Intel-gfx] [PATCH v12 3/5] drm/i915: Manipulate DBuf slices properly

2020-01-16 Thread Stanislav Lisovskiy
m_supported_dbuf_slices instead of intel_dbuf_max_slices function as it is trivial(Matthew Roper) Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 23 ++--- .../drm/i915/display/intel_display_power.c| 98 --- .../drm/i915/display/intel_

[Intel-gfx] [PATCH v12 2/5] drm/i915: Move dbuf slice update to proper place

2020-01-16 Thread Stanislav Lisovskiy
-by: Ville Syrjälä Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_display.c | 37 +++- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index eee

[Intel-gfx] [PATCH v15 3/5] drm/i915: Introduce parameterized DBUF_CTL

2020-01-20 Thread Stanislav Lisovskiy
le Syrjälä) Reviewed-by: Ville Syrjälä Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy --- .../drm/i915/display/intel_display_power.c| 30 +++ .../drm/i915/display/intel_display_power.h| 5 drivers/gpu/drm/i915/i915_reg.h | 7 +++-- drivers/gp

[Intel-gfx] [PATCH v15 1/5] drm/i915: Remove skl_ddl_allocation struct

2020-01-20 Thread Stanislav Lisovskiy
: Changed "enabled_slices" to be "enabled_dbuf_slices_num" (Matt Roper) v4: - Wrapped the line getting number of dbuf slices(Matt Roper) - Removed indeed redundant skl_ddb_values declaration(Matt Roper) Reviewed-by: Matt Roper Signed-off-by: Stanislav Lisovskiy ---

<    1   2   3   4   5   6   7   8   >