From: Thierry Reding tred...@nvidia.com
A race condition currently exists on Tegra, where it can happen that a
monitor attached via HDMI isn't detected during the initial FB helper
setup, but the hotplug event happens too early to be processed by the
poll helpers because they haven't been
From: Thierry Reding tred...@nvidia.com
To implement hotplug detection in a race-free manner, drivers must call
drm_kms_helper_poll_init() before hotplug events can be triggered. Such
events can be triggered right after any of the encoders or connectors
are initialized. At the same time
into the hdmi -detect function.
Cc: Thierry Reding tred...@nvidia.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v3:
- remove an additional occurrence of i915's enable_hotplug_processing
that was introduced after the original patch
From: Thierry Reding tred...@nvidia.com
There's no need for this to be modifiable. Make it const so that it can
be put into the .rodata section.
Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Thierry Reding tred...@nvidia.com
---
drivers/gpu/drm/armada/armada_fbdev.c | 2
/CEA specfic
- Removed usage of temporary aspect_ratio variable
v3: Thierry's review comments.
- Fixed indentation
v4: Thierry's review comments.
- Return ENOMEM when property creation fails
Signed-off-by: Vandana Kannan vandana.kan...@intel.com
Cc: Thierry Reding
On Wed, Jul 30, 2014 at 05:32:28PM +0900, Michel Dänzer wrote:
On 30.07.2014 17:22, Daniel Vetter wrote:
On Wed, Jul 30, 2014 at 11:59:33AM +0900, Michel Dänzer wrote:
On 30.07.2014 06:32, Daniel Vetter wrote:
+ * due to lack of driver support or because the crtc is off.
+ */
+void
On Tue, Jul 29, 2014 at 11:32:22PM +0200, Daniel Vetter wrote:
[...]
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
[...]
+ ret = wait_event_timeout(dev-vblank[crtc].queue,
+ C, msecs_to_jiffies(100));
100 milliseconds looks like a very
On Wed, Jul 30, 2014 at 05:06:38PM +0200, Daniel Vetter wrote:
On Wed, Jul 30, 2014 at 04:24:06PM +0200, Thierry Reding wrote:
On Tue, Jul 29, 2014 at 11:32:22PM +0200, Daniel Vetter wrote:
[...]
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
[...]
+ ret
On Wed, Jul 30, 2014 at 05:36:21PM +0300, Ville Syrjälä wrote:
On Wed, Jul 30, 2014 at 04:20:25PM +0200, Thierry Reding wrote:
On Wed, Jul 30, 2014 at 05:32:28PM +0900, Michel Dänzer wrote:
On 30.07.2014 17:22, Daniel Vetter wrote:
On Wed, Jul 30, 2014 at 11:59:33AM +0900, Michel Dänzer
On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote:
From: Sonika Jindal sonika.jin...@intel.com
Adding new defines, older one will be removed in the last patch in the series.
This is to rename the defines to have levels instead of values for vswing and
pre-emph levels as
On Wed, Aug 27, 2014 at 08:51:35AM +0100, Damien Lespiau wrote:
On Wed, Aug 27, 2014 at 08:47:54AM +0100, Damien Lespiau wrote:
An alternative would be to provide a second set of defines for eDP 1.4
where the name implies the meaning and then use them as appropriate.
We went through
On Wed, Aug 27, 2014 at 08:47:54AM +0100, Damien Lespiau wrote:
On Tue, Aug 26, 2014 at 01:28:19PM +0200, Thierry Reding wrote:
On Fri, Aug 08, 2014 at 04:23:40PM +0530, sonika.jin...@intel.com wrote:
From: Sonika Jindal sonika.jin...@intel.com
Adding new defines, older one
On Wed, Aug 14, 2013 at 06:19:08PM +0100, Damien Lespiau wrote:
To set the active aspect ratio value in the AVI infoframe today, you not
only have to set the active_aspect field, but also the active_info_valid
bit. Out of the 1 user of this API, we had 100% misuse, forgetting the
_valid bit.
On Wed, Aug 14, 2013 at 06:19:09PM +0100, Damien Lespiau wrote:
Just like:
Author: Damien Lespiau damien.lesp...@intel.com
Date: Mon Aug 12 11:53:24 2013 +0100
video/hdmi: Don't let the user of this API create invalid infoframes
But this time for the horizontal/vertical bar
On Wed, Aug 14, 2013 at 06:19:10PM +0100, Damien Lespiau wrote:
[...]
diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index ac84215..59c4748 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -286,6 +286,94 @@ ssize_t hdmi_audio_infoframe_pack(struct
On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote:
[...]
+#define HDMI_IDENTIFIER 0x000c03
HDMI_IDENTIFIER sounds really generic. Perhaps HDMI_INFOFRAME_OUI_HDMI?
Thierry
pgpsLkgvKVXmx.pgp
Description: PGP signature
___
Intel-gfx
On Wed, Aug 14, 2013 at 06:19:13PM +0100, Damien Lespiau wrote:
[...]
diff --git a/include/linux/hdmi.h b/include/linux/hdmi.h
[...]
+union hdmi_vendor_infoframe {
+ struct {
+ enum hdmi_infoframe_type type;
+ unsigned char version;
+ unsigned char
On Mon, Aug 19, 2013 at 02:49:50PM +0100, Damien Lespiau wrote:
On Thu, Aug 15, 2013 at 05:12:00PM +0200, Thierry Reding wrote:
On Wed, Aug 14, 2013 at 06:19:12PM +0100, Damien Lespiau wrote:
[...]
+#define HDMI_IDENTIFIER 0x000c03
HDMI_IDENTIFIER sounds really generic. Perhaps
On Mon, Aug 19, 2013 at 04:58:54PM +0100, Damien Lespiau wrote:
[...]
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
[...]
+static int
+do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
+{
[...]
+ u8 vic;
+
+ vic = db[9 +
(by, in turn,
renaming the hdmi_vendor_infoframe enum to hdmi_vendor_any_infoframe)
- Renamed HDMI_IDENTIFIER to HDMI_IEEE_OUI
The series looks good to me. Thanks for doing this Damien!
Reviewed-by: Thierry Reding tred...@nvidia.com
pgpRPMU_SMnVH.pgp
Description: PGP signature
On Mon, May 12, 2014 at 10:03:55AM +0200, Daniel Vetter wrote:
On Mon, May 12, 2014 at 11:37:53AM +0530, Sagar Arun Kamble wrote:
I support approach using docbook to start since there are not lot of
properties. Laurent has ack'ed this one. Can we go ahead with this?
On Mon, May 12, 2014 at 04:46:42PM +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This property will be used by the MST code to provide userspace
with a path to parse so it can recognise connectors around hotplugs.
Signed-off-by: Dave Airlie airl...@redhat.com
---
On Mon, May 12, 2014 at 04:46:41PM +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This can be called to update things after dynamic connectors/encoders
are created/deleted.
Signed-off-by: Dave Airlie airl...@redhat.com
---
drivers/gpu/drm/drm_crtc.c | 9 +
On Mon, May 12, 2014 at 04:46:47PM +1000, Dave Airlie wrote:
[...]
@@ -3813,6 +3838,7 @@ static const struct drm_info_list i915_debugfs_list[] =
{
{i915_pc8_status, i915_pc8_status, 0},
{i915_power_domain_info, i915_power_domain_info, 0},
{i915_display_info,
On Tue, May 13, 2014 at 09:34:45AM +0200, Daniel Vetter wrote:
On Tue, May 13, 2014 at 9:17 AM, Thierry Reding
thierry.red...@gmail.com wrote:
On Mon, May 12, 2014 at 10:03:55AM +0200, Daniel Vetter wrote:
On Mon, May 12, 2014 at 11:37:53AM +0530, Sagar Arun Kamble wrote:
I support
On Tue, May 13, 2014 at 12:18:35PM +0200, Daniel Vetter wrote:
On Tue, May 13, 2014 at 10:33:27AM +0200, Thierry Reding wrote:
On Mon, May 12, 2014 at 04:46:47PM +1000, Dave Airlie wrote:
[...]
@@ -3813,6 +3838,7 @@ static const struct drm_info_list
i915_debugfs_list
On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote:
Daniel,
Please find my comments inline.
Regards
Shashank
On 5/12/2014 8:58 PM, Daniel Vetter wrote:
On Mon, May 12, 2014 at 05:35:13PM +0530, Sharma, Shashank wrote:
Thanks for your time and the comments David.
please find
On Thu, May 15, 2014 at 10:52:38AM +0530, Sharma, Shashank wrote:
[...]
Please note that the color correction methods changes per platform and
what's valid for one Intel platform may not be valid for other. So the
atomic modeset should have a clear idea of what is supported on which
platforms.
On Wed, May 14, 2014 at 08:51:09PM +0200, Daniel Vetter wrote:
[...]
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
[...]
index dd786d84daab..5ff986bd4de4 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -1,6 +1,5 @@
-/**
- * \file drm_irq.c
- *
-by: Thierry Reding tred...@nvidia.com
pgpk7N3wuAH7q.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Thu, May 15, 2014 at 12:10:16PM +0200, Daniel Vetter wrote:
On Thu, May 15, 2014 at 9:34 AM, Thierry Reding
thierry.red...@gmail.com wrote:
This seems slightly backwards. Since drm_vblank_get() is what's being
deprecated here, wouldn't it make more sense to write
drm_crtc_vblank_get
On Tue, May 20, 2014 at 12:04:38PM +0200, Daniel Vetter wrote:
Also adding dri-devel and linux-media. Please don't forget these lists for
the next round.
-Daniel
On Tue, May 20, 2014 at 12:02:04PM +0200, Daniel Vetter wrote:
Adding Greg just as an fyi since we've chatted briefly about the
On Tue, May 20, 2014 at 04:45:56PM +0200, Daniel Vetter wrote:
On Tue, May 20, 2014 at 4:29 PM, Imre Deak imre.d...@intel.com wrote:
On Tue, 2014-05-20 at 05:52 +0300, Lin, Mengdong wrote:
This RFC is based on previous discussion to set up a generic
communication channel between display and
On Tue, May 20, 2014 at 05:07:51PM +0200, Daniel Vetter wrote:
On 20/05/2014 16:57, Thierry Reding wrote:
On Tue, May 20, 2014 at 04:45:56PM +0200, Daniel Vetter wrote:
On Tue, May 20, 2014 at 4:29 PM, Imre Deakimre.d...@intel.com wrote:
On Tue, 2014-05-20 at 05:52 +0300, Lin, Mengdong wrote
-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Thierry Reding tred...@nvidia.com
pgpk47T2UOhHK.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel
do we even need this timer? Why
not simply disable interrupts when the last vblank reference goes away?
Generally, though:
Reviewed-by: Thierry Reding tred...@nvidia.com
pgp_M10LG3SwK.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx
On Wed, May 14, 2014 at 08:51:05PM +0200, Daniel Vetter wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If there's a blocking vblank wait in progress while the vblank interrupt
gets disabled, the current code will just let the vblank wait time out.
Instead make it return immediately
On Wed, May 21, 2014 at 01:20:55PM +0200, Thierry Reding wrote:
On Wed, May 14, 2014 at 08:51:05PM +0200, Daniel Vetter wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
If there's a blocking vblank wait in progress while the vblank interrupt
gets disabled, the current code
On Wed, May 14, 2014 at 08:51:07PM +0200, Daniel Vetter wrote:
Originally these functions have been for user modesetting drivers to
ensure vblank processing doesn't fall over completely around modeset
changes. This has been carried over ever since then.
Now that Ville cleaned our vblank
On Tue, May 20, 2014 at 03:03:41PM +0300, Ville Syrjälä wrote:
On Wed, May 14, 2014 at 08:51:11PM +0200, Daniel Vetter wrote:
Now that we unconditionally dtrt when disabling/enabling crtcs we
don't need any hacks any longer to keep the vblank logic sane when
all the registers go poof. So
also not vblank waits.
Just return early on such drivers.
Note that with pageflips drivers are free to implement them however
they wish to.
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_irq.c | 6 ++
1 file changed, 6 insertions(+)
Reviewed-by: Thierry
On Wed, May 14, 2014 at 08:51:16PM +0200, Daniel Vetter wrote:
If we want to use this functionality in generic helpers to make
sure that all drivers have somewhat sane vblank handling across
modesets/dpms, we need to make it work for all drivers. But some
don't support interrupts and hence
On Wed, May 21, 2014 at 10:35:59AM +0200, Daniel Vetter wrote:
On Wed, May 21, 2014 at 11:26:55AM +0300, Ville Syrjälä wrote:
For everything but the reset_vblank_counter() thing:
Reviewed-by: Ville Syrjälä ville.syrj...@linux.intel.com
And another caveat: I only glanced at the
On Thu, May 22, 2014 at 04:50:48PM +0530, Vandana Kannan wrote:
Added a property to enable user space to set aspect ratio.
This patch contains declaration of the property and code to create the
property.
Signed-off-by: Vandana Kannan vandana.kan...@intel.com
Cc:
On Thu, May 22, 2014 at 04:50:49PM +0530, Vandana Kannan wrote:
In case user has specified an input for aspect ratio through the property,
then the user space value for PAR would take preference over the value from
CEA mode list.
Signed-off-by: Vandana Kannan vandana.kan...@intel.com
Cc:
Populate... as per review comments
Signed-off-by: Vandana Kannan vandana.kan...@intel.com
Cc: Thierry Reding thierry.red...@gmail.com
Cc: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_edid.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
alphabetically or you should append new entries.
But that's somewhat bikesheddy, so feel free to ignore.
With my first comment addressed:
Reviewed-by: Thierry Reding tred...@nvidia.com
pgpW84RKLVodb.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel
Populate... as per review comments
v3: Thierry's review comments.
- Modified the comment to block comment format.
Signed-off-by: Vandana Kannan vandana.kan...@intel.com
Cc: Thierry Reding thierry.red...@gmail.com
---
drivers/gpu/drm/drm_edid.c | 10 --
1 file changed, 8
On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote:
[...]
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
/**
+ * drm_mode_create_aspect_ratio_property - create aspect ratio property
+ * @dev: DRM device
+ *
+ * Called by a driver the first time it's
On Tue, Jun 10, 2014 at 02:00:37PM +0530, Vandana Kannan wrote:
On Jun-05-2014 2:58 PM, Thierry Reding wrote:
On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote:
[...]
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
On Thu, Nov 28, 2013 at 04:49:52PM +0100, Daniel Vetter wrote:
On Thu, Nov 28, 2013 at 03:29:18PM +, Damien Lespiau wrote:
We had some mode_valid() vfuncs returning an int, others the enum. Let's
use the latter everywhere.
Signed-off-by: Damien Lespiau damien.lesp...@intel.com
Replace an open-coded occurrence by a call to the new drm_crtc_mask()
helper.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
drivers/gpu/drm/i915/intel_display.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b
King (1):
drm: provide a helper for the encoder possible_crtcs mask
Thierry Reding (1):
drm/i915: Use drm_crtc_mask() helper
drivers/gpu/drm/drm_crtc.c | 38
drivers/gpu/drm/drm_crtc_helper.c| 16 +++
drivers/gpu/drm/i915
-by: Thierry Reding tred...@nvidia.com
---
Changes in v2:
- further extract a new drm_crtc_index() function
- move to DRM core (drm_crtc.c)
drivers/gpu/drm/drm_crtc.c| 38 ++
drivers/gpu/drm/drm_crtc_helper.c | 16 +++-
include/drm/drm_crtc.h
The intel_encoder_crtc_ok() is a duplicate of the drm_encoder_crtc_ok()
function that used to be only available in the DRM CRTC helpers. It has
recently been moved to the core, so the duplicate can now be dropped.
Acked-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Thierry Reding tred
for the encoder possible_crtcs mask
Thierry Reding (2):
drm: Move drm_encoder_crtc_ok() to core
drm/i915: Use drm_encoder_crtc_ok()
drivers/gpu/drm/drm_crtc.c | 23 +++
drivers/gpu/drm/drm_crtc_helper.c| 29 -
drivers/gpu/drm/i915
Using the new drm_crtc_mask() function, drm_encoder_crtc_ok() can now be
written in a significantly shorter way, so it can be moved to a header
file and be made static inline.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v3:
- new patch
drivers/gpu/drm/drm_crtc_helper.c | 13
of the DPCD and operate on that, without a way to write data
back to the DPCD (e.g. for configuration of the link).
Subsequent patches will build upon this infrastructure to provide common
functionality in a generic way.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v3:
- reorder
Implements an I2C-over-AUX I2C adapter on top of the generic drm_dp_aux
infrastructure. It extracts the retry logic from existing drivers, which
should help in porting those drivers to this new helper.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v3:
- add back DRM_DEBUG_KMS
The function reads the link status (6 bytes starting at offset 0x202)
from the DPCD so that it can be conveniently passed to other DPCD
helpers.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
drivers/gpu/drm/drm_dp_helper.c | 16
include/drm/drm_dp_helper.h | 3 +++
2
codes
Changes in v2:
- reimplement I2C-over-AUX functionality to get rid of the additional
layer
- extract retry logic from existing drivers
- add more kerneldoc comments
Thierry
Thierry Reding (4):
drm/dp: Add AUX channel infrastructure
drm/dp: Add drm_dp_dpcd_read_link_status()
drm/dp
On Tue, Jan 14, 2014 at 10:52:55AM -0500, Alex Deucher wrote:
On Tue, Jan 14, 2014 at 9:55 AM, Thierry Reding thierry.red...@gmail.com
wrote:
[...]
+/**
+ * drm_dp_link_configure() - configure a DisplayPort link
+ * @aux: DisplayPort AUX cahnnel
+ * @link: pointer to a structure
- add more kerneldoc comments
Thierry
Thierry Reding (5):
drm/dp: Add AUX channel infrastructure
drm/dp: Add drm_dp_dpcd_read_link_status()
drm/dp: Add DisplayPort link helpers
drm/dp: Allow registering AUX channels as I2C busses
drm/tegra: Add eDP support
.../bindings/gpu/nvidia,tegra20
The function reads the link status (6 bytes starting at offset 0x202)
from the DPCD so that it can be conveniently passed to other DPCD
helpers.
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off-by: Thierry Reding tred...@nvidia.com
...@intel.com
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v4:
- fix typo bitrate - bit rate
Changes in v3:
- add back DRM_DEBUG_KMS and DRM_ERROR messages
- embed i2c_adapter within struct drm_dp_aux
- fix typo in comment
drivers/gpu/drm/drm_dp_helper.c | 183
On Fri, Jan 17, 2014 at 03:22:08PM +0200, Jani Nikula wrote:
On Tue, 14 Jan 2014, Thierry Reding thierry.red...@gmail.com wrote:
[...]
+int drm_dp_link_probe(struct drm_dp_aux *aux, struct drm_dp_link *link)
+{
+ u8 values[3];
+ int err;
+
+ memset(link, 0, sizeof(*link
Add a helper to probe a DP link (read out the supported DPCD revision,
maximum rate, link count and capabilities) as well as power up the DP
link and configure it accordingly.
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off-by: Thierry
jani.nik...@intel.com
Signed-off-by: Thierry Reding tred...@nvidia.com
---
Changes in v4:
- fix a typo in a comment
Changes in v3:
- reorder drm_dp_dpcd_writeb() arguments to be more intuitive
- return number of bytes transferred in drm_dp_dpcd_write()
- factor out drm_dp_dpcd_access()
- describe error
From: Thierry Reding tred...@nvidia.com
Add a helper to probe a DP link (read out the supported DPCD revision,
maximum rate, link count and capabilities) as well as power up the DP
link and configure it accordingly.
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
Reviewed-by: Jani Nikula
From: Thierry Reding tred...@nvidia.com
This is a superset of the current i2c_dp_aux bus functionality and can
be used to transfer native AUX in addition to I2C-over-AUX messages.
Helpers are provided to read and write the DPCD, either blockwise or
byte-wise. Many of the existing helpers
From: Thierry Reding tred...@nvidia.com
The function reads the link status (6 bytes starting at offset 0x202)
from the DPCD so that it can be conveniently passed to other DPCD
helpers.
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
Reviewed-by: Jani Nikula jani.nik...@intel.com
Signed-off
From: Thierry Reding tred...@nvidia.com
Implements an I2C-over-AUX I2C adapter on top of the generic drm_dp_aux
infrastructure. It extracts the retry logic from existing drivers, which
should help in porting those drivers to this new helper.
Reviewed-by: Alex Deucher alexander.deuc...@amd.com
On Tue, Feb 18, 2014 at 03:13:33PM +0200, Ville Syrjälä wrote:
[...]
Once we have drm_planes for cursors, I was thinking we might add some kind
of enum property that lists all the supported sizes for the plane.
This comment was intriguing, so I was wondering whether you could
elaborate a little
On Fri, Feb 21, 2014 at 10:41:14AM -0500, Alex Deucher wrote:
On Fri, Feb 21, 2014 at 9:46 AM, Ville Syrjälä
ville.syrj...@linux.intel.com wrote:
On Fri, Feb 21, 2014 at 02:20:24PM +, Sharma, Shashank wrote:
Hi Ville,
Thanks for your time and comments.
I can understand two basic
characters.
I don't feel all that strongly about either of the above, so:
Reviewed-by: Thierry Reding tred...@nvidia.com
pgpZN07uvRcGA.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org
WARNs as part of the recent kerneldoc abi polishing done in
Tested-by: Thierry Reding tred...@nvidia.com
pgptSZEMMOr8y.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
in drm_fb_helper_initial_config.
Fixes any of the WARNINGs remaining after patch 1/2 for me on Tegra as
well, so:
Tested-by: Thierry Reding tred...@nvidia.com
pgp9xXBCMW7V6.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http
harder is a bit a bug. Caught by Thierry
since it resulted in some mode_config.mutex locking backtraces.
Cc: Thierry Reding tred...@nvidia.com
Cc: Matt Roper matthew.d.ro...@intel.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_plane_helper.c | 1 -
1 file
to be asserted when
the fb helper calls into the hdmi -detect function.
Cc: Thierry Reding tred...@nvidia.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
---
drivers/gpu/drm/drm_fb_helper.c | 11 +--
drivers/gpu/drm/i915/i915_dma.c | 3 ---
drivers/gpu/drm/i915/i915_drv.c
On Tue, Apr 22, 2014 at 10:26:37AM +0200, Daniel Vetter wrote:
On Thu, Apr 17, 2014 at 10:38:17AM +0200, Thierry Reding wrote:
On Wed, Apr 16, 2014 at 04:45:21PM +0200, Daniel Vetter wrote:
Some drivers need to be able to have a perfect race-free fbcon setup.
Current drivers only enable
On Tue, Apr 22, 2014 at 10:26:37AM +0200, Daniel Vetter wrote:
On Thu, Apr 17, 2014 at 10:38:17AM +0200, Thierry Reding wrote:
On Wed, Apr 16, 2014 at 04:45:21PM +0200, Daniel Vetter wrote:
Some drivers need to be able to have a perfect race-free fbcon setup.
Current drivers only enable
From: Thierry Reding tred...@nvidia.com
To implement hotplug detection in a race-free manner, drivers must call
drm_kms_helper_poll_init() before hotplug events can be triggered. Such
events can be triggered right after any of the encoders or connectors
are initialized. At the same time
into the hdmi -detect function.
Cc: Thierry Reding tred...@nvidia.com
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch
Signed-off-by: Thierry Reding tred...@nvidia.com
---
drivers/gpu/drm/drm_fb_helper.c | 11 +--
drivers/gpu/drm/i915/i915_dma.c | 3 ---
drivers/gpu/drm/i915/i915_drv.c | 2
From: Thierry Reding tred...@nvidia.com
A race condition currently exists on Tegra, where it can happen that a
monitor attached via HDMI isn't detected during the initial FB helper
setup, but the hotplug event happens too early to be processed by the
poll helpers because they haven't been
From: Thierry Reding tred...@nvidia.com
There's no need for this to be modifiable. Make it const so that it can
be put into the .rodata section.
Signed-off-by: Thierry Reding tred...@nvidia.com
---
drivers/gpu/drm/armada/armada_fbdev.c | 2 +-
drivers/gpu/drm/ast/ast_fb.c | 2
On Tue, Apr 22, 2014 at 05:54:06PM +0200, Daniel Vetter wrote:
On Tue, Apr 22, 2014 at 04:42:20PM +0200, Thierry Reding wrote:
[...]
diff --git a/drivers/gpu/drm/drm_fb_helper.c
b/drivers/gpu/drm/drm_fb_helper.c
[...]
@@ -502,6 +503,33 @@ static void drm_fb_helper_crtc_free(struct
On Wed, Apr 23, 2014 at 09:35:48AM +0200, Daniel Vetter wrote:
On Wed, Apr 23, 2014 at 09:14:41AM +0200, Thierry Reding wrote:
On Tue, Apr 22, 2014 at 05:54:06PM +0200, Daniel Vetter wrote:
On Tue, Apr 22, 2014 at 04:42:20PM +0200, Thierry Reding wrote:
[...]
diff --git a/drivers/gpu
;
plane-fb = fb;
+ fb = NULL;
}
drm_modeset_unlock_all(dev);
Ugh... and again I sent the same patch because I didn't look properly
and missed yours.
Reviewed-by: Thierry Reding thierry.red...@avionic-design.de
pgpqswReDPoni.pgp
Description: PGP signature
Today's linux-next merge of the drm-intel tree got conflicts in
drivers/gpu/drm/i915/intel_display.c
I fixed it up (see below). Please check if the resolution looks correct.
Thanks,
Thierry
---
diff --cc drivers/gpu/drm/i915/intel_display.c
index e5822e7,cbbdab6..76870f0
---
Today's linux-next merge of the drm-intel tree got conflicts in:
drivers/gpu/drm/i915/i915_dma.c
drivers/gpu/drm/i915/intel_dp.c
drivers/gpu/drm/i915/intel_drv.h
caused by commits e1264eb (Revert drm/i915: Delay disabling of VGA memory
until vgacon-fbcon handoff is done)
Today's linux-next merge of the drm tree got conflicts in
drivers/gpu/drm/i915/intel_drv.h
caused by commits e1264eb (Revert drm/i915: Delay disabling of VGA memory
until vgacon-fbcon handoff is done), 20ddf66 (drm/i915: Make
intel_crtc_active() available outside intel_pm.c), 18442d0
: Thierry Reding from nvidia is also working on a DSI
design for the tegra driver. Atm he seems to aim for a full-blown DSI bus
based on his drm_panel patches for getting the panel metadata out of an
ARM DT (we'd use VBT instead). Iirc there's no patches anywhere yet, but
maybe Thierry could
it here:
Reviewed-by: Thierry Reding tred...@nvidia.com
pgpb1iR3mjIM2.pgp
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Nov 15, 2013 at 03:01:50PM +0200, Jani Nikula wrote:
Preparing for the future eDP panels.
Signed-off-by: Jani Nikula jani.nik...@intel.com
---
include/drm/drm_dp_helper.h | 29 +
1 file changed, 29 insertions(+)
Reviewed-by: Thierry Reding tred
-by: Thierry Reding tred...@nvidia.com
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index cbf33be..ea4f3d1 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2816,6 +2816,20 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp
On Mon, Nov 18, 2013 at 10:09:56AM -0500, Alex Deucher wrote:
On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding
thierry.red...@gmail.com wrote:
On Fri, Nov 15, 2013 at 03:01:51PM +0200, Jani Nikula wrote:
Debug print the capabilities, and flag an error if the panel does not
support adjusting
On Mon, Nov 18, 2013 at 05:20:54PM +0100, Daniel Vetter wrote:
On Mon, Nov 18, 2013 at 04:26:17PM +0100, Thierry Reding wrote:
On Mon, Nov 18, 2013 at 10:09:56AM -0500, Alex Deucher wrote:
On Mon, Nov 18, 2013 at 9:27 AM, Thierry Reding
thierry.red...@gmail.com wrote:
On Fri, Nov 15
On Mon, Nov 18, 2013 at 05:38:18PM +0100, Daniel Vetter wrote:
On Mon, Nov 18, 2013 at 5:31 PM, Thierry Reding
thierry.red...@gmail.com wrote:
Note that there's already a bit of abstraction for i2c over dp aux, but
imo that's at the wrong level. At least reading through i915, gma500
() completely, so I've
removed them as part of the patch as well.
I suppose the attached patch and equivalent ones for the other drivers
would need to be carried in this series to avoid regressions.
Thierry
From 1b7539953054f8f4b102570c21ddee36a65f4a06 Mon Sep 17 00:00:00 2001
From: Thierry Reding
On Mon, Oct 13, 2014 at 08:15:00PM +0800, Yao Cheng wrote:
drm/ipvr is a new GEM driver for baytrail's vxd392, which accelerates VP8
video decoding.
The driver name ipvr means the PowerVR's IP wrapped by Intel. In the
future, ipvr may support other platforms such as Merrifield.
Code is
1 - 100 of 416 matches
Mail list logo
