and demarchi for help with the move!
and thank you for preparing all the patches to the different repos.
Lucas De Marchi
Ryszard
De Marchi
, I presume any further cleanups touching the
surrounding context would have a bigger footprint in drm-intel-next.
Acked-by: Lucas De Marchi
for both patches
thanks,
Lucas De Marchi
BR,
Jani.
---
drivers/gpu/drm/xe/display/xe_display.c | 1 -
drivers/gpu/drm/xe/xe_device_types.h| 2 --
-intel-next?
Acked-by: Lucas De Marchi
thanks
Lucas De Marchi
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9.
thanks
Lucas De Marchi
drm-xe-fixes-2024-05-09:
- Fix use zero-length element array
- Move more from system wq to ordered private wq
- Do not ignore return for drmm_mutex_init
The following changes since commit
Reviewed-by: Jani Nikula
Thanks.
I was going to push this to drm-xe-next, but I should actually
push it to drm-intel-next since I'll be massaging this stuff
there.
xe maintainers, ack for merging via drm-intel-next?
Acked-by: Lucas De Marchi
Lucas De Marchi
Roper
Signed-off-by: Radhakrishna Sripada
Acked-by: Lucas De Marchi
for merging this through drm-intel-next.
Lucas De Marchi
---
drivers/gpu/drm/xe/regs/xe_gt_regs.h | 3 ++
drivers/gpu/drm/xe/xe_device.c | 49
drivers/gpu/drm/xe/xe_device.h | 1 +
3
Das
Signed-off-by: Radhakrishna Sripada
Acked-by: Lucas De Marchi
for merging this through drm-intel-next since right now only display
needs it.
Lucas De Marchi
---
drivers/gpu/drm/xe/xe_gt_printk.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/xe/xe_gt_printk.h
b
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9-rc7.
Two important fixes: one avoiding a use-after-free in the rebind worker
and the other to make display work in ADL-N.
thanks
Lucas De Marchi
drm-xe-fixes-2024-05-02:
- Fix UAF on rebind worker
- Fix ADL-N display
ude "intel_tdf.h"
+
+void intel_td_flush(struct drm_i915_private *i915)
+{
+ xe_device_td_flush(i915);
this would be the display side "calling back onto xe". I think it's ok
given the current status quo, but Cc'ing Jani.
This also needs the previous 2 patches, which I'm ok with merging
through drm-intel-next if this user here is the correct way to
implement.
Lucas De Marchi
+}
--
2.34.1
On Tue, Apr 30, 2024 at 10:28:50AM GMT, Radhakrishna Sripada wrote:
From: Balasubramani Vivekanandan
Enable the display support for Battlemage
Signed-off-by: Balasubramani Vivekanandan
Reviewed-by: Shekhar Chauhan
Signed-off-by: Radhakrishna Sripada
Acked-by: Lucas De Marchi
to merge
On Thu, Apr 25, 2024 at 11:22:30AM GMT, Matt Roper wrote:
On Thu, Apr 25, 2024 at 11:16:09AM -0700, Lucas De Marchi wrote:
Contrary to i915, in xe ADL-N is kept as a different platform, not a
subplatform of ADL-P. Since the display side doesn't need to
differentiate between P and N, i.e
On Wed, Apr 24, 2024 at 01:41:59PM GMT, Ryszard Knop wrote:
The drm-intel repo is moving from the classic fd.o git host to GitLab.
Update its location with a URL matching other fd.o GitLab kernel trees.
Signed-off-by: Ryszard Knop
Acked-by: Lucas De Marchi
Also Cc'ing maintainers
Hi Dave and Sima
Please pull the drm-xe-fixes for this week targeting v6.9-rc6.
Simple fixes not really visible to end users: 2 around error paths on
drm managed allocations and 1 on PF/VF relay messages that are not
enabled by default.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-25:
- Fix
[ cut here ]
xe :00:02.0: drm_WARN_ON(!((dev_priv)->info.platform ==
XE_ALDERLAKE_S) && !((dev_priv)->info.platform == XE_ALDERLAKE_P))
And wrong paths being taken on the display side.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/
On Mon, Apr 22, 2024 at 03:10:10PM GMT, Jani Nikula wrote:
drivers/gpu/drm/xe/xe_debugfs.c | 1 +
drivers/gpu/drm/xe/xe_gt_debugfs.c | 2 ++
drivers/gpu/drm/xe/xe_uc_debugfs.c | 2 ++
Acked-by: Lucas De Marchi
thanks
Lucas De Marchi
Marchi
thanks
Lucas De Marchi
8 files changed, 167 insertions(+), 199 deletions(-)
--
2.44.0
Acked-by: Lucas De Marchi
Lucas De Marchi
+https://gitlab.freedesktop.org/drm/i915/kernel.git
+ssh://g...@gitlab.freedesktop.org/drm/i915/kernel.git
+"
+drm_old_urls[drm-intel]="
ssh://git.freedesktop.org/git/drm/drm-intel
ssh://git.freedesktop.org/git/drm-intel
git://anongit.freedesk
/display/intel_dmc.c | 175 +++---
drivers/gpu/drm/i915/i915_params.c| 3 -
drivers/gpu/drm/i915/i915_params.h| 1 -
drivers/gpu/drm/xe/xe_device_types.h | 3 -
Acked-by: Lucas De Marchi
thanks
Lucas De Marchi
6 files changed, 112 insertions(+), 75
error messages in the log if we had such option.
Another upside is that we could also just skip requesting the firmware
altogether, similar to what we have currently.
It's just a small naming problem... what should the magic string for
"disabled" be? Like, yes, that's the obvious choice right there, but
it's also a valid filename. Who am I to say how people should name their
firmware blobs. :)
"/dev/null"?
I like this one!
+1
Lucas De Marchi
Hi Dave and Sima,
Please pull the drm-xe-fixes for this week targeting v6.9-rc5.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-18:
- Fix bo leak on error path during fb init
- Fix use-after-free due to order vm is put and destroyed
The following changes since commit
raw accesses, then we can probably drop (1) above.
Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_irq.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_irq.c
b/drivers/gpu/
future commit making use of that register.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-11:
- Fix double display mutex initializations
- Fix u32 -> u64 implicit conversions
- Fix RING_CONTEXT_CONTROL not marked as masked
The following changes since commit fec50db7033ea478773b159e0e2efb135270e
(Lucas),
- avoid confusing 'if' statement condition (Lucas).
Could you please confirm if your R-b still applies?
yes, LGTM.
Reviewed-by: Lucas De Marchi
thanks
Lucas De Marchi
, I suggest merging the lot via
drm-intel-next. Please ack if this is fine for you.
Acked-by: Lucas De Marchi
Lucas De Marchi
-by: Lucas De Marchi
I skimmed through the series and left just one comment. It may be very
well because I skimmed through it too fast though. I agree on merging
it through drm-intel-next.
Lucas De Marchi
dev_priv->display.irq.de_irq_mask[pipe];
is this a good name though? I'd expect to see something like
display.irq.mask in the code.
Lucas De Marchi
On Fri, Apr 05, 2024 at 10:37:37PM +0300, Jani Nikula wrote:
Some cleanups on i915 side, and subsequent cleanups on xe side. I'd like
to merge all of these via drm-intel-next.
For the entire series:
Reviewed-by: Lucas De Marchi
and ack on merging via drm-intel-next.
Lucas De Marchi
BR
On Fri, Apr 05, 2024 at 10:37:39PM +0300, Jani Nikula wrote:
Avoid the dependency on intel_uc_fw.h, and allow removal of xe compat
intel_uc_fw.h. If there needs to be duplication of the URL, at least
have the duplication in a sensible way.
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
R Murthy
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/xe/display/xe_display.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/xe_display.c
b/drivers/gpu/drm/xe/display/xe_display.c
index e4db069f0db3..6ec375c1c4b6 100644
--- a/drivers/gpu/drm/xe/displa
what does "rebase" instead of "PATCH" is supposed to mean here?
And then we have a "PATCH v2" as reply to this one.
Shouldn't this go to dri-devel (too)?
Lucas De Marchi
On Thu, Apr 04, 2024 at 12:48:11PM +0200, Maarten Lankhorst wrote:
From: Maarten Lankhorst
with the
workqueue changes introduced in v6.9. That shouldn't be the normal use
case but was causing CI to abort further tests. Other changes include
fixes around rebinding and TLB invalidation.
thanks
Lucas De Marchi
drm-xe-fixes-2024-04-04:
- Stop using system_unbound_wq for preempt fences,
as this can
>display.backlight.lock,
...,
NULL);
if (err)
return err;
or... just stop using drmm_mutex_init and add the destroy. No need for
unwind as mutex_init() can't fail. We still need
in another patch.
Lucas De Marchi
eters specific to
display")
Fixes: 0d82a0d6f556 ("drm/i915/display: move dmc_firmware_path to display
params")
Cc: Jouni Högander
Cc: Luca Coelho
Cc: # v6.8+
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
... but what's the purpose of the duplication? How on
On Thu, Mar 28, 2024 at 02:22:28PM +0200, Alexander Usyskin wrote:
Add auxiliary driver for intel discrete graphics
on-die spi device.
CC: Rodrigo Vivi
Signed-off-by: Tomas Winkler
Signed-off-by: Lucas De Marchi
did you mean to Cc me? I never gave my s-o-b afair.
The order of the s-o-b
://github.com/thesofproject/linux/pull/4878
Signed-off-by: Rodrigo Vivi
Acked-by: Lucas De Marchi
to merge in our topic/core-for-CI branch.
thanks
Lucas De Marchi
---
sound/soc/sof/core.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/sound/soc/sof/core.c b
it 689b097a06ba
("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported
GCC"). So we should be able to pull this off now.
Cc: "Arnd Bergmann"
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
great! I had a vague memory of us using these localized warning-suppress
r
:
const char *debugfs_path = igt_debugfs_mount();
char path[PATH_MAX];
if (igt_debug_on(!debugfs_path || (strlen(debugfs_path) + strlen("/kunit")
>= PATH_MAX)))
return NULL;
strcat(stpcpy(path, debugfs_path), "/kunit");
return opendir(path);
Lucas De Marchi
d to treat it specially if this returns
-EINPROGRESS? That would probably be bug in our ktap parser or a format
change or something like that so we may want to start failing rather
than skipping.
anyway, consider the comments above as just nits. This seems like a
great improvement.
Reviewed-by:
)
- Fix build on mips
- Fix wrong bound checks
- Fix use of msec rather than jiffies
- Remove dead code
Lucas De Marchi (1):
drm/xe: Fix END redefinition
Matthew Auld (5
ani Nikula
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gt/intel_workarounds.c.rej| 18 --
1 file changed, 18 deletions(-)
delete mode 100644 drivers/gpu/drm/i915/gt/intel_workarounds.c.rej
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c.rej
b/drivers/gpu/d
On Mon, Mar 25, 2024 at 11:56:51AM +0200, Jani Nikula wrote:
On Tue, 19 Mar 2024, Lucas De Marchi wrote:
.../gpu/drm/i915/gt/intel_workarounds.c.rej | 18 +
create mode 100644 drivers/gpu/drm/i915/gt/intel_workarounds.c.rej
Whoops. [1]
argh... sorry about that. Should I just amend
On Tue, Mar 19, 2024 at 11:02:57PM -0700, Lucas De Marchi wrote:
For CI coverage. No change from previous version except the rebase.
See 20240312235145.2443975-1-lucas.demar...@intel.com
and 20240312235145.2443975-1-lucas.demar...@intel.com for details.
I will probably wait the drm-next
_mutex);
- drmm_mutex_init(>drm, >display.pps.mutex);
- drmm_mutex_init(>drm, >display.hdcp.hdcp_mutex);
+ if ((drmm_mutex_init(>drm, >sb_lock)) ||
^^
you only need 2 parenthesis if you were going to record the return.
Lucas De Marchi
On Fri, Mar 22, 2024 at 11:06:20AM -0500, Lucas De Marchi wrote:
On Fri, Mar 22, 2024 at 10:48:43AM +0200, Jani Nikula wrote:
On Thu, 21 Mar 2024, Lucas De Marchi wrote:
On Thu, Mar 21, 2024 at 06:20:57PM +0200, Jani Nikula wrote:
On Thu, 21 Mar 2024, Jani Nikula wrote
On Fri, Mar 22, 2024 at 10:48:43AM +0200, Jani Nikula wrote:
On Thu, 21 Mar 2024, Lucas De Marchi wrote:
On Thu, Mar 21, 2024 at 06:20:57PM +0200, Jani Nikula wrote:
On Thu, 21 Mar 2024, Jani Nikula wrote:
The dmc_firmware_path parameter is clearly a display parameter. Move
?!
not sure what you meant here. Patches makes sense to me.
Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_params.c | 3 +++
drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
drivers/gpu/drm/i915/display/intel_dmc.c| 8
MO this is one of them where the alternative is uglier and more error
prone.
thoughts?
We should not proceed with the remaining mutex_init in case of failures. As an
alternative we can have
with the code above, we are not proceeding with the other drmm_mutex_init()
initializations.
foo() || bar() do
PCI IDs for PVC were never added and platform always marked with
force_probe. Drop what's not used and rename some places as needed.
The registers not used anymore are also removed.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gem/i915_gem_object_types.h
-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 5 ++---
drivers/gpu/drm/i915/gt/uc/intel_guc.c| 4
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
index 396f5fe993c3f
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending on the platform/IP checks.
The registers not used anymore are also removed.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
With no platform using graphics/media IP_VER(12, 50), replace the
checks throughout the code with IP_VER(12, 55) so the code makes sense
by itself with no additional explanation of previous baggage.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gem/selftests
it completely.
Reviewed-by: Gustavo Sousa
Reviewed-by: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_pci.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index
Now that DG2 is the only user of this forcewake table, remove the macro
and use FORCEWAKE_RENDER explicitly for range 0xd800 - 0xd87f.
Suggested-by: Matt Roper
Reviewed-by: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/intel_uncore.c | 297 ++--
1
.
Lucas De Marchi (6):
drm/i915: Drop dead code for xehpsdv
drm/i915: Remove XEHP_FWRANGES()
drm/i915: Stop inheriting IP_VER(12, 50)
drm/i915: Update IP_VER(12, 50)
drm/i915: Drop dead code for pvc
drm/i915: Remove special handling for !RCS_MASK()
Documentation/gpu/rfc/i915_vm_bind.h
On Thu, Mar 14, 2024 at 01:57:46PM -0700, Matt Roper wrote:
On Tue, Mar 12, 2024 at 04:51:45PM -0700, Lucas De Marchi wrote:
With both XEHPSDV and PVC removed (as platforms, most of their code
remain used by others), there's no need to handle !RCS_MASK() as
other platforms don't ever have fused
) ||
(err = drmm_mutex_init(>drm, >display.backlight.lock)) ||
(err = ...))
return err;
I think there are few places in life for assignment + check in single
statement, but IMO this is one of them where the alternative is uglier
and more error prone.
thoughts?
mailing list so it
triggers CI on those machines
Lucas De Marchi
.
Lucas De Marchi
drm-xe-next-fixes-2024-03-14:
Driver changes:
- Invalidate userptr VMA on page pin fault, allowing userspace
to free userptr while still having bindings
- Fail early on sysfs file creation error
- Skip VMA pinning on xe_exec with num_batch_buffer == 0
The following changes
I added this while applying.
thanks
Lucas De Marchi
/8] drm/i915/xe2lpd: Load DMC
commit: bf1a72ab5a446e383682e34347237ee5317c2185
[8/8] drm/xe/lnl: Enable display support
commit: 79263e4b3f0ed5928a1622300d32ed35f7d8fc24
Best regards,
--
Lucas De Marchi
to remove XEHP_FWRANGES()
- Split out a patch touching i915_pci.c, removing the version from
the _FEATURES macros
- Fix holes in the forcewake tables
Lucas De Marchi (6):
drm/i915: Drop dead code for xehpsdv
drm/i915: Remove XEHP_FWRANGES()
drm/i915: Stop inheriting IP_VER(12, 50)
drm
With both XEHPSDV and PVC removed (as platforms, most of their code
remain used by others), there's no need to handle !RCS_MASK() as
other platforms don't ever have fused-off render. Remove those code
paths and the special WA flag when initializing GuC.
Signed-off-by: Lucas De Marchi
it completely.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_pci.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index b318b7c6bf73..8b673fdcf178 100644
--- a/drivers/gpu/drm/i915
PCI IDs for PVC were never added and platform always marked with
force_probe. Drop what's not used and rename some places as needed.
The registers not used anymore are also removed.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gem/i915_gem_object_types.h
Now that DG2 is the only user of this forcewake table, remove the macro
and use FORCEWAKE_RENDER explicitly for range 0xd800 - 0xd87f.
Suggested-by: Matt Roper
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/intel_uncore.c | 297 ++--
1 file changed, 145
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending on the platform/IP checks.
The registers not used anymore are also removed.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
With no platform using graphics/media IP_VER(12, 50), replace the
checks throughout the code with IP_VER(12, 55) so the code makes sense
by itself with no additional explanation of previous baggage.
Reviewed-by: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gem/selftests
)) ||
From what I can see, this workaround is also needed on Xe_LPG+ (12.74)
Isn't that an Xe platform? Or is 12.74 just ARL?
official xe platforms start with Xe2, with graphics version being 20
Lucas De Marchi
On Tue, Mar 12, 2024 at 03:54:09PM -0700, Matt Roper wrote:
On Wed, Mar 06, 2024 at 11:36:39AM -0800, Lucas De Marchi wrote:
With dynamic load-balancing disabled on the compute side, there's no
reason left to enable WA 16015675438. Drop it from both PVC and DG2.
Note that this can be done
On Tue, Mar 12, 2024 at 03:58:19PM -0700, Matt Roper wrote:
On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote:
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending
On Mon, Mar 11, 2024 at 11:16:06AM -0400, Rodrigo Vivi wrote:
On Wed, Mar 06, 2024 at 11:36:40AM -0800, Lucas De Marchi wrote:
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending
On Tue, Mar 12, 2024 at 09:54:41AM +, Tvrtko Ursulin wrote:
On 11/03/2024 19:27, Lucas De Marchi wrote:
On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote:
On 06/03/2024 19:36, Lucas De Marchi wrote:
Remove platforms that never had their PCI IDs added to the driver
On Mon, Mar 11, 2024 at 05:43:00PM +, Tvrtko Ursulin wrote:
On 06/03/2024 19:36, Lucas De Marchi wrote:
Remove platforms that never had their PCI IDs added to the driver and
are of course marked with requiring force_probe. Note that most of the
code for those platforms is actually used
ut looking further, that warning shouldn't really be caused by
this patch.
Lucas De Marchi
uld also keep the caller as well.
right... I had removed it but brought it back since I noticed the
kernel-doc mentions and forgot to bring back the caller too. I will fix
this in next rev.
thanks
Lucas De Marchi
On Mon, Mar 11, 2024 at 10:54:57AM -0400, Rodrigo Vivi wrote:
On Wed, Mar 06, 2024 at 06:43:39AM -0800, Lucas De Marchi wrote:
With dynamic load-balancing disabled on the compute side, there's no
reason left to enable WA 16015675438. Drop it from both PVC and DG2.
Note that this can be done
On Mon, Mar 11, 2024 at 11:18:03AM -0400, Rodrigo Vivi wrote:
On Wed, Mar 06, 2024 at 11:36:41AM -0800, Lucas De Marchi wrote:
With no platform declaring graphics/media IP_VER(12, 50),
this is not true.
We still have
#define XE_HPM_FEATURES \
.__runtime.media.ip.ver = 12
On Fri, Mar 08, 2024 at 01:55:52PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/display/drm_dp_mst_topology_internal.h | 4 +++-
1 file changed, 3 insertions
On Fri, Mar 08, 2024 at 01:55:53PM +0200, Jani Nikula wrote:
Prefer forward declarations over includes where possible.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
---
drivers/gpu/drm/drm_crtc_helper_internal.h | 10 ++
1 file changed, 6 insertions
On Fri, Mar 08, 2024 at 01:55:45PM +0200, Jani Nikula wrote:
Make documentation match code. Slightly fix up the documentation
comments while at it.
v2:
- Move comments next to members instead of struct comment (Lucas)
- Small fixups while at it
Cc: Lucas De Marchi
Acked-by: Thomas Zimmermann
On Thu, Feb 29, 2024 at 10:06:02PM -0600, Lucas De Marchi wrote:
On Thu, Feb 29, 2024 at 08:27:30PM +0200, Andy Shevchenko wrote:
On Thu, Feb 29, 2024 at 12:21:34PM -0600, Lucas De Marchi wrote:
On Thu, Feb 29, 2024 at 12:49:57PM +0200, Andy Shevchenko wrote:
On Wed, Feb 28, 2024 at 05:39
* drivers for the PXP services
- * @tee_dev: device that provide the PXP service from TEE Bus.
- * @pxp_ops: Ops implemented by TEE driver, used by i915 driver.
*/
... which you follow here.
Lucas De Marchi
struct i915_pxp_component {
+ /**
+* @tee_dev: device that provide the PXP
service from MEI Bus.
^provides
+*/
struct device *hdcp_dev;
+
+ /**
+* @ops: Ops implemented by hdcp driver or intel_hdcp_gsc , used by i915
extra space before ","
anyway,
Reviewed-by: Lucas De Marchi
Lucas
On Wed, Mar 06, 2024 at 08:31:20PM +0200, Jani Nikula wrote:
There's no proper way to document function pointer members, but at least
silence the warnings.
Signed-off-by: Jani Nikula
Reviewed-by: Lucas De Marchi
Lucas De Marchi
With both XEHPSDV and PVC removed (as platforms, most of their code
remain used by others), there's no need to handle !RCS_MASK() as
other platforms don't ever have fused-off render. Remove those code
paths and the special WA flag when initializing GuC.
Signed-off-by: Lucas De Marchi
PCI IDs for PVC were never added and platform always marked with
force_probe. Drop what's not used and rename some places as needed.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
.../gpu/drm/i915/gem/i915_gem_object_types.h | 2 +-
drivers/gpu/drm/i915
PCI IDs for XEHPSDV were never added and platform always marked with
force_probe. Drop what's not used and rename some places to either be
xehp or dg2, depending on the platform/IP checks.
The registers not used anymore are also removed.
Signed-off-by: Lucas De Marchi
---
Potential problem
is still needed because of 18020744125, so update
the comment accordingly.
Cc: Mateusz Jablonski
Cc: Michal Mrozek
Cc: Rodrigo Vivi
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 2 +-
2 files changed, 2
-lucas.demar...@intel.com .
While loooking at this WA I was wondering why we still had some of that
code around.
Build-tested only for now.
Lucas De Marchi (5):
drm/i915: Drop WA 16015675438
drm/i915: Drop dead code for xehpsdv
drm/i915: Update IP_VER(12, 50)
drm/i915: Drop dead code
without pointless overrides.
Signed-off-by: Lucas De Marchi
---
drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 4 ++--
.../gpu/drm/i915/gem/selftests/i915_gem_client_blt.c | 8
drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt
is still needed because of 18020744125, so update
the comment accordingly.
Cc: Rodrigo Vivi
Acked-by: Mateusz Jablonski
Acked-by: Michal Mrozek
Signed-off-by: Lucas De Marchi
---
This is the i915 counter part. The xe version of this patch
(https://lore.kernel.org/intel-xe/20240304233103.1687412-1
o find all the issues
my configs didn't catch.
I built this on x86-64 (both gcc and clang), arm and arm64, and
[ ... ]
Acked-by: Maxime Ripard
Thanks everyone for acks and reviews, pushed to drm-misc-next.
should we start removing the now duplicate ones in i915 and xe?
Lucas De Marchi
-by: Lucas De Marchi
Lucas De Marchi
drivers/gpu/drm/i915/display/intel_hdcp_gsc.c | 6 +
drivers/gpu/drm/i915/display/intel_hdcp_gsc.h | 7 +-
drivers/gpu/drm/xe/Makefile | 1 +
drivers/gpu/drm/xe/display/xe_hdcp_gsc.c | 241 +-
drivers/gpu/drm/xe
On Tue, Feb 27, 2024 at 11:02:04AM +0530, Suraj Kandpal wrote:
Enable HDCP for Xe by defining functions which take care of
interaction of HDCP as a client with the GSC CS interface.
Add intel_hdcp_gsc_message to Makefile and add corresponding
changes to xe_hdcp_gsc.c to make it build.
--v2
-add
On Mon, Mar 04, 2024 at 03:30:27PM -0300, Gustavo Sousa wrote:
From: Balasubramani Vivekanandan
Enable display support for Lunar Lake.
Signed-off-by: Balasubramani Vivekanandan
Signed-off-by: Lucas De Marchi
Signed-off-by: Gustavo Sousa
Reviewed-by: Lucas De Marchi
No need to merge
E 0x8000
^ missing DMC_ here to be like the other macros below?
other than that, Reviewed-by: Lucas De Marchi
Lucas De Marchi
#define XELPDP_DMC_MAX_FW_SIZE 0x7000
#define DISPLAY_VER13_DMC_MAX_FW_SIZE 0x2
#define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
+#de
handling page fault on a VM not in fault mode
- Drop use of "grouped target" feature in Makefile since that's
only available in make >= 4.3
thanks,
Lucas De Marchi
The following changes since commit c6d6a82d8a9f8f9326b760accaa532b839b80140:
Merge tag 'drm-misc-next-fixes-2024-02-
On Fri, Mar 01, 2024 at 05:06:16PM +0100, Christian König wrote:
Am 01.03.24 um 17:04 schrieb Lucas De Marchi:
On Thu, Feb 29, 2024 at 02:01:05PM +0100, Christian König wrote:
Gentle ping. Can I get an rb for that?
Thanks,
Christian.
Reviewed-by: Lucas De Marchi
Thanks!
For some
1 - 100 of 3092 matches
Mail list logo
