fd)
> @@ -222,8 +266,15 @@ int intel_register_access_needs_fakewake(struct
> intel_mmio_data *mmio_data)
> void
> intel_register_access_fini(struct intel_mmio_data *mmio_data)
> {
> - if (mmio_data->key && intel_register_access_needs_wake(mmio_data))
> + if (igt_warn_on_f(!mmio_data->key,
> + "test bug: argument doesn't point to struct
> intel_mmio_data initialized with intel_register_access_init()\n"))
Same here, please shorten this warn.
Btw, in this lib error condition for key is -1, so maybe this
should also be cheked ?
> + return;
> +
> + if (intel_register_access_needs_wake(mmio_data))
> release_forcewake_lock(mmio_data->key);
> + mmio_data->key = 0;
> +
> + intel_mmio_unmap_pci_bar(mmio_data);
> }
>
> /**
> --
> 2.25.1
>
Please correct desciption of global var igt_global_mmio, there
is one more method for initialize it: intel_mmio_use_pci_bar
as you wrote on irc.
Regards,
Kamil Konieczny
use .pci_device_id field content as an indicator of arg initialization
> via intel_register_access_init(),
> - improve checks of argument initialization status,
> - shorten warning messages (Kamil),
> - don't fill .mmio_size field until initialization succeeds (Kamil)
>
&g
Hi Janusz,
Dnia 2022-03-07 at 16:06:10 +0100, Janusz Krzysztofik napisał(a):
> Hi Kamil,
>
> On Monday, 7 March 2022 14:23:30 CET Kamil Konieczny wrote:
> > Hi Janusz,
> >
> > Dnia 2022-03-07 at 09:26:43 +0100, Janusz Krzysztofik napisał(a):
> > > Commit 5
of forcewake release, broken in v3,
> - improve comments and warning messages (Kamil)
>
> Signed-off-by: Janusz Krzysztofik
> Cc: Kamil Konieczny
> ---
> lib/intel_io.h | 4 +++
> lib/intel_mmio.c | 64 +---
> 2 files chang
gem_write(i915, batch, 0, , sizeof(bbe));
> +
> + igt_fork_helper() {
> + for (;;) {
> + memset(, 0, sizeof(info));
> + ret = __igt_parse_drm_fdinfo(dir, buf, ,
> +
ed mode by default and interactive command 'm' and
> command line switch '-m' can be used to toggle that.
>
> Both only affect the interactive view, while JSON output always contains
> separate memory regions.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
>
arse_drm_fdinfo() will then be possible to be greater
> than zero even when engine stats are not supported.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> tests/intel/drm_fdinfo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel/drm_fdin
Hi Tvrtko,
On 2023-10-12 at 09:15:43 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Igt_drm_fdinfo defines it as an unsigned long so it is best that it
> matches here as well.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> l
Hi Tvrtko,
On 2023-10-12 at 09:15:42 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> I will need some record of which regions were found for intel_gpu_top so
> lets just copy over the region name from the map on the first match.
>
> Signed-off-by: Tvrtko Ursulin
Hi Tvrtko,
On 2023-10-12 at 09:15:45 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Wrap all operations on clients via the Intel specific wrappers in order to
> simplify upcoming work.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
>
Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_drm_clients.c | 5 +++--
> lib/igt_drm_clients.h | 3 ++-
> tools/gputop.c| 4 ++--
> tools/intel_gpu_top.c | 8 +---
> 4 files changed, 12 insertions(+), 8 deletions(-)
>
Hi Tvrtko,
On 2023-10-12 at 09:15:46 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> JSON output has the full breakdown but for now the interactive mode only
> shows total and resident aggregated for all memory regions.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-b
Hi Tvrtko,
On 2023-10-12 at 09:15:41 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> A few basic smoke tests to check per client memory info looks legit.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> tests/int
utions.
>
> Update the comment with a reference to the kernel side fix and a
> clarification on why we need to keep the workaround in place.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_ktap.c | 13 ++---
> 1 file changed, 10 insertion
Hi Janusz,
On 2023-10-03 at 11:10:53 +0200, Janusz Krzysztofik wrote:
> Recent improvements to the kernel kunit framework allow us to obtain a
> list of test cases provided by a kunit test module without actually
> running them. Use that feature to get a list of expected test cases
> before we
usz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
> index d98e6c5f9e..05ff178b27 100644
> --- a/lib/igt_kmod.c
> +++ b/lib/igt_kmod.c
> @@ -783,
gt; function. Update that documentation and move it to where it now belongs.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c | 17 -
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/lib/ig
Hi Janusz,
On 2023-10-03 at 11:10:47 +0200, Janusz Krzysztofik wrote:
> Use a more verbose variant of igt_fail() when failing a dynamic sub-
> subtest on kernel taint. Also, print a debug message on string
> duplication failure.
>
> Signed-off-by: Janusz Krzysztofik
Rev
s/kunit/style.html
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> tests/kms_selftest.c | 37 -
> 1 file changed, 16 insertions(+), 21 deletions(-)
>
> diff --git a/tests/kms_selftest.c b/tests/kms_selftest.c
&g
f-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 10601e66b18e..60fe06917531 100644
> --- a/tools/intel_gpu_top.
Hi Tvrtko,
On 2023-10-10 at 12:07:13 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Padding the percentage bars and table columns with spaces happens quite a
> lot so lets do better than putchar at a time. Have a table of visually
> empty strings and build the required length out of
our first patch touching this function?
With or without this suggestion,
Reviewed-by: Kamil Konieczny
Regards,
Kamil
> {
> static const char *spaces[] = {
> " ",
> @@ -950,7 +950,7 @@ static unsigned int n_spaces(const unsigned int n)
> &quo
count of test
> suites in a module"), included in the mainline kernel since v6.6-rc1, has
> fixed that issue, that workaround is no longer needed. Drop it.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_ktap.c | 12 --
Hi Janusz,
On 2023-10-09 at 14:27:59 +0200, Janusz Krzysztofik wrote:
> Planned changes require a couple of loops around kunit_result_free().
> Since we already have such loop, move it into a helper in preparation for
> future uses.
>
> Signed-off-by: Janusz Krzysztofik
Rev
is successfully loaded and
> there will be no concurrently running modprobe thread, we need to make
> synchronization of reads from /dev/kmsg with potential errors modprobe
> thread optional.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
result right after loading the kunit test module for execution.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c | 66 ++
> 1 file changed, 35 insertions(+), 31 deletions(-)
>
>
Hi Janusz,
On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote:
> There was an attempt to parse KTAP reports in the background while a kunit
> test module is loading. However, since dynamic sub-subtests can be
> executed only from the main thread, that attempt was not quite successful,
> as
ed. Consequence of this is that client name gets printed
> as the second field and not under the "NAME" column header.
>
> Fix it by emitting spaces instead of engine utilisation until two samples
> have been collected.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Koni
; @@ -1035,7 +1109,8 @@ __igt_kunit(struct igt_ktest *tst, const char *name,
> const char *opts)
>
> igt_skip_on(modprobe.err);
> igt_skip_on(igt_kernel_tainted());
> - igt_skip_on_f(ret, "KTAP parser failed\n");
> + if (ret != -EINPROGRESS)
> +
after a valid result from the parser has been processed,
> - fix trailing newlines missing from error messages,
> - add more debug statements,
> - integrate common code around kunit_result_free() into it.
> v2: Interrupt blocking read() on modprobe failure.
>
> Sig
expected return codes from
> kunit_kmsg_get_result(),
> - use kunit_results_free() helper,
> - fix typos (Kamil),
> - update commit description.
>
> Signed-off-by: Janusz Krzysztofik
> Acked-by: Kamil Konieczny # v2
Reviewed-by: Kamil Konieczny
> ---
> li
ired length out of those chunks.
>
> While at it, also move the percentage bar table into its function scope.
>
> v2:
> * Fix checkpatch and use ARRAY_SIZE. (Kamil)
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Kamil Konieczny
Reviewed-by: Kamil Konieczn
Hi Janusz,
On 2023-10-10 at 19:49:35 +0200, Janusz Krzysztofik wrote:
> Hi Kamil,
>
> Thanks for review.
>
> On Tuesday, 10 October 2023 17:59:56 CEST Kamil Konieczny wrote:
> > Hi Janusz,
> > On 2023-10-09 at 14:27:55 +0200, Janusz Krzysztofik wrote:
> > >
file descriptor fd_drm failed
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/8830
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/500
> Signed-off-by: Janusz Krzysztofik
> Cc: Petri Latvala
Reviewed-by: Kamil Konieczny
> ---
> tests/core_hot
Hi Ashutosh,
On 2022-04-13 at 11:11:06 -0700, Ashutosh Dixit wrote:
> Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt
> sysfs. This patch adds the following files to gt/gtN sysfs:
> * media_RP0_freq_mhz
> * media_RPn_freq_mhz
- ^
Can we keep it in lowercase ? So it
Hi John,
On 2022-06-02 at 17:54:04 -0700, john.c.harri...@intel.com wrote:
> From: Rodrigo Vivi
>
> Newer platforms have an embedded table giving details about that
> platform's hardware configuration. This table can be retrieved from
> the KMD via the existing query API. So add a test for it
On 2022-06-03 at 09:25:51 -0700, john.c.harri...@intel.com wrote:
> From: John Harrison
>
> None of the query tests had a description. So make some up.
>
> Signed-off-by: John Harrison
> ---
Reviewed-by: Kamil Konieczny
> tests/i915/i915_query.c | 12
Hi Tvrtko,
On 2022-06-17 at 10:08:28 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> We need some coverage of the virtual engines.
>
> v2:
> * Mark contexts as "allow hang". (Umesh)
> * Fix destruction order in virtual_all.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Umesh Nerlige
tel/-/issues/3952
> Signed-off-by: Andrzej Hajda
Reviewed-by: Kamil Konieczny
> ---
> tests/i915/gem_ctx_persistence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_persistence.c
> b/tests/i915/gem_ctx_persistence.c
> in
y: Matthew Auld
> Cc: Kamil Konieczny
> Cc: Petri Latvala
> Cc: Andrzej Hajda
> Cc: Nirmoy Das
> ---
> .../igt-gpu-tools/igt-gpu-tools-docs.xml | 1 +
> lib/dmabuf_sync_file.c| 211 ++
> lib/dmabuf_sync_file.h
Hi Matt,
On 2022-12-05 at 17:11:44 +, Matthew Auld wrote:
> On 05/12/2022 16:31, Kamil Konieczny wrote:
> > Hi Matt,
> >
> > after re-reading I have few more nits.
> >
> > On 2022-12-02 at 12:02:41 +, Matthew Auld wrote:
> > > So we can use th
a_t *data, enum pipe pipe)
>
> test_init(data, pipe);
>
> + for_each_memory_region(r, data->drm_fd)
> + if (r->ci.memory_class == I915_MEMORY_CLASS_DEVICE)
> + mem_size = r->cpu_size;
imho either max(mem_size, r->cpu
Hi Matthew,
few nits, see below.
On 2022-11-18 at 15:53:35 +, Matthew Auld wrote:
> With parallel submission it should be easy to get a fence array as the
> output fence. Try importing this into dma-buf reservation object, to see
> if anything explodes.
>
> References:
Hi Matthew,
one more nit, see below.
On 2022-11-18 at 15:53:35 +, Matthew Auld wrote:
> With parallel submission it should be easy to get a fence array as the
> output fence. Try importing this into dma-buf reservation object, to see
> if anything explodes.
>
> References:
Hi Matthew,
On 2022-12-01 at 16:49:43 +, Matthew Auld wrote:
> So we can use this across different tests.
>
> Signed-off-by: Matthew Auld
> Cc: Kamil Konieczny
> Cc: Andrzej Hajda
> Cc: Nirmoy Das
> ---
> lib/dmabuf_sync_file.c | 138 ++
On 2023-01-12 at 17:47:26 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Mostly by popular demand from
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/109, although for
> some of these changes I'd like some second opinions. For instance is it user
> friendly to change the
Hi,
On 2023-01-26 at 16:09:29 +, Tvrtko Ursulin wrote:
>
> On 26/01/2023 15:39, Kamil Konieczny wrote:
> > On 2023-01-12 at 17:47:27 +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > New lines are not respected when rst2man generat
On 2023-01-12 at 17:47:27 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> New lines are not respected when rst2man generates the page so try to work
> around that by followin advice from the Internet.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Koniec
On 2023-01-12 at 17:47:29 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Default mode is to aggreate engines per class but some users would prefer
> to be able to start in physical engine mode too.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Dmitry Rogozhkin
Reviewe
make the tool output that itself.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Eero Tamminen
Reviewed-by: Kamil Konieczny
> ---
> man/intel_gpu_top.rst | 2 +-
> tools/intel_gpu_top.c | 6 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/man/i
> Signed-off-by: Tvrtko Ursulin
> Cc: Dmitry Rogozhkin
Reviewed-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index e91b47baf72b..7aa233570463 10
Hi,
please rebase and resend, also please change commit subject to start
with lib: or lib/[name of lib changed]: rest od commit description
For example, in 3/8 instead of
libdrmclients: Record client drm minor
write:
lib/igt_drm_clients: Record client drm minor
If there are more lib changes,
Hi,
On 2023-01-30 at 10:55:42 +, Tvrtko Ursulin wrote:
>
> On 27/01/2023 16:10, Kamil Konieczny wrote:
> > Hi Tvrtko,
> >
> > On 2023-01-27 at 11:12:40 +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Av
Hi,
On 2023-01-30 at 11:04:07 +, Tvrtko Ursulin wrote:
>
> On 27/01/2023 16:17, Kamil Konieczny wrote:
> > Hi Tvrtko,
> >
> > On 2023-01-27 at 11:12:41 +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Now that DRM
er name instead.
>
> Caveat that the driver key was on a blacklist so far, and although I can't
> imagine it can be slow to probe, this is something to double check.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Kamil Konieczny
> Cc: Zbigniew Kempczyński
Please send this a
Hi Tvrtko,
On 2023-01-27 at 11:12:40 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Avoid trying to dereference null engines on exit when there are either
> none which are supported, or kernel does not have i915 PMU support.
>
> Also fix a memory leak on the same failure path just so
dy -o option description.
> * Update dates.
> * Convert the filter list to table.
>
> Signed-off-by: Tvrtko Ursulin
> Reviewed-by: Kamil Konieczny # v1
--- ^
Remove this addition at end,
s/ # v1//
Man page looks much b
Hi,
On 2023-01-31 at 10:17:30 +0100, Janusz Krzysztofik wrote:
> From: Chris Wilson
>
> Try opening the perf stream while there is a flurry of activity on the
> system, both new and old contexts. This will exercise the ability of the
> driver to modify those contexts to work with perf.
>
>
Hi Janusz,
please send patches to igt ML and add other addresses to cc:
I have one nit, see below.
On 2023-01-31 at 10:17:31 +0100, Janusz Krzysztofik wrote:
> Add a new subtest focused on exercising interaction between perf open /
> close operations, which replace active barriers with perf
Hi Janusz,
On 2023-02-01 at 20:16:11 +0100, Janusz Krzysztofik wrote:
> Hi Kamil,
>
> On Wednesday, 1 February 2023 19:21:57 CET Kamil Konieczny wrote:
> > Hi Janusz,
> >
> > please send patches to igt ML and add other addresses to cc:
> > I have one nit, see be
e and no RCS available.
Lgtm,
Reviewed-by: Kamil Konieczny
--
Kamil
>
> Suggested-by: Chris Wilson
> Signed-off-by: Janusz Krzysztofik
> ---
> tests/i915/gem_barrier_race.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_barrier_ra
hutosh), add it to
> tests/i915/gem_ctx_exec.c,
> - don't touch lib/i915/perf.c (Umesh, Ashutosh), duplicate reused code
> from tests/i915/perf.c in tests/i915/gem_ctx_exec.c.
>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6333
> Signed-off-by: Janusz K
#5 ../csu/libc-start.c:128
> __libc_start_main@@GLIBC_2.34()
> (i915_suspend:9050) igt_core-INFO: #6 [_start+0x2a]
> END ****
>
> Fixes: f7aff600ab16 ("tests/i915/i915_suspend: Disable d3cold_allowed for
> basic-s2idle-without-i915")
> Signed-off-by: Janus
Hi Ashutosh,
On 2023-04-26 at 13:40:28 -0700, Dixit, Ashutosh wrote:
> On Tue, 25 Apr 2023 09:24:04 -0700, Vinay Belgaumkar wrote:
> >
> > diff --git a/tests/i915/i915_pm_freq_api.c b/tests/i915/i915_pm_freq_api.c
> > new file mode 100644
> > index ..17adacbc
> > --- /dev/null
> > +++
tting.
>
> Fix it by tracking the largest width for both the pid and name fields and
> use them dynamically.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 66 +--
> 1 file changed, 58
n (bar) is kept the
> same.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 20 +++-
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
&g
On 2023-03-28 at 13:54:28 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> It appears we had an off by one of a kind where we were not using the full
> width of the terminal window for the global metrics section.
>
> Signed-off-by: Tvrtko Ursulin
Reviewed-b
- key_size_dw: 0x40
> - modulus_size_dw: 0x40
> - exponent_size_dw: 0x1
> - time: 0x452109
> - username: b'sys_gbsb'
> - buildnumber: b'PC-1.0.3150\x00'
> - sw_version: 0x460501
> - vf_version: 0x0
> - reserved0: [0, 0, 0, 0,
Hi Tvrtko,
On 2023-01-31 at 11:32:37 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Rudimentary vendor agnostic example of how lib_igt_drm_clients can be used
> to display a sorted by card and usage list of processes using GPUs.
>
> Borrows a bit of code from intel_gpu_top but for now
Hi Tvrtko,
On 2023-02-06 at 09:19:02 +, Tvrtko Ursulin wrote:
>
> On 03/02/2023 16:42, Kamil Konieczny wrote:
> > Hi Tvrtko,
> >
> > On 2023-01-31 at 11:32:37 +, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Rudimentary
On 2023-02-03 at 11:16:35 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Internal cleanup only - the name text is more accurate given the output
> can also go to a file.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Caleb Callaway
Lgtm,
Reviewed-by: Kamil Konie
Signed-off-by: Tvrtko Ursulin
> Cc: Caleb Callaway
Reviewed-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 19 ++-
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 0a1de
On 2023-02-03 at 11:31:19 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Add CSV output mode.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Caleb Callaway
Reviewed-by: Kamil Konieczny
> ---
> man/intel_gpu_top.rst | 3 ++
>
Hi,
On 2023-02-10 at 08:53:12 +0100, Janusz Krzysztofik wrote:
> Hi,
>
> On Thursday, 9 February 2023 12:50:38 CET Janusz Krzysztofik wrote:
> > Users reported oopses on list corruptions when using i915 perf with a
> > number of concurrently running graphics applications. That indicates we
> >
Hi Tvrtko,
one small nit, see below.
On 2023-02-03 at 11:16:34 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> If output is redirected to a file, or a pipe, lets not repeat the headers
> because that can usually mean user is trying to parse the data later and
> so repeated headers are
the subtest out of tests/i915/perf.c (Ashutosh), add it to
> tests/i915/gem_ctx_exec.c,
> - don't touch lib/i915/perf.c (Umesh, Ashutosh), duplicate reused code
> from tests/i915/perf.c in tests/i915/gem_ctx_exec.c.
>
> References: https://gitlab.freedesktop.org/drm
Hi Janusz,
I have one nit, see below.
On 2023-02-09 at 20:32:31 +0100, Janusz Krzysztofik wrote:
> If any of *-without-i915 subtests fails or skips for any reason, it may
> leave the i915 module unloaded while keeping our device list populated
> with initially collected data. In a follow up
Hi Tvrtko,
On 2023-02-10 at 15:22:07 +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> No one remembered to add names for the new compute engines.
Actually there was patch:
https://patchwork.freedesktop.org/series/112674/
intel_gpu_top: Add display name for compute engine class
Submitted
Hi Janusz,
On 2023-02-10 at 15:21:20 +0100, Janusz Krzysztofik wrote:
> On Friday, 10 February 2023 15:02:59 CET Kamil Konieczny wrote:
> > Hi Janusz,
> >
> > I have one nit, see below.
> >
> > On 2023-02-09 at 20:32:31 +0100, Janusz Krzysztofik wrote:
> &
Hi Vinay,
On 2023-05-24 at 12:19:06 -0700, Vinay Belgaumkar wrote:
> Hang and heartbeat subtests are not supported with GuC submission
> enabled.
>
> Signed-off-by: Vinay Belgaumkar
> ---
> tests/i915/gem_ctx_persistence.c | 32 +++-
> 1 file changed, 19
Hi Vinay,
On 2023-06-06 at 15:14:18 -0700, Vinay Belgaumkar wrote:
> Hang subtest is not supported with GuC submission enabled.
This is Guc which do not support some operations, so please
improve description, maybe use Andrzej suggestions ?
Regards,
Kamil
>
> Cc: Kamil Konieczny
>
ulin
> Cc: Rob Clark
Acked-by: Kamil Konieczny
> ---
> tools/intel_gpu_top.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 453090c298bc..937280a7151a 100644
&
ulin
> Cc: Rob Clark
Acked-by: Kamil Konieczny
> ---
> tools/gputop.c | 19 +--
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/gputop.c b/tools/gputop.c
> index 4fb5ce63e07c..681f0a6bb748 100644
> --- a/tools/gputo
Hi Tvrtko,
On 2023-07-05 at 17:31:05 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Show total and resident memory usage for clients which support it.
>
> For simplicity all memory regions are summed up and shown under a single
> heading.
>
> Co-developed-by: Rob Clark
>
Hi Tvrtko,
please check your patches with Linux kernel script checkpatch.pl
Some of it's warnings seems strange, like:
WARNING: Co-developed-by and Signed-off-by: name/email do not match
#12:
Co-developed-by: Rob Clark
Signed-off-by: Tvrtko Ursulin
On 2023-07-05 at 17:31:03 +0100, Tvrtko
Hi Tvrtko,
On 2023-07-05 at 17:31:04 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Define the storage structure and copy over memory data as parsed by the
> fdinfo helpers.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Rob Clark
> ---
> lib/igt_drm_clients.c | 31
ff-by: Tvrtko Ursulin
> Cc: Rob Clark
> Cc: Chris Healy
> Cc: Kamil Konieczny
> ---
> lib/igt_drm_clients.c | 32
> lib/igt_drm_clients.h | 11 +++
> 2 files changed, 43 insertions(+)
>
> diff --git a/lib/igt_drm_
gions, or allowing for the caller to pass
> in a map with predefined index to name relationship.
>
> v2:
> * Fix s-o-b and satisfy kernel checkpatch. (Kamil)
>
> Co-developed-by: Rob Clark
> Signed-off-by: Rob Clark
> Signed-off-by: Tvrtko Ursulin
> Cc: Kamil K
ff-by: Tvrtko Ursulin
> Cc: Rob Clark
> Cc: Chris Healy
> Cc: Kamil Konieczny
Thx for v2 with fix and reply, LGTM,
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_drm_clients.c | 32
> lib/igt_drm_clients.h | 11 +++
> 2 files
Hi Vinay,
small nit, see below.
On 2023-06-16 at 08:50:48 -0700, Vinay Belgaumkar wrote:
> Verify that SLPC API works as expected after a suspend. Added
> another subtest that does multiple GT resets and checks freq api
> works as expected after each one.
>
> We now check requested frequency
Hi Janusz,
On 2023-05-15 at 10:50:20 +0200, Janusz Krzysztofik wrote:
> Visible glitches have been observed when running graphics applications on
> Linux under Xen hypervisor. Those observations have been confirmed with
> failures from kms_pwrite_crc IGT test that verifies data coherency of DRM
Hi Vinay,
On 2024-01-04 at 17:10:00 -0800, Vinay Belgaumkar wrote:
looks good, there are some nits, first about subject:
[PATCH i-g-t] tests/perf_pmu: Restore sysfs freq in exit handler
s!tests/perf_pmu:!tests/intel/perf_pmu:!
Also you can drop "sysfs", so it will look:
[PATCH i-g-t]
> exit_handler necessitated moving drm_close() into the handler. However,
> the module-reload subtest at the end expects drm-fd to be closed.
> Also setup expected frequencies (Kamil) and address other nits (Kamil)
>
> Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9432
&
Hi Janusz,
On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote:
> Up to now we were loading a KUnit test module in test execution mode only
> once per subtest, in background, and then, in parallel with execution of
> test cases while the module was loading, we were looking through dmesg for
merical overlay would be skipped to.
>
> The bug would also shift the layout of following UI elements since the
> progress bar would not be consuming all the allocated horizontal space.
>
> Signed-off-by: Tvrtko Ursulin
> Reported-by: anonymoustranquill...@proton
e central
> location, and free it from a closing igt_fixture section before return.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c | 35 ---
> 1 file changed, 20 insertions(+), 15 deletions(-)
>
>
le
> free on final cleanup. For their convenience, teach igt_ktap_free() to
> accept that location as an argument and reset the pointer after freeing
> the structure.
>
> Signed-off-by: Janusz Krzysztofik
LGTM,
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c
g successful load of the KUnit test module in execution
> mode. Then, there is no need to set up a similar timeout before we start
> to extract and parse that report.
>
> Suggested-by: Kamil Konieczny
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib
of test cases
> from a single test suite or test module. Go for it.
>
> Signed-off-by: Janusz Krzysztofik
Reviewed-by: Kamil Konieczny
> ---
> lib/igt_kmod.c | 15 ++-
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/lib/igt_kmod.c b/
Hi Janusz,
On 2024-02-27 at 16:10:41 +0100, Janusz Krzysztofik wrote:
> Up to now we were loading a KUnit test module in test execution mode only
> once per subtest, in background, and then, in parallel with execution of
> test cases while the module was loading, we were looking through dmesg for
1 - 100 of 106 matches
Mail list logo
