Re: [Intel-gfx] Shutdown hooks

2019-05-16 Thread Krzysztofik, Janusz
On Wednesday, May 15, 2019 5:00:40 PM CEST Chris Wilson wrote: > Janus, some old patches that may be of use for shutdown prior to kexec. > -Chris Hi Chris, Thanks for sharing. I'm only not sure why you mentioned kexec. I have an impression someone else was talking about kexec recently so

Re: [Intel-gfx] [v7, 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:33 CEST Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all >

Re: [Intel-gfx] [v7, 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-21 Thread Krzysztofik, Janusz
Hi Andy, On Thursday, 20 July 2023 23:07:30 CEST Andi Shyti wrote: > We always assumed that a device might either have AUX or FLAT > CCS, but this is an approximation that is not always true If there exists a device that can have CCSs that fall into either none or both of those categories then

Re: [Intel-gfx] [v7, 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:35 CEST Andi Shyti wrote: > Commit af9e423a8aae You can't use this commit ID, it is invalid (the patch you are referring to belongs to your series, then is not available in any official repository, hence no stable commit ID yet). > ("drm/i915/gt:

Re: [Intel-gfx] [v7, 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:37 CEST Andi Shyti wrote: > Perform some refactoring with the purpose of keeping in one > single place all the operations around the aux table > invalidation. > > With this refactoring add more engines where the invalidation > should be performed. > >

Re: [Intel-gfx] [v7, 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:34 CEST Andi Shyti wrote: > Just a trivial refactoring for reducing the number of code > duplicate. This will come at handy in the next commits. > > Signed-off-by: Andi Shyti > Cc: # v5.8+ > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-26 Thread Krzysztofik, Janusz
On Tuesday, 26 March 2024 13:48:38 CET Badal Nilawar wrote: > i915_hwmon and its resources are managed resources of i915 dev. > During i915 driver unregister flow the function i915_hwmon_unregister() > explicitly makes i915_hwmon resource NULL. This happen before > hwmon is actually unregistered.

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-28 Thread Krzysztofik, Janusz
Hi Ashutosh, On Wednesday, 27 March 2024 21:37:19 CET Dixit, Ashutosh wrote: > On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > > > > Hi Janusz, > > > For me, that still doesn't explain why you think that i915->hwmon reset to > > NULL on i915

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-27 Thread Krzysztofik, Janusz
Hi Badal, On Wednesday, 27 March 2024 05:30:17 CET Nilawar, Badal wrote: > > On 27-03-2024 02:58, Krzysztofik, Janusz wrote: > > On Tuesday, 26 March 2024 13:48:38 CET Badal Nilawar wrote: > >> i915_hwmon and its resources are managed resources of i915 dev. > >>