Re: [Intel-gfx] [PATCH 4/5] Add support for forcing 6 bpc on DP pipes.

On Mon, May 23, 2016 at 10:42:41AM -0700, Jim Bride wrote: > On Mon, May 23, 2016 at 11:22:17AM +0300, Ander Conselvan De Oliveira wrote: > > On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: > > > From: Jim Bride <jim.br...@linux.intel.com> > > > > >

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Disable the Link training automation support

On Mon, May 23, 2016 at 11:10:24AM +0300, Ander Conselvan De Oliveira wrote: > On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: > > Kernel does not have automation support for DP compliance Link > > training tests. So the Link Training test handler should return

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement intel_dp_autotest_video_pattern function for DP Video pattern compliance tests

On Mon, May 23, 2016 at 03:00:20PM +0300, Ander Conselvan De Oliveira wrote: > On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: > > This video pattern test function gets invoked through the > > compliance test handler on a HPD short pulse if the test type is > > set to

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Fixes to support the DP Compliance EDID tests.

On Mon, May 23, 2016 at 11:18:20AM +0300, Ander Conselvan De Oliveira wrote: > On Fri, 2016-04-29 at 18:28 -0700, Manasi Navare wrote: > > This patch addresses a few issues from the original patch for > > DP Compliance EDID test support submitted by > > Todd Previte<todd.pr

Re: [Intel-gfx] [PATCH 4/5] Add support for forcing 6 bpc on DP pipes.

On Tue, May 24, 2016 at 08:45:45AM +0300, Ander Conselvan De Oliveira wrote: > On Mon, 2016-05-23 at 10:42 -0700, Jim Bride wrote: > > On Mon, May 23, 2016 at 11:22:17AM +0300, Ander Conselvan De Oliveira wrote: > > > > > > On Fri, 2016-04-29 at 18:28

[Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

Previte <tprev...@gmail.com>) Signed-off-by: Todd Previte <tprev...@gmail.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- tools/Makefile.sources |1 + tools/intel_dp_compliance.c | 1091 +++ 2 files change

[Intel-gfx] [PATCH 5/5] drm/i915: Implement intel_dp_autotest_video_pattern function for DP Video pattern compliance tests

be completed without the risk of interruption from the userspace app that is polling on that flag. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 14 ++- drivers/gpu/drm/i915/intel_dp.c | 76 + drivers/g

[Intel-gfx] [PATCH 1/5] drm/i915: Invoke the DP Compliance test request handler in the short pulse path

HPD Short pulse test requests occur for DP Compliance Link Training and Video Pattern tests.The DP Test request handler needs to be invoked by these tests in the short pulse path in order to support automated DP Compliance tests. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.

[Intel-gfx] [PATCH 2/5] drm/i915: Disable the Link training automation support

Kernel does not have automation support for DP compliance Link training tests. So the Link Training test handler should return a TEST_NAK. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] [PATCH 0/5] Add automation support for DP compliance Tests

This patch series adds the automation support for DP Compliance Tests for EDID and Video Pattern generation from CTS specification 1.2 Rev 1.1. Jim Bride (1): Add support for forcing 6 bpc on DP pipes. Manasi Navare (4): drm/i915: Invoke the DP Compliance test request handler in the short

[Intel-gfx] [PATCH 4/5] Add support for forcing 6 bpc on DP pipes.

; Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 32 ++-- drivers/gpu/drm/i915/intel_drv.h | 1 + 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/dr

[Intel-gfx] [PATCH 3/5] drm/i915: Fixes to support the DP Compliance EDID tests.

status should be connected even if detect_edid is NULL when compliance_test flag is set. This is required to handle the corrupt EDID (CTS 4.2.2.6) or EDID Read Failure I2C NACK/I2C DEFER (CTS 4.2.2.4 and 4.2.2.5) tests from CTS spec. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>

Re: [Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

Thanks for reviewing, I have a few comments/queries as below: Manasi On Thu, May 19, 2016 at 06:40:45PM +0300, Marius Vlad wrote: > On Mon, May 16, 2016 at 05:50:40PM -0700, Manasi Navare wrote: > > This is the userspace component of the Displayport Compliance > > testing so

[Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

m> Signed-off-by: Todd Previte <tprev...@gmail.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- tools/Makefile.sources |1 + tools/intel_dp_compliance.c | 1089 +++ 2 files changed, 1090 insertions(+)

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Move DP link retraining into intel_dp_detect()

On Thu, Jul 28, 2016 at 11:15:22PM +0300, Ville Syrjälä wrote: > On Thu, Jul 28, 2016 at 12:48:53PM -0700, Manasi Navare wrote: > > On Thu, Jul 28, 2016 at 05:50:43PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä <ville.syrj...@linux.inte

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Move DP link retraining into intel_dp_detect()

On Fri, Jul 29, 2016 at 12:52:55PM +0300, Ville Syrjälä wrote: > On Thu, Jul 28, 2016 at 05:36:14PM -0700, Manasi Navare wrote: > > On Thu, Jul 28, 2016 at 11:15:22PM +0300, Ville Syrjälä wrote: > > > On Thu, Jul 28, 2016 at 12:48:53PM -0700, Manasi Navare wrote: > > > &

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Move DP link retraining into intel_dp_detect()

On Thu, Jul 28, 2016 at 05:36:14PM -0700, Manasi Navare wrote: > On Thu, Jul 28, 2016 at 11:15:22PM +0300, Ville Syrjälä wrote: > > On Thu, Jul 28, 2016 at 12:48:53PM -0700, Manasi Navare wrote: > > > On Thu, Jul 28, 2016 at 05:50:43PM +0300, ville.syrj...@linux.inte

[Intel-gfx] [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link

of checking whether link is valid and training it independently. v2: * Changed the function name from intel_dp_check_link_status() to intel_dp_link_is_valid() (Lukas Wunner) * Checks for CRTC and active CRTC are moved outside the intel_dp_link_is_valid() function (Rodrigo Vivi) Signed-off-by: Manasi

Re: [Intel-gfx] [PATCH 0/9] Enable upfront link training on DDI platforms

This patch series had some git format-patch issues due to which it did not apply cleanly in CI system. So please disregard this patch set. I will be sending a new patch series for enabling upfront link training. Regards Manasi On Mon, Aug 08, 2016 at 07:33:09PM -0700, Manasi Navare wrote

Re: [Intel-gfx] [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link

On Fri, Aug 12, 2016 at 02:50:58PM -0700, Pandiyan, Dhinakaran wrote: > On Fri, 2016-08-12 at 10:56 -0700, Manasi Navare wrote: > > On Thu, Aug 11, 2016 at 08:18:54PM -0700, Pandiyan, Dhinakaran wrote: > > > On Thu, 2016-08-11 at 15:23 -0700, Manasi Navare wrote: > > &g

[Intel-gfx] [PATCH v3] drm/i915: intel_dp_link_is_valid() should only return status of link

CRTC are moved outside the intel_dp_link_is_valid() function (Rodrigo Vivi) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 53 ++--- 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/drivers/g

Re: [Intel-gfx] [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link

On Thu, Aug 11, 2016 at 08:18:54PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2016-08-11 at 15:23 -0700, Manasi Navare wrote: > > Intel_dp_link_is_valid() function reads the Link status registers > > and returns a boolean to indicate link is valid or not. > > If t

Re: [Intel-gfx] [PATCH] drm/i915: intel_dp_check_link_status should only return status of link

On Sat, Jul 02, 2016 at 11:29:05AM +0200, Lukas Wunner wrote: > On Fri, Jul 01, 2016 at 03:47:56PM -0700, Manasi Navare wrote: > > Intel_dp_check_link_status() function reads the Link status registers > > and returns a boolean to indicate link is good or bad. > &g

[Intel-gfx] [PATCH] drm/i915: intel_dp_link_is_valid() should only return status of link

intel_dp_check_link_status() to intel_dp_link_is_valid() (Lukas Wunner) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 44 +++-- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915: intel_dp_check_link_status should only return status of link

On Fri, Jul 01, 2016 at 05:35:25PM -0700, Rodrigo Vivi wrote: > On Fri, Jul 1, 2016 at 3:47 PM, Manasi Navare <manasi.d.nav...@intel.com> > wrote: > > Intel_dp_check_link_status() function reads the Link status registers > > and returns a boolean to indicate link is good

[Intel-gfx] [PATCH v2 4/9] drm/i915: Split intel_ddi_pre_enable() into DP and HDMI versions

From: Ander Conselvan de Oliveira Split intel_ddi_pre_enable() into encoder type specific versions that don't depend on crtc_state. The necessary parameters are passed as function arguments. This split will be necessary for implementing DP upfront link

[Intel-gfx] [PATCH 1/9] drm/i915: Don't pass crtc_state to intel_dp_set_link_params()

de Oliveira <ander.conselvan.de.olive...@intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c| 5 - drivers/gpu/drm/i915/intel_dp.c | 14 +- drivers/gpu/drm/i915/intel_dp_mst.c | 6 -- drivers/gpu/drm/

[Intel-gfx] [PATCH v8 5/9] drm/i915/dp: Enable Upfront link training for typeC DP support on BXT

pfront in intel_dp.c (Ville) Changes since v1: * all pll related functions inside ddi.c Signed-off-by: Durgadoss R <durgados...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 7/9] drm/i915/dp: Enable upfront link training on SKL

aining for Skylake. Signed-off-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 58 --- drivers/gpu/drm/i915/intel_dp.c | 4 +-- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 9/9] drm/i915: Enable upfront link training support for HSW/BDW

Get the PLLs for HSW/BDW using the platform specific function and add hooks for enabling upfront link training on HSW and BDW. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 2 ++ drivers/gpu/drm/i915/intel_dp.c | 4 +++- 2 files chan

[Intel-gfx] [PATCH 0/9] Enable upfront link training on DDI platforms

: Split intel_ddi_pre_enable() into DP and HDMI versions Durgadoss R (2): drm/i915: Split bxt_ddi_pll_select() drm/i915/dp: Enable Upfront link training for typeC DP support on BXT Jim Bride (2): drm/i915: Split skl_get_dpll() drm/i915/dp: Enable upfront link training on SKL Manasi Navare (2

[Intel-gfx] [PATCH 6/9] drm/i915: Split skl_get_dpll()

intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 131 +- drivers/gpu/drm/i915/intel_dpll_mgr.h | 4 ++ 2 files changed, 87 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dpl

[Intel-gfx] [PATCH v2 2/9] drm/i915: Remove ddi_pll_sel from intel_crtc_state

From: Ander Conselvan de Oliveira The value of ddi_pll_sel is derived from the selection of shared dpll, so just calculate the final value when necessary. v2: Actually remove it from crtc state and delete remaining usages. (CI) Reviewed-by: Durgadoss R

[Intel-gfx] [PATCH 8/9] drm/i915: Split hsw_get_dpll()

Split out the DisplayPort and HDMI pll setup code into separate functions and refactor the DP code that calculates the pll so that it doesn't depend on crtc state. This will be used for acquiring port pll when doing upfront link training. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.

[Intel-gfx] [PATCH v2 3/9] drm/i915: Split intel_ddi_pre_enable() into DP and HDMI versions

From: Ander Conselvan de Oliveira Split intel_ddi_pre_enable() into encoder type specific versions that don't depend on crtc_state. The necessary parameters are passed as function arguments. This split will be necessary for implementing DP upfront link

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Move DP link retraining into intel_dp_detect()

On Thu, Jul 28, 2016 at 05:50:43PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > DP link retraining needs to grab some modeset locks to not race with > modesets, so we can't really do it safely from the hpd_pulse, lest we > risk deadlocking

Re: [Intel-gfx] [CI 4/4] drm/i915: Split bxt_ddi_pll_select()

esn't depend on > crtc state. This will be used for enabling the port pll when doing > upfront link training. > > v2: > * Refactored code so that bxt_clk_div need not be exported (Durga) > v1: > * Rebased on top of intel_dpll_mgr.c (Durga) > * Initial version from Ander on top of inte

[Intel-gfx] [PATCH v2 4/9] drm/i915: Split bxt_ddi_pll_select()

From: Durgadoss R Split out of bxt_ddi_pll_select() the logic that calculates the pll dividers and dpll_hw_state into a new function that doesn't depend on crtc state. This will be used for enabling the port pll when doing upfront link training. v2: * Refactored code so

[Intel-gfx] [PATCH 9/9] drm/i915: Enable upfront link training support for HSW/BDW

Get the PLLs for HSW/BDW using the platform specific function and add hooks for enabling upfront link training on HSW and BDW. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 2 ++ drivers/gpu/drm/i915/intel_dp.c | 4 +++- 2 files chan

[Intel-gfx] [PATCH v8 5/9] drm/i915/dp: Enable Upfront link training for typeC DP support on BXT

pfront in intel_dp.c (Ville) Changes since v1: * all pll related functions inside ddi.c Signed-off-by: Durgadoss R <durgados...@intel.com> Signed-off-by: Jim Bride <jim.br...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH v2 3/9] drm/i915: Split intel_ddi_pre_enable() into DP and HDMI versions

From: Ander Conselvan de Oliveira Split intel_ddi_pre_enable() into encoder type specific versions that don't depend on crtc_state. The necessary parameters are passed as function arguments. This split will be necessary for implementing DP upfront link

[Intel-gfx] [PATCH 8/9] drm/i915: Split hsw_get_dpll()

Split out the DisplayPort and HDMI pll setup code into separate functions and refactor the DP code that calculates the pll so that it doesn't depend on crtc state. This will be used for acquiring port pll when doing upfront link training. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.

[Intel-gfx] [PATCH v2 2/9] drm/i915: Remove ddi_pll_sel from intel_crtc_state

From: Ander Conselvan de Oliveira The value of ddi_pll_sel is derived from the selection of shared dpll, so just calculate the final value when necessary. v2: Actually remove it from crtc state and delete remaining usages. (CI) Reviewed-by: Durgadoss R

[Intel-gfx] [PATCH 1/9] drm/i915: Don't pass crtc_state to intel_dp_set_link_params()

From: Ander Conselvan de Oliveira Decouple intel_dp_set_link_params() from struct intel_crtc_state. This will be useful for implementing DP upfront link training. Reviewed-by: Durgadoss R Signed-off-by: Ander Conselvan de Oliveira

[Intel-gfx] [PATCH 0/9] Enable upfront link training on DDI platforms

: Split intel_ddi_pre_enable() into DP and HDMI versions Durgadoss R (2): drm/i915: Split bxt_ddi_pll_select() drm/i915/dp: Enable Upfront link training for typeC DP support on BXT Jim Bride (2): drm/i915: Split skl_get_dpll() drm/i915/dp: Enable upfront link training on SKL Manasi Navare (2

[Intel-gfx] [PATCH 7/9] drm/i915/dp: Enable upfront link training on SKL

From: Jim Bride Split the PLL selection code out of the BXT upfront link training implementation and into a stand-alone function in order to allow for the implementation of a platform neutral upfront link training function, and then enable upfront link training for

[Intel-gfx] [PATCH] drm/i915: intel_dp_check_link_status should only return status of link

Intel_dp_check_link_status() function reads the Link status registers and returns a boolean to indicate link is good or bad. If the link is bad, it is retrained outside the function based on the return value. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/dr

[Intel-gfx] DP Compliance Link Training tests failures

I have been working on getting the instrumentation in the kernel so that we run the DP compliance tests using DPR 120. After adding the necessary code in the kernel, I am able to run the DP Compliance test suite against our driver. According to the DP Spec 1.2 and the Compliance tests, for link

Re: [Intel-gfx] [PATCH v1½ 00/13] drm/i915/dp: link rate and lane count refactoring

On Wed, Feb 01, 2017 at 11:40:06AM -0800, Manasi Navare wrote: > Are you planning on submitting a v2 for these pretty soon > that can make it to patchwork/ > > Regards > Manasi > > On Thu, Jan 26, 2017 at 09:44:14PM +0200, Jani Nikula wrote: > > This is kind of versio

Re: [Intel-gfx] [PATCH v1½ 12/13] drm/i915/dp: localize link rate index variable more

On Thu, Jan 26, 2017 at 09:44:26PM +0200, Jani Nikula wrote: > Localize link_rate_index to the if block, and rename to just index to > reduce indent. > > Cc: Manasi Navare <manasi.d.nav...@intel.com> > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > Signed

[Intel-gfx] Do no reset the max link parameters when userspace reprobes modes

Hi, I am working on a solution for handling link failures during or after the modeset. In case of link failure, the max link rate/lane count values are updated to lower link rate/lane count as per the spec and uevent is sent to the userspace with link-status BAD. The userspace is expected to

Re: [Intel-gfx] [PATCH v2 12/13] drm/i915/dp: localize link rate index variable more

This has been tested to correctly execute the compliance request. Reviewed-by: Manasi Navare <manasi.d.nav...@intel.com> Manasi On Fri, Feb 03, 2017 at 04:19:35PM +0200, Jani Nikula wrote: > Localize link_rate_index to the if block, and rename to just index to > reduce indent. >

Re: [Intel-gfx] [PATCH v2 00/13] drm/i915/dp: link rate and lane count refactoring

the problem of max link rate/lane count getting reset through ->detect callback from fill_modes(), but that will be fixed in a separate patch. As far as these patches, the fallback and compliance works properly: Tested-by: Manasi Navare <manasi.d.nav...@intel.com> Manasi On Fri, Feb 03, 2017

[Intel-gfx] [PATCH] drm/i915/dp: Reset the link params on HPD/connected boot/resume

detect() calls. This is important when link training fails and the max link params are modified to the lower fallback values. Cc: Ville Syrjala <ville.syrj...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 16 ---

[Intel-gfx] [PATCH] drm/i915/dp: Clean up/Get rid of detect_done flag

calls to .detect() Cc: Ville Syrjala <ville.syrj...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- drivers/gpu/drm/i915/intel_dp.c | 10 +- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a

Re: [Intel-gfx] [PATCH v1½ 00/13] drm/i915/dp: link rate and lane count refactoring

Are you planning on submitting a v2 for these pretty soon that can make it to patchwork/ Regards Manasi On Thu, Jan 26, 2017 at 09:44:14PM +0200, Jani Nikula wrote: > This is kind of version 1½ of [1], basically just rebased on current git > (including Manasi's test automation patches) and a

Re: [Intel-gfx] [PATCH v1½ 12/13] drm/i915/dp: localize link rate index variable more

On Thu, Feb 02, 2017 at 10:42:48AM +0200, Jani Nikula wrote: > On Thu, 02 Feb 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > On Thu, Jan 26, 2017 at 09:44:26PM +0200, Jani Nikula wrote: > >> Localize link_rate_index to the if block, and rename to just ind

Re: [Intel-gfx] [PATCH i-g-t v4] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

ouble checked and tested with this tool. These changes are already part of the i915 kernel defined in drm_dp-helper.h. So we are good to go! Regards Manasi > On Mon, Jan 23, 2017 at 06:48:53PM -0800, Manasi Navare wrote: > > From: "Navare, Manasi D" <manasi.d.nav...@intel.com

[Intel-gfx] [PATCH v5 1/4] drm/i915: Add support for DP link training compliance

(Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> --- drivers/gpu/d

[Intel-gfx] [PATCH v4 4/4] drm/i915: Add support for DP Video pattern compliance tests

(Jani Nikula) v4: *Return TEST_NAK on read failures and invalid values (Jani Nikula) * Address CRC mismatch errors v3: * Use the updated properly shifted bit definitions (Jani Nikula) * Force dithering to be disabled on 18bpp compliance test request (Manasi Navare) v2: * Updated the DPCD Register

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

On Tue, Jan 24, 2017 at 06:40:51PM +0200, Jani Nikula wrote: > On Mon, 23 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > As far as I know, I have addressed the review comments from previous > > round and answered the questions/concerns that you had either in

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: do not proceed with autotests if we don't ACK them

if we're about to NAK the request. Some > drive-by cleanups while at it. > > v2: look at the ACK bit, as the result may also contain > TEST_EDID_CHECKSUM_WRITE > Reviewed-by: Manasi Navare <manasi.d.nav...@intel.com> Tested-by: Manasi Navare <manasi.d.nav...@intel.com&g

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

Thanks Jani for reviewing this patch and for your feedback. Its very useful feedback and below are some of my comments: On Fri, Jan 20, 2017 at 05:05:03PM +0200, Jani Nikula wrote: > On Fri, 20 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > This patch adds su

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

On Mon, Jan 23, 2017 at 12:50:07PM -0800, Manasi Navare wrote: > Thanks Jani for reviewing this patch and for your feedback. > Its very useful feedback and below are some of my comments: > > On Fri, Jan 20, 2017 at 05:05:03PM +0200, Jani Nikula wrote: > > On Fri, 20 Jan 2

[Intel-gfx] [PATCH i-g-t v4] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

e the compliance tests. This app is based on some prior work done in April 2015 (by Todd Previte <tprev...@gmail.com>) v2: * Add mode unset on hotplug uevent on disconnect (Manasi Navare) v3: Made capitalization consistent Reduced line lengths Added return value checks Changed how GLib

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

errors v3: * Use the updated properly shifted bit definitions (Jani Nikula) * Force dithering to be disabled on 18bpp compliance test request (Manasi Navare) v2: * Updated the DPCD Register reads based on proper defines in header (Jani Nikula) * Squahsed the patch that forced the pipe bpp to compliance

[Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

aniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- include/drm/drm_dp_helper.h | 57 + 1 file changed, 57 insertions(+) diff --git a/include/drm/drm_d

[Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

d read debugfs data from test_data.edid if its EDID test (Jani NIkula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> --- drive

[Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

if it is a 18bpp compliance test request. Manasi Navare (4): drm/i915: Add support for DP link training compliance drm/i915: Fixes to support DP Compliance EDID tests drm: Add definitions for DP compliance Video pattern tests drm/i915: Add support for DP Video pattern compliance tests drivers/gpu

[Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

: * Validate the test link rate and lane count as soon as the request comes (Jani Nikula) v2: * Validate the test lane count before using it in intel_dp_compute_config (Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: D

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

On Fri, Jan 20, 2017 at 06:27:29PM +0200, Martin Peres wrote: > On 19/01/17 13:34, Ville Syrjälä wrote: > >On Wed, Jan 18, 2017 at 11:05:18PM +0200, Martin Peres wrote: > >>On 16/12/16 15:48, Daniel Vetter wrote: > >>>On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote: > The two

[Intel-gfx] [PATCH v2] drm: Add DPCD definitions for DP 1.4 DSC feature

Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. v2: * Rebased on drm-tip Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Paulo Zanoni

Re: [Intel-gfx] [PATCH] drm/i915/dp: Reset the link params on HPD/connected boot/resume

On Tue, Feb 14, 2017 at 09:08:25PM +0200, Ville Syrjälä wrote: > On Tue, Feb 07, 2017 at 04:54:11PM -0800, Manasi Navare wrote: > > The max link parameters should be set/reset only on HPD or > > connected boot case or on system resume. > > > > Add a flag reset_link_p

[Intel-gfx] [PATCH] drm: Add DPCD definitions for DP 1.4 DSC feature

Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.com>

Re: [Intel-gfx] [PATCH] drm/i915/dp: Reset the link params on HPD/connected boot/resume

you please take a look at this when you get a chance and let me know if anything else is required. Regards Manasi On Tue, Feb 07, 2017 at 04:54:11PM -0800, Manasi Navare wrote: > The max link parameters should be set/reset only on HPD or > connected boot case or on system resume. > >

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Apparently some DP sinks are a little nuts and cause HPD to drop > intermittently during modesets. This happens eg. on an ASUS PB287Q. > In oder to recover from

Re: [Intel-gfx] [PATCH] drm/i915: Perform link quality check unconditionally during long pulse

On Thu, Feb 16, 2017 at 07:18:57PM +0200, Ville Syrjälä wrote: > On Thu, Feb 16, 2017 at 09:07:53AM -0800, Manasi Navare wrote: > > On Thu, Feb 16, 2017 at 05:30:07PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä <ville.syrj...@linux.intel.c

[Intel-gfx] [PATCH] drm: Add DPCD definitions for DP 1.4 DSC feature

Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Paulo Zanoni <paulo.r.zan...@intel.

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

On Sat, Jan 21, 2017 at 05:16:42PM +0200, Jani Nikula wrote: > On Sat, 21 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > This patch series addresses all the review comments from the previous > > series: > > https://patchwork.freedesktop.org

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

On Mon, Jan 23, 2017 at 09:05:02AM -0800, Manasi Navare wrote: > On Sat, Jan 21, 2017 at 05:16:42PM +0200, Jani Nikula wrote: > > On Sat, 21 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > > This patch series addresses all the review comments from th

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

lag for connector disconnected case too. (DK) > Commit message changes. > > Cc: sta...@vger.kernel.org > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Ander Conselvande Oliveira <ander.conselvan.de.olive...@intel.com> > Cc: Jani Nikula <jani.nik...@linux.i

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

of interruption from the userspace app that is polling on that flag. v2: * Updated the DPCD Register reads based on proper defines in header (Jani Nikula) * Squahsed the patch that forced the pipe bpp to compliance test bpp (Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc

[Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

v2: * Add all the other DP Complianec TEST register defs (Jani Nikula) Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> Signed-off-by: Manasi Na

[Intel-gfx] [PATCH 0/4] Add Automation Support for DP Compliance Testing (Rev 4)

tool, userspace reads the video pattern values from corresponding debugfs files and fills the framebuffers and triggers a modeset. Manasi Navare (4): drm/i915: Add support for DP link training compliance drm/i915: Fixes to support DP Compliance EDID tests drm: Add definitions for DP compliance

[Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

is sent in order to trigger another modeset during which the pipe is configured and link is retrained and enabled for link parameters requested by the test. v2: * Validate the test lane count before using it in intel_dp_compute_config (Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.

[Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

d read debugfs data from test_data.edid if its EDID test (Jani NIkula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> --- drive

Re: [Intel-gfx] DP compliance failure due to dithering for 18bpp video pattern

On Fri, Jan 13, 2017 at 09:11:49AM +0200, Jani Nikula wrote: > On Fri, 13 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote: > > On Thu, Jan 12, 2017 at 03:41:07PM -0800, Rodrigo Vivi wrote: > >> On Thu, Jan 12, 2017 at 3:30 PM, Manasi Navare > >>

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

Hi Jani, Could you please review this patch? I have added the lane count checking and other review comments you had. Is there anything else that is blocking from getting this patch merged? Regards Manasi On Tue, Jan 17, 2017 at 02:57:12PM -0800, Manasi Navare wrote: > This patch adds supp

Re: [Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

Manasi On Tue, Jan 17, 2017 at 02:57:14PM -0800, Manasi Navare wrote: > v2: > * Add all the other DP Complianec TEST register defs (Jani Nikula) > Cc: dri-de...@lists.freedesktop.org > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Daniel Vetter <daniel.vet...@intel.

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

Hi Jani, This is another simple patch that only changed EDID test to PREFERRED vs STANDARD as per the CTS spec. Is there anything else that is blocking this patch getting merged? Regards Manasi On Tue, Jan 17, 2017 at 02:57:13PM -0800, Manasi Navare wrote: > This patch addresses a few iss

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

Hi Jani, Could you please review this patch? All your previous review comments are addressed. Is there anything else that is blocking this patch from getting merged? Regards Manasi On Tue, Jan 17, 2017 at 02:57:15PM -0800, Manasi Navare wrote: > The intel_dp_autotest_video_pattern() funct

Re: [Intel-gfx] [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

gt; > sysfs nodes for kernel interaction, this utility should be run as > > Root. Once this user application is up and running, waiting for > > test requests, the test appliance software on the windows host > > can now be used to execute the compliance tests. > > > > This

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

On Thu, Jan 19, 2017 at 09:26:36PM +0200, Ville Syrjälä wrote: > On Thu, Jan 19, 2017 at 11:01:01AM -0800, Manasi Navare wrote: > > On Thu, Jan 19, 2017 at 03:42:34PM +0200, Ville Syrjälä wrote: > > > On Tue, Jan 17, 2017 at 09:40:42AM -0800, Manasi Navare wrote: > > > &

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

On Thu, Jan 19, 2017 at 03:42:34PM +0200, Ville Syrjälä wrote: > On Tue, Jan 17, 2017 at 09:40:42AM -0800, Manasi Navare wrote: > > I have verified this patch with the latest drm-tip and it is also > > absolutely necessary to ensure the link gets properly retrained > > aft

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: Do not reset detect_done flag in intel_dp_detect

On Thu, Jan 19, 2017 at 09:59:54PM +0200, Ville Syrjälä wrote: > On Thu, Jan 19, 2017 at 11:38:56AM -0800, Manasi Navare wrote: > > On Thu, Jan 19, 2017 at 09:26:36PM +0200, Ville Syrjälä wrote: > > > On Thu, Jan 19, 2017 at 11:01:01AM -0800, Manasi Navare wrote: > > > &

[Intel-gfx] [PATCH 4/4] drm/i915: Add support for DP Video pattern compliance tests

to be disabled on 18bpp compliance test request (Manasi Navare) v2: * Updated the DPCD Register reads based on proper defines in header (Jani Nikula) * Squahsed the patch that forced the pipe bpp to compliance test bpp (Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani

[Intel-gfx] [PATCH 2/4] drm/i915: Fixes to support DP Compliance EDID tests

d read debugfs data from test_data.edid if its EDID test (Jani NIkula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> --- drive

[Intel-gfx] [PATCH 3/4] drm: Add definitions for DP compliance Video pattern tests

<ville.syrj...@linux.intel.com> Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> --- include/drm/drm_dp_helper.h | 64 + 1 file changed, 64 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 0468135..7ab4

[Intel-gfx] [PATCH 1/4] drm/i915: Add support for DP link training compliance

it in intel_dp_compute_config (Jani Nikula) Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> --- drivers/gpu/d

[Intel-gfx] [PATCH 0/4] Add Automation Support for DP Compliance (Rev 5)

, then we force the dither to be off so that CRC for the RGB pixels of the rendered video pattern matches the expected CRC. Manasi Navare (4): drm/i915: Add support for DP link training compliance drm/i915: Fixes to support DP Compliance EDID tests drm: Add definitions for DP compliance Video

  1   2   3   4   5   6   7   8   9   10   >