Re: [PHP-DEV] apache and MSHUTDOWN

2008-03-18 Thread Antony Dovgal
On 03/17/2008 10:43 PM, ati wrote: hi, what is the correct behavior, if apache killing _idle_ child processes in an environment where: apache prefork_mpm php loaded as apache module php loads a module with extension=xy.so should be the msshutdown function called for each httpd child or

Re: [PHP-DEV] Patch for opcode caches

2008-03-18 Thread Dmitry Stogov
The patch has been just committed. You should use something like the following code to make it work. function cache_compile_file($filename) { if (!is_cached($filename)) { ... orig_compiler_options = CG(compiler_optins);

Re: [PHP-DEV] Dropping ze1_compatibility_mode (PHP 5.3)

2008-03-18 Thread Felipe Pena
Hallo developers, Have we a decision? 2008/3/11, Cristian Rodriguez [EMAIL PROTECTED]: 2008/3/10, Felipe Pena [EMAIL PROTECTED]: Hello! I've backported the Dmitry's patch (HEAD) for to drop zend.ze1_compatibility_mode in PHP_5_3 branch. Would be interesting remove it in 5_3?

Re: [PHP-DEV] Dropping ze1_compatibility_mode (PHP 5.3)

2008-03-18 Thread Dmitry Stogov
Drop it. Dmitry. Felipe Pena wrote: Hallo developers, Have we a decision? 2008/3/11, Cristian Rodriguez [EMAIL PROTECTED]: 2008/3/10, Felipe Pena [EMAIL PROTECTED]: Hello! I've backported the Dmitry's patch (HEAD) for to drop zend.ze1_compatibility_mode in PHP_5_3 branch. Would

Re: [PHP-DEV] Dropping ze1_compatibility_mode (PHP 5.3)

2008-03-18 Thread Xuefer
On Tue, Mar 18, 2008 at 10:10 PM, Dmitry Stogov [EMAIL PROTECTED] wrote: Drop it. Dmitry. php5/ext/pdo/pdo_dbh.c:1530: error: 'zend_executor_globals' has no member named 'ze1_compatibility_mode' sorry for the noise again, who's responsive to extension relatived to this change? there're more if

Re: [PHP-DEV] Dropping ze1_compatibility_mode (PHP 5.3)

2008-03-18 Thread Antony Dovgal
On 03/18/2008 05:41 PM, Xuefer wrote: php5/ext/pdo/pdo_dbh.c:1530: error: 'zend_executor_globals' has no member named 'ze1_compatibility_mode' Fixed, check it out again. sorry for the noise again, who's responsive to extension relatived to this change? there're more if you grep the source,

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Andrei Zmievski
Why would we not want to stop on illegal sequences? -Andrei Stephen Bach wrote: Attached is a simple proposed patch that fixes Bug 43477. Basically, the code that set the error mode of the ICU converter was giving it an instruction (the context parameter) to only skip or substitute if the

Re: [PHP-DEV] setjmp usage

2008-03-18 Thread Stanislav Malyshev
Hi! We are using setjmp(__bailout) in zend_try, but setjmp behaves differently on BSD and Linux. POSIX doesn't specify whether the signal mask should be saved or not for this call, so different operating systems do different things here. I think it would be more consistent if we used

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Geoffrey Sneddon
On 18 Mar 2008, at 17:43, Andrei Zmievski wrote: Why would we not want to stop on illegal sequences? Stuff relies on things _not_ stopping. No web browser stops on an illegal sequence: they all use some replacement character (U+FFFD REPLACEMENT CHARACTER in most). Sure, idealists will

[PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)

2008-03-18 Thread Mike Lively
On Thu, Mar 13, 2008 at 6:48 AM, Mike Lively [EMAIL PROTECTED] wrote: New patches can be found at http://www.digitalsandwich.com/Patches/index.html I have fixed the forward_static_call (I am not attached to the name and am open to suggestions) patch to use a callable. In doing this I also

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Stephen Bach
I'm just suggesting that other error modes should do what they claim to do. Stopping on an illegal sequence is fine, unless the user had called a function telling the converter to do something else. U_CONV_ERROR_STOP: stops on illegal character (the default) U_CONV_ERROR_ESCAPE_*: 5 different

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Geoffrey Sneddon
On 18 Mar 2008, at 19:37, Stephen Bach wrote: Shouldn't U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST work the same way? I guess: U_CONV_ERROR_SKIP is just U_CONV_ERROR_SUBST with the substitution string as nothing, though I expect slight speed gains could be made by keeping them separate

Re: [PHP-DEV] [PATCH] Bug 43477 - Unicode error mode ignored

2008-03-18 Thread Stephen Bach
Sorry for the ambiguity. Allow me to clarify: I meant that U_CONV_ERROR_SKIP and U_CONV_ERROR_SUBST should work the same as the other error modes. Otherwise, what's the point of having them? -Stephen On Tuesday 18 March 2008 06:02:36 pm Geoffrey wrote: On 18 Mar 2008, at 19:37, Stephen Bach

Re: [PHP-DEV] apache and MSHUTDOWN

2008-03-18 Thread ati
On Tue, 2008-03-18 at 11:48 +0300, Antony Dovgal wrote: On 03/17/2008 10:43 PM, ati wrote: should be the msshutdown function called for each httpd child or only once if the whole httpd server shuts down? Since Apache children are separate processes, they have their own shutdown

Re: [PHP-DEV] Re: [PATCH] LSB - new patches for forward_static_call and parent:: forwarding (was: 5.3 Release Planning)

2008-03-18 Thread Etienne Kneuss
Hello, the forward_static_call looks like a decent non-intrusive solution, and your patch looks good from what I can tell! I guess you should commit it so it can be documented and all. regards On Tue, Mar 18, 2008 at 7:55 PM, Mike Lively [EMAIL PROTECTED] wrote: On Thu, Mar 13, 2008 at 6:48

[PHP-DEV] Re: cvs: php-src(PHP_5_3) /main SAPI.c SAPI.h main.c php_globals.h /sapi/apache mod_php5.c ZendEngine2 zend_execute.h zend_execute_API.c

2008-03-18 Thread Edward Z. Yang
Rasmus Lerdorf wrote: exit_on_timeout patch Hi Rasmus, I noticed that this patch modifies the Zend Engine API slightly. Does this translate into any changes that need documentation at php.net? -- Edward Z. YangGnuPG: 0x869C48DA HTML Purifier http://htmlpurifier.org

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) /main SAPI.c SAPI.h main.c php_globals.h /sapi/apache mod_php5.c ZendEngine2 zend_execute.h zend_execute_API.c

2008-03-18 Thread Rasmus Lerdorf
Edward Z. Yang wrote: Rasmus Lerdorf wrote: exit_on_timeout patch Hi Rasmus, I noticed that this patch modifies the Zend Engine API slightly. Does this translate into any changes that need documentation at php.net? No, I don't think so. I checked all extensions in php cvs, including

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) /main SAPI.c SAPI.h main.c php_globals.h /sapi/apache mod_php5.c ZendEngine2 zend_execute.h zend_execute_API.c

2008-03-18 Thread Edward Z. Yang
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Rasmus Lerdorf wrote: No, I don't think so. I checked all extensions in php cvs, including pecl, and none of them call zend_set_timeout() which is the function that was changed. And I can't see any foreign extension needing to call that function