Re: [PHP-DEV] problem with apache segfault

2009-03-27 Thread William A. Rowe, Jr.
jvlad wrote: #2 0x2c145afb in apr_pool_destroy () from /usr/lib64/libapr-1.so.0 No symbol table info available. See http://httpd.apache.org/dev/debugging.html on how to grab the -win32-symbols.zip package. Unpack it over httpd and you will probably have more legible backtraces.

Re: [PHP-DEV] request for comments on threadsafe / multi-thread enabled Embed2 SAPI

2009-03-27 Thread Bas van Beek
Hello Moriyoshi, Op 27 mrt 2009, om 03:38 heeft Moriyoshi Koizumi het volgende geschreven: Isn't it better to avoid any behaviour-changing #define's in a header file? I mean the following series of lines in php_embed2.h: I agree... I have moved the defines and inclusion of php_smart_str.h

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Hannes Magnusson
2009/3/27 Felipe Pena felipe...@gmail.com: Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no mail will be sent. [...] +      (Felipe, Steph) Kudos!! -Hannes -- PHP

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Scott MacVicar
David Coallier wrote: 2009/3/27 Hannes Magnusson hannes.magnus...@gmail.com: 2009/3/27 Felipe Pena felipe...@gmail.com: Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Sebastian Bergmann
Felipe Pena schrieb: + - Removed: + - UG(unicode) checks + - pcre_cache_entry.unicode_mode + - Changed: + - ZEND_STR_TYPE - IS_UNICODE + - convert_to_text - convert_to_unicode + - convert_to_text_ex -

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread David Coallier
2009/3/27 Hannes Magnusson hannes.magnus...@gmail.com: 2009/3/27 Felipe Pena felipe...@gmail.com: Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no mail will be sent. [...]

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Felipe Pena
Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no mail will be sent. +* ZendEngine2/zend.c + ZendEngine2/zend.h + ZendEngine2/zend_API.c +

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread David Coallier
2009/3/27 Sebastian Bergmann s...@sebastian-bergmann.de: Felipe Pena schrieb: +      - Removed: +             - UG(unicode) checks +             - pcre_cache_entry.unicode_mode +      - Changed: +             - ZEND_STR_TYPE - IS_UNICODE +             - convert_to_text - convert_to_unicode

[PHP-DEV] Fw: problem with apache segfault

2009-03-27 Thread rats1027-phpmaillinglist
thank you so much all of you guys, but still we are facing the same problem. we recompiled new php source, upgraded httpd to 2.2.11 but still getting same backtrace. nothing more. we removed .htaccess rules and tested but no use. can you guys suggest me any other ways of debugging pls?

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Steph
Felipe Pena wrote: Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no mail will be sent. I'd given up hope of ever seeing that reach CVS :) Thanks Felipe! - Steph -- PHP

[PHP-DEV] Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Josef Šimánek
My first patch (very easy). I have one more idea about this. The text will stay in intputbox only if not found. What do you think ? Bug is mentioned here : http://bugs.php.net/bug.php?id=40698 I was studying bug tracker code, because of GSOC. I want to join one idea about bug tracker (improve

[PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Josef Šimánek
Sorry, forgot to post diff file inside message (I attached it only). Index: php-bugs-web/include/layout.inc --- php-bugs-web/include/layout.inc Base (1.33) +++ php-bugs-web/include/layout.inc Locally Modified (Based On 1.33) @@ -220,7 +220,7 @@ input type=hidden name=cmd value=display /

Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Mike Bretz
Hello Josef, I think nobody will refuse you to join efforts to make everything better... but this patch I would not use to make this specific page better. You managed to break the page with this patch since you do not escape the output of the user supplied input variable. This is a simple

Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Stefan Esser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Josef, before you want to commit something to the PHP bugs website, you should recheck your code for obvious XSS bugs in it... +input class=small type=text name=search_for value=?php if(isset($_GET['search_for'])) echo

Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Philip Olson
Greetings Josef, Nice, you're already looking at code and proposing patches! :) My first patch (very easy). I have one more idea about this. The text will stay in intputbox only if not found. What do you think ? Bug is mentioned here : http://bugs.php.net/bug.php?id=40698 Seems logical,

Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Josef Šimánek
ok, but Mike Bretz wrote that it will be better to mark this bug as Bogus according to all browsers auto-form completion function. This patch was written very fast, without thinking. Next time I spend more time to focus on security. ok, what about these bugs : http://bugs.php.net/bug.php?id=46663

Re: [PHP-DEV] Re: Bug #40698 Re-use search term in the quicksearch input field

2009-03-27 Thread Kalle Sommer Nielsen
Hi Josef 2009/3/27 Josef Šimánek retri...@gmail.com: ok, but Mike Bretz wrote that it will be better to mark this bug as Bogus according to all browsers auto-form completion function. This patch was written very fast, without thinking. Next time I spend more time to focus on security. ok,