[PHP-DEV] Replace a builtin function

2009-09-03 Thread Aron Szabo
Hello! Is it possible to replace an existing PHP function ( like mail() ) in an extension. I've been patching PHP to have a custom mail() function, but I think replacing the mail function with an extension would be better and will save a lot of time. Can somebody give me a clue or an

Re: [PHP-DEV] Replace a builtin function

2009-09-03 Thread Johannes Schlüter
Hi, On Thu, 2009-09-03 at 11:12 +0200, Aron Szabo wrote: Hello! Is it possible to replace an existing PHP function ( like mail() ) in an extension. Look for the implementation of disable_functions. (zend_disable_function() in zend_API.c) johannes -- PHP Internals - PHP Runtime

Re: [PHP-DEV] Replace a builtin function

2009-09-03 Thread Derick Rethans
On Thu, 3 Sep 2009, Aron Szabo wrote: Hello! Is it possible to replace an existing PHP function ( like mail() ) in an extension. I've been patching PHP to have a custom mail() function, but I think replacing the mail function with an extension would be better and will save a lot of time.

Re: [PHP-DEV] Replace a builtin function

2009-09-03 Thread Aron Szabo
Thanks Johannes Derick ! I see the light now :D Yours, Aron Derick Rethans wrote: On Thu, 3 Sep 2009, Aron Szabo wrote: Hello! Is it possible to replace an existing PHP function ( like mail() ) in an extension. I've been patching PHP to have a custom mail() function, but I think

Re: [PHP-DEV] ReflectionMethod::setAccessible()

2009-09-03 Thread Sebastian Bergmann
Sebastian Bergmann schrieb: The patch below adds the ReflectionMethod::setAccessible() method and adds support for the ignore_visibility flag that is controlled by this method to ReflectionMethod::invoke() and ReflectionMethod::invokeArgs(). The patch complements

Re: [PHP-DEV] ReflectionMethod::setAccessible()

2009-09-03 Thread Pierre Joye
hi Sebastian, I like the idea, a definitive +1. I did not check the implementation yet however I'd to say that I'm not in favor of including it in 5.3.1 (for obvious reasons). Cheers, On Wed, Sep 2, 2009 at 9:48 PM, Sebastian Bergmanns...@sebastian-bergmann.de wrote:  The patch below adds

[PHP-DEV] Consistent error messages in ReflectionMethod::invokeArgs()

2009-09-03 Thread Sebastian Bergmann
http://gist.github.com/180226 makes the error messages of ReflectionMethod::invokeArgs() consistent with those of ReflectionMethod::invoke(). Any objections? -- Sebastian BergmannCo-Founder and Principal Consultant http://sebastian-bergmann.de/

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /win32/build template.rc

2009-09-03 Thread Richard Quadling
2008/11/4 Steph Fox st...@php.net: How you got both files is beyond me - winres.h is not present in either the 2003 sdk or the 6.1 sdk (used with VC6 and VC9 respectively) - our current instructions for building involve renaming header files in the sdk which is a very silly thing. Nah, it'll

[PHP-DEV] Timezone for php_error_log.

2009-09-03 Thread Richard Quadling
Hi. I've been playing with the MS SQL Server driver (https://sqlsrvphp.svn.codeplex.com/svn). Using this code (editing it to work with the default WinResrc.h rather than the winres.h it is currently asking for) ... AND ... turning on the logging via the ini file (as I was playing I just wanted

Re: [PHP-DEV] Timezone for php_error_log.

2009-09-03 Thread Jani Taskinen
Errors output from MINIT can not and will not ever have any other timezone than what is the system's timezone. If you're reporting a bug, please do it at http://bugs.php.net/. Anyways the code in sqlsrv is pretty horrible. I'd cleanup that mess first. Unless of course you can reproduce same

[PHP-DEV] Secure SVN access

2009-09-03 Thread techtonik
Greeetings to php-core developers, Am I right that there is no https:// and svn+ssh:// access to svn.php.net repositories? If that's the case - how do you feel about sniffing developer's passwords? Please, CC. --anatoly t. -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] Timezone for php_error_log.

2009-09-03 Thread Richard Quadling
2009/9/3 Jani Taskinen jani.taski...@iki.fi: Errors output from MINIT can not and will not ever have any other timezone than what is the system's timezone. If you're reporting a bug, please do it at http://bugs.php.net/. Anyways the code in sqlsrv is pretty horrible. I'd cleanup that mess

Re: [PHP-DEV] Secure SVN access

2009-09-03 Thread Scott MacVicar
On 3 Sep 2009, at 13:48, techtonik wrote: Greeetings to php-core developers, Am I right that there is no https:// and svn+ssh:// access to svn.php.net repositories? If that's the case - how do you feel about sniffing developer's passwords? We use Digest authentication so while they are

RE: [PHP-DEV] Secure SVN access

2009-09-03 Thread Uwe Schindler
Hi anatoly, there problem is not only with SVN. In principle if a developer logs in to the PHP bug tracking system on http://bugs.php.net he also uses his password in plain text. Because of this, I see no difference here. I personally use a different password for PHP and no high-security one I

Re: [PHP-DEV] Secure SVN access

2009-09-03 Thread Richard Quadling
2009/9/3 techtonik techto...@php.net: Greeetings to php-core developers, Am I right that there is no https:// and svn+ssh:// access to svn.php.net repositories? If that's the case - how do you feel about sniffing developer's passwords? Please, CC. --anatoly t. -- PHP Internals - PHP

Re: [PHP-DEV] Secure SVN access

2009-09-03 Thread Gwynne Raskind
On Sep 3, 2009, at 8:56 AM, Richard Quadling wrote: 2009/9/3 techtonik techto...@php.net: Greeetings to php-core developers, Am I right that there is no https:// and svn+ssh:// access to svn.php.net repositories? If that's the case - how do you feel about sniffing developer's passwords?

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /win32/build template.rc

2009-09-03 Thread Elizabeth M Smith
Richard Quadling wrote: 2008/11/4 Steph Fox st...@php.net: How you got both files is beyond me - winres.h is not present in either the 2003 sdk or the 6.1 sdk (used with VC6 and VC9 respectively) - our current instructions for building involve renaming header files in the sdk which is a very

[PHP-DEV] Logic for mmap in php_stream_open_for_zend_ex

2009-09-03 Thread Rasmus Lerdorf
Guys, what was the reasoning behind the mmap in php_stream_open_for_zend_ex()? Especially for small files, I don't see a speedup here, and because of some rather sub-optimal fstat behaviour it seems like this has slowed things down quite a bit. See http://bugs.php.net/49383 We now have 3 fstats

[PHP-DEV] PHP 5.2.11RC2 Testing

2009-09-03 Thread Ilia Alshanetsky
The second release candidate of 5.2.11 was just released for testing and can be downloaded here: http://downloads.php.net/ilia/php-5.2.11RC2.tar.bz2 (md5sum: e6796ccffa4a319f460670472c4d8ecc) The windows binaries are available at: http://windows.php.net/qa/ This is a purely a bug-fix

RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Garrett Serack
Without the patch, That is what will you see (windows or linux). (Which is wrong...) The patch corrects the case where the stream has been fseek'd to the last line in the file, when the last line doesn't end with a line terminator. (where you see 'false' in the results). Without the patch,

RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Garrett Serack
Ah, I found another case... when the line length is longer than the read buffer. I'll post again in a few minutes. G -Original Message- From: Garrett Serack [mailto:garre...@microsoft.com] Sent: Thursday, September 03, 2009 1:22 PM To: Hans Åhlin; internals@lists.php.net Subject: RE:

RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Garrett Serack
Ah, no. That is correctly handled. (the default max line length is 8k), and passing in a larger number works just fine. G -Original Message- From: Garrett Serack Sent: Thursday, September 03, 2009 1:32 PM To: Garrett Serack; Hans Åhlin; internals@lists.php.net Subject: RE: [PHP-DEV] Fix

[PHP-DEV] Re: #49346 [Bgs]: using return() with an empty argument list is causing in a parser error

2009-09-03 Thread Mark Skilbeck
mirko dot steiner at slashdevslashnull dot de wrote: ID: 49346 User updated by: mirko dot steiner at slashdevslashnull dot de Reported By: mirko dot steiner at slashdevslashnull dot de Status: Bogus Bug Type: Reproducible crash Operating System: linux,

Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Pierre Joye
hi Garrett, As the patch looks simple I still like to have a bunch set of other tests before applying it (especially for 5.2/3). The tests should ideally use various stream backends (user, bz, etc.). Cheers, On Thu, Sep 3, 2009 at 10:38 PM, Garrett Serackgarre...@microsoft.com wrote: Ah, no.

RE: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Garrett Serack
I'll have to wait till next week to write those. No Problem. G -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Thursday, September 03, 2009 2:16 PM To: Garrett Serack Cc: Hans Åhlin; internals@lists.php.net Subject: Re: [PHP-DEV] Fix for 49148 (combination of

[PHP-DEV] 5.3.1 process

2009-09-03 Thread Johannes Schlüter
Hi, a new tool provides new opportunities and challenges, with the move to svn I took some of the new possibilities and after many discussions created a new release process which I'll try for 5.3.1 for which RC1 is about to be packed. (having trouble accessing the snaps box to build it...) The

Re: [PHP-DEV] Re: #49346 [Bgs]: using return() with an empty argument list is causing in a parser error

2009-09-03 Thread Kalle Sommer Nielsen
2009/9/3 Mark Skilbeck m...@codegeckodevelopments.com: mirko dot steiner at slashdevslashnull dot de wrote: echo is a language construct also, no? Please don't reply to bug reports, but yes echo is also a language construct. The manual lists all the reserved keywords and constructs for future

Re: [PHP-DEV] Fix for 49148 (combination of stream_get_line and fseek does not work correctly)

2009-09-03 Thread Stanislav Malyshev
Hi! it happens on Linux and Windows. I've repro'd it in both places. The bug submitter hadn't tested elsewhere. You are right. However, I notice something strange with your patch - if I call stream_get_line again with the same parameters I get . Shouldn't I get false instead, as it's at