Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Rasmus Lerdorf
On 06/22/2015 01:27 PM, Dmitry Stogov wrote: Actually, when you added type hints, php compiler stopped optimizing and using ZEND_DEFINED (and others) instead of internal function calls, but of course this shouldn't change behavior. I'll need to take a look into difference. Right, behaviour

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Dmitry Stogov
On Mon, Jun 22, 2015 at 5:23 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: On 06/22/2015 05:11 AM, Dmitry Stogov wrote: Hi Rasmus, Your latest changes broke more than 100 tests. Sorry, but I had to revert your commits and related Bob's fixes. You may find them in internal-arg-info

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-22 Thread Pierre Joye
On Jun 22, 2015 4:11 PM, Rowan Collins rowan.coll...@gmail.com wrote: On Jun 22, 2015 1:45 AM, Jan Ehrhardt php...@ehrhardt.nl wrote: Pierre Joye in php.internals (Mon, 22 Jun 2015 00:48:20 +0700): Excuse me? I did not ever say that. In contrary I said I know cases where it is used.

[PHP-DEV] Re: Announcing PHP 5.5 security-only

2015-06-22 Thread Stanislav Malyshev
Hi! *** The PHP 5.5 branch is going to enter in security only, and in the same time, PHP 5.4 will finally die *** I think http://php.net/supported-versions.php says we end 5.4 support on 14 Sep 2015 so we have 2 more releases? Unless we have reason to change it or that page is wrong? In

Re: [PHP-DEV] Re: Announcing PHP 5.5 security-only

2015-06-22 Thread Adam Harvey
On 22 June 2015 at 14:10, Stanislav Malyshev smalys...@gmail.com wrote: Hi! *** The PHP 5.5 branch is going to enter in security only, and in the same time, PHP 5.4 will finally die *** I think http://php.net/supported-versions.php says we end 5.4 support on 14 Sep 2015 so we have 2 more

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Stanislav Malyshev
Hi! Actually, when you added type hints, php compiler stopped optimizing and using ZEND_DEFINED (and others) instead of internal function calls, but This probably needs to be fixed, there's no reason to stop optimizations for internal functions even with arginfo types, since I think the

RE: [PHP-DEV] Re: Announcing PHP 5.5 security-only

2015-06-22 Thread Anatol Belski
Hi, -Original Message- From: Stanislav Malyshev [mailto:smalys...@gmail.com] Sent: Monday, June 22, 2015 11:10 PM To: Julien Pauli; PHP Internals; Ferenc Kovacs; Stanislav Malyshev; Kalle Sommer Nielsen; Pierre Joye; David Soria Parra; Anatol Belsky Subject: [PHP-DEV] Re:

[PHP-DEV] Re: Announcing PHP 5.5 security-only

2015-06-22 Thread Ferenc Kovacs
On Mon, Jun 22, 2015 at 11:10 PM, Stanislav Malyshev smalys...@gmail.com wrote: Hi! *** The PHP 5.5 branch is going to enter in security only, and in the same time, PHP 5.4 will finally die *** I think http://php.net/supported-versions.php says we end 5.4 support on 14 Sep 2015 so we

RE: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Anatol Belski
Hi, -Original Message- From: Rasmus Lerdorf [mailto:ras...@lerdorf.com] Sent: Monday, June 22, 2015 9:10 PM To: Dmitry Stogov Cc: Bob Weinand; Anatol Belski; Kalle Sommer Nielsen; Stanislav Malyshev; Nikita Popov; PHP internals Subject: Re: [PHP-DEV] hasType() for internal function

Re: [PHP-DEV] Re: Announcing PHP 5.5 security-only

2015-06-22 Thread Ángel González
On 22/06/15 23:40, Anatol Belski wrote: Hi, Actually I was relying on that page as well. While it would be great if 5.4 branch were blocked, as we would branch 7.0 ... disregarding were it wrong or not, IMHO 14th September should be the date. Even if the page is wrong, the info is public,

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Rasmus Lerdorf
On 06/22/2015 07:54 PM, Stanislav Malyshev wrote: Hi! So I tried to remove the checks for ZEND_ACC_HAS_TYPE_HINTS: https://github.com/php/php-src/pull/1354 Turns out there is a lot of tests that assume function with wrong arguments throws Error, but ZPP and type checks work differently -

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Stanislav Malyshev
Hi! So I tried to remove the checks for ZEND_ACC_HAS_TYPE_HINTS: https://github.com/php/php-src/pull/1354 Turns out there is a lot of tests that assume function with wrong arguments throws Error, but ZPP and type checks work differently - ZPP first checks argument number (and doesn't throw if

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Dmitry Stogov
Hi Rasmus, Your latest changes broke more than 100 tests. Sorry, but I had to revert your commits and related Bob's fixes. You may find them in internal-arg-info branch. Please, don't do experiments on the common code base at beta stage. On the other hand, I don't see a big problem committing

Re: [PHP-DEV] LDAP module requirements?

2015-06-22 Thread Andreas Heigl
Hi Côme Am 22.06.15 um 11:36 schrieb Côme BERNIGAUD: On 2015-06-18 15:31, Kalle Sommer Nielsen wrote: Seeing as you are one of the only people that I can re-call in recent time that are working on ext/ldap I guess that choice would be up to you. I have CC'ed the other listed extension

Re: [PHP-DEV] LDAP module requirements?

2015-06-22 Thread Kalle Sommer Nielsen
Hi Côme 2015-06-22 11:36 GMT+02:00 Côme BERNIGAUD come.bernig...@opensides.be: Is there a place where such requirements are supposed to be listed? Make sure to note that in any related files that should be in ext/ldap (some extensions supply a document for such information), the documentation

[PHP-DEV] Announcing PHP 5.5 security-only

2015-06-22 Thread Julien Pauli
Hi internals. As you may know/remember , PHP 5.5 has been released two years ago. We've released 26 versions so far (24 would be the normal computing, but we always got some bad releases, mainly from human failure factor). The actual stable 5.5 is PHP 5.5.26. This week, I'm going to tag the

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-22 Thread Rowan Collins
On Jun 22, 2015 1:45 AM, Jan Ehrhardt php...@ehrhardt.nl wrote: Pierre Joye in php.internals (Mon, 22 Jun 2015 00:48:20 +0700): Excuse me? I did not ever say that. In contrary I said I know cases where it is used. Sorry. I apparently misunderstood you, but it is a literal quote from

Re: [PHP-DEV] LDAP module requirements?

2015-06-22 Thread Côme BERNIGAUD
On 2015-06-18 15:31, Kalle Sommer Nielsen wrote: Seeing as you are one of the only people that I can re-call in recent time that are working on ext/ldap I guess that choice would be up to you. I have CC'ed the other listed extension maintainers of ext/ldap (from EXTENSIONS in the php-src root).

Re: [PHP-DEV] PHP-FPM: How to clear the realpath cache on deployment?

2015-06-22 Thread Ferenc Kovacs
On Mon, Jun 22, 2015 at 9:26 PM, Sebastian Bergmann sebast...@php.net wrote: On 06/19/2015 05:46 PM, Rasmus Lerdorf wrote: I think this is a symptom of doing deploys incorrectly. You are right, of course. Thank you for pointing out this layer 8 problem :-) No clue why I did it different

Re: [PHP-DEV] PHP-FPM: How to clear the realpath cache on deployment?

2015-06-22 Thread Sebastian Bergmann
On 06/19/2015 05:46 PM, Rasmus Lerdorf wrote: I think this is a symptom of doing deploys incorrectly. You are right, of course. Thank you for pointing out this layer 8 problem :-) No clue why I did it different (read: stupid) for a private project when I know better. Oh, well. -- PHP

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Dmitry Stogov
On Mon, Jun 22, 2015 at 8:35 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: On 06/22/2015 01:27 PM, Dmitry Stogov wrote: Actually, when you added type hints, php compiler stopped optimizing and using ZEND_DEFINED (and others) instead of internal function calls, but of course this shouldn't

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Rasmus Lerdorf
On 06/22/2015 03:00 PM, Dmitry Stogov wrote: On Mon, Jun 22, 2015 at 8:35 PM, Rasmus Lerdorf ras...@lerdorf.com mailto:ras...@lerdorf.com wrote: On 06/22/2015 01:27 PM, Dmitry Stogov wrote: Actually, when you added type hints, php compiler stopped optimizing and using

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Levi Morrison
On Mon, Jun 22, 2015 at 6:57 PM, Rasmus Lerdorf ras...@lerdorf.com wrote: On 06/22/2015 07:54 PM, Stanislav Malyshev wrote: Hi! So I tried to remove the checks for ZEND_ACC_HAS_TYPE_HINTS: https://github.com/php/php-src/pull/1354 Turns out there is a lot of tests that assume function with

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Stanislav Malyshev
Hi! Is it a BC break against real code though? Fixing tests isn't a big deal. What kind of real code would break by turning calls with the wrong number of args from an error to a warning? Well, if we move to checking in ZPP only, then some of the errors that previously were fatals (like

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-22 Thread Rasmus Lerdorf
On 06/22/2015 05:11 AM, Dmitry Stogov wrote: Hi Rasmus, Your latest changes broke more than 100 tests. Sorry, but I had to revert your commits and related Bob's fixes. You may find them in internal-arg-info branch. Please, don't do experiments on the common code base at beta stage. On