On Tue, Jun 23, 2015 at 10:33 AM, Xinchen Hui larue...@php.net wrote:
Hey:
On Tue, Jun 23, 2015 at 7:37 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi all,
I'm trying to optimize php_html_entities().
Since htmlspecialchars()/htmlentities() are sensitive function, I would
like to ask
Hey:
On Tue, Jun 23, 2015 at 7:37 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi all,
I'm trying to optimize php_html_entities().
Since htmlspecialchars()/htmlentities() are sensitive function, I would
like to ask comments before merge.
https://github.com/php/php-src/pull/1356
Current
W dniu 2015-06-23 o 14:07, Ferenc Kovacs pisze:
Hi,
I would like to add two new PHP versions to the bugtracker, which can be
used for target version for feature requests.
Currently filling that out is mandatory, so we have a bunch of feature
request with random target versions (usually either
On Jun 23, 2015 1:21 PM, Rasmus Lerdorf ras...@lerdorf.com wrote:
On 06/22/2015 11:51 PM, Stanislav Malyshev wrote:
Hi!
Is it a BC break against real code though? Fixing tests isn't a
big deal. What kind of real code would break by turning calls with
the wrong number of args from an
Dear internals,
I would like to submit an RFC for supporting typed arrays as function/method
argument and return types. Please either throw stones at me or give me enough
karma to post it.
My php.net http://php.net/ username is tim-bezhashvyly.
Regards,
Tim
Hi!
Current php_html_entities() convert int/float/etc to string, then convert
it.
int/float/etc is not required to be escaped. Optimize it by simply
converting them to string.
I'm not sure this is the case that is used frequently enough to actually
optimize for it in PHP code. If for
Hi Anthony,
I got it.
On Wed, Jun 24, 2015 at 6:41 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
On Wed, Jun 24, 2015 at 12:21 AM, Anthony Ferrara ircmax...@gmail.com
wrote:
In addition, this breaks the contract, specifically when using scalar
types. Because you're no longer going to error
Tim Bezhashvyly wrote:
I would like to submit an RFC for supporting typed arrays as function/method
argument and return types. Please either throw stones at me or give me enough
karma to post it.
My php.net http://php.net/ username is tim-bezhashvyly.
Note that there is already
Hi Xinchen,
On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui larue...@php.net wrote:
But passing an non-string to htmlspecialchars are not common used cases..
optimize not common used cases... will bring nothing to us..
The reason why I brought up this now is scalar type hint.
Before PHP7,
Hi Anthony,
On Wed, Jun 24, 2015 at 12:21 AM, Anthony Ferrara ircmax...@gmail.com
wrote:
In addition, this breaks the contract, specifically when using scalar
types. Because you're no longer going to error when the contract is
broken (considering htmlspecialchars is documented as
Hi,
I would like to add two new PHP versions to the bugtracker, which can be
used for target version for feature requests.
Currently filling that out is mandatory, so we have a bunch of feature
request with random target versions (usually either the version used by
the reporter or the latest
Hi Xinchen,
On Wed, Jun 24, 2015 at 11:42 AM, Xinchen Hui larue...@php.net wrote:
and for the age usage you replied in github, I think the author of
such codes should be aware, if it's only number, then instead of
htmlespcicalchars($age), he should use echo $age directly... which is
more
Hi Anthony,
On Wed, Jun 24, 2015 at 10:40 AM, Anthony Ferrara ircmax...@gmail.com
wrote:
IMHO, escape/unescape/encode/decode/conversion function is better to
accept
any types.
HTML template may be separated script, but database code etc may not.
Writing code like
?php
Yasuo,
Did you test the performance impact on strings? Since you changed how it
works the impact can be positive and maybe worth to make the method more
broad.
Juan Basso
On Jun 23, 2015 23:01, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Anthony,
On Wed, Jun 24, 2015 at 10:40 AM, Anthony
Hi Juan,
On Wed, Jun 24, 2015 at 12:05 PM, Juan Basso jrba...@gmail.com wrote:
Did you test the performance impact on strings? Since you changed how it
works the impact can be positive and maybe worth to make the method more
broad.
It's a bit slower (~3%) for 'abc' as input string. If I
Hi Anthony,
On Wed, Jun 24, 2015 at 12:00 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
On Wed, Jun 24, 2015 at 10:40 AM, Anthony Ferrara ircmax...@gmail.com
wrote:
IMHO, escape/unescape/encode/decode/conversion function is better to
accept
any types.
HTML template may be separated
Hi Kevin,
Kevin Bradwick wrote:
Too many times have I seen developers throwing Exceptions when what they
really needed was something that gave it context like
InvalidArgumentException or RuntimeException.
Yes, I agree this is something to tackle at code review (and I do) but
I feel PHP
On 06/22/2015 11:51 PM, Stanislav Malyshev wrote:
Hi!
Is it a BC break against real code though? Fixing tests isn't a
big deal. What kind of real code would break by turning calls with
the wrong number of args from an error to a warning?
Well, if we move to checking in ZPP only, then some
Hi all,
I'm trying to optimize php_html_entities().
Since htmlspecialchars()/htmlentities() are sensitive function, I would
like to ask comments before merge.
https://github.com/php/php-src/pull/1356
Current php_html_entities() convert int/float/etc to string, then convert
it.
int/float/etc is
Hello, internals!
I remember the crazy code for invalidating the opcache/realpath entries
from CLI.
Logic was the following: tool asks for the server name with php-fpm to
connect to via ssh connection, then it prepares a small PHP-file and
uploads it to the temp directory on this server and then
Levi Morrison wrote:
One thing I really want to work towards in the future is consistency
between user-land and internal functions. There are currently multiple
observable differences.
+1, as they say.
This is the goal we should be aiming for. Having differences between
userland and internal
Yasuo,
IMHO, escape/unescape/encode/decode/conversion function is better to accept
any types.
HTML template may be separated script, but database code etc may not.
Writing code like
?php
declare(strict_types=1);
$sql = 'SELECT * FROM '. pg_escape_identifier((string)$table). ' WHERE id
Hi all,
I'm wondering the state of Fast ZPP.
https://wiki.php.net/rfc/fast_zpp
Last year's Dmirty's commit message say, it should
only applied to most used functions due to the state of
Fast ZPP.
commit 27f38798a1963de1c60aae4ef8a3675138255574
Author: Dmitry Stogov dmi...@zend.com
Date: Fri
Hey:
On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Xinchen,
On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui larue...@php.net wrote:
But passing an non-string to htmlspecialchars are not common used cases..
optimize not common used cases... will bring nothing to
Hi Xinchen,
On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui larue...@php.net wrote:
On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Xinchen,
On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui larue...@php.net wrote:
But passing an non-string to htmlspecialchars
Hey:
On Wed, Jun 24, 2015 at 10:35 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Xinchen,
On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui larue...@php.net wrote:
On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
Hi Xinchen,
On Tue, Jun 23, 2015 at 11:33 PM,
Quick behavioral question:
If an extension is implementing a Session handler, and returns FAILURE from its
PS_OPEN_FUNC(), will the extension receive subsequent
PS_READ_FUNC()/PS_WRITE_FUNC() calls?
Also, if an extension returns FAILURE from its PS_OPEN_FUNC(), will the
extension receive a
Hi all,
On Wed, Jun 24, 2015 at 5:20 AM, Christoph Becker cmbecke...@gmx.de wrote:
I would like to submit an RFC for supporting typed arrays as
function/method argument and return types. Please either throw stones at me
or give me enough karma to post it.
My php.net http://php.net/
Hi all,
On Wed, Jun 24, 2015 at 6:51 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
I got it.
On Wed, Jun 24, 2015 at 6:41 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote:
On Wed, Jun 24, 2015 at 12:21 AM, Anthony Ferrara ircmax...@gmail.com
wrote:
In addition, this breaks the contract,
Tim Bezhashvyly wrote:
Please either throw stones at me or give me enough karma to post it.
Sorry, I have neither the ability to give karma, nor a convenient pile
of stones.
Christoph Becker wrote:
Note that there is already https://wiki.php.net/rfc/arrayof, which has
been declined.
The
Hi Xinchen,
On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui larue...@php.net wrote:
But passing an non-string to htmlspecialchars are not common used cases..
optimize not common used cases... will bring nothing to us..
The reason why I looked into this in the first place is one of my friend
31 matches
Mail list logo
