Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Benjamin Eberlei
On Thu, Feb 14, 2019 at 11:05 PM Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 7:27 PM Levi Morrison wrote: > > > To all internals, but especially to Zeev and Dmitry, > > > > Having a JIT which does not support ZTS is a bit short-sighted. > > > I don't think anybody's advocating for not having

[PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Dmitry Stogov
On 2/14/19 8:55 PM, Anatol Belski wrote: > Hi Nikita, > >> -Original Message- >> From: Nikita Popov >> Sent: Wednesday, February 13, 2019 1:02 AM >> To: Dmitry Stogov >> Cc: Joe Watkins ; Bob Weinand ; >> Nikita Popov ; Anatol Belski (a...@php.net) ; >> z...@php.net; PHP internals >>

[PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Dmitry Stogov
Hi Anatol, On 2/14/19 8:44 PM, Anatol Belski wrote: > Hi Dmitry, > >> -Original Message- >> From: Dmitry Stogov >> Sent: Wednesday, February 13, 2019 12:26 AM >> To: Joe Watkins ; Bob Weinand ; >> Nikita Popov ; Anatol Belski (a...@php.net) ; >> z...@php.net >> Cc: PHP internals >>

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Pierre Joye
Good morning, Again a long reply from me, sorry :) There are a few things I would like to clarify from my perspective.On Windows, historically (for years), the only usable webserver was Apache. And the only way to work with it for years as well was mod_php. Given the Apache's design, it requires

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Larry Garfield
On Thursday, February 14, 2019 4:33:27 PM CST Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 7:57 PM Larry Garfield > > wrote: > > Data point: At Platform.sh (web host), we've been running ZTS builds of > > 7.1, > > 7.2, and 7.3 exclusively for a while now. We don't even offer non-ZTS > >

Re: [PHP-DEV] Re: Old branches

2019-02-14 Thread Peter Kokot
Hello, On Fri, 10 Aug 2018 at 12:54, Christoph M. Becker wrote: > > On 30.07.2018 at 10:35, Gabriel Caruso wrote: > > > Recently, while checking some branches, I’ve noticed that we have really > > old branches out there in php-src: > > > > 15+ years old: > > > >- experimental/RETURN_REF > >

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 7:57 PM Larry Garfield wrote: > Data point: At Platform.sh (web host), we've been running ZTS builds of > 7.1, > 7.2, and 7.3 exclusively for a while now. We don't even offer non-ZTS > versions of those releases. I presume you haven't been using a threaded Web server

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 7:27 PM Levi Morrison wrote: > To all internals, but especially to Zeev and Dmitry, > > Having a JIT which does not support ZTS is a bit short-sighted. I don't think anybody's advocating for not having ZTS support for JIT. I am questioning the portof the absence of ZTS

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Larry Garfield
On Thursday, February 14, 2019 9:59:18 AM CST Rowan Collins wrote: > On Thu, 14 Feb 2019 at 15:47, Christoph M. Becker wrote: > > On 14.02.2019 at 12:56, Zeev Suraski wrote: > > > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > > >> The ZTS build is very commonly used in Windows today > >

[PHP-DEV] RE: ZTS improvement idea

2019-02-14 Thread Anatol Belski
Hi Nikita, > -Original Message- > From: Nikita Popov > Sent: Wednesday, February 13, 2019 1:02 AM > To: Dmitry Stogov > Cc: Joe Watkins ; Bob Weinand ; > Nikita Popov ; Anatol Belski (a...@php.net) ; > z...@php.net; PHP internals > Subject: Re: ZTS improvement idea > > On Wed, Feb 13,

[PHP-DEV] RE: ZTS improvement idea

2019-02-14 Thread Anatol Belski
Hi Dmitry, > -Original Message- > From: Dmitry Stogov > Sent: Wednesday, February 13, 2019 12:26 AM > To: Joe Watkins ; Bob Weinand ; > Nikita Popov ; Anatol Belski (a...@php.net) ; > z...@php.net > Cc: PHP internals > Subject: ZTS improvement idea > > Hi, > > > > > After JIT+ZTS

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Levi Morrison
To all internals, but especially to Zeev and Dmitry, Having a JIT which does not support ZTS is a bit short-sighted. Think about it. You want to add a JIT partly so that PHP will be better at non-web, CPU intensive tasks. If the JIT is successful, eventually you will want parallelism in that

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 6:13 PM Joe Watkins wrote: > EXACTLY > > Sorry I didn't answer in full, but I've been listening to people say its > not important for so long, I'm pretty tired of it by now. > Joe, all, Again, ISAPI was super important until one day, it wasn't. If the main reason ZTS

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Joe Watkins
EXACTLY Sorry I didn't answer in full, but I've been listening to people say its not important for so long, I'm pretty tired of it by now. We are talking about merging a thing that has the ability to make some maths faster, at huge cost to the project, in two days I wrote a new extension called

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 5:59 PM Rowan Collins wrote: > All that being said, it would be nice if ZTS became more mainstream, so > more people had access to userland threading / parallel processing > extensions. I think the most promising parallel processing paradigms today are based on

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 15:47, Christoph M. Becker wrote: > On 14.02.2019 at 12:56, Zeev Suraski wrote: > > > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > > > >> The ZTS build is very commonly used in Windows today > > > > Any idea why? > > windows.php.net: > > | With Apache you have to

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 5:47 PM Christoph M. Becker wrote: > On 14.02.2019 at 12:56, Zeev Suraski wrote: > > > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > > > >> The ZTS build is very commonly used in Windows today > > > > Any idea why? > > windows.php.net: > > | With Apache you have

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Christoph M. Becker
On 14.02.2019 at 12:56, Zeev Suraski wrote: > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > >> The ZTS build is very commonly used in Windows today > > Any idea why? windows.php.net: | With Apache you have to use the Thread Safe (TS) versions of PHP. -- Christoph M. Becker -- PHP

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Joe Watkins
Packages such as xampp, which are very widely used, bundle a thread safe interpreter. It's a fact that ZTS is important on Windows. Cheers Joe On Thu, 14 Feb 2019 at 16:22, Rowan Collins wrote: > On Thu, 14 Feb 2019 at 11:57, Zeev Suraski wrote: > > > On Wed, Feb 13, 2019 at 11:26 AM Joe

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 5:22 PM Rowan Collins wrote: > On Thu, 14 Feb 2019 at 11:57, Zeev Suraski wrote: > > > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > > > > > The ZTS build is very commonly used in Windows today > > > > > > > Any idea why? > > > > > https://windows.php.net/

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 11:57, Zeev Suraski wrote: > On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > > > The ZTS build is very commonly used in Windows today > > > > Any idea why? > https://windows.php.net/ currently recommends using an NTS build with FastCGI, but there is (or was?) also

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 13:34, Arvids Godjuks wrote: > I agree with this sentiment and the general idea of shipping JIT as > experimental in 7.4 and required to build with a configure flag. > master for 8.0 is going to contain much more and be more unstable and not > practical for testing what

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Joe Watkins
Morning all, This idea of an experimental feature as complex as a JIT is dangerous. It is not finished, and dmitry has said he's not willing to put more time into until it's merged. That's his prerogative, and it is ours to say that we don't want unfinished software that only one or two people

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Dmitry Stogov
On 2/14/19 2:38 PM, Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 12:19 PM Nikita Popov wrote: >> On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: >>> On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann >> * First and foremost for me: Maintenance. We are only shortly after >>

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Arvids Godjuks
чт, 14 февр. 2019 г. в 14:54, Nicolas Grekas : > > [...] I think that whether or not we include it in 7.4 > > is a tactical decision (and I'm not sure myself where I stand on it), > but I > > do think there's a reasonable case for both directions. > > > > If I may add some voice to Zeev's

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Björn Larsson
Den 2019-02-13 kl. 14:07, skrev Dmitry Stogov: Hi Internals, According to comments, code reviews and discussions, JIT RFC was extended with few new sections. Please, consider to review the RFC once again. https://wiki.php.net/rfc/jit Any suggestion for RFC improvement are welcome. I'm not

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Nicolas Grekas
> [...] I think that whether or not we include it in 7.4 > is a tactical decision (and I'm not sure myself where I stand on it), but I > do think there's a reasonable case for both directions. > If I may add some voice to Zeev's arguments, being able to play with JIT as early as possible would

Re: [PHP-DEV] wiki.php.net

2019-02-14 Thread Ben Ramsey
> On Feb 14, 2019, at 02:33, Sebastian Bergmann wrote: > > Who is in charge of wiki.php.net and updates for its software? I ask because > every time I am (logged in) on that site I see warnings such as > > Hotfix release available: 2018-04-22b "Greebo". upgrade now! > Hotfix release

Re: [PHP-DEV] Re: ZTS improvement idea

2019-02-14 Thread Zeev Suraski
On Wed, Feb 13, 2019 at 11:26 AM Joe Watkins wrote: > The ZTS build is very commonly used in Windows today > Any idea why? Zeev

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 12:17 PM Rowan Collins wrote: > On Thu, 14 Feb 2019 at 09:43, Zeev Suraski wrote: > >> Does it mean that when PHP 8.0 comes out (in roughly two years' time most >> probably), we'd be saying this is experimental? Or that only in the >> meantime, for the brave folks that

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 12:19 PM Nikita Popov wrote: > On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: > > > On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann > > wrote: > > > > > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > > > I do not believe that something major like this

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Nikita Popov
On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann > wrote: > > > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > > I do not believe that something major like this should make it into any > > > PHP 7.x release. Having it as experimental

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 09:43, Zeev Suraski wrote: > Does it mean that when PHP 8.0 comes out (in roughly two years' time most > probably), we'd be saying this is experimental? Or that only in the > meantime, for the brave folks that want to experiment PHP 8.0 ~2yrs before > it's released, we'd

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann wrote: > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > I do not believe that something major like this should make it into any > > PHP 7.x release. Having it as experimental new feature in the master/PHP > > 8.0 branch makes the most sense

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Missing param in arginfo_pdostatement_setfetchmode: ext/pdo/pdo_stmt.c

2019-02-14 Thread Nikita Popov
On Thu, Feb 14, 2019 at 8:38 AM Sebastian Bergmann wrote: > Am 14.02.2019 um 08:13 schrieb Gabriel Caruso: > > Commit:ad75511c8e5461cc6ba5cf7aad8f5265615560a8 > > Author:Gabriel Caruso Fri, 16 > Feb 2018 21:29:34 -0200 > > Parents: d57c56cd6304b92db83180e7939eb6288c3a18af > >

[PHP-DEV] wiki.php.net

2019-02-14 Thread Sebastian Bergmann
Who is in charge of wiki.php.net and updates for its software? I ask because every time I am (logged in) on that site I see warnings such as Hotfix release available: 2018-04-22b "Greebo". upgrade now! Hotfix release available: 2018-04-22a "Greebo". upgrade now! New release available:

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Sebastian Bergmann
Am 31.01.2019 um 18:08 schrieb Derick Rethans: I do not believe that something major like this should make it into any PHP 7.x release. Having it as experimental new feature in the master/PHP 8.0 branch makes the most sense to me. ACK -- PHP Internals - PHP Runtime Development Mailing List To