Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Stanislav Malyshev
Hi! > Better error messages are obviously better than just replacing the name of > the token, however this argument is saying that because this isn't perfect > let's do nothing. I don't think this is the argument. I think the argument is rather than half-fix the problem wrong way, let's fully

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread G. P. B.
Hello Andrea, Benjamin, and others, Better error messages are obviously better than just replacing the name of the token, however this argument is saying that because this isn't perfect let's do nothing. I wasn't aware that Rowan had made good progress on his patch, however, if this patch needs

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Dan Ackroyd
On Sat, 27 Jun 2020 at 11:20, Benjamin Eberlei wrote: > 1. The token name has historic value and should be preserved as such I don't think it has historic value. It might have nostalgic value but nostalgia for: > I think everyone hits it once or twice, has the "wtf?" moment, googles, and >

Re: [PHP-DEV] Trait constants

2020-06-27 Thread tyson andre
> Can anyone working on internals explain why traits don’t allow constants > (either technically or philosophically)? > Moreover, what’s the opinion(s) of the list, on adding support for this? > Would an RFC be needed? I don't think there's any insurmountable obstacles, but it would be useful

Re: [PHP-DEV] Trait constants

2020-06-27 Thread tyson andre
> It’s always struck me as slightly odd that traits don’t support constants the > way classes and interfaces do. > I tried to find an explanation of the lack of support in the original RFC, > and came up empty. > > A consequent discussion in R11 has led me here. > Can anyone working on

Re: [PHP-DEV] [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-06-27 Thread tyson andre
Hi Dan Ack, > Also, I didn't understand why there was a problem with formatting > traces in userland. I saw a link to some code, but no clear > description of what the problem was. I expanded the description of how `getTraceAsString()` might be improperly used in existing code and moved it to

Re: [PHP-DEV] [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-06-27 Thread tyson andre
> > > > I've created a new RFC > > https://wiki.php.net/rfc/throwable_string_param_max_len > > How come you're proposing an ini setting instead of adding a parameter > to getTraceAsString() that specifies the length for params? I don't expect many people to use a parameter for

Re: [PHP-DEV] [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-06-27 Thread Dan Ackroyd
On Sat, 27 Jun 2020 at 16:16, tyson andre wrote: > > I've created a new RFC https://wiki.php.net/rfc/throwable_string_param_max_len How come you're proposing an ini setting instead of adding a parameter to getTraceAsString() that specifies the length for params? Also, I didn't understand why

Re: [PHP-DEV] [RFC] \PHP namespace usage heuristics

2020-06-27 Thread Mike Schinkel
> On Jun 23, 2020, at 8:30 PM, Larry Garfield wrote: > > Greetings, Internalians. > > There has been much talk of the \PHP namespace of late, including one > unsuccessful RFC. In the discussion, the pushback broke down into two main > camps: > > * We should never namespace anything ever.

Re: [PHP-DEV] Trait constants

2020-06-27 Thread Mike Schinkel
> On Jun 27, 2020, at 9:52 AM, Stephen Reay wrote: > > Hi, > > It’s always struck me as slightly odd that traits don’t support constants the > way classes and interfaces do. > I tried to find an explanation of the lack of support in the original RFC, > and came up empty. > > A consequent

[PHP-DEV] [RFC] throwable_string_param_max_len: Configurable string length in getTraceAsString()

2020-06-27 Thread tyson andre
Hi internals, I've created a new RFC https://wiki.php.net/rfc/throwable_string_param_max_len Since 2003, `Throwable->getTraceAsString()` and `Throwable->__toString()` have limited the length of string function arguments in stringified stack traces to 15 bytes (e.g. `#0 /path/to/file.php(line)

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Rowan Tommins
On 27/06/2020 10:56, Andrea Faulds wrote: Of course, if T_PAAMAYIM_NEKUDOTAYIM was never encountered by userland developers, this RFC wouldn't exist. The thing is, I don't think T_DOUBLE_COLON should be encountered by userland developers either — in my view, as an implementation detail, token

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Andrea Faulds
Hi again, A further and perhaps more important thought: I think the token names are actually the least confusing part of parser errors, even for the famous T_PAAMAYIM_NEKUDOTAYIM. Changing it to T_DOUBLE_COLON may not help much, because the parser only tells you what the next token it

[PHP-DEV] Trait constants

2020-06-27 Thread Stephen Reay
Hi, It’s always struck me as slightly odd that traits don’t support constants the way classes and interfaces do. I tried to find an explanation of the lack of support in the original RFC, and came up empty. A consequent discussion in R11 has led me here. Can anyone working on internals explain

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Nikita Popov
On Sat, Jun 27, 2020 at 11:57 AM Andrea Faulds wrote: > Hi, > > G. P. B. wrote: > > https://wiki.php.net/rfc/rename-double-colon-token > > I have voted No to this, and I hope I can convince some others to do the > same. > > T_PAAMAYIM_NEKUDOTAYIM is such a famous token that there is probably >

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Benjamin Eberlei
On Sat, Jun 27, 2020 at 11:57 AM Andrea Faulds wrote: > Hi, > > G. P. B. wrote: > > https://wiki.php.net/rfc/rename-double-colon-token > > I have voted No to this, and I hope I can convince some others to do the > same. > > T_PAAMAYIM_NEKUDOTAYIM is such a famous token that there is probably >

Re: [PHP-DEV][RFC][VOTE] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-27 Thread Andrea Faulds
Hi, G. P. B. wrote: https://wiki.php.net/rfc/rename-double-colon-token I have voted No to this, and I hope I can convince some others to do the same. T_PAAMAYIM_NEKUDOTAYIM is such a famous token that there is probably nobody in internals who doesn't know what it means, and for new