Re: [PHP-DEV] Re: [RFC] Migrating to GitHub issues

2022-12-30 Thread Stanislav Malyshev
Hi! I had enabled that some weeks ago, since there has been a spam attack on bugsnet, so we could test the new feature. I probably should have written to list right away, or at least have kept an eye on it, but I've assumed to be notified about reported issues. I'll have a closer look at the

Re: [PHP-DEV] What to do with opaque GMP objects which allows instantiation

2022-12-30 Thread Hans Henrik Bergan
Why isn't that generating an ArgumentCountError? On Fri, Dec 30, 2022, 21:36 Tim Düsterhus wrote: > Hi > > On 12/30/22 18:36, G. P. B. wrote: > > - Add a proper constructor that does the same as gmp_init() in > master/8.2.1 > > My preference would be this (without any target branch

Re: [PHP-DEV] Re: [RFC] Migrating to GitHub issues

2022-12-30 Thread Christoph M. Becker
On 30.12.2022 at 22:12, Nikita Popov wrote: > On Thu, Nov 10, 2022, at 14:29, Christoph M. Becker wrote: > >> On 09.11.2022 at 23:27, Nikita Popov wrote: >> >>> It looks like GitHub has just added support for private security reports: >>>

Re: [PHP-DEV] Re: [RFC] Migrating to GitHub issues

2022-12-30 Thread Nikita Popov
On Thu, Nov 10, 2022, at 14:29, Christoph M. Becker wrote: > On 09.11.2022 at 23:27, Nikita Popov wrote: > > > It looks like GitHub has just added support for private security reports: > > https://github.blog/changelog/2022-11-09-privately-report-vulnerabilities-to-repository-maintainers/ > > > >

Re: [PHP-DEV] What to do with opaque GMP objects which allows instantiation

2022-12-30 Thread Tim Düsterhus
Hi On 12/30/22 18:36, G. P. B. wrote: - Add a proper constructor that does the same as gmp_init() in master/8.2.1 My preference would be this (without any target branch preference): If there is no technical reason to disallow creating new GMP objects via 'new', then I believe that making

[PHP-DEV] What to do with opaque GMP objects which allows instantiation

2022-12-30 Thread G. P. B.
Hello internals, While working on something, I was using GMP for a test case and creating it by doing akin to $o = new GMP(5); However, this does *not* create a GMP object initialized to 5, rather it creates and sets the value to 0. This is because it does not define a constructor, and the

[PHP-DEV] update php.ini variables_order setting to EGPCS to reflect documentation

2022-12-30 Thread easteregg
hey folks, the tl;dr documentation states a default of EGPCS but both php.ini files have it set to GPCS - which is confusing. i was asked to send this PR https://github.com/php/php-src/pull/10182 to the internals list to discuss the topic. is the performance impact of populating $_ENV still