Re: [PHP-DEV] [RFC] [Discussion] Resource to object conversion

2024-01-03 Thread Máté Kocsis
Hey Larry, That's fine for the main vote, but the others are all either/or votes, not > yes/no votes, so 2/3 majority doesn't mean anything. Do you mean those are > 50/50 votes, or something else? > Thanks for your insight again, You are right, it was a silly bug in the RFC. I've just fixed it s

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Larry Garfield
On Wed, Jan 3, 2024, at 7:11 AM, Nicolas Grekas wrote: > Hi Max, > > Hi, I'd like to propose a new attribute, #[NotSerializable]. This >> functionality is already available for internal classes - userspace should >> benefit from it, too. >> >> The RFC: https://wiki.php.net/rfc/not_serializable >> P

Re: [PHP-DEV] [RFC] [Discussion] Resource to object conversion

2024-01-03 Thread Larry Garfield
On Wed, Jan 3, 2024, at 7:36 AM, Máté Kocsis wrote: > Hi Everyone, > > If there are no further complaints, I intend to start the votes ( > https://wiki.php.net/rfc/resource_to_object_conversion) the day after > tomorrow. > > Regards, > Máté "Each vote requires 2/3 majority in order to be accepted.

Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Michał Marcin Brzuchalski
śr., 3 sty 2024 o 15:57 Gina P. Banyard napisał(a): > On Wednesday, 3 January 2024 at 14:38, Michał Marcin Brzuchalski < > michal.brzuchal...@gmail.com> wrote: > > Hi Gina, > > śr., 3 sty 2024 o 14:41 Gina P. Banyard napisał(a): > > Hello internals, > > I would like to propose an RFC to add the

Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Gina P. Banyard
On Wednesday, 3 January 2024 at 14:38, Michał Marcin Brzuchalski wrote: > Hi Gina, > śr., 3 sty 2024 o 14:41 Gina P. Banyard napisał(a): > >> Hello internals, >> >> I would like to propose an RFC to add the functions >> http_get_last_request_headers() and http_clear_last_request_headers() to

Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Gina P. Banyard
On Wednesday, 3 January 2024 at 14:34, Aleksander Machniak wrote: > On 3.01.2024 14:41, Gina P. Banyard wrote: > > > Link: https://wiki.php.net/rfc/http-last-response-headers > > > Wrong function name in the subject (should be "response" not "request") Ah yes indeed, the RFC title is also incorr

Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Michał Marcin Brzuchalski
Hi Gina, śr., 3 sty 2024 o 14:41 Gina P. Banyard napisał(a): > Hello internals, > > I would like to propose an RFC to add the functions > http_get_last_request_headers() and http_clear_last_request_headers() to > PHP to replace the magic variable $http_response_header. > > Link: https://wiki.php

Re: [PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Aleksander Machniak
On 3.01.2024 14:41, Gina P. Banyard wrote: Link: https://wiki.php.net/rfc/http-last-response-headers Wrong function name in the subject (should be "response" not "request") I don't think we need the clearing function. Do we? I don't like that this is HTTP specific feature while we have other

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Michał Marcin Brzuchalski
śr., 3 sty 2024 o 11:10 Nicolas Grekas napisał(a): > śr., 3 sty 2024 o 08:12 Nicolas Grekas napisał(a): > Hi Max, > > Hi, I'd like to propose a new attribute, #[NotSerializable]. This > > functionality is already available for internal classes - userspace > sho

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread G. P. B.
On Wed, 3 Jan 2024 at 13:17, Max Semenik wrote: > > this actively prevents writing a child class that'd make a parent > serializable if it wants to. > > Wouldn't this violate LSP? > No it doesn't. Making a child class unserializable if the parent is serializable however is violating LSP, and pro

[PHP-DEV] [RFC] Add http_(get|clear)_last_request_headers() function

2024-01-03 Thread Gina P. Banyard
Hello internals, I would like to propose an RFC to add the functions http_get_last_request_headers() and http_clear_last_request_headers() to PHP to replace the magic variable $http_response_header. Link: https://wiki.php.net/rfc/http-last-response-headers Best regards, Gina P. Banyard

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Max Semenik
On Wed, Jan 3, 2024 at 10:11 AM Nicolas Grekas wrote: > > Regarding the inheritance-related behavior ("The non-serializable flag is > inherited by descendants"), this is very unlike any other attributes, and > this actively prevents writing a child class that'd make a parent > serializable if it

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Nicolas Grekas
> > >>> śr., 3 sty 2024 o 08:12 Nicolas Grekas >>> napisał(a): >>> Hi Max, Hi, I'd like to propose a new attribute, #[NotSerializable]. This > functionality is already available for internal classes - userspace should > benefit from it, too. > > The RFC: htt

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Michał Marcin Brzuchalski
śr., 3 sty 2024 o 10:09 Nicolas Grekas napisał(a): > Hi Nicolas, >> >> śr., 3 sty 2024 o 08:12 Nicolas Grekas >> napisał(a): >> >>> Hi Max, >>> >>> Hi, I'd like to propose a new attribute, #[NotSerializable]. This >>> > functionality is already available for internal classes - userspace >>> shou

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Nicolas Grekas
> Hi Nicolas, > > śr., 3 sty 2024 o 08:12 Nicolas Grekas > napisał(a): > >> Hi Max, >> >> Hi, I'd like to propose a new attribute, #[NotSerializable]. This >> > functionality is already available for internal classes - userspace >> should >> > benefit from it, too. >> > >> > The RFC: https://wiki.

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Michał Marcin Brzuchalski
Hi Nicolas, śr., 3 sty 2024 o 08:12 Nicolas Grekas napisał(a): > Hi Max, > > Hi, I'd like to propose a new attribute, #[NotSerializable]. This > > functionality is already available for internal classes - userspace > should > > benefit from it, too. > > > > The RFC: https://wiki.php.net/rfc/not_

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2024-01-03 Thread Dusk
On Jan 2, 2024, at 23:11, Nicolas Grekas wrote: > Regarding the inheritance-related behavior ("The non-serializable flag is > inherited by descendants"), this is very unlike any other attributes, and > this actively prevents writing a child class that'd make a parent > serializable if it wants to.