Re: [PHP-DEV] Implement SeekableIterator for SplObjectStorage

2024-03-10 Thread Niels Dossche
Hi Bruce On 10/03/2024 21:43, Bruce Weirdan wrote: > On Sun, Mar 10, 2024 at 9:14 PM Niels Dossche wrote: > >> I opened a PR to make SplObjectStorage implement SeekableIterator, this >> means that it'll now be possible to use `seek(int $offset): void` on >> SplObjectStorage > > Note that it's

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2024-03-10 Thread Marc Bennewitz
Hi Larry, On 10.03.24 16:52, Larry Garfield wrote: On Sun, Mar 10, 2024, at 10:31 AM, Gina P. Banyard wrote: On Saturday, 9 March 2024 at 16:00, Larry Garfield wrote: I am still opposed to this. Logically, ceil/float/round should be returning ints, not floats. Only returning ints if it was

Re: [PHP-DEV] Implement SeekableIterator for SplObjectStorage

2024-03-10 Thread Bruce Weirdan
On Sun, Mar 10, 2024 at 9:14 PM Niels Dossche wrote: > I opened a PR to make SplObjectStorage implement SeekableIterator, this means > that it'll now be possible to use `seek(int $offset): void` on > SplObjectStorage Note that it's a BC break for descendants of SplObjectStorage with an incompa

[PHP-DEV] Implement SeekableIterator for SplObjectStorage

2024-03-10 Thread Niels Dossche
Hi internals I opened a PR to make SplObjectStorage implement SeekableIterator, this means that it'll now be possible to use `seek(int $offset): void` on SplObjectStorage. I'm mainly posting here to see if there are any objections. PR link: https://github.com/php/php-src/pull/13665 Kind regards

Re: [PHP-DEV] int|float for sleep? sleep(0.1) => sleep 0.1 seconds

2024-03-10 Thread Tim Düsterhus
Hi On 3/8/24 09:12, Hans Henrik Bergan wrote: Does this work for you guys? As said before, not a fan of the voting choices, because of the implicit dependencies that you would need to carefully specify. adding a short *nix explanation of when sleep will return earlier than expected would

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2024-03-10 Thread Larry Garfield
On Sun, Mar 10, 2024, at 10:31 AM, Gina P. Banyard wrote: > On Saturday, 9 March 2024 at 16:00, Larry Garfield > wrote: > >> I am still opposed to this. Logically, ceil/float/round should be returning >> ints, not floats. Only returning ints if it was given an int is, er, kinda >> pointless, as

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2024-03-10 Thread Gina P. Banyard
On Saturday, 9 March 2024 at 16:00, Larry Garfield wrote: > I am still opposed to this. Logically, ceil/float/round should be returning > ints, not floats. Only returning ints if it was given an int is, er, kinda > pointless, as you'll just get back the value you passed in. (Because it's > al