Re: [PHP-DEV] [RFC] [Vote] #[\Deprecated] attribute

2024-05-22 Thread Benjamin Außenhofer
On Wed, May 22, 2024 at 9:33 AM Nicolas Grekas wrote: > Hi Benjamin, > > The vote for the RFC #[\Deprecated] attribute is now open: >> >> https://wiki.php.net/rfc/deprecated_attribute >> >> Voting will close on Wednesday 5th June, 08:00 GMT. >> > > I voted "no" because I think this is better

[PHP-DEV] [RFC] [Vote] #[\Deprecated] attribute

2024-05-22 Thread Benjamin Außenhofer
The vote for the RFC #[\Deprecated] attribute is now open: https://wiki.php.net/rfc/deprecated_attribute Voting will close on Wednesday 5th June, 08:00 GMT.

Re: [PHP-DEV] Switching max_execution_time from CPU time to wall-clock time and from SIGPROF to SIGALRM

2024-05-21 Thread Benjamin Außenhofer
On Fri, May 17, 2024 at 3:49 PM Arnaud Le Blanc wrote: > Hi internals, > > There is an issue with max_execution_time on MacOS, probably only > MacOS 14 on Apple Silicon, that causes timeouts to fire too early [1]. > max_execution_time is implemented with setitimer(ITIMER_PROF) on this >

[PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-05-17 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 3:27 PM Benjamin Außenhofer wrote: > Hi internals, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to > revisit it and asked Tim to help me out with the wo

[PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-05-14 Thread Benjamin Außenhofer
On Thu, May 2, 2024 at 1:00 PM Benjamin Außenhofer wrote: > > > On Tue, Apr 23, 2024 at 3:27 PM Benjamin Außenhofer > wrote: > >> Hi internals, >> >> My PR for #[\Deprecated] attribute was in hibernation for a long while >> now and after some off-list di

Re: [PHP-DEV] Inconsistencies between parameter number and index when reflecting a method/function

2024-05-02 Thread Benjamin Außenhofer
On Thu, May 2, 2024 at 2:51 PM Ollie Read wrote: > Hi All, > > I've been working on a PR that introduces > ReflectionFunctionAbstract::getParameter() and > ReflectionFunctionAbstract::hasParameter(), to fall more inline with the > other method sets we have, as well as just generally making

[PHP-DEV] Re: [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-05-02 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 3:27 PM Benjamin Außenhofer wrote: > Hi internals, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now > and after some off-list discussion a few weeks ago I have decided to > revisit it and asked Tim to help me out with the wo

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-26 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 7:27 PM Levi Morrison wrote: > On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer > wrote: > > > > Hi internals, > > > > My PR for #[\Deprecated] attribute was in hibernation for a long while > now and after some off-list discussi

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 7:18 PM Jorg Sowa wrote: > I like the proposition and I like the idea of $since parameter, however, > this option is too ambiguous about what should store. Should it store the > PHP version, package version, or the date? > > What about setting this parameter vaguely as

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 2:55 PM Lynn wrote: > > > On Tue, Apr 23, 2024 at 3:30 PM Benjamin Außenhofer > wrote: > >> Hi internals, >> >> My PR for #[\Deprecated] attribute was in hibernation for a long while >> now and after some off-list discussion a few

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Wed, Apr 24, 2024 at 3:57 PM Nicolas Grekas wrote: > Hi Benjamin, > > My PR for #[\Deprecated] attribute was in hibernation for a long while now >> and after some off-list discussion a few weeks ago I have decided to >> revisit it and asked Tim to help me out with the work. >> >> Tim has

Re: [PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-24 Thread Benjamin Außenhofer
On Tue, Apr 23, 2024 at 7:27 PM Levi Morrison wrote: > On Tue, Apr 23, 2024 at 7:30 AM Benjamin Außenhofer > wrote: > > > > Hi internals, > > > > My PR for #[\Deprecated] attribute was in hibernation for a long while > now and after some off-list discussi

[PHP-DEV] [RFC] [Discussion] #[\Deprecated] attribute again v1.3

2024-04-23 Thread Benjamin Außenhofer
Hi internals, My PR for #[\Deprecated] attribute was in hibernation for a long while now and after some off-list discussion a few weeks ago I have decided to revisit it and asked Tim to help me out with the work. Tim has cleaned up the PR quite a bit and also worked in additional features such

Re: [PHP-DEV] [RFC] [Discussion] Add openStream() to XML{Reader,Writer}

2024-04-23 Thread Benjamin Außenhofer
On Mon, Apr 22, 2024 at 8:43 PM Niels Dossche wrote: > Hi internals > > I'm opening the discussion for my RFC "Add openStream() to > XML{Reader,Writer}". > RFC link: https://wiki.php.net/rfc/xmlreader_writer_streams Not sure this needs an RFC. Its a sensible addition and the explanations make

Re: [PHP-DEV] [RFC[ Property accessor hooks, take 2

2024-02-27 Thread Benjamin Außenhofer
Hey, On Wed, Feb 21, 2024 at 7:58 PM Larry Garfield wrote: > Hello again, fine Internalians. > > After much on-again/off-again work, Ilija and I are back with a more > polished property access hooks/interface properties RFC. It’s 99% > unchanged from last summer; the PR is now essentially

Re: [PHP-DEV] Declaration-aware attributes

2023-05-31 Thread Benjamin Außenhofer
On Tue, May 30, 2023 at 2:49 AM Andreas Hennings wrote: > Hello internals, > I am picking up an idea that was mentioned by Benjamin Eberlei in the past. > https://externals.io/message/110217#110395 > (we probably had the idea independently, but Benjamin's is the first > post where I see it

Re: [PHP-DEV] [RFC] Property hooks, nee accessors

2023-05-09 Thread Benjamin Außenhofer
On Mon, May 8, 2023 at 11:38 PM Larry Garfield wrote: > Ilija Tovilo and I would like to offer another RFC for your > consideration. It's been a while in coming, and we've evolved the design > quite a bit just in the last week so if you saw an earlier draft of it in > the past few months, I

Re: [PHP-DEV] [VOTE] PHP Technical Committee

2023-05-01 Thread Benjamin Außenhofer
On Fri, Apr 28, 2023 at 12:01 PM Jakub Zelenka wrote: > Hi, > > The vote is now open for the RFC about introduction of the PHP Technical > Committee: > > https://wiki.php.net/rfc/php_technical_committee I found this idea of a TC interesting on the outset, but after carefully consideirng I