Re: [PHP-DEV] [VOTE] Generator Delegation

2015-03-15 Thread Damien Tournoud
Hi Daniel, In the formal definition, you have: $throw $e; ... which I assume is a typo? Damien On Sun, Mar 15, 2015 at 8:18 PM, Daniel Lowrey rdlow...@php.net wrote: Hi folks! As the discussion period has reached its conclusion I'd like to announce a two week voting period on the

Re: [PHP-DEV] [VOTE] Generator Delegation

2015-03-15 Thread Damien Tournoud
Hi Daniel, Would you mind clarifying the relationship between the Generator Delegation RFC and the Generator Return Expressions RFC? While I really appreciate the Generator Delegation RFC, the Generator Return Expressions looks both unnecessary and kind of a hack to me. In evented system based

Re: [PHP-DEV] [VOTE] Generator Delegation

2015-03-15 Thread Damien Tournoud
On Sun, Mar 15, 2015 at 9:35 PM, Daniel Lowrey rdlow...@php.net wrote: This is actually a *vastly* inferior solution to language-level support for generator returns. greenlet/gevent does it this way because these libraries were created before Python supported generator delegation (and

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Christian, On Fri, Feb 27, 2015 at 5:15 PM, Christian Stoller stol...@leonex.de wrote: In this case FALSE is an expected result and it is intended. And as I said other languages are going the same way. Other languages are also doing something saner. It's not really an argument either way.

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: Drupal homepage: One new E_DEPRECATED warning, which seems to catch a real bug, or at least faulty looking code: $path = trim($path, '/'); // raises E_DEPRECATED, as $path is boolean false. return $path;

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Christian, On Fri, Feb 27, 2015 at 3:38 PM, Christian Stoller stol...@leonex.de wrote: It is not a bug. FALSE as a return value of substr() is the identificator for an error (e.g. invalid arguments), as it is stated in the documentation: [...] It is documented that way and it is not a

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Lester, On Fri, Feb 27, 2015 at 6:51 PM, Lester Caine les...@lsces.co.uk wrote: This may not be what YOU want substr to do and it would perhaps be useful to ADD additional checks so that 'false' is returned when it can't created a string because of the 'invalid arguments', but type hints

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Lester, On Fri, Feb 27, 2015 at 9:53 PM, Lester Caine les...@lsces.co.uk wrote: Please, read the examples again, the current behavior is nothing but inconsistent: substr(a, 1) = FALSE substr(a, -300) = ? That was the case prior to PHP5.2.1 The fixes in 5.2.2 were not

Re: [PHP-DEV] Re: Security changes in PHP 7

2015-02-08 Thread Damien Tournoud
On Sun, Feb 8, 2015 at 5:15 PM, Daniel Lowrey rdlow...@php.net wrote: Currently PHP's openssl_random_pseudo_bytes() uses the latter function and allows users to pass a by-reference $crypto_strong out parameter to determine if the result is cryptographically strong. This is fine if you know

Re: [PHP-DEV] Zend language parser improvements

2014-12-08 Thread Damien Tournoud
On Thu, Dec 4, 2014 at 1:46 AM, guilhermebla...@gmail.com guilhermebla...@gmail.com wrote: Examples are COM, PDO Statement, DOM XML and MySQLi. They also reduce the amount of checks of bison when parsing a php file, it provides a nicer fatal error around multiple final and multiple abstract

Re: [PHP-DEV] Zend language parser improvements

2014-12-08 Thread Damien Tournoud
On Mon, Dec 8, 2014 at 1:30 PM, Damien Tournoud d...@damz.org wrote: PDO statement should not be made final, or this is a breaking language change (requiring an RFC and a 2/3 majority). I see from the PR that it's PDORow, not PDOStatement. That one is not actually exposed as such to userspace

Re: [PHP-DEV] [RFC] [VOTE] Filtered unserialize()

2014-11-03 Thread Damien Tournoud
On Mon, Nov 3, 2014 at 10:10 PM, Stas Malyshev smalys...@sugarcrm.com wrote: I'd like to put to vote my proposal about the filtered unserialize(): https://wiki.php.net/rfc/secure_unserialize Hi, Coming late to the discussion. Was there any discussion to make the new argument a callback

Re: [PHP-DEV] New Standardized HTTP Interface

2014-11-01 Thread Damien Tournoud
On Sat, Nov 1, 2014 at 1:40 PM, Andrea Faulds a...@ajf.me wrote: On 31 Oct 2014, at 18:37, Larry Garfield la...@garfieldtech.com wrote: IF internals wanted to add implementation, not just improving streams, something like the following would be much more useful: $request =

Re: [PHP-DEV] Re: Merging O+ into 5.5

2013-03-15 Thread Damien Tournoud
On Fri, Mar 15, 2013 at 10:24 AM, Dmitry Stogov dmi...@zend.com wrote: I mean not git subtree merge but git read-dir --prefix Actually it imports all the history form O+ repo, but it's recorded with original patches (e.g. ZendAccelerator.h instead of moved

Re: [PHP-DEV] Re: Merging O+ into 5.5

2013-03-15 Thread Damien Tournoud
On Fri, Mar 15, 2013 at 11:08 AM, Dmitry Stogov dmi...@zend.com wrote: This solution clones the history, but makes merging between PHP and O+ repo (it's going to be used for pecl build for old PHP versions) even more difficult. Thanks. Dmitry. Not sure. Merging between the two repositories

Re: [PHP-DEV] PHP causing high number of NFS getattr operations?

2013-02-18 Thread Damien Tournoud
On Mon, Feb 18, 2013 at 10:03 PM, Brendon Colby bren...@newgrounds.com wrote: I tried apc.include_once_override - no change. I set up Apache to one process and straced it. I clicked around on the site a few times and see the typical pattern: open([PATH]/CacheFile.class.php, O_RDONLY) = 10

Re: [PHP-DEV] Re: O+ 1st results

2013-02-15 Thread Damien Tournoud
I assume that something is functionally wrong on Symfony/O+: Symfony, IIS, cache, PHP5.5.0devvc11: 2195 Symfony, IIS, cache, PHP5.5.0devvc11: 1919 Symfony, IIS, cache, PHP5.5.0devvc11: 2127 There was a previous report that Twig did not work at all with optimizations enabled. Damien On Fri,

Re: [PHP-DEV] Re: O+ 1st results

2013-02-15 Thread Damien Tournoud
On Fri, Feb 15, 2013 at 9:54 AM, Pierre Joye pierre@gmail.com wrote: Mediawiki is slower because it does not support yet O+ for usercache, along other things. Is the same the case with Symfony? no, MediaWiki caching modules only support APC or Wincache so far. As far as I understand,

Re: [PHP-DEV] PHP build-in HTTP server and the HEAD method

2012-09-12 Thread Damien Tournoud
On Wed, Sep 12, 2012 at 10:54 AM, Ivan Enderlin @ Hoa ivan.ender...@hoa-project.net wrote: Hello, It is probably me but it seems like the build-in HTTP server does not well support the HEAD method. Here is my following test case. First, the foo.php file: ?php

Re: [PHP-DEV] SQLite3 class missing createCollation()

2012-01-23 Thread Damien Tournoud
Also see https://bugs.php.net/bug.php?id=55226 Same idea, but for the PDO_sqlite implementation. Damien On Mon, Jan 23, 2012 at 11:28 PM, b dewar macde...@gmail.com wrote: Hi I initially sent this to php-db, but I guess it really belongs on internals. The C API for SQLite3 has an

Re: [PHP-DEV] REQUEST_TIME change in PHP 5.4

2011-12-27 Thread Damien Tournoud
On Sat, Dec 24, 2011 at 7:07 AM, Pierre Joye pierre@gmail.com wrote: Right, and that's why I would be in favour of a BC change, maybe by introducing a REQUEST_TIME_FLOAT instead, so people willing to use the float version can still have it while the existing code needs no change. We

Re: [PHP-DEV] [RFC] New extension proposal: meta

2011-09-04 Thread Damien Tournoud
On Sun, Sep 4, 2011 at 9:21 AM, Nikita Popov nikita@googlemail.com wrote: Hi Flavius! I am working on PHP Parser in user land code (https://github.com/nikic/PHP-Parser), which currently has capabilities to parse PHP 5.3 into an AST and compile the nodes back to PHP source. Just as a

[PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
Just FYI, this commit broke the build: http://svn.php.net/viewvc?view=revisionrevision=314515 One occurrence as been missed in: ext/xsl/xsltprocessor.c:DOM_RET_OBJ(rv, (xmlNodePtr) newdocp, ret, NULL); Reference:

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
8, 2011 at 10:45 AM, Damien Tournoud d...@damz.org wrote: Just FYI, this commit broke the build:  http://svn.php.net/viewvc?view=revisionrevision=314515 One occurrence as been missed in:  ext/xsl/xsltprocessor.c:                        DOM_RET_OBJ(rv, (xmlNodePtr) newdocp, ret, NULL

Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c

2011-08-08 Thread Damien Tournoud
#yay Packages now build again on http://apt.damz.org/ Damien On Mon, Aug 8, 2011 at 6:49 PM, Ilia Alshanetsky i...@prohost.org wrote: Different error, fixed now as well. On Mon, Aug 8, 2011 at 12:39 PM, Damien Tournoud d...@damz.org wrote: Thanks for the fix, but it is still failing

Re: [PHP-DEV] Volnitsky substring search algo

2011-03-02 Thread Damien Tournoud
), but that will increase the overall cost (both computing and memory) of the algorithm. Damien Tournoud