Re: [PHP-DEV] Update coding standards wrt. C99?

On Wed, May 6, 2020 at 6:20 PM Xinchen Hui wrote: > > Hey: > > On Wed, May 6, 2020 at 3:32 PM Christoph M. Becker > wrote: > >> Hi all, >> >> since master requires (mostly) C99 compliant compilers anyway, I wonder >> if we like to update our coding

Re: [PHP-DEV] Update coding standards wrt. C99?

gt; > Thoughts? > > [1] <https://github.com/php/php-src/blob/master/CODING_STANDARDS.md> > [2] > < > https://github.com/php/php-src/blob/master/CODING_STANDARDS.md#documentation-and-folding-hooks > > > > -- > Christoph M. Becker > > -- > PHP Internals - PHP Run

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

uys. :) > FAST_CALL should only affects win32. and it can bring some improvement in win32.. People should use zif_handler instead of define there own from now on, I think documented it in UPGRADING is enough thanks > > -- > Christoph M. Becker > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Weird PHP 7.2 bug

types "by usage" makes sense (for array) > > e.g. $a[$n]++ should change the type of array. > I > > Thanks. Dmitry. > > > -- > *From:* Xinchen Hui <larue...@php.net> > *Sent:* Monday, October 30, 2017 10:05:30 AM > *To:* D

Re: [PHP-DEV] Weird PHP 7.2 bug

> https://derickrethans.nl | https://xdebug.org | https://dram.io > Like Xdebug? Consider a donation: https://xdebug.org/donate.php > twitter: @derickr and @xdebug > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

[PHP-DEV] Re: Request shutdown optimization

ging fast_shutdown problems, maybe we could change it to : fast_shutdown = #if ZEND_DEBUG !report_memleaks && #endif is_zend_mm && !full_table_clean; ), anyway, this feature is already exists in opcache for quite a long time, so I think could commit it

Re: [PHP-DEV] Regression between RC1 and RC2?

rwise I'd suggest to > revert to the previous behavior in 7.0+ and do a fix in an appropriate > higher branch. > The real problem is: we are expecting __debugInfo always returns array, but it doesn't if exception is threw. so, if we keep the exception, then we need inserts checks for exception (no array) after every debugInfo is called, or, make a FATAL error like the way I did however, I think latter is better, but maybe we could improve the fatal error message: " Fatal error, __debugInfo must return an array, but an exception with " msg" is threw" thanks > > Thanks > > Anatol > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] JIT for PHP project

you may see like 5% improvement on wordpress. :) thanks > > Wish us luck :) > > Thanks. Dmitry. > > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] More packed hash optimizations in array.c

ked array doesn't means alwasy start with index 0, like: $array = array(1 => 1, 2, 3, 4, 5, 6); this is also a packed array so, we can not do such opt only if offset == 0 thanks > > Ben > > > == Original == > From: Xinchen Hui <xinche...@zend.com&

Re: [PHP-DEV] More packed hash optimizations in array.c

xt_index_zval(return_value, zcolval); } if zkey is NULL(index_key), then only add_next_index_zval is executed. do you have any reproduce script to show the broken? thanks > > Cheers, > > Benjamin > > == Original == > From: Xinchen Hui <xinche

Re: [PHP-DEV] More packed hash optimizations in array.c

10306c881a9f0a82b8503a45 thanks > > Please let me know your thoughts. > > Thanks, > > Ben > > -- > > Bejamin Coutu > ben.co...@zeyos.com > > ZeyOS, Inc. > http://www.zeyos.com > > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Optimizing array_reverse for packed hash tables (when preserve_keys=false)

f, or let me to commit your idea? thanks > > Thanks, > > Ben > > -- > > Bejamin Coutu > ben.co...@zeyos.com > > ZeyOS, Inc. > http://www.zeyos.com > > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Inconsistent implementation of array sorting (old zend_qsort in array_multisort)

7.1 , however, we can not remove zend_qsort, because its a ZEND_API , some third extensions may use it. thanks > Thanks, > > Ben > > -- > > Bejamin Coutu > ben.co...@zeyos.com > > ZeyOS, Inc. > http://www.zeyos.com > > -- Xinchen Hui @Laruence http://www.laruence.com/

[PHP-DEV] Re: Enable Zend Signals by Default

rocess. > Any objections? > > > No objections here. I have been hitting annoying segfaults in 7.0 that > will likely be helped by this. > No objections here neither, I already tried enable it in 7.0 :) thanks > > -Rasmus > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] [RFC] Throw Exception on Attempt of Constant Redefinition

ithub.com/php/php-src/commit/40702799b5f08b093477098881b6e0cfcb3ea411 ) to -1 I think it's better also include this into the patch? thanks > > > Thanks. Dmitry. > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] [RFC] Fix inconsistent behavior of $this variable

the codes doesn't work in 7.0 neither. it will result in fatal error: PHP Fatal error: Cannot re-assign $this thanks > > https://wiki.php.net/rfc/this_var > > > Thanks. Dmitry. > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] reused hash tables in large data structures in PHP7

recursion check. But > the array might be stored in shared memory(immutable array), in this case, you should not edit the apply count , you should check it, like what json does: https://github.com/php/php-src/blob/master/ext/json/json_encoder.c#L156 thanks it's not always, and a php-fpm restart can make it go away. > > Can anyone think of why this might happen? > > Thanks, > Adam > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Opcache::get($key), set($key, $value) to shared memory, is planned in PHP 7.1?

$value); > > Is planned in PHP 7.1? > you could try https://github.com/laruence/yac it's a "A fast shared memory user data cache for PHP " thanks > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Object getter method optimization

e.g. methods without arguments and FETCH_OBJ_R UNUSED, >> CONST -> TMP; RETURN TMP). >> >> Then INIT_METHOD_CALL may check this flag and execute "optimized code >> sequence" instead of pushing stack frame and real call. >> >> >> However, I'm not sure wh

Re: [PHP-DEV] Change in internal call_user_function() API.

is is for 7.1, right?) the value caller want to pass in should goes via arguments, which is a more reasonable way. thanks > > > https://gist.github.com/dstogov/5550827aa695ff8cb803 > > > The tricky way was used in phpdbg only, but that code doesn't work, and > should

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

anks > > > > -- > Regards, > Mike > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

[PHP-DEV] Re: Line numbers for "finally"

lock. otherwise, restore the exception, then goes like a new exception is throw(jmp to a CATCH block or leave current function which will result ZEND_HANDLE_EXCEPTION again). - I can't come up with PHP code that sets extended_value here either. > try { try { } finally { } /* this fast_ret will set to RET_TO_CATCH */ } catch () { } try { try { } finally { } /* this fast_ret will set to RET_TO_FINALLY */ } finally { } thanks > Can you? thanks > > cheers, > Derick > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] What's up with gcov.php.net?

s about coverage too, so… > and also valgrind, which is quite useful, since it takes too long to run in laptop. thanks > > Anyway, you’ve probably got to talk to Nuno; IIRC he was/is managing the > gcov box. > > Cheers, > Mike > > > -- > PHP Internals -

Re: [PHP-DEV] opcache.file_cache_only = 1 disables Opcode Caching

eaf7e7bfed681f8dfb4b901e55 now it will print: Zend OPcache Opcode Caching => Up and Running Optimization => Enabled SHM Cache => Disabled File Cache => Enabled Startup => OK thanks > Thanks :) > > // Tom > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] PHP7 Zend Heap validation

hat may be privileged and/or confidential. If you are not an > intended recipient, please notify the sender by return e-mail and delete > this e-mail and any attachments. Certain required legal entity disclosures > can be accessed on our website.< > http://site.thomsonreuters.com/site/disclosures/> > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] ext/interbase maintanance

Hey: On Tue, Dec 22, 2015 at 7:41 PM, Xinchen Hui <larue...@gmail.com> wrote: > Hey： > > Sent from my iPhone > > > On Dec 22, 2015, at 18:23, Lester Caine <les...@lsces.co.uk> wrote: > > > > On 22/12/15 08:43, Xinchen Hui wrote: > &g

Re: [PHP-DEV] ext/interbase maintanance

e on this one. since I still don't have setup a evn to test it... so there might be some problems thanks > Thanks > > Anatol > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] ext/interbase maintanance

Hey： Sent from my iPhone > On Dec 22, 2015, at 18:23, Lester Caine <les...@lsces.co.uk> wrote: > > On 22/12/15 08:43, Xinchen Hui wrote: >>> Here is a working patch of mine: >> https://gist.github.com/laruence/f3af903012902818d7da >> >> if you are goin

Re: [PHP-DEV] Travis CI is failing

eck the status of the build/tests after your commits: > https://travis-ci.org/php/php-src/branches > > At the moment ext/session/tests/bug32330.phpt fails for 5.6, 7.0 and > master. > most of them relates to session, Yasuo, could you please have a look into them? thanks > > T

Re: [PHP-DEV] Re: static:: and PHP 7 (from bug #70997)

Hey： > On Nov 30, 2015, at 22:48, Rowan Collins wrote: > > Andreas Heigl wrote on 30/11/2015 12:23: >>> Am 30.11.15 um 13:18 schrieb Peter Cowburn: >>> class A { const TEST = false; public function test() { var_dump(static::TEST);

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

Hey: On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov <nikita@gmail.com> wrote: > On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui <larue...@php.net> wrote: > >> Hey: >> >> >> >> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand <bobw...@hotmail.c

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

Hey: On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov <nikita@gmail.com> wrote: > On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui <larue...@php.net> wrote: > >> Hey: >> >> >> >> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand <bobw...@hotmail.c

Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness

a syntax , but \int result a compiler error, which seems a little in-consistent. thanks > Bob > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] 7.0.0 release

> official release. > I agree. I also go for a) thanks > > If something is found, it doesn't make the release any less high quality. > Any bugs that would be found between now and the 3rd will still be found > (and probably more), and they will still be fixed. The only difference > would be a 0.0.1 version number. > > /2c > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

t; looks more like lost attention. We could go with more RC, sure. However > in > > that case IMO we would catch bugs at very low speed with no guarantee we > > have a good thing at the end when we "think" it's good. This will cause > us > > to defer things for much longer time. Releasing on 26th (or on 3rd with > > respect to Thanksgiving, if there are still strong concerns) were IMHO > > convenient for this reasons. > > > > People that don't test RC won't start to test any later RC anyway. People > > that don't test RC will start to use GA and that will lead to bug > reports, > > in any case. So IMHO at this point we are good enough to do the first > > release with all the known bugs fixed, with the knowledge that no > critical > > bugs are present, with the knowledge that community projects like Drupal > 8, > > Symfony, etc. report the green tests, and with intention to get people > > waiting for GA involved. > > > > Regards > > > > Anatol > > > > > > > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

leases" may be > true for some, but the history is there that has caused MANY open > source projects a TON of pain. So it's definitely not something to > brush off. > > I'm less concerned by the specific issue here than by the 2 facts that > surround it: It was known by engine maintainers for months, and the > I get a little confused, who said this was known months ago? thanks > cavalier attitude around what defines "stable". Both of these are far > more critical and worth delaying to "get right" than this particular > "bug" is... > > Anthony > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable

er it's okey for PHP-7.0. will discuss with welting and Dmitry on Monday. thanks > > Thoughts? > Anthony > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

iveness of the variable won't be intrruptted? like: previously we emit: ZEND_ADD, ZEND_FAST_CALL, ZEND_RETURN. now we emit: ZEND_ADD, ZEND_RETURN, ZEND_FAST_CALL, ZEND_RETURN then in HANDLE_EXCEPTION we can dtor EX(return_value) if it is already set? this could also fixed double return memory leak like Zend/tests/try/bug70228.phpt thanks > > Thanks. Dmitry, > > > >> >> Nikita >> >> > -- Xinchen Hui @Laruence http://www.laruence.com/

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

On Wed, Nov 11, 2015 at 11:10 AM, Xinchen Hui <xinche...@zend.com> wrote: > Hey: > > On Tue, Nov 10, 2015 at 7:29 PM, Dmitry Stogov <dmi...@zend.com> wrote: > >> >> >> On Tue, Nov 10, 2015 at 1:42 PM, Nikita Popov <nikita@gmail.com> >>

[PHP-DEV] Re: Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)

inchen, could you please review and verify this once again, > then add necessary tests and commit. > No problem, all issues we met are resovled , thanks :) tested and committed. and aslo thanks the fabian who provides us ssh access to a reproducible box (it's really hard to reproduce locally)

[PHP-DEV] Re: Speed up fetching of class entries for self:: parent:: and static:: (Bob's idea)

branch, we can keep do something opts base on this after it merged. thanks > > (I realize there's a lot overhead, but that's because I try to have a not > too synthetic benchmark; but at least these methods are the bottleneck of > most HTTP/2 traffic in this server app, so, if I can speed these up, it > will be significant.) > > Bob > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Issues with exceptions and overloading opcodes

seems you already fixed it. :) thanks > > > Thanks. Dmitry. > > On Thu, Oct 22, 2015 at 5:43 AM, Xinchen Hui <larue...@php.net> wrote: > >> Hey: >> >> >> >> On Wed, Oct 21, 2015 at 10:38 PM, Derick Rethans <der...@php.net> wrote: >> >

Re: [PHP-DEV] few questions about op_array

gle instance of op_array in each moment. Fields reordering alrecy >> helped to reduce cache-misses. But I may be wrog :) >> >> Thanks. Dmitry. >> >> > >> > >> > >> > Cheers, >> > Yo-An Lin >> > https://github.com/c9s >> > >> > > > > -- > Best Regards, > > Yo-An Lin > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Issues with exceptions and overloading opcodes

> > > > > >>> Am 20.10.2015 um 17:11 schrieb Xinchen Hui <larue...@php.net>: > > >>> > > >>> On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans <der...@php.net > <mailto:der...@php.net>> wrote: > > >

[PHP-DEV] Re: Issues with exceptions and overloading opcodes

+bob On Tue, Oct 20, 2015 at 11:11 PM, Xinchen Hui <larue...@php.net> wrote: > Hey: > > > > On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans <der...@php.net> wrote: > >> Hi! >> >> When hacking on Xdebug for PHP 7, I ran into some issues where

[PHP-DEV] Re: Issues with exceptions and overloading opcodes

onation: http://xdebug.org/donate.php > twitter: @derickr and @xdebug > Posted with an email client that doesn't mangle email: alpine > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()

e should forbid such things as well for this moment, because it make things complicated to judge(if it is critical or not), such things can goes to 7.1 let's only allows bugs fix (as you mentioned above) to be committed into PHP-7.0 before the final release of its thanks > > Hopefully I could express myself better now. Cherry-pick is of course a > solution, but IMHO it is important every dev to understand the unique > situation we currently have to face. It is better to avoid cherry-picking > in favor of the "mission aware" code :) > Regards > > Anatol > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Xinchen Hui @Laruence http://www.laruence.com/

Re: [PHP-DEV] taint

k is right. Just for the record , Taint is ready for PHP7: https://github.com/laruence/taint/tree/php7 thanks > -- > Stas Malyshev > smalys...@gmail.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- X

[PHP-DEV] Re: [PHP-CVS] com php-src: Added an experemental ability to move PHP code pages (PHP TEXT segment) into HUGE pages. PHP should be configured and built with --enable-huge-code-pages, OS shoul

E" == "yes"; then >> AC_DEFINE(HAVE_OPCACHE_FILE_CACHE, 1, [Define to enable file based >> caching (experimental)]) >>fi >> >> + if test "$PHP_HUGE_CODE_PAGES" == "yes"; then >> +AC_DEFINE(HAVE_HUGE_CODE_PAGES, 1, [

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

Hey: On Tue, Sep 8, 2015 at 9:23 AM, Ryan Pallas <derokor...@gmail.com> wrote: > > On Mon, Sep 7, 2015 at 7:11 PM, Xinchen Hui <larue...@gmail.com> wrote: >> >> >> >> Sent from my iPhone >> >> > On Sep 8, 2015, at 02:09, Andrea Faulds &l

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiersin PHP 7.1+

Sent from my iPhone > On Sep 8, 2015, at 02:09, Andrea Faulds wrote: > > Hi Stas, > > Stanislav Malyshev wrote: >> >> Private and protected methods and properties are private for a reason - >> they may be radically changed or gone when the code is changing, and >> thus external

Re: [PHP-DEV] [RFC] [Discussion] Short Closures

r number of tokens to follow, not to mention that I need to >> pay attention to the use-blocks which may or may not be importing >> certain variables. The bottom reads exactly how I would expect it to. > > That's because you wrote it and know in advance what it is supposed to &

Re: [PHP-DEV] Need help finding segfault in php 7

, I finally get the reason of this bug.. I get a simple reproduce script and quick fix. all listed in https://bugs.php.net/bug.php?id=70272thanks=1 @dmitry: do you see a better solution ? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] Introduction and some opcache SSE related stuff

to get data from RAM is 100 cycles usually.. Nevertheless... they don't heart and it seems they still have a very small benefit so I preserved the original instruction and I added a new prefetch request for the destination pointer. Hope it helps, Bogdan -- Xinchen Hui @Laruence http

Re: [PHP-DEV] [RFC] Block requests to builtin SQL functions where PHP can prove the call is vulnerable to a potential SQL-injection attack

List To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] bug35437.php fails on master?

Kovács @Tyr43l - http://tyrael.hu -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Make debug_zval_dump prints int as long

are worrying about this will break some APPs unit tests .. anyway, welting doesn't find any in github.. so, is there any objections to merge this into PHP7.0? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit

Re: [PHP-DEV] Optimizing php_html_entities()

approximation unset($t[array_search(max($t), $t)]); unset($t[array_search(max($t), $t)]); $time = array_sum($t)/(ITER-2); echo Time Avg: ${time}\n; -- Yasuo Ohgaki yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] Optimizing php_html_entities()

cases.. optimize not common used cases... will bring nothing to us.. thanks -- Yasuo Ohgaki yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Optimizing php_html_entities()

Hey: On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Xinchen, On Tue, Jun 23, 2015 at 11:33 PM, Xinchen Hui larue...@php.net wrote: But passing an non-string to htmlspecialchars are not common used cases.. optimize not common used cases... will bring nothing

Re: [PHP-DEV] Optimizing php_html_entities()

Hey: On Wed, Jun 24, 2015 at 10:35 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Xinchen, On Wed, Jun 24, 2015 at 11:31 AM, Xinchen Hui larue...@php.net wrote: On Wed, Jun 24, 2015 at 8:32 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Xinchen, On Tue, Jun 23, 2015 at 11:33 PM

Re: [PHP-DEV] Segfault in master with PHPUnit

Hey Bob: On Sun, Jun 14, 2015 at 2:08 PM, Sebastian Bergmann sebast...@php.net wrote: Am 14.06.2015 um 07:55 schrieb Xinchen Hui: maybe related to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247 Yes, reverting that commit fixes it. Thanks for the pointer! please have a look of it.. I'd like

Re: [PHP-DEV] Segfault in master with PHPUnit

to this : 3cfa58367b1b85d346d9be6cf9ae116c63571247 could you please try again with revert that? thanks -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] PR #1325 - array_column() for array of objects

an array is populated with a mixed set of objects and arrays; any professional would baulk at the idea, but rules of the jungle are pervasive. Before I merge this, are there any objections to shipping this with 7.0? -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP

Re: [PHP-DEV] Bug #69180: Reflection does not honor trait conflict resolution / method aliasing

Hey: On Fri, May 29, 2015 at 5:21 PM, Sebastian Bergmann sebast...@php.net wrote: On 05/29/2015 08:59 AM, Xinchen Hui wrote: Actually, I had looked it, but there is no such Infos can be used after compiling is done in current traits design, so But calling C::bar() works, so PHP knows

Re: [PHP-DEV] Bug #69180: Reflection does not honor trait conflict resolution / method aliasing

Hey： Sent from my iPhone On May 29, 2015, at 1:57 PM, Sebastian Bergmann sebast...@php.net wrote: Would be nice if somebody could have a look at https://bugs.php.net/bug.php?id=69180 -- thanks! Actually, I had looked it, but there is no such Infos can be used after compiling is done in

Re: [PHP-DEV] Pull request labels handling

-- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Bug #69640 Unhandled EngineExceptions thrown from userland do not produce any output

Hey: On Sat, May 16, 2015 at 1:41 AM, Dan Ackroyd dan...@basereality.com wrote: On 15 May 2015 at 17:12, Xinchen Hui larue...@gmail.com wrote: How would that work when people want to write unit/integration tests to test the behaviour of a module when an EngineException is thrown? If you

Re: [PHP-DEV] Bug #69640 Unhandled EngineExceptions thrown from userland do not produce any output

Hey： On May 16, 2015, at 12:35 AM, Dan Ackroyd dan...@basereality.com wrote: On 15 May 2015 at 14:38, Xinchen Hui larue...@gmail.com wrote: Hey: as described in https://bugs.php.net/bug.php?id=69640thanks=1 instead of fixing it by exam the error type, I'd prefer to disallow

Re: [PHP-DEV] Fixing bundled extension version mess

Hey： Sent from my iPhone On Apr 15, 2015, at 10:21 AM, Pierre Joye pierre@gmail.com wrote: hi, We tried that many times but we fail to handle the version of bundled extensions. Along with some installer work and other integration (projects dependencies management, composer or

Re: [PHP-DEV] is_callable and function_exists with disable_functions

Hey: On Fri, Mar 27, 2015 at 1:14 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi all, On Fri, Mar 27, 2015 at 11:57 AM, Xinchen Hui larue...@php.net wrote: On Fri, Mar 27, 2015 at 3:06 AM, Kalle Sommer Nielsen ka...@php.net wrote: Forgot to CC list -- Forwarded message

Re: [PHP-DEV] [RFC] Fix the Tenary Operator -- Please!? Please?

freeze should block bug fixes... thanks --Kris -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] is_callable and function_exists with disable_functions

be discussed and analysed carefully. However preventing conversion of disabled functions into opcodes and their optimization makes full sense. okey, I will separate these part to a single fix thanks Thanks. Dmitry. On Fri, Mar 27, 2015 at 9:41 AM, Xinchen Hui larue...@php.net wrote: Hey

[PHP-DEV] is_callable and function_exists with disable_functions

. function_exisis tell it is not exists but is_callable said it is callable.. do you mind if I change the current behavior of is_callable , to return false on this case? or, at least, change function_exists's behavior instead? thanks -- Xinchen Hui @Laruence http://www.laruence.com

[PHP-DEV] Re: Use ropes for string concatenation

Hey: On Tue, Mar 24, 2015 at 5:28 PM, Xinchen Hui larue...@gmail.com wrote: Hey Sent from my iPhone On Mar 24, 2015, at 5:11 PM, Nikita Popov nikita@gmail.com wrote: On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, Recently, Xinchen and me worked

[PHP-DEV] Re: Use ropes for string concatenation

Hey Sent from my iPhone On Mar 24, 2015, at 5:11 PM, Nikita Popov nikita@gmail.com wrote: On Mon, Mar 23, 2015 at 11:41 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, Recently, Xinchen and me worked on optimization that eliminates useless reallocations and copying during string

[PHP-DEV] Re: Use ropes for string concatenation

Nikita -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Use ropes for string concatenation

Hey: On Tue, Mar 24, 2015 at 2:04 PM, Pierre Joye pierre@gmail.com wrote: On Tue, Mar 24, 2015 at 1:01 PM, Xinchen Hui xinche...@zend.com wrote: Hey: On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye pierre@gmail.com wrote: On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui xinche...@zend.com

Re: [PHP-DEV] Use ropes for string concatenation

Hey: On Tue, Mar 24, 2015 at 1:54 PM, Pierre Joye pierre@gmail.com wrote: On Tue, Mar 24, 2015 at 12:35 PM, Xinchen Hui xinche...@zend.com wrote: Hey: On Tue, Mar 24, 2015 at 1:31 PM, Pierre Joye pierre@gmail.com wrote: hi! On Tue, Mar 24, 2015 at 5:41 AM, Dmitry Stogov dmi

Re: [PHP-DEV] Use ropes for string concatenation

experiment and implement this idea sounds safer to me (read: we have a bit less than a year to valid it then). Cheers, -- Pierre @pierrejoye | http://www.libgd.org -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe

Re: [PHP-DEV] 回复： [RFC][DISCUSSION] Add preg_replace_callback_array function

Hey: On Fri, Mar 20, 2015 at 9:14 PM, Xinchen Hui larue...@php.net wrote: Hey: On Fri, Mar 20, 2015 at 7:53 PM, Alain Williams a...@phcomp.co.uk wrote: On Fri, Mar 20, 2015 at 10:46:58PM +1100, Pierre Joye wrote: On Fri, Mar 20, 2015 at 7:03 PM, Wei Dai zxcvda...@gmail.com wrote: Hi

Re: [PHP-DEV] 回复： [RFC][DISCUSSION] Add preg_replace_callback_array function

/ Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php #include std_disclaimer.h -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP

Re: [PHP-DEV] [RFC][Accepted] Scalar Type Declarations V0.5

the word strict from strict_types at least as it is not strict at all if caller(parent script) does not specify strict_types=1. Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] About declare(strict_types = 1)

Hey: On Mon, Mar 16, 2015 at 9:32 PM, Pascal Chevrel pascal.chev...@free.fr wrote: Le 16/03/2015 12:39, Xinchen Hui a écrit : Hey: And last comment, if there no such declare thing, I will definitely vote yes to this RFC. Hi Xinchen, You can also not vote at all, that's a very valid

Re: [PHP-DEV] Dual Mode STH

this new feature is accepted and used. Again, I call upon everybody to vote Yes for the Dual Mode RFC to ensure that we have some form of STH in PHP 7.0. Unecessary for everybody, one or two change from no to yes will make it pass. :) thanks Zeev -- Xinchen Hui @Laruence http

Re: [PHP-DEV] About declare(strict_types = 1)

Hey: On Mon, Mar 16, 2015 at 7:33 PM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Derick, On Mon, Mar 16, 2015 at 8:18 PM, Derick Rethans der...@php.net wrote: On Mon, 16 Mar 2015, Xinchen Hui wrote: On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye pierre@gmail.com wrote: On Mar

Re: [PHP-DEV] About declare(strict_types = 1)

Hey: On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans der...@php.net wrote: On Mon, 16 Mar 2015, Xinchen Hui wrote: On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye pierre@gmail.com wrote: On Mar 16, 2015 4:29 PM, Xinchen Hui larue...@php.net wrote: that means, I need to add a lots

Re: [PHP-DEV] About declare(strict_types = 1)

On Mon, Mar 16, 2015 at 7:32 PM, Xinchen Hui larue...@php.net wrote: Hey: On Mon, Mar 16, 2015 at 7:18 PM, Derick Rethans der...@php.net wrote: On Mon, 16 Mar 2015, Xinchen Hui wrote: On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye pierre@gmail.com wrote: On Mar 16, 2015 4:29 PM

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

Laruence's RFC: https://wiki.php.net/rfc/second_arg_to_preg_callback and its discussion thread (http://php.markmail.org/thread/qwiyq5o2vwlbdczq). thanks Any objections? — Best, Wei Dai -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

Hey: On Mon, Mar 16, 2015 at 11:32 PM, Peter Cowburn petercowb...@gmail.com wrote: On 16 March 2015 at 14:59, Xinchen Hui larue...@php.net wrote: Hey: On Mon, Mar 16, 2015 at 5:45 PM, Peter Cowburn petercowb...@gmail.com wrote: On 16 March 2015 at 01:40, Wei Dai zxcvda...@gmail.com wrote

Re: [PHP-DEV] [RFC][DISCUSSION] Add preg_replace_callback_array function

we removed /e if you objections raise in couple days, I will merge this. thanks — Best, Wei Dai -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Minimum version of GCC required to build PHP

To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] About declare(strict_types = 1)

Hey: On Mon, Mar 16, 2015 at 5:00 PM, Pierre Joye pierre@gmail.com wrote: Hi, On Mar 16, 2015 4:29 PM, Xinchen Hui larue...@php.net wrote: Hey: The most unaccept feature in current STH thing(v.5.0) is this. acutaly, I believe in most applications, they will still keep

[PHP-DEV] About declare(strict_types = 1)

']); //recoverable error since all input in _GET _POST is string by default ? that means, I need to add a lots of (int) while I try to call a function in a library which is not written by myself. is that right? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals

Re: [PHP-DEV] About declare(strict_types = 1)

Hey: On Mon, Mar 16, 2015 at 1:49 PM, Dennis Birkholz den...@birkholz.biz wrote: Hello Xinchen, Am 16.03.2015 um 06:28 schrieb Xinchen Hui: lib.php ?php declare(strict_types = 1); function add(int $a, int $b) { } ?php add($_GET['a'], $_GET['b

Re: [PHP-DEV] Drop Multiply VM kind support

Hey: On Sat, Mar 14, 2015 at 8:01 PM, Bob Weinand bobw...@hotmail.com wrote: Am 13.03.2015 um 05:01 schrieb Xinchen Hui larue...@php.net: Hey: We have CALL SWITCH GOTO vm kind supports for long time. And we use CALL for default. SWITCH GOTO seems useless now, and brings us

[PHP-DEV] Re: Drop Multiply VM kind support

with CALL and global CPU registers s well :( that exactly how the problem came to my :) thanks Thanks. Dmitry. On Fri, Mar 13, 2015 at 7:01 AM, Xinchen Hui larue...@php.net wrote: Hey: We have CALL SWITCH GOTO vm kind supports for long time. And we use CALL for default

[PHP-DEV] Drop Multiply VM kind support

) = execute_data-opline-handler(execute_data); So, maybe it's time for us to remove GOTO and SWITCH at all? thanks -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [Discussion] Deprecate function sizeof()

: anyway, I'd prefer don't do it. especially with little gain. thanks Regards, -- Yasuo Ohgaki yohg...@ohgaki.net -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Arrays being generated with length and no content on master

Hey： On Mar 7, 2015, at 1:23 PM, Juan Basso jrba...@gmail.com wrote: I was testing CakePHP framework with PHP 7 and some tests were failing. Digging into the issue I found that using compact in a certain way can cause PHP to create an array with length but no content inside. I reported

  1   2   3   >