Hi Marcus,
I committed the ZE part of your patch with exception for
zend_error(E_ERROR, Cannot destroy active lambda function);
Catching this error may cause memory corruption and crash.
Thanks. Dmitry.
Marcus Boerger wrote:
Hello Johannes, Christian, Felipe,
and here 5.3 and 6.0
Hello Dmitry,
Monday, August 11, 2008, 10:51:44 AM, you wrote:
Hi Marcus,
I committed the ZE part of your patch with exception for
zend_error(E_ERROR, Cannot destroy active lambda function);
Catching this error may cause memory corruption and crash.
Alright, didn't see that immediately.
Hello guys,
all submitted now. Thanks everyone for their help and especially
Christian for getting this started.
marcus
Monday, August 11, 2008, 12:23:57 PM, you wrote:
Hello Dmitry,
Monday, August 11, 2008, 10:51:44 AM, you wrote:
Hi Marcus,
I committed the ZE part of your patch
Hi,
all submitted now. Thanks everyone for their help and especially
Christian for getting this started.
Thanks for making my patch work after the modifications in
zend_closures.c. I'm sorry I couldn't do it myself but I was kind of
busy the last few days and the simple fix created memory
Hello Christian,
Monday, August 11, 2008, 8:43:31 PM, you wrote:
Hi,
all submitted now. Thanks everyone for their help and especially
Christian for getting this started.
Thanks for making my patch work after the modifications in
zend_closures.c. I'm sorry I couldn't do it myself but I
Hello Christian,
Monday, August 11, 2008, 8:43:31 PM, you wrote:
Hi,
all submitted now. Thanks everyone for their help and especially
Christian for getting this started.
Thanks for making my patch work after the modifications in
zend_closures.c. I'm sorry I couldn't do it myself but I
Hi Marcus,
Account approved and access granted.
Thanks!
Please provide the function copying in a function next to _free_function()
I just committed that (and included some tests). I hope I didn't do
anything wrong in the process, if so, feel free to do so.
and care for parameter info as
Hello Christian,
Tuesday, August 12, 2008, 12:34:41 AM, you wrote:
Hi Marcus,
Account approved and access granted.
Thanks!
Please provide the function copying in a function next to _free_function()
I just committed that (and included some tests). I hope I didn't do
anything wrong in
Hello Christian,
I updated your patch for 5.3 due to recent changes. It works pretty fine
for me. Care to test again, especially with your new tests? Note that test
ext/reflection/tests/closures_001.phpt does not work for me and I have no
clue why. Well, besides that obviously the closure class
Hello Christian, Johannes,
Friday, August 8, 2008, 11:48:37 PM, you wrote:
Hello Christian,
I updated your patch for 5.3 due to recent changes. It works pretty fine
for me. Care to test again, especially with your new tests? Note that test
ext/reflection/tests/closures_001.phpt does not
Hi Marcus,
I have no objections against ZE part of the patch.
If you like ext/reflection part please commit the whole patch.
Thanks. Dmitry.
Christian Seiler wrote:
Hi,
http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch
Christian,
On Mon, 2008-08-04 at 11:33 +0400, Dmitry Stogov wrote:
http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch
http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch
without applying and
Hi Dmitry, Hi Marcus,
I have no objections against ZE part of the patch.
If you like ext/reflection part please commit the whole patch.
Due to your cleanup wrt. handlers the reflection part will currently
(probably) segfault. I'll post an updated patch for this tomorrow.
Regards,
Christian
Hi,
http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch
http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch
The last CVS commit for apply_func_t and TSRMLS_CC conflicted with the
patches, I merged the
Hello Christian,
patch looks fine and should go in.
do you think ReflectionMethod::__construct implementation could be done
using parameterparsing 'f' rather than the spcial case 'o'? Unfortunately
we would still need the zs version unless we add another 'F' parameter
parsing that allows
Hi Marcus,
patch looks fine and should go in.
Thanks.
do you think ReflectionMethod::__construct implementation could be done
using parameterparsing 'f' rather than the spcial case 'o'?
The Problem with 'f' is that it will accept every callback, even normal
functions, so that would
Hello Christian,
Friday, July 25, 2008, 9:01:13 PM, you wrote:
Hi Marcus,
patch looks fine and should go in.
Thanks.
do you think ReflectionMethod::__construct implementation could be done
using parameterparsing 'f' rather than the spcial case 'o'?
The Problem with 'f' is that it
On 25.07.2008, at 20:56, Marcus Boerger wrote:
Hello Christian,
patch looks fine and should go in.
do you think ReflectionMethod::__construct implementation could be
done
using parameterparsing 'f' rather than the spcial case 'o'?
Unfortunately
we would still need the zs version
Hi,
I'd like to add the following patch to reflection before the feature
freeze, because it does not change any current reflection behaviour but
adds quite a bit of good stuff for closures.
With the current closure implementation, __invoke always has the same
signature as the original lambda
19 matches
Mail list logo
