Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Nikita Popov
On Mon, Jul 8, 2019 at 6:56 PM Zeev Suraski wrote: > > > On Mon, Jul 8, 2019 at 5:37 PM Nikita Popov wrote: > >> >> I'm certainly not a domain expert in RTL languages. I'd be happy to drop >> hebrev() from this RFC if someone can bring forward a good technical >> argument as to why these

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Zeev Suraski
On Mon, Jul 8, 2019 at 5:37 PM Nikita Popov wrote: > > I'm certainly not a domain expert in RTL languages. I'd be happy to drop > hebrev() from this RFC if someone can bring forward a good technical > argument as to why these functions are still necessary and where they would > be used. > I do

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Nikita Popov
On Mon, Jul 8, 2019 at 4:01 PM Zeev Suraski wrote: > > > On Mon, Jul 8, 2019 at 3:38 PM Nikita Popov wrote: > >> On Mon, Jul 8, 2019 at 1:55 PM Zeev Suraski wrote: >> >>> >>> >>> On Mon, Jul 8, 2019 at 1:28 PM Nikita Popov >>> wrote: >>> I have now made the following changes to the RFC:

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-07-08 Thread Nikita Popov
On Mon, Jul 8, 2019 at 3:41 PM Claude Pache wrote: > The deprecation RFC lists `apache_request_headers()`, because it is “an > Apache-specific name is also available in other SAPIs, even though it is > also available under the SAPI-independent name getallheaders()”. > > Have you ever thought

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Zeev Suraski
On Mon, Jul 8, 2019 at 3:38 PM Nikita Popov wrote: > On Mon, Jul 8, 2019 at 1:55 PM Zeev Suraski wrote: > >> >> >> On Mon, Jul 8, 2019 at 1:28 PM Nikita Popov wrote: >> >>> I have now made the following changes to the RFC: >>> >>> * Removed enable_dl deprecation. The fact that dl() is

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-07-08 Thread Claude Pache
The deprecation RFC lists `apache_request_headers()`, because it is “an Apache-specific name is also available in other SAPIs, even though it is also available under the SAPI-independent name getallheaders()”. Have you ever thought about making a more thorough and consistent change with other

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Thomas Hruska
On 7/8/2019 4:55 AM, Zeev Suraski wrote: Why are we proactively making the lives of users more difficult for literally no gain at all? Zeev Because that's what software developers tend to do when they are bored. Instead of focusing on API stability, squashing bugs and other generally

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Nikita Popov
On Mon, Jul 8, 2019 at 1:55 PM Zeev Suraski wrote: > > > On Mon, Jul 8, 2019 at 1:28 PM Nikita Popov wrote: > >> I have now made the following changes to the RFC: >> >> * Removed enable_dl deprecation. The fact that dl() is currently >> available >> by default on CGI, which is a server SAPI,

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Zeev Suraski
On Mon, Jul 8, 2019 at 1:28 PM Nikita Popov wrote: > I have now made the following changes to the RFC: > > * Removed enable_dl deprecation. The fact that dl() is currently available > by default on CGI, which is a server SAPI, makes this more dicey and needs > more careful consideration. As

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-08 Thread Nikita Popov
On Fri, Jul 5, 2019 at 4:37 PM Nikita Popov wrote: > On Sat, Jun 22, 2019 at 10:21 PM Stanislav Malyshev > wrote: > >> Hi! >> >> enable_dl - I am not clear what is proposed - to remove dl() >> functionality in PHP 8 completely, even in CLI? Or to keep it in CLI >> always on and remove the

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-07-05 Thread Nikita Popov
On Sat, Jun 22, 2019 at 10:21 PM Stanislav Malyshev wrote: > Hi! > > enable_dl - I am not clear what is proposed - to remove dl() > functionality in PHP 8 completely, even in CLI? Or to keep it in CLI > always on and remove the directive? > My opinion: drop the directive, let the SAPI decide if

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Andrey Andreev
Hi, On Sat, Jun 22, 2019 at 3:59 PM Nikita Popov wrote: > > On Sat, Jun 22, 2019 at 2:24 PM Andrey Andreev wrote: >> >> Hi, >> >> With regards to the array_key_exists() deprecation, the RFC currently >> says nothing about things like ArrayAccess and object properties that >> contain arrays. I'm

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Christoph M. Becker
On 22.06.2019 at 21:31, Stanislav Malyshev wrote: >> While I understand where you are coming from on this, I do think that >> functionality that is better supported by dedicated extensions to do >> the job instead of providing some functions in the standard library >> that converts from a few

Re: [PHP-DEV] [RFC] Deprecations for 7.4 - specifics

2019-06-22 Thread Stanislav Malyshev
Hi! enable_dl - I am not clear what is proposed - to remove dl() functionality in PHP 8 completely, even in CLI? Or to keep it in CLI always on and remove the directive? My opinion: drop the directive, let the SAPI decide if dl() is possible, with CLI keeping it. Not sure about embed though. But

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Stanislav Malyshev
Hi! > In general, something is considered a primary vote if it could be > conducted independently of other primary votes in the same RFC - ie, it > is not an implementation detail. > > So, what we have here is multiple primary votes ... I am not talking bureaucracy here, I'm talking about

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Stanislav Malyshev
Hi! > While I understand where you are coming from on this, I do think that > functionality that is better supported by dedicated extensions to do > the job instead of providing some functions in the standard library > that converts from a few specific encodings to another: It may be supported

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Nikita Popov
On Sat, Jun 22, 2019 at 6:11 PM Pieter Hordijk wrote: > > > > Also, it's unclear to me why get_called_class() should be deprecated. > > While the rest of the listed deprecations have either motivation > > written for them or are self-evidently legacy functionalities that > > nobody should be

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Pieter Hordijk
> Also, it's unclear to me why get_called_class() should be deprecated. > While the rest of the listed deprecations have either motivation > written for them or are self-evidently legacy functionalities that > nobody should be using today, this one seems to be just a case of > "let's not have

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Nikita Popov
On Sat, Jun 22, 2019 at 2:24 PM Andrey Andreev wrote: > Hi, > > With regards to the array_key_exists() deprecation, the RFC currently > says nothing about things like ArrayAccess and object properties that > contain arrays. I'm sure that these are exceptions that aren't meant > to be deprecated,

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Andrey Andreev
Hi, With regards to the array_key_exists() deprecation, the RFC currently says nothing about things like ArrayAccess and object properties that contain arrays. I'm sure that these are exceptions that aren't meant to be deprecated, but can you please specify that explicitly? We all know how little

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Zeev Suraski
On Sat, Jun 22, 2019 at 10:23 AM Kalle Sommer Nielsen wrote: > Hi > Den lør. 22. jun. 2019 kl. 02.04 skrev Stanislav Malyshev < > smalys...@gmail.com>: > > My first question for many of those is - why? I.e. it deprecates a bunch > > of niche functions. Most people do not use these functions, so

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Claude Pache
> Le 22 juin 2019 à 09:22, Kalle Sommer Nielsen a écrit : > > Hi > Den lør. 22. jun. 2019 kl. 02.04 skrev Stanislav Malyshev > : >> My first question for many of those is - why? I.e. it deprecates a bunch >> of niche functions. Most people do not use these functions, so they >> probably don't

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Joe Watkins
Just a note on process. It is not necessary to hold multiple RFC's: > For procedural reasons, multiple RFCs may be combined into one, in which case there may be multiple primary votes. > Combining multiple RFCs into one does not allow turning a primary vote into a secondary vote. In general,

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-22 Thread Kalle Sommer Nielsen
Hi Den lør. 22. jun. 2019 kl. 02.04 skrev Stanislav Malyshev : > My first question for many of those is - why? I.e. it deprecates a bunch > of niche functions. Most people do not use these functions, so they > probably don't care. Those they do use them would find their code broken > or produce

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Stanislav Malyshev
Hi! > I've update the RFC to say that the option will be removed without > deprecation, with argv always available on CLI and never on non-CLI. > Throwing a deprecation warning when accessing $argv in non-CLI SAPIs is too > complicated and/or unreliable. So this means CGI binary would not have

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Stanislav Malyshev
Hi! > Nikita and I would like to open the discussion for the RFC: > "Deprecations for 7.4", this RFC targets a larger set of various > features targeting for deprecation in 7.4 with the intention of > removal in PHP 8.0. My first question for many of those is - why? I.e. it deprecates a bunch of

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Bishop Bettini
On Fri, Jun 21, 2019 at 2:46 PM Claude Pache wrote: > > > > Le 21 juin 2019 à 20:15, Bishop Bettini a écrit : > > > > On Fri, Jun 21, 2019, 13:54 Claude Pache > wrote: > > > > > > > Le 21 juin 2019 à 17:20, Kalle Sommer Nielsen ka...@php.net>> a écrit : > > > >

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Claude Pache
> Le 21 juin 2019 à 20:15, Bishop Bettini a écrit : > > On Fri, Jun 21, 2019, 13:54 Claude Pache > wrote: > > > > Le 21 juin 2019 à 17:20, Kalle Sommer Nielsen > > a écrit : > > > > Greetings Internals > > > > Nikita and I would like

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Bishop Bettini
On Fri, Jun 21, 2019, 13:54 Claude Pache wrote: > > > > Le 21 juin 2019 à 17:20, Kalle Sommer Nielsen a écrit : > > > > Greetings Internals > > > > Nikita and I would like to open the discussion for the RFC: > > "Deprecations for 7.4", this RFC targets a larger set of various > > features

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Claude Pache
> Le 21 juin 2019 à 17:20, Kalle Sommer Nielsen a écrit : > > Greetings Internals > > Nikita and I would like to open the discussion for the RFC: > "Deprecations for 7.4", this RFC targets a larger set of various > features targeting for deprecation in 7.4 with the intention of > removal in

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Nikita Popov
On Fri, Jun 21, 2019 at 6:54 PM Theodore Brown wrote: > On Fri, Jun 21, 2019 at 10:20 AM Kalle Sommer Nielsen > wrote: > > > Nikita and I would like to open the discussion for the RFC: > > "Deprecations for 7.4", this RFC targets a larger set of various > > features targeting for deprecation in

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Theodore Brown
On Fri, Jun 21, 2019 at 10:20 AM Kalle Sommer Nielsen wrote: > Nikita and I would like to open the discussion for the RFC: > "Deprecations for 7.4", this RFC targets a larger set of various > features targeting for deprecation in 7.4 with the intention of > removal in PHP 8.0. > >

Re: [PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Rowan Collins
On Fri, 21 Jun 2019 at 16:20, Kalle Sommer Nielsen wrote: > Greetings Internals > > Nikita and I would like to open the discussion for the RFC: > "Deprecations for 7.4", this RFC targets a larger set of various > features targeting for deprecation in 7.4 with the intention of > removal in PHP

[PHP-DEV] [RFC] Deprecations for 7.4

2019-06-21 Thread Kalle Sommer Nielsen
Greetings Internals Nikita and I would like to open the discussion for the RFC: "Deprecations for 7.4", this RFC targets a larger set of various features targeting for deprecation in 7.4 with the intention of removal in PHP 8.0. https://wiki.php.net/rfc/deprecations_php_7_4 If there is no major