Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Hans Henrik Bergan
dang, yeah completely missed that, sorry On Mon, 11 Oct 2021 at 13:14, Tim Starling wrote: > On 11/10/21 9:33 pm, Hans Henrik Bergan wrote: > > @Nicolas i hope mediawiki doesn't run on Windows, because that > > escapeshellarg-replacement you did is not valid for windows. > > Maybe you missed

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Tim Starling
On 11/10/21 9:33 pm, Hans Henrik Bergan wrote: > @Nicolas i hope mediawiki doesn't run on Windows, because that > escapeshellarg-replacement you did is not valid for windows. Maybe you missed the Windows-specific code on lines 113-146.

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Hans Henrik Bergan
@Nicolas i hope mediawiki doesn't run on Windows, because that escapeshellarg-replacement you did is not valid for windows. the code prints: echo 'foo && whoami && echo ' and when i run that in bash i get: C:\Users\hansh>echo 'foo && whoami && echo ' 'foo laptop-1plmku02\hansh ' - whoami was

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-11 Thread Nicolas Grekas
Le lun. 11 oct. 2021 à 03:33, Tim Starling a écrit : > On 4/10/21 9:08 pm, Nikita Popov wrote: > > > > Hi Tim, > > > > Thanks for creating this proposal, it looks great! > > > > I think this is a very beneficial change, and the amount of > > incorrect locale-dependent calls we had just in

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-10 Thread Tim Starling
On 4/10/21 9:08 pm, Nikita Popov wrote: > > Hi Tim, > > Thanks for creating this proposal, it looks great! > > I think this is a very beneficial change, and the amount of > incorrect locale-dependent calls we had just in php-src further > convinced me of this: We're generally aware of the problem,

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-04 Thread Bob Weinand
> Am 04.10.2021 um 12:08 schrieb Nikita Popov : > > On Thu, Sep 23, 2021 at 8:32 AM Tim Starling > > wrote: > >> Please consider my RFC for locale-independent case conversion. >> >> https://wiki.php.net/rfc/strtolower-ascii >>

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-10-04 Thread Nikita Popov
On Thu, Sep 23, 2021 at 8:32 AM Tim Starling wrote: > Please consider my RFC for locale-independent case conversion. > > https://wiki.php.net/rfc/strtolower-ascii > https://github.com/php/php-src/pull/7506 > > The RFC and associated PR ended up going some way beyond the original > scope, because

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-09-23 Thread Tim Starling
On 23/9/21 4:53 pm, Pierre Joye wrote: > I wonder if either JIT could be used for the intrinsics support, > adding neon, sse[2-4.2] or avc256/512 (the latter would basically > allow most common strings to be converted in one go. > > If not, maybe split implementation however runtime cpu support

Re: [PHP-DEV] [RFC] Locale-independent case conversion

2021-09-23 Thread Pierre Joye
Hi Tim, On Thu, Sep 23, 2021 at 1:32 PM Tim Starling wrote: > > Please consider my RFC for locale-independent case conversion. > > https://wiki.php.net/rfc/strtolower-ascii very good one, thanks :) > https://github.com/php/php-src/pull/7506 > The RFC and associated PR ended up going some way

[PHP-DEV] [RFC] Locale-independent case conversion

2021-09-23 Thread Tim Starling
Please consider my RFC for locale-independent case conversion. https://wiki.php.net/rfc/strtolower-ascii https://github.com/php/php-src/pull/7506 The RFC and associated PR ended up going some way beyond the original scope, because for consistency, it's best if everything has the same concept of