Re: [PHP-DEV] [RFC] Typed Properties

On 11 July 2018 at 14:44, Levi Morrison wrote: > > My logic is quite simple: > > 1. Something as big as Typed Properties shouldn't be a last minute, > rushed > > RFC. Really - any RFC shouldn't - but in particular major language > changes. > > I have seen this sentiment expressed elsewhere. I

Re: [PHP-DEV] [RFC] Typed Properties

Nope On Thu, 12 Jul 2018, 21:10 Stanislav Malyshev, wrote: > Hi! > > > - As I said earlier, this patch has already been tested against some > > extremely tricky scenarios, so from a userland perspective it is safe for > > inclusion. If you don't have confidence in something related to it, >

Re: [PHP-DEV] [RFC] Typed Properties

Hi! > - As I said earlier, this patch has already been tested against some > extremely tricky scenarios, so from a userland perspective it is safe for > inclusion. If you don't have confidence in something related to it, please > write a test case and help out. It sounds like you are talking

Re: [PHP-DEV] [RFC] Typed Properties

Hi! > Well... it's not being voted on because, despite being six days till > the originally planned feature freeze date, neither sponsor has opened > a vote. And I think it's a good thing. Both for selfish reasons (I haven't actually have the time to read the proposal and the mail thread

Re: [PHP-DEV] [RFC] Typed Properties

Hi! > Ah, thanks, Nikita! Considering this, I'm not against delaying beta1 > for two weeks and having an alpha4, provided that we do not allow any > new (i.e. not yet under discussion) RFC to target 7.3. > > Stas, what do you think? Sorry for late answer, I've been behind my emails due to

Re: [PHP-DEV] [RFC] Typed Properties

On Wed, Jul 11, 2018 at 10:43 AM, Levi Morrison wrote: >> It is being rushed as far as the RFC process & discussions around it are >> concerned - that's what I meant. > > I do not agree with this either. This has been previously discussed, > they have given it an ample discussion period, and it

Re: [PHP-DEV] [RFC] Typed Properties

On Wed, Jul 11, 2018 at 5:44 PM Levi Morrison wrote: > > It is being rushed as far as the RFC process & discussions around it are > concerned - that's what I meant. > > I do not agree with this either. This has been previously discussed, > they have given it an ample discussion period, and it

Re: [PHP-DEV] [RFC] Typed Properties

> It is being rushed as far as the RFC process & discussions around it are > concerned - that's what I meant. I do not agree with this either. This has been previously discussed, they have given it an ample discussion period, and it seems the only reason it's not being voted on is because people

Re: [PHP-DEV] [RFC] Typed Properties

On Wed, Jul 11, 2018 at 4:44 PM Levi Morrison wrote: > > My logic is quite simple: > > 1. Something as big as Typed Properties shouldn't be a last minute, > rushed > > RFC. Really - any RFC shouldn't - but in particular major language > changes. > > I have seen this sentiment expressed

Re: [PHP-DEV] [RFC] Typed Properties

On Wed, Jul 11, 2018 at 3:44 PM, Levi Morrison wrote: > > My logic is quite simple: > > 1. Something as big as Typed Properties shouldn't be a last minute, > rushed > > RFC. Really - any RFC shouldn't - but in particular major language > changes. > > I have seen this sentiment expressed

Re: [PHP-DEV] [RFC] Typed Properties

> My logic is quite simple: > 1. Something as big as Typed Properties shouldn't be a last minute, rushed > RFC. Really - any RFC shouldn't - but in particular major language changes. I have seen this sentiment expressed elsewhere. I want to personally affirm that Nikita and Bob have been

Re: [PHP-DEV] [RFC] Typed Properties

On 10.07.2018 at 12:26, Nikita Popov wrote: > I've just updated the RFC with the last major change (switch to the "no > intrinsic types" alternative for reference handling). Apart from some minor > tweaks (maybe add a bit more information on how the implementation works) > the RFC itself should

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 10:19 PM Larry Garfield wrote: > While the marketing angle is valid, Zeev, it seems predicated on the idea > that > there won't be any other major new-and-cool features developed between now > and > 8.0. I'm reasonably confident that someone will find some user-facing >

Re: [PHP-DEV] [RFC] Typed Properties

On Tuesday, July 10, 2018 6:56:24 AM CDT Zeev Suraski wrote: > On Tue, Jul 10, 2018 at 2:06 PM Pedro Magalhães wrote: > > On Tue, Jul 10, 2018 at 11:33 AM Zeev Suraski wrote: > >> I've also given several examples - some of them arguably quite bigger > >> than > >> this proposal - where we sat on

Re: [PHP-DEV] [RFC] Typed Properties

Le mar. 10 juil. 2018 à 14:56, Zeev Suraski a écrit : > On Tue, Jul 10, 2018 at 2:06 PM Pedro Magalhães wrote: > >> On Tue, Jul 10, 2018 at 11:33 AM Zeev Suraski wrote: >> >>> I've also given several examples - some of them arguably quite bigger >>> than >>> this proposal - where we sat on

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 2:06 PM Pedro Magalhães wrote: > On Tue, Jul 10, 2018 at 11:33 AM Zeev Suraski wrote: > >> I've also given several examples - some of them arguably quite bigger than >> this proposal - where we sat on code for a very long time (multiple years >> even) in order for it to

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 11:33 AM Zeev Suraski wrote: > I've also given several examples - some of them arguably quite bigger than > this proposal - where we sat on code for a very long time (multiple years > even) in order for it to be included in a major version, and not a minor > one (phpng,

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 1:22 PM Nicolas Grekas wrote: > 2018-07-10 11:18 GMT+02:00 Marco Pivetta : > > > It's been a few weeks since this has first landed here, and we're just > > wasting time in relatively silly discussions at this point: > > > > - As I said earlier, this patch has already

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 11:18 AM, Marco Pivetta wrote: > It's been a few weeks since this has first landed here, and we're just > wasting time in relatively silly discussions at this point: > > - As I said earlier, this patch has already been tested against some > extremely tricky scenarios, so

Re: [PHP-DEV] [RFC] Typed Properties

On Tue, Jul 10, 2018 at 12:21 PM, Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > I'm definitely ith you on this one Marco, typed properties is something > userland asks since a long time and postponing it to 8.0 for "marketing" > reasons might be very frustrating (well, we'll deal with

Re: [PHP-DEV] [RFC] Typed Properties

2018-07-10 11:18 GMT+02:00 Marco Pivetta : > It's been a few weeks since this has first landed here, and we're just > wasting time in relatively silly discussions at this point: > > - As I said earlier, this patch has already been tested against some > extremely tricky scenarios, so from a

Re: [PHP-DEV] [RFC] Typed Properties

> >> ; Dan Ackroyd ; > >> Stanislav Malyshev ; Marco Pivetta > >> ; PHP internals > >> Subject: Re: [PHP-DEV] [RFC] Typed Properties > >> > >> Just want to be annoying about this since the currently scheduled fork > date for > >> PHP-7.3

Re: [PHP-DEV] [RFC] Typed Properties

.net; Björn Larsson >> ; Dan Ackroyd ; >> Stanislav Malyshev ; Marco Pivetta >> ; PHP internals >> Subject: Re: [PHP-DEV] [RFC] Typed Properties >> >> Just want to be annoying about this since the currently scheduled fork date >> for >> PHP-7.3 is 11 day

Re: [PHP-DEV] [RFC] Typed Properties

Pivetta ; PHP internals Subject: Re: [PHP-DEV] [RFC] Typed Properties Just want to be annoying about this since the currently scheduled fork date for PHP-7.3 is 11 days off. 1/ Do we have *ANY* objections to additional alpha(s) to accommodate Typed Props? (I would propose two additional alphas) 2/ Do

Re: [PHP-DEV] [RFC] Typed Properties

On 08.07.2018 at 01:35, Sara Golemon wrote: > On Fri, Jul 6, 2018 at 4:46 PM, Christoph M. Becker wrote: > >> Why should we have 2 additional alphas? In my opinion, a single >> additional alpha is sufficient, and it is really important not to add >> yet further features. > > Because in the best

Re: [PHP-DEV] [RFC] Typed Properties

Hi Lester, Typed properties combined with value objects (quite widespread technique) provide a decent level of safety at this point in time. So far, there haven't been many nay-sayers to the patch: it's OK to vote "no" if you don't understand or don't want the feature. Greets, Marco On Sun, 8

Re: [PHP-DEV] [RFC] Typed Properties

On 08/07/18 00:35, Sara Golemon wrote: Personally, I think even independently of typed variables, typed properties feel like an 8.0 feature, not a 7.x feature. I probably agree with you on that. (Again, still undecided). The debate seems to assume that Typed Properties ARE a done deal even

Re: [PHP-DEV] [RFC] Typed Properties

On Fri, Jul 6, 2018 at 4:46 PM, Christoph M. Becker wrote: > Why should we have 2 additional alphas? In my opinion, a single > additional alpha is sufficient, and it is really important not to add > yet further features. > Because in the best case scenario (with a single extra alpha), the RFC is

RE: [PHP-DEV] [RFC] Typed Properties

ivetta > ; PHP internals > Subject: Re: [PHP-DEV] [RFC] Typed Properties > > Just want to be annoying about this since the currently scheduled fork date > for > PHP-7.3 is 11 days off. > 1/ Do we have *ANY* objections to additional alpha(s) to accommodate Typed > Props?

Re: [PHP-DEV] [RFC] Typed Properties

On 06/07/2018 21:57, Nicolas Grekas wrote: if ((new ReflectionReference($array[$key]))->getRefcount() > 2) { I just realized that this interface would suffer from a significant drawback: it would trigger COW when iterating over immutable arrays, defeating the shared-memory optimization

Re: [PHP-DEV] [RFC] Typed Properties

Den lør. 7. jul. 2018 kl. 10.47 skrev Björn Larsson : > I leave this to the judgement of the RMs. I have no opinion myself, > besides I think it's a good idea to keep the GA date. I agree, and an additional few weeks will make the release date very close to the holidays, I think late

Re: [PHP-DEV] [RFC] Typed Properties

On 7/6/2018 9:35 PM, Sara Golemon wrote: It's up to a combination of internals@ opinion, and RM best-judgement. I for one, see no issue with pushing FF out (we can do an alpha4, even an alpha5). On the other end we have the option of reducing the number of RCs, or pushing GA by the same delay.

Re: [PHP-DEV] [RFC] Typed Properties

Le jeu. 21 juin 2018 à 19:37, Nicolas Grekas a écrit : > if ((new ReflectionReference($array[$key]))->getRefcount() > 2) { /* is >> ref */ } else { /* not a ref */ }, for computing the allowed types you’d >> intersect the types of the ReflectionProperties returned by >>

Re: [PHP-DEV] [RFC] Typed Properties

On 06.07.2018 at 21:35, Sara Golemon wrote: >> It's up to a combination of internals@ opinion, and RM best-judgement. >> I for one, see no issue with pushing FF out (we can do an alpha4, even >> an alpha5). On the other end we have the option of reducing the >> number of RCs, or pushing GA by

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jul 5, 2018 at 11:37 AM, Christoph M. Becker wrote: >>> Is there any precendent for postponing feature freeze during the (late) >>> alpha stage? >> >> This was done for the PHP 7.1 release at pretty much the same time (before >> the beta1 release it was decided to go with another alpha

Re: [PHP-DEV] [RFC] Typed Properties

On 05.07.2018 at 17:25, Nikita Popov wrote: > On Thu, Jul 5, 2018 at 1:25 PM, Christoph M. Becker > wrote: > >> On 05.07.2018 at 13:05, Björn Larsson wrote: >> >>> Den 2018-07-05 kl. 12:17, skrev Nikita Popov: >>> As such, I think that this feature can only go into 7.3 if the release

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jul 5, 2018 at 1:25 PM, Christoph M. Becker wrote: > On 05.07.2018 at 13:05, Björn Larsson wrote: > > > Den 2018-07-05 kl. 12:17, skrev Nikita Popov: > > > >> On Thu, Jul 5, 2018 at 11:09 AM, Björn Larsson > >> > >> wrote: > >> > >>> Den 2018-06-21 kl. 20:41, skrev Sara Golemon: > >>> >

Re: [PHP-DEV] [RFC] Typed Properties

https://marc.info/?l=php-internals=136093001212358=2 Maybe the opcache case in PHP5.5 is a precendent, I think. 2018年7月5日(木) 20:26 Christoph M. Becker : > On 05.07.2018 at 13:05, Björn Larsson wrote: > > > Den 2018-07-05 kl. 12:17, skrev Nikita Popov: > > > >> On Thu, Jul 5, 2018 at 11:09 AM,

Re: [PHP-DEV] [RFC] Typed Properties

On 05.07.2018 at 13:05, Björn Larsson wrote: > Den 2018-07-05 kl. 12:17, skrev Nikita Popov: > >> On Thu, Jul 5, 2018 at 11:09 AM, Björn Larsson >> >> wrote: >> >>> Den 2018-06-21 kl. 20:41, skrev Sara Golemon: >>> >>> On Thu, Jun 21, 2018 at 12:57 PM, Dan Ackroyd wrote: > On 21

Re: [PHP-DEV] [RFC] Typed Properties

Den 2018-07-05 kl. 12:17, skrev Nikita Popov: On Thu, Jul 5, 2018 at 11:09 AM, Björn Larsson wrote: Den 2018-06-21 kl. 20:41, skrev Sara Golemon: On Thu, Jun 21, 2018 at 12:57 PM, Dan Ackroyd wrote: On 21 June 2018 at 17:49, Stanislav Malyshev wrote: I think it's better not to feel

Re: [PHP-DEV] [RFC] Typed Properties

As such, I think that this feature can only go into 7.3 if the release schedule is adjusted. Extending the schedule by another 2-week alpha cycle would be sufficient to land this proposal in PHP 7.3. +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jul 5, 2018 at 11:09 AM, Björn Larsson wrote: > Den 2018-06-21 kl. 20:41, skrev Sara Golemon: > > On Thu, Jun 21, 2018 at 12:57 PM, Dan Ackroyd >> wrote: >> >>> On 21 June 2018 at 17:49, Stanislav Malyshev >>> wrote: >>> I think it's better not to feel pressured by the

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jul 5, 2018 at 11:09 AM, Björn Larsson wrote: > it feels a bit > way off having this to wait for this feature until 2020. > I didn't realise this. Now that I did: AAARGH!

Re: [PHP-DEV] [RFC] Typed Properties

Den 2018-06-21 kl. 20:41, skrev Sara Golemon: On Thu, Jun 21, 2018 at 12:57 PM, Dan Ackroyd wrote: On 21 June 2018 at 17:49, Stanislav Malyshev wrote: I think it's better not to feel pressured by the deadline for 7.3 The deadline isn't a deadline - it's just the current consensus for when

Re: [PHP-DEV] [RFC] Typed Properties

I'm not sure why the mailing list is not picking up my messages, but TL:DR; is that I spent the weekend testing all of its corners, and the patch works flawlessly and can be pushed forward IMO. It works consistently with current PHP semantics and significantly improves the language, so let's make

Re: [PHP-DEV] [RFC] Typed Properties

On 20/06/2018 22:59, Nikita Popov wrote: Hi internals, Bob and I would like to present a new typed properties proposal for your consideration: https://wiki.php.net/rfc/typed_properties_v2 Hi Nikita, and Bob, Thanks for the extremely thorough RFC. I think you've made a great case for

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jun 21, 2018 at 12:57 PM, Dan Ackroyd wrote: > On 21 June 2018 at 17:49, Stanislav Malyshev wrote: >> >> I think it's better not >> to feel pressured by the deadline for 7.3 > > The deadline isn't a deadline - it's just the current consensus for > when we'd like to see 7.3 released. > >

Re: [PHP-DEV] [RFC] Typed Properties

On 21 June 2018 at 17:49, Stanislav Malyshev wrote: > > I think it's better not > to feel pressured by the deadline for 7.3 The deadline isn't a deadline - it's just the current consensus for when we'd like to see 7.3 released. If people thought this RFC needed more time but would make PHP 7.3

Re: [PHP-DEV] [RFC] Typed Properties

> > if ((new ReflectionReference($array[$key]))->getRefcount() > 2) { /* is > ref */ } else { /* not a ref */ }, for computing the allowed types you’d > intersect the types of the ReflectionProperties returned by > getReferencingProperties(). > Would work also I suppose, sounds good thanks for

RE: [PHP-DEV] [RFC] Typed Properties

From: nicolas.gre...@gmail.com On Behalf Of Nicolas Grekas Sent: Thursday, June 21, 2018 18:51 To: Bob Weinand Cc: Nikita Popov ; PHP internals Subject: Re: [PHP-DEV] [RFC] Typed Properties something like a ReflectionReference class, which will give you the referencing properties via

Re: [PHP-DEV] [RFC] Typed Properties

> something like a ReflectionReference class, which will give you the > referencing properties via ReflectionProperty instances > I may not have the object when walking on data structures, but only the reference (in an array.) It could work this way I suppose:

Re: [PHP-DEV] [RFC] Typed Properties

Hi! > Finally, while this RFC currently targets PHP 7.3, this is a large and > complex proposal and we may not be able to meet the deadline, in which case > this feature will go into the next PHP version. I haven't read the RFC yet, so I just want to address this point. I think unless the RFC is

RE: [PHP-DEV] [RFC] Typed Properties

> From: Patrick ALLAERT > Sent: Thursday, June 21, 2018 18:25 > To: Nikita Popov > Cc: PHP internals > Subject: Re: [PHP-DEV] [RFC] Typed Properties > > My only concern is about regular variables, not bound to any classes. Isn't > that a little bit inconsistent that

RE: [PHP-DEV] [RFC] Typed Properties

Hey Larry, > From: Larry Garfield > Sent: Thursday, June 21, 2018 18:17 > To: internals@lists.php.net > Subject: Re: [PHP-DEV] [RFC] Typed Properties > Questions along the way: > > * There was at one point in time a related RFC regarding property accessors > (dedicat

Re: [PHP-DEV] [RFC] Typed Properties

Le jeu. 21 juin 2018 à 00:00, Nikita Popov a écrit : > Hi internals, > > Bob and I would like to present a new typed properties proposal for your > consideration: > > https://wiki.php.net/rfc/typed_prwould some benefitsoperties_v2 > > > The

Re: [PHP-DEV] [RFC] Typed Properties

On Wednesday, June 20, 2018 4:59:33 PM CDT Nikita Popov wrote: > Hi internals, > > Bob and I would like to present a new typed properties proposal for your > consideration: > > https://wiki.php.net/rfc/typed_properties_v2 > > The proposal allows you to annotate properties with types, which

Re: [PHP-DEV] [RFC] Typed Properties

> On 21 Jun 2018, at 4:59 am, Nikita Popov wrote: > > Hi internals, > > Bob and I would like to present a new typed properties proposal for your > consideration: > >https://wiki.php.net/rfc/typed_properties_v2 > > The proposal allows you to annotate properties with types, which are >

Re: [PHP-DEV] [RFC] Typed Properties

On 21.06.2018 at 16:50, Sara Golemon wrote: > On Thu, Jun 21, 2018 at 9:13 AM, Bob Weinand wrote: > >> I agree that we're pretty late to the party, however I see typed properties >> being >> a pretty central feature to the PHP 7.3 feature set then, just because of >> its size. >> I think it

Re: [PHP-DEV] [RFC] Typed Properties

On Thu, Jun 21, 2018 at 9:13 AM, Bob Weinand wrote: > I agree that we're pretty late to the party, however I see typed properties > being > a pretty central feature to the PHP 7.3 feature set then, just because of its > size. > I think it may be worth pushing the release of 7.3 a few weeks

RE: [PHP-DEV] [RFC] Typed Properties

> From: nicolas.gre...@gmail.com On Behalf Of > Nicolas Grekas > Sent: Thursday, June 21, 2018 16:08 > To: Nikita Popov > Cc: PHP internals > Subject: Re: [PHP-DEV] [RFC] Typed Properties > > Hi Nikita, Bob, > > I anticipate one case on Symfony VarDumper that wi

RE: [PHP-DEV] [RFC] Typed Properties

Hey Sara, > From: p...@golemon.com On Behalf Of Sara Golemon > Sent: Thursday, June 21, 2018 15:43 > To: Nikita Popov > Cc: PHP internals > Subject: Re: [PHP-DEV] [RFC] Typed Properties > > On Wed, Jun 20, 2018 at 4:59 PM, Nikita Popov > wrote: > > Finally, wh

Re: [PHP-DEV] [RFC] Typed Properties

Hi Nikita, Bob, https://wiki.php.net/rfc/typed_properties_v2 > This is really well thought and written, sounds really primising. I agree that "References without intrinsic type" look the best. I anticipate one case on Symfony VarDumper that will break on typed references: the only way to

Re: [PHP-DEV] [RFC] Typed Properties

On Wed, Jun 20, 2018 at 4:59 PM, Nikita Popov wrote: > Bob and I would like to present a new typed properties proposal for your > consideration: > > https://wiki.php.net/rfc/typed_properties_v2 > At a glance, yes please. Will dig in deeper when I'm not busy moving. > Finally, while this RFC

Re: [PHP-DEV] [RFC] Typed Properties

Nikita, Bob I'd love to thank you and everyone involved on this one. Types properties on PHP is something that we tried before, but due to a number of issues, we didn't make it. Unfortunately, I don't have the knowledge to help in the implementation, but I'd like to drop some comments about the

Re: [PHP-DEV] [RFC] Typed Properties

Hi Bob, On Thu, Jun 21, 2018 at 1:42 AM, Bob Weinand wrote: > __get() is a very normal function - the special semantics are generally > only applied if called for overloaded properties. So obviously, there is no > check applied if you call it directly. > Thanks! The dev branch is stable for

RE: [PHP-DEV] [RFC] Typed Properties

> From: Marco Pivetta > Sent: Thursday, June 21, 2018 01:10 > To: Nikita Popov > Cc: PHP Internals List > Subject: Re: [PHP-DEV] [RFC] Typed Properties > > Hi Nikita, Bob, > > On Wed, 20 Jun 2018, 23:59 Nikita Popov, wrote: > > > Hi internals, > >

Re: [PHP-DEV] [RFC] Typed Properties

Hi Nikita, Bob, On Wed, 20 Jun 2018, 23:59 Nikita Popov, wrote: > Hi internals, > > Bob and I would like to present a new typed properties proposal for your > consideration: > > https://wiki.php.net/rfc/typed_properties_v2 > > The proposal allows you to annotate properties with types, which

[PHP-DEV] [RFC] Typed Properties

Hi internals, Bob and I would like to present a new typed properties proposal for your consideration: https://wiki.php.net/rfc/typed_properties_v2 The proposal allows you to annotate properties with types, which are enforced at runtime. Unlike the previous RFC on this topic, the new

Re: [PHP-DEV] [RFC] Typed Properties

On 19/11/2016 18:38, Stanislav Malyshev wrote: Hi! Any plans to revive this RFC or is it officially dead? I really wish people won't use [Vote] subject in topics having nothing to do with RFC voting start/stop. It's because it's a reply to an old thread. Which is annoying in itself for

Re: [PHP-DEV] [RFC] Typed Properties

Hi! > Any plans to revive this RFC or is it officially dead? I really wish people won't use [Vote] subject in topics having nothing to do with RFC voting start/stop. -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

[PHP-DEV] [RFC] Typed Properties On Hold

Morning internals, Since some important details regarding the recently accepted nullable types feature were missing from the RFC, the vote has been stopped for typed properties, while we resolve these issues and update the RFC, and implementation. Voting on the final implementation will