Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-11 Thread Peter Bowyer
On Tue, 11 Feb 2020 at 09:34, AllenJB wrote: > If you want to change the way developers think about hashing when > writing PHP, I would start with the documentation rather than > deprecating functions which are essentially aliases and are highly > likely used all over the place in cases where

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-11 Thread AllenJB
As others have mentioned, this will do nothing but make people annoyed and switch to the hash_file() version of exactly the same thing or put up another hurdle to updgrading PHP. The password hashing API now provides an obvious go-to for password hashing. For other hashing usages there are, I

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Tom Van Looy via internals
On Tue, 11 Feb 2020, 06:59 Stanislav Malyshev, wrote: > Hi! > > > I suggest to deprecated the functions md5_file() and sha1_file(). This > will > > Not sure what's the point of it. SHA1 and MD5 didn't change. The > recommendations for their usage has changed, but we generally don't use >

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Stanislav Malyshev
Hi! > the hash_file() function still supports md5 and sha1 so people that need it > should then migrate to hash_file('md5', ...) or hash_file('sha1', ...) > instead. That was the idea This means spending time and effort to cause extra work to people that already have working code with existing

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Stanislav Malyshev
Hi! > I suggest to deprecated the functions md5_file() and sha1_file(). This will Not sure what's the point of it. SHA1 and MD5 didn't change. The recommendations for their usage has changed, but we generally don't use deprecation warnings to improve users' code and recommend them how to

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Derick Rethans
On 10 February 2020 21:52:42 GMT, j adams wrote: >I disagree. While MD5 and SHA1 might not be suitable for modern >cryptographic operations, these functions might be needed for legacy >situations -- e.g., munging through old data. > > >On Mon, Feb 10, 2020 at 1:50 PM Tom Van Looy via internals <

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread G. P. B.
On Mon, 10 Feb 2020 at 22:50, Tom Van Looy via internals < internals@lists.php.net> wrote: > Hi > > While in some environments the use of MD5 and SHA1 are still acceptable for > some use cases like file integrity verification etc. the use of these > algorithms should be discouraged and not be

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Tom Van Looy via internals
the hash_file() function still supports md5 and sha1 so people that need it should then migrate to hash_file('md5', ...) or hash_file('sha1', ...) instead. That was the idea Kind regards, Tom On Mon, Feb 10, 2020 at 10:52 PM j adams wrote: > I disagree. While MD5 and SHA1 might not be

Re: [PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread j adams
I disagree. While MD5 and SHA1 might not be suitable for modern cryptographic operations, these functions might be needed for legacy situations -- e.g., munging through old data. On Mon, Feb 10, 2020 at 1:50 PM Tom Van Looy via internals < internals@lists.php.net> wrote: > Hi > > While in some

[PHP-DEV] [RFC] deprecate md5_file and sha1_file

2020-02-10 Thread Tom Van Looy via internals
Hi While in some environments the use of MD5 and SHA1 are still acceptable for some use cases like file integrity verification etc. the use of these algorithms should be discouraged and not be your choice when developing new applications. I suggest to deprecated the functions md5_file() and