[PHP-DEV] DOMDocument Extension: Output current nodelist

2008-07-29 Thread Benjamin Eberlei
Hello, this is my first posting and first patch proposal, so please be kind :) I recognized at work today that DOMDocument has two function saveHTML and saveHTMLFile, but only a save function for the unfiltered xml node structure to save to a file although libxml provides the functionality to

Re: [PHP-DEV] DOMDocument Extension: Output current nodelist

2008-07-29 Thread Johannes Schlüter
On Wed, 2008-07-30 at 00:23 +0200, Benjamin Eberlei wrote: I recognized at work today that DOMDocument has two function saveHTML and saveHTMLFile, but only a save function for the unfiltered xml node structure to save to a file although libxml provides the functionality to export the data to

Re: [PHP-DEV] DOMDocument Extension: Output current nodelist

2008-07-29 Thread Benjamin Eberlei
Thats embarassing. I missed saveXML. :) Regarding the ifs, that is mostly copy paste. the original functions saveHtml and save don't have braces currently. Regarding naming: Output, because of the naming scheme saveHtml - saveHtmlFile and save (represeting what saveHtmlFile did) i had to come